Changeset 278546 in webkit


Ignore:
Timestamp:
Jun 6, 2021, 11:31:54 PM (4 years ago)
Author:
commit-queue@webkit.org
Message:

Unreviewed, reverting r277464.
​https://bugs.webkit.org/show_bug.cgi?id=226709

No longer necessary

Reverted changeset:

"Work around WebCore failing to build due to NDEBUG getting
undefined in release"
​https://bugs.webkit.org/show_bug.cgi?id=225782
​https://trac.webkit.org/changeset/277464

Location:
trunk/Source
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/PAL/ChangeLog

    r278530 r278546  
     12021-06-06  Commit Queue  <commit-queue@webkit.org>
     2
     3        Unreviewed, reverting r277464.
     4        https://bugs.webkit.org/show_bug.cgi?id=226709
     5
     6        No longer necessary
     7
     8        Reverted changeset:
     9
     10        "Work around WebCore failing to build due to NDEBUG getting
     11        undefined in release"
     12        https://bugs.webkit.org/show_bug.cgi?id=225782
     13        https://trac.webkit.org/changeset/277464
     14
    1152021-06-05  Wenson Hsieh  <wenson_hsieh@apple.com>
    216

  • trunk/Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h

    r277986 r278546  
    3939#if USE(APPLE_INTERNAL_SDK)
    4040
    41 // FIXME (77983361): Remove this workaround when <rdar://problem/77977216> is fixed.
    42 #if defined(NDEBUG) && NDEBUG
    43 #define WK_NDEBUG 1
    44 #endif
    45 
    4641#include <CoreGraphics/CGContextDelegatePrivate.h>
    4742#include <CoreGraphics/CGFontCache.h>
    … …  
    4944#include <CoreGraphics/CoreGraphicsPrivate.h>
    5045#include <CoreGraphics/CGStylePrivate.h>
    51 
    52 #if defined(WK_NDEBUG) && !defined(NDEBUG)
    53 #define NDEBUG 1
    54 #undef WK_NDEBUG
    55 #endif
    5646
    5747#if PLATFORM(MAC)

  • trunk/Source/WebCore/PAL/pal/spi/ios/GraphicsServicesSPI.h

    r277464 r278546  
    3232#if USE(APPLE_INTERNAL_SDK)
    3333
    34 // FIXME (77983361): Remove this workaround when <rdar://problem/77977216> is fixed.
    35 #if defined(NDEBUG) && NDEBUG
    36 #define WK_NDEBUG 1
    37 #endif
    38 
    3934#import <GraphicsServices/GraphicsServices.h>
    40 
    41 #if defined(WK_NDEBUG) && !defined(NDEBUG)
    42 #define NDEBUG 1
    43 #undef WK_NDEBUG
    44 #endif
    4535
    4636#endif

  • trunk/Source/WebKit/ChangeLog

    r278542 r278546  
     12021-06-06  Commit Queue  <commit-queue@webkit.org>
     2
     3        Unreviewed, reverting r277464.
     4        https://bugs.webkit.org/show_bug.cgi?id=226709
     5
     6        No longer necessary
     7
     8        Reverted changeset:
     9
     10        "Work around WebCore failing to build due to NDEBUG getting
     11        undefined in release"
     12        https://bugs.webkit.org/show_bug.cgi?id=225782
     13        https://trac.webkit.org/changeset/277464
     14
    1152021-06-06  Wenson Hsieh  <wenson_hsieh@apple.com>
    216

  • trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h

    r278183 r278546  
    2727
    2828#if USE(APPLE_INTERNAL_SDK)
    29 
    30 // FIXME (77983361): Remove this workaround when <rdar://problem/77977216> is fixed.
    31 #if defined(NDEBUG) && NDEBUG
    32 #define WK_NDEBUG 1
    33 #endif
    3429
    3530#import <UIKit/NSTextAlternatives.h>
    … …  
    141136#endif
    142137
    143 #if defined(WK_NDEBUG) && !defined(NDEBUG)
    144 #define NDEBUG 1
    145 #undef WK_NDEBUG
    146 #endif
    147 
    148138#else // USE(APPLE_INTERNAL_SDK)
    149139
Note: See TracChangeset for help on using the changeset viewer.