Changeset 278741 in webkit

Timestamp:

Jun 10, 2021, 4:55:52 PM (4 years ago)

Author:

sihui_liu@apple.com

Message:

Regression(r278449): add null check for completionHandler in WebIDBServer::close
​https://bugs.webkit.org/show_bug.cgi?id=226900
rdar://79160392

Reviewed by Chris Dumez.

• NetworkProcess/IndexedDB/WebIDBServer.cpp:

(WebKit::WebIDBServer::close):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• NetworkProcess/IndexedDB/WebIDBServer.cpp (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-06-10  Sihui Liu  <sihui_liu@apple.com>
+
+        Regression(r278449): add null check for completionHandler in WebIDBServer::close
+        https://bugs.webkit.org/show_bug.cgi?id=226900
+        rdar://79160392
+
+        Reviewed by Chris Dumez.
+
+        * NetworkProcess/IndexedDB/WebIDBServer.cpp:
+        (WebKit::WebIDBServer::close):
+
 2021-06-10  Eric Carlson  <eric.carlson@apple.com>
 

trunk/Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.cpp

@@ -410 +410 @@
 
     // Dispatch last task to clean up.
-   postTask([this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)]() mutable {
+    postTask([this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)]() mutable {
         m_connectionMap.clear();
 
@@ -419 +419 @@
 
         postTaskReply([protectedThis = WTFMove(protectedThis), completionHandler = WTFMove(completionHandler)]() mutable {
-            completionHandler();
+            if (completionHandler)
+                completionHandler();
         });
     });