Changeset 279640 in webkit

Timestamp:

Jul 7, 2021, 1:12:26 AM (4 years ago)

Author:

Chris Lord

Message:

[WPE] Fieldset elements can incorrectly get treated as opaque with async scrolling overflow areas enabled
​https://bugs.webkit.org/show_bug.cgi?id=227679

Reviewed by Simon Fraser.

Source/WebCore:

Don't treat fieldset elements as opaque as their background shape is
determined by its children and can be non-rectangular.

No new tests, covered by existing tests.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect const):

LayoutTests:

WPT fieldset-overflow test now passes with async overflow scrolling
enabled.

• platform/wpe/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/wpe/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderLayer.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-07-07  Chris Lord  <clord@igalia.com>
+
+        [WPE] Fieldset elements can incorrectly get treated as opaque with async scrolling overflow areas enabled
+        https://bugs.webkit.org/show_bug.cgi?id=227679
+
+        Reviewed by Simon Fraser.
+
+        WPT fieldset-overflow test now passes with async overflow scrolling
+        enabled.
+
+        * platform/wpe/TestExpectations:
+
 2021-07-06  Commit Queue  <commit-queue@webkit.org>
 

trunk/LayoutTests/platform/wpe/TestExpectations

@@ -719 +719 @@
 webkit.org/b/224596 imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-rl-001.html [ ImageOnlyFailure ]
 webkit.org/b/224596 imported/w3c/web-platform-tests/css/css-position/hypothetical-box-scroll-parent.html [ ImageOnlyFailure ]
-webkit.org/b/224596 imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/fieldset-overflow.html [ ImageOnlyFailure ]
+webkit.org/b/227061 imported/w3c/web-platform-tests/css/css-ui/outline-negative-offset-composited-scroll.html [ ImageOnlyFailure ]
 
 # These tests are passing most of the times since r275515.

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-07-07  Chris Lord  <clord@igalia.com>
+
+        [WPE] Fieldset elements can incorrectly get treated as opaque with async scrolling overflow areas enabled
+        https://bugs.webkit.org/show_bug.cgi?id=227679
+
+        Reviewed by Simon Fraser.
+
+        Don't treat fieldset elements as opaque as their background shape is
+        determined by its children and can be non-rectangular.
+
+        No new tests, covered by existing tests.
+
+        * rendering/RenderLayer.cpp:
+        (WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect const):
+
 2021-07-06  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/WebCore/rendering/RenderLayer.cpp

@@ -5032 +5032 @@
         return false;
 
+    // A fieldset with a legend will have an irregular shape, so can't be treated as opaque.
+    if (renderer().isFieldset())
+        return false;
+
     // FIXME: We currently only check the immediate renderer,
     // which will miss many cases.