Changeset 279647 in webkit

Timestamp:

Jul 7, 2021, 10:32:20 AM (4 years ago)

Author:

commit-queue@webkit.org

Message:

XPC services should release their os transaction when given a SIGTERM signal
​https://bugs.webkit.org/show_bug.cgi?id=227747
<rdar://72430454>

Patch by Alex Christensen <​achristensen@webkit.org> on 2021-07-07
Reviewed by Geoff Garen.

Apparently when you shut down your computer, processes are given a SIGTERM signal and expected to release their os_transaction_t
to indicate that they can now be terminated "cleanly".

• Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h:

(WebKit::XPCServiceInitializer):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-07-07  Alex Christensen  <achristensen@webkit.org>
+
+        XPC services should release their os transaction when given a SIGTERM signal
+        https://bugs.webkit.org/show_bug.cgi?id=227747
+        <rdar://72430454>
+
+        Reviewed by Geoff Garen.
+
+        Apparently when you shut down your computer, processes are given a SIGTERM signal and expected to release their os_transaction_t
+        to indicate that they can now be terminated "cleanly".
+
+        * Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h:
+        (WebKit::XPCServiceInitializer):
+
 2021-07-07  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h

@@ -102 +102 @@
 #if PLATFORM(MAC)
     osTransaction() = adoptOSObject(os_transaction_create("WebKit XPC Service"));
+    signal(SIGTERM, [] (int signal) {
+        RELEASE_ASSERT(signal == SIGTERM);
+        osTransaction() = nullptr;
+    });
 #endif