Changeset 280397 in webkit

Timestamp:

Jul 28, 2021, 1:07:23 PM (4 years ago)

Author:

timothy_horton@apple.com

Message:

iOS Simulator doesn't have any WebKit system feature flags
​https://bugs.webkit.org/show_bug.cgi?id=228557
rdar://80991854

Reviewed by Darin Adler.

• Scripts/generate-feature-flags-plist.sh:

Install iOS feature flags for the simulator (and watchOS and tvOS for their respective simulators).
This was causing on-by-default features like GPUP to be disabled in the simulator.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Scripts/generate-feature-flags-plist.sh (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-07-28  Tim Horton  <timothy_horton@apple.com>
+
+        iOS Simulator doesn't have any WebKit system feature flags
+        https://bugs.webkit.org/show_bug.cgi?id=228557
+        rdar://80991854
+
+        Reviewed by Darin Adler.
+
+        * Scripts/generate-feature-flags-plist.sh:
+        Install iOS feature flags for the simulator (and watchOS and tvOS for their respective simulators).
+        This was causing on-by-default features like GPUP to be disabled in the simulator.
+
 2021-07-28  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKit/Scripts/generate-feature-flags-plist.sh

@@ -26 +26 @@
 set -e
 
-if [[ ${WK_PLATFORM_NAME} == "appletvos" ]]; then
+if [[ ${WK_PLATFORM_NAME} == "appletvos" || ${WK_PLATFORM_NAME} == "appletvsimulator" ]]; then
     WEBKIT_PLIST_FILE_NAME="WebKit-appletvos.plist"
-elif [[ ${WK_PLATFORM_NAME} == "iphoneos" ]]; then
+elif [[ ${WK_PLATFORM_NAME} == "iphoneos" || ${WK_PLATFORM_NAME} == "iphonesimulator" ]]; then
     WEBKIT_PLIST_FILE_NAME="WebKit-ios.plist"
 elif [[ ${WK_PLATFORM_NAME} == "macosx" ]]; then
     WEBKIT_PLIST_FILE_NAME="WebKit-macos.plist"
-elif [[ ${WK_PLATFORM_NAME} == "watchos" ]]; then
+elif [[ ${WK_PLATFORM_NAME} == "watchos" || ${WK_PLATFORM_NAME} == "watchsimulator" ]]; then
     WEBKIT_PLIST_FILE_NAME="WebKit-watchos.plist"
 else