Changeset 281139 in webkit

Timestamp:

Aug 17, 2021, 9:01:58 AM (4 years ago)

Author:

Razvan Caliman

Message:

Web Inspector: Do not show contextual documentation popup in the Changes panel
​https://bugs.webkit.org/show_bug.cgi?id=229001
<rdar://problem/81792379>

Reviewed by Devin Rousso.

Add config option to WI.SpreadsheetStyleProperty to prevent showing a contextual documentation button.

• UserInterface/Views/ChangesDetailsSidebarPanel.js:

(WI.ChangesDetailsSidebarPanel.prototype._createRuleElement.onEach):

• UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype._addContextualDocumentationButton):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/ChangesDetailsSidebarPanel.js (modified) (1 diff)
• UserInterface/Views/SpreadsheetStyleProperty.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2021-08-17  Razvan Caliman  <rcaliman@apple.com>
+
+        Web Inspector: Do not show contextual documentation popup in the Changes panel
+        https://bugs.webkit.org/show_bug.cgi?id=229001
+        <rdar://problem/81792379>
+
+        Reviewed by Devin Rousso.
+
+        Add config option to WI.SpreadsheetStyleProperty to prevent showing a contextual documentation button.
+
+        * UserInterface/Views/ChangesDetailsSidebarPanel.js:
+        (WI.ChangesDetailsSidebarPanel.prototype._createRuleElement.onEach):
+        * UserInterface/Views/SpreadsheetStyleProperty.js:
+        (WI.SpreadsheetStyleProperty.prototype._addContextualDocumentationButton):
+
 2021-08-12  Patrick Angle  <pangle@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/ChangesDetailsSidebarPanel.js

@@ -144 +144 @@
 
             const delegate = null;
-            let stylePropertyView = new WI.SpreadsheetStyleProperty(delegate, cssProperty, {readOnly: true});
+            let stylePropertyView = new WI.SpreadsheetStyleProperty(delegate, cssProperty, {readOnly: true, hideDocumentation: true});
             propertyLineElement.append(WI.indentString(), stylePropertyView.element, "\n");
         }

trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js

@@ -35 +35 @@
         this._property = property;
         this._readOnly = options.readOnly || false;
+        this._hideDocumentation = !!options.hideDocumentation;
         this._element = document.createElement("div");
 
@@ -528 +529 @@
     _addContextualDocumentationButton()
     {
+        if (this._hideDocumentation)
+            return;
+
         if (this._contextualDocumentationButton) {
             this._contextualDocumentationButton.remove();