Changeset 282091 in webkit

Timestamp:

Sep 7, 2021, 9:37:33 AM (4 years ago)

Author:

Jonathan Bedard

Message:

Exception in run-webkit-tests: Bad file descriptor (Part 1)
​https://bugs.webkit.org/show_bug.cgi?id=229994

Reviewed by Aakash Jain.

• Scripts/webkitpy/port/server_process.py:

(ServerProcess.write): Catch "Bad file descriptor."
(ServerProcess._wait_for_data_and_update_buffers_using_select): Ditto.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/port/server_process.py (modified) (3 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2021-09-07  Jonathan Bedard  <jbedard@apple.com>
+
+        Exception in run-webkit-tests: Bad file descriptor (Part 1)
+        https://bugs.webkit.org/show_bug.cgi?id=229994
+
+        Reviewed by Aakash Jain.
+
+        * Scripts/webkitpy/port/server_process.py:
+        (ServerProcess.write): Catch "Bad file descriptor."
+        (ServerProcess._wait_for_data_and_update_buffers_using_select): Ditto.
+
 2021-09-07  Jonathan Bedard  <jbedard@apple.com>
 

trunk/Tools/Scripts/webkitpy/port/server_process.py

@@ -185 +185 @@
             self._proc.stdin.write(string_utils.encode(bytes))
             self._proc.stdin.flush()
-        except (IOError, ValueError):
+        except (IOError, OSError, ValueError):
             self.stop(0.0)
             # stop() calls _reset(), so we have to set crashed to True after calling stop()
@@ -285 +285 @@
         try:
             read_fds, _, _ = select.select(select_fds, [], select_fds, max(deadline - time.time(), 0))
+        except OSError:
+            # FIXME: https://bugs.webkit.org/show_bug.cgi?id=229994
+            _log.debug('Caught OSError for {}, continuing'.format(self.pid()))
+            return
         except select.error as e:
             # We can ignore EINVAL since it's likely the process just crashed and we'll
@@ -313 +317 @@
                     self._crashed = True
                 self._error += data
+        except OSError:
+            # FIXME: https://bugs.webkit.org/show_bug.cgi?id=229994
+            _log.debug('Caught OSError for {}, continuing'.format(self.pid()))
+            pass
         except IOError:
             # We can ignore the IOErrors because we will detect if the subporcess crashed