Changeset 282416 in webkit


Ignore:
Timestamp:
Sep 14, 2021, 3:25:25 PM (4 years ago)
Author:
Ryan Haddad
Message:

Unreviewed, reverting r282408.

Breaks internal builds.

Reverted changeset:

"Enable RTCRtpScriptTransform by default"
​https://bugs.webkit.org/show_bug.cgi?id=230220
​https://commits.webkit.org/r282408

Location:
trunk
Files:
15 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r282415 r282416  
     12021-09-14  Ryan Haddad  <ryanhaddad@apple.com>
     2
     3        Unreviewed, reverting r282408.
     4
     5        Breaks internal builds.
     6
     7        Reverted changeset:
     8
     9        "Enable RTCRtpScriptTransform by default"
     10        https://bugs.webkit.org/show_bug.cgi?id=230220
     11        https://commits.webkit.org/r282408
     12
    1132021-09-14  Myles C. Maxfield  <mmaxfield@apple.com>
    214

  • trunk/LayoutTests/http/wpt/webrtc/no-webrtc-transform.html

    r282408 r282416  
    1010promise_test(async (test) => {
    1111    if (window.internals)
    12         internals.settings.setWebRTCEncodedTransformEnabled(true);
     12        internals.settings.setWebRTCInsertableStreamsEnabled(true);
    1313
    1414    const worker = new Worker('no-transform.js');
    … …  
    1919promise_test(async (test) => {
    2020    if (window.internals)
    21         internals.settings.setWebRTCEncodedTransformEnabled(false);
     21        internals.settings.setWebRTCInsertableStreamsEnabled(false);
    2222
    2323    const worker = new Worker('no-transform.js');

  • trunk/Source/WTF/ChangeLog

    r282415 r282416  
     12021-09-14  Ryan Haddad  <ryanhaddad@apple.com>
     2
     3        Unreviewed, reverting r282408.
     4
     5        Breaks internal builds.
     6
     7        Reverted changeset:
     8
     9        "Enable RTCRtpScriptTransform by default"
     10        https://bugs.webkit.org/show_bug.cgi?id=230220
     11        https://commits.webkit.org/r282408
     12
    1132021-09-14  Myles C. Maxfield  <mmaxfield@apple.com>
    214

  • trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml

    r282408 r282416  
    13931393      default: WebKit::defaultWebMParserEnabled()
    13941394
    1395 WebRTCEncodedTransformEnabled:
    1396   type: bool
    1397   condition: ENABLE(WEB_RTC)
    1398   humanReadableName: "WebRTC Encoded Transform API"
    1399   humanReadableDescription: "Enable WebRTC Encoded Transform API"
    1400   defaultValue:
    1401     WebKitLegacy:
    1402       default: false
    1403     WebKit:
    1404       default: true
    1405     WebCore:
    1406       default: true
    1407 
    14081395# FIXME: Is this implemented for WebKitLegacy? If not, this should be excluded from WebKitLegacy entirely.
    14091396WebRTCH264LowLatencyEncoderEnabled:
    … …  
    14321419      default: false
    14331420
     1421WebRTCInsertableStreamsEnabled:
     1422  type: bool
     1423  condition: ENABLE(WEB_RTC)
     1424  humanReadableName: "WebRTC Insertable Streams API"
     1425  humanReadableDescription: "Enable WebRTC Insertable Streams API"
     1426  defaultValue:
     1427    WebKitLegacy:
     1428      default: false
     1429    WebKit:
     1430      default: false
     1431    WebCore:
     1432      default: false
     1433
    14341434# FIXME: This is not relevent for WebKitLegacy, so should be excluded from WebKitLegacy entirely.
    14351435WebRTCPlatformCodecsInGPUProcessEnabled:
    … …  
    14661466      default: true
    14671467
    1468 WebRTCSFrameTransformEnabled:
    1469   type: bool
    1470   condition: ENABLE(WEB_RTC)
    1471   humanReadableName: "WebRTC SFrame Transform API"
    1472   humanReadableDescription: "Enable WebRTC SFrame Transform API"
    1473   defaultValue:
    1474     WebKitLegacy:
    1475       default: false
    1476     WebKit:
    1477       default: false
    1478     WebCore:
    1479       default: false
    1480 
    14811468WebRTCSocketsProxyingEnabled:
    14821469  type: bool

  • trunk/Source/WebCore/ChangeLog

    r282415 r282416  
     12021-09-14  Ryan Haddad  <ryanhaddad@apple.com>
     2
     3        Unreviewed, reverting r282408.
     4
     5        Breaks internal builds.
     6
     7        Reverted changeset:
     8
     9        "Enable RTCRtpScriptTransform by default"
     10        https://bugs.webkit.org/show_bug.cgi?id=230220
     11        https://commits.webkit.org/r282408
     12
    1132021-09-14  Myles C. Maxfield  <mmaxfield@apple.com>
    214

  • trunk/Source/WebCore/Modules/mediastream/RTCEncodedAudioFrame.idl

    r282408 r282416  
    3535[
    3636    Conditional=WEB_RTC,
    37     EnabledBySetting=WebRTCEncodedTransform,
     37    EnabledBySetting=WebRTCInsertableStreams,
    3838    Exposed=DedicatedWorker,
    3939    ImplementationLacksVTable,

  • trunk/Source/WebCore/Modules/mediastream/RTCEncodedVideoFrame.idl

    r282408 r282416  
    4444[
    4545    Conditional=WEB_RTC,
    46     EnabledBySetting=WebRTCEncodedTransform,
     46    EnabledBySetting=WebRTCInsertableStreams,
    4747    Exposed=DedicatedWorker,
    4848    ImplementationLacksVTable,

  • trunk/Source/WebCore/Modules/mediastream/RTCRtpReceiver+Transform.idl

    r282408 r282416  
    2828[
    2929    Conditional=WEB_RTC,
    30     EnabledBySetting=WebRTCEncodedTransform,
     30    EnabledBySetting=WebRTCInsertableStreams,
    3131    Exposed=Window,
    3232    ImplementedBy=RTCRtpReceiverWithTransform,

  • trunk/Source/WebCore/Modules/mediastream/RTCRtpSFrameTransform.idl

    r282408 r282416  
    4444    ActiveDOMObject,
    4545    Conditional=WEB_RTC,
    46     EnabledBySetting=WebRTCSFrameTransform,
     46    EnabledBySetting=WebRTCInsertableStreams,
    4747    ExportMacro=WEBCORE_EXPORT,
    4848    Exposed=(Window,DedicatedWorker),

  • trunk/Source/WebCore/Modules/mediastream/RTCRtpSFrameTransformErrorEvent.idl

    r282408 r282416  
    3737[
    3838    Conditional=WEB_RTC,
    39     EnabledBySetting=WebRTCSFrameTransform,
     39    EnabledBySetting=WebRTCInsertableStreams,
    4040    Exposed=(Window,DedicatedWorker),
    4141    InterfaceName=SFrameTransformErrorEvent

  • trunk/Source/WebCore/Modules/mediastream/RTCRtpScriptTransform.idl

    r282408 r282416  
    2727    ActiveDOMObject,
    2828    Conditional=WEB_RTC,
    29     EnabledBySetting=WebRTCEncodedTransform,
     29    EnabledBySetting=WebRTCInsertableStreams,
    3030    Exposed=Window,
    3131    JSGenerateToNativeObject,

  • trunk/Source/WebCore/Modules/mediastream/RTCRtpScriptTransformer.idl

    r282408 r282416  
    2727    ActiveDOMObject,
    2828    Conditional=WEB_RTC,
    29     EnabledBySetting=WebRTCEncodedTransform,
     29    EnabledBySetting=WebRTCInsertableStreams,
    3030    Exposed=DedicatedWorker,
    3131    JSGenerateToNativeObject,

  • trunk/Source/WebCore/Modules/mediastream/RTCRtpSender+Transform.idl

    r282408 r282416  
    2828[
    2929    Conditional=WEB_RTC,
    30     EnabledBySetting=WebRTCEncodedTransform,
     30    EnabledBySetting=WebRTCInsertableStreams,
    3131    Exposed=Window,
    3232    ImplementedBy=RTCRtpSenderWithTransform,

  • trunk/Source/WebCore/Modules/mediastream/RTCTransformEvent.idl

    r282408 r282416  
    2525[
    2626    Conditional=WEB_RTC,
    27     EnabledBySetting=WebRTCEncodedTransform,
     27    EnabledBySetting=WebRTCInsertableStreams,
    2828    Exposed=Worker,
    2929    InterfaceName=RTCTransformEvent,

  • trunk/Source/WebCore/workers/DedicatedWorkerGlobalScope.idl

    r282408 r282416  
    4747
    4848[Conditional=OFFSCREEN_CANVAS_IN_WORKERS, EnabledAtRuntime=OffscreenCanvasInWorkers] DedicatedWorkerGlobalScope includes AnimationFrameProvider;
    49 [Conditional=WEB_RTC, EnabledBySetting=WebRTCEncodedTransform] DedicatedWorkerGlobalScope includes RTCRtpScriptTransformProvider;
     49[Conditional=WEB_RTC, EnabledBySetting=WebRTCInsertableStreams] DedicatedWorkerGlobalScope includes RTCRtpScriptTransformProvider;
Note: See TracChangeset for help on using the changeset viewer.