Changeset 282955 in webkit


Ignore:
Timestamp:
Sep 23, 2021, 4:50:41 AM (4 years ago)
Author:
ntim@apple.com
Message:

Replace axObject->isAXHidden() || axObject->isDOMHidden() with axObject->isHidden()
​https://bugs.webkit.org/show_bug.cgi?id=230678

Reviewed by Antti Koivisto.

No behaviour change. The definition of isHidden is:

bool isHidden() const override { return isAXHidden() || isDOMHidden(); }

  • inspector/InspectorAuditAccessibilityObject.cpp:

(WebCore::InspectorAuditAccessibilityObject::getComputedProperties):

  • inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):

Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r282954 r282955  
     12021-09-23  Tim Nguyen  <ntim@apple.com>
     2
     3        Replace `axObject->isAXHidden() || axObject->isDOMHidden()` with `axObject->isHidden()`
     4        https://bugs.webkit.org/show_bug.cgi?id=230678
     5
     6        Reviewed by Antti Koivisto.
     7
     8        No behaviour change. The definition of isHidden is:
     9
     10        `bool isHidden() const override { return isAXHidden() || isDOMHidden(); }`
     11
     12        * inspector/InspectorAuditAccessibilityObject.cpp:
     13        (WebCore::InspectorAuditAccessibilityObject::getComputedProperties):
     14        * inspector/agents/InspectorDOMAgent.cpp:
     15        (WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):
     16
    1172021-09-23  Jean-Yves Avenard  <jya@apple.com>
    218

  • trunk/Source/WebCore/inspector/InspectorAuditAccessibilityObject.cpp

    r278253 r282955  
    176176
    177177        computedProperties.headingLevel = axObject->headingLevel();
    178         computedProperties.hidden = axObject->isAXHidden() || axObject->isDOMHidden();
     178        computedProperties.hidden = axObject->isHidden();
    179179        computedProperties.hierarchicalLevel = axObject->hierarchicalLevel();
    180180        computedProperties.ignored = axObject->accessibilityIsIgnored();

  • trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.cpp

    r279439 r282955  
    21182118                invalid = Protocol::DOM::AccessibilityProperties::Invalid::True;
    21192119           
    2120             if (axObject->isAXHidden() || axObject->isDOMHidden())
     2120            if (axObject->isHidden())
    21212121                hidden = true;
    21222122           
Note: See TracChangeset for help on using the changeset viewer.