Changeset 285101 in webkit

Timestamp:

Nov 1, 2021, 1:42:19 AM (4 years ago)

Author:

commit-queue@webkit.org

Message:

Fix build with GCC 8.4 on Ubuntu 18.04
​https://bugs.webkit.org/show_bug.cgi?id=232305

Patch by Daniel Kolesa <Daniel Kolesa> on 2021-11-01
Reviewed by Adrian Perez de Castro.

Source/WebCore:

Fix build with GCC 8.4 on Ubuntu 18.04

Thes sections of the code trigger an internal compiler error with
GCC 8.4, segfaulting the compiler. This adds a workaround that
makes it work again.

• Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp:

(WebCore::ClipboardItemBindingsDataSource::collectDataForWriting):

Source/WebKit:

Thes sections of the code trigger an internal compiler error with
GCC 8.4, segfaulting the compiler. This adds a workaround that
makes it work again.

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::deleteAndRestrictWebsiteDataForRegistrableDomains):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/NetworkProcess/NetworkProcess.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-11-01  Daniel Kolesa  <dkolesa@igalia.com>
+
+        Fix build with GCC 8.4 on Ubuntu 18.04
+        https://bugs.webkit.org/show_bug.cgi?id=232305
+
+        Reviewed by Adrian Perez de Castro.
+
+        Fix build with GCC 8.4 on Ubuntu 18.04
+
+        Thes sections of the code trigger an internal compiler error with
+        GCC 8.4, segfaulting the compiler. This adds a workaround that
+        makes it work again.
+
+        * Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp:
+        (WebCore::ClipboardItemBindingsDataSource::collectDataForWriting):
+
 2021-10-31  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp

@@ -140 +140 @@
 
         auto promise = typeAndItem.value;
-        promise->whenSettled([this, protectedItem = Ref { m_item }, destination = m_writingDestination, promise, type, weakItemTypeLoader = WeakPtr { itemTypeLoader }] () mutable {
+        /* hack: gcc 8.4 will segfault if the WeakPtr is instantiated within the lambda captures */
+        auto wl = WeakPtr { itemTypeLoader };
+        promise->whenSettled([this, protectedItem = Ref { m_item }, destination = m_writingDestination, promise, type, weakItemTypeLoader = WTFMove(wl)] () mutable {
             if (!weakItemTypeLoader)
                 return;

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-11-01  Daniel Kolesa  <dkolesa@igalia.com>
+
+        Fix build with GCC 8.4 on Ubuntu 18.04
+        https://bugs.webkit.org/show_bug.cgi?id=232305
+
+        Reviewed by Adrian Perez de Castro.
+
+        Thes sections of the code trigger an internal compiler error with
+        GCC 8.4, segfaulting the compiler. This adds a workaround that
+        makes it work again.
+
+        * NetworkProcess/NetworkProcess.cpp:
+        (WebKit::NetworkProcess::deleteAndRestrictWebsiteDataForRegistrableDomains):
+
 2021-10-31  Fujii Hironori  <Hironori.Fujii@sony.com>
 

trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp

@@ -1941 +1941 @@
     if (websiteDataTypes.contains(WebsiteDataType::DiskCache)) {
         forEachNetworkSession([sessionID, fetchOptions, &domainsToDeleteAllNonCookieWebsiteDataFor, &callbackAggregator](auto& session) {
-            fetchDiskCacheEntries(session.cache(), sessionID, fetchOptions, [domainsToDeleteAllNonCookieWebsiteDataFor, callbackAggregator, session = WeakPtr { session }](auto entries) mutable {
+            /* hack: gcc 8.4 will segfault if the WeakPtr is instantiated within the lambda captures */
+            auto ws = WeakPtr { session };
+            fetchDiskCacheEntries(session.cache(), sessionID, fetchOptions, [domainsToDeleteAllNonCookieWebsiteDataFor, callbackAggregator, session = WTFMove(ws)](auto entries) mutable {
                 if (!session)
                     return;