Changeset 285150 in webkit

Timestamp:

Nov 1, 2021, 7:30:27 PM (4 years ago)

Author:

Fujii Hironori

Message:

ImageDiff.cpp(74): warning C4477: 'fprintf' : format string '%lu' requires an argument of type 'unsigned long', but variadic argument 2 has type 'size_t'
​https://bugs.webkit.org/show_bug.cgi?id=232596

Reviewed by Don Olmstead.

Since r284764, MSVC reports the following warning and a suggestion.

Tools\ImageDiff\ImageDiff.cpp(74): warning C4477: 'fprintf' : format string '%lu' requires an argument of type 'unsigned long', but variadic argument 2 has type 'size_t'
Tools\ImageDiff\ImageDiff.cpp(74): note: consider using '%zu' in the format string

• ImageDiff/ImageDiff.cpp:

(processImages): Use %zu for size_t.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• ImageDiff/ImageDiff.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2021-11-01  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        ImageDiff.cpp(74): warning C4477: 'fprintf' : format string '%lu' requires an argument of type 'unsigned long', but variadic argument 2 has type 'size_t'
+        https://bugs.webkit.org/show_bug.cgi?id=232596
+
+        Reviewed by Don Olmstead.
+
+        Since r284764, MSVC reports the following warning and a suggestion.
+
+        > Tools\ImageDiff\ImageDiff.cpp(74): warning C4477: 'fprintf' : format string '%lu' requires an argument of type 'unsigned long', but variadic argument 2 has type 'size_t'
+        > Tools\ImageDiff\ImageDiff.cpp(74): note: consider using '%zu' in the format string
+
+        * ImageDiff/ImageDiff.cpp:
+        (processImages): Use %zu for size_t.
+
 2021-11-01  Jonathan Bedard  <jbedard@apple.com>
 

trunk/Tools/ImageDiff/ImageDiff.cpp

@@ -72 +72 @@
 
     if (printDifference)
-        fprintf(stdout, "maxDifference=%u; totalPixels=%lu\n", differenceData.maxDifference, differenceData.totalPixels);
+        fprintf(stdout, "maxDifference=%u; totalPixels=%zu\n", differenceData.maxDifference, differenceData.totalPixels);
 
     fprintf(stdout, "#EOF\n");