Changeset 285927 in webkit

Timestamp:

Nov 17, 2021, 6:50:52 AM (4 years ago)

Author:

youenn@apple.com

Message:

Increase CoreAudioCaptureSource capture verify timer to handle the case of device change
​https://bugs.webkit.org/show_bug.cgi?id=233250

Reviewed by Eric Carlson.

Previously, our capture verify timer was starting with 10 seconds to handle slow start up times, and decreasing to 2 seconds to be snappy.
We are now sticking to 10 seconds to handle the case of changing of capture device while capturing.
This happens on iOS for instance when going from builtin microphone to BT headset microphone.

Manually tested.

• platform/mediastream/mac/CoreAudioCaptureSource.cpp:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/mediastream/mac/CoreAudioCaptureSource.cpp (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-11-17  Youenn Fablet  <youenn@apple.com>
+
+        Increase CoreAudioCaptureSource capture verify timer to handle the case of device change
+        https://bugs.webkit.org/show_bug.cgi?id=233250
+
+        Reviewed by Eric Carlson.
+
+        Previously, our capture verify timer was starting with 10 seconds to handle slow start up times, and decreasing to 2 seconds to be snappy.
+        We are now sticking to 10 seconds to handle the case of changing of capture device while capturing.
+        This happens on iOS for instance when going from builtin microphone to BT headset microphone.
+
+        Manually tested.
+
+        * platform/mediastream/mac/CoreAudioCaptureSource.cpp:
+
 2021-11-17  Alan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp

@@ -140 +140 @@
     uint64_t m_microphoneProcsCalledLastTime { 0 };
     Timer m_verifyCapturingTimer;
+    static constexpr Seconds verifyCaptureInterval = 10_s;
 };
 
@@ -501 +502 @@
     m_ioUnitStarted = true;
 
-    m_verifyCapturingTimer.startRepeating(10_s);
+    m_verifyCapturingTimer.startRepeating(verifyCaptureInterval);
     m_microphoneProcsCalled = 0;
     m_microphoneProcsCalledLastTime = 0;
@@ -512 +513 @@
     if (m_microphoneProcsCalledLastTime != m_microphoneProcsCalled) {
         m_microphoneProcsCalledLastTime = m_microphoneProcsCalled;
-        if (m_verifyCapturingTimer.repeatInterval() == 10_s)
-            m_verifyCapturingTimer.startRepeating(2_s);
         return;
     }