Changeset 285975 in webkit

Timestamp:

Nov 17, 2021, 7:46:53 PM (4 years ago)

Author:

Devin Rousso

Message:

Web Inspector: assertion failures in WI.GridOverlayConfigurationDiagnosticEventRecorder
​https://bugs.webkit.org/show_bug.cgi?id=233298

Reviewed by Patrick Angle.

• UserInterface/Controllers/GridOverlayConfigurationDiagnosticEventRecorder.js:

(WI.GridOverlayConfigurationDiagnosticEventRecorder.prototype.teardown):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Controllers/GridOverlayConfigurationDiagnosticEventRecorder.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2021-11-17  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: assertion failures in `WI.GridOverlayConfigurationDiagnosticEventRecorder`
+        https://bugs.webkit.org/show_bug.cgi?id=233298
+
+        Reviewed by Patrick Angle.
+
+        * UserInterface/Controllers/GridOverlayConfigurationDiagnosticEventRecorder.js:
+        (WI.GridOverlayConfigurationDiagnosticEventRecorder.prototype.teardown):
+
 2021-11-17  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Controllers/GridOverlayConfigurationDiagnosticEventRecorder.js

@@ -65 +65 @@
         window.removeEventListener("keydown", this, options);
         window.removeEventListener("mousedown", this, options);
-        WI.overlayManager.addEventListener(WI.OverlayManager.Event.GridOverlayShown, this._handleGridOverlayShown, this);
-        WI.overlayManager.addEventListener(WI.OverlayManager.Event.GridOverlayHidden, this._handleGridOverlayHidden, this);
+        WI.overlayManager.removeEventListener(WI.OverlayManager.Event.GridOverlayShown, this._handleGridOverlayShown, this);
+        WI.overlayManager.removeEventListener(WI.OverlayManager.Event.GridOverlayHidden, this._handleGridOverlayHidden, this);
 
         this._stopEventSamplingTimerIfNeeded();