Changeset 286141 in webkit

Timestamp:

Nov 23, 2021, 7:47:06 PM (4 years ago)

Author:

Lauro Moura

Message:

[GTK] GdkRGBA expects colors to be in the 0.0 to 1.0 range
​https://bugs.webkit.org/show_bug.cgi?id=233452

Reviewed by Michael Catanzaro.

GTK4 debug was hitting assertInRange inside ColorTypes.h due to 255
being used as the max value, while GdkRGBA expects the value to be
between 0.0 and 1.0, per the official docs [1][2].

[1] ​https://docs.gtk.org/gdk3/struct.RGBA.html
[2] ​https://docs.gtk.org/gdk4/struct.RGBA.html

• MiniBrowser/gtk/BrowserWindow.c:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• MiniBrowser/gtk/BrowserWindow.c (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2021-11-23  Lauro Moura  <lmoura@igalia.com>
+
+        [GTK] GdkRGBA expects colors to be in the 0.0 to 1.0 range
+        https://bugs.webkit.org/show_bug.cgi?id=233452
+
+        Reviewed by Michael Catanzaro.
+
+        GTK4 debug was hitting assertInRange inside ColorTypes.h due to 255
+        being used as the max value, while GdkRGBA expects the value to be
+        between 0.0 and 1.0, per the official docs [1][2].
+
+        [1] https://docs.gtk.org/gdk3/struct.RGBA.html
+        [2] https://docs.gtk.org/gdk4/struct.RGBA.html
+
+        * MiniBrowser/gtk/BrowserWindow.c:
+
 2021-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Tools/MiniBrowser/gtk/BrowserWindow.c

@@ -1333 +1333 @@
 static void browser_window_init(BrowserWindow *window)
 {
-    window->backgroundColor.red = window->backgroundColor.green = window->backgroundColor.blue = 255;
-    window->backgroundColor.alpha = 1;
+    window->backgroundColor.red = window->backgroundColor.green = window->backgroundColor.blue = 1.0;
+    window->backgroundColor.alpha = 1.0;
 
     gtk_window_set_title(GTK_WINDOW(window), defaultWindowTitle);