Changeset 287521 in webkit

Timestamp:

Jan 2, 2022, 11:05:11 AM (4 years ago)

Author:

Wenson Hsieh

Message:

Followup to r287494
​https://bugs.webkit.org/show_bug.cgi?id=234747
rdar://85899879

Reviewed by Darin Adler.

Use auto instread of RefPtr when storing the result of enclosingImageElement() in a few places; this
method already returns a RefPtr.

• html/HTMLAttachmentElement.cpp:

(WebCore::HTMLAttachmentElement::updateAttributes):
(WebCore::HTMLAttachmentElement::updateEnclosingImageWithData):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLAttachmentElement.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        Followup to r287494
+        https://bugs.webkit.org/show_bug.cgi?id=234747
+        rdar://85899879
+
+        Reviewed by Darin Adler.
+
+        Use `auto` instread of `RefPtr` when storing the result of `enclosingImageElement()` in a few places; this
+        method already returns a `RefPtr`.
+
+        * html/HTMLAttachmentElement.cpp:
+        (WebCore::HTMLAttachmentElement::updateAttributes):
+        (WebCore::HTMLAttachmentElement::updateEnclosingImageWithData):
+
 2022-01-02  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/html/HTMLAttachmentElement.cpp

@@ -208 +208 @@
 {
     if (!newFilename.isNull()) {
-        if (RefPtr enclosingImage = enclosingImageElement())
+        if (auto enclosingImage = enclosingImageElement())
             enclosingImage->setAttributeWithoutSynchronization(HTMLNames::altAttr, newFilename);
         setAttributeWithoutSynchronization(HTMLNames::titleAttr, newFilename);
     } else {
-        if (RefPtr enclosingImage = enclosingImageElement())
+        if (auto enclosingImage = enclosingImageElement())
             enclosingImage->removeAttribute(HTMLNames::altAttr);
         removeAttribute(HTMLNames::titleAttr);
@@ -241 +241 @@
         return;
 
-    RefPtr enclosingImage = enclosingImageElement();
+    auto enclosingImage = enclosingImageElement();
     if (!enclosingImage)
         return;