Changeset 287759 in webkit

Timestamp:

Jan 7, 2022, 10:43:28 AM (4 years ago)

Author:

youenn@apple.com

Message:

Expose rvfc processingDuration for the WebRTC code path
​https://bugs.webkit.org/show_bug.cgi?id=234949

Reviewed by Eric Carlson.

Source/WebCore:

This processing duration is the time it took for an assembled frame to be decoded and sent to RealtimIncomingVideoSource.
This duration can be approximately retrieved from WebRTC encoded transform (time for the assembled frame, aka time just before decoding)
and the time at which it is exposed by requestVideoFrameCallback (aka time just after decoding).
The processing duration is rounded in milliseconds.

Covered by updated test.

• platform/mediastream/RealtimeIncomingVideoSource.cpp:

LayoutTests:

• webrtc/peerConnection-rvfc.html:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/webrtc/peerConnection-rvfc.html (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/mediastream/RealtimeIncomingVideoSource.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2022-01-07  Youenn Fablet  <youenn@apple.com>
+
+        Expose rvfc processingDuration for the WebRTC code path
+        https://bugs.webkit.org/show_bug.cgi?id=234949
+
+        Reviewed by Eric Carlson.
+
+        * webrtc/peerConnection-rvfc.html:
+
 2022-01-07  Simon Fraser  <simon.fraser@apple.com>
 

trunk/LayoutTests/webrtc/peerConnection-rvfc.html

@@ -54 +54 @@
     assert_equals(metadata.width, 320);
     assert_greater_than(metadata.presentedFrames, presentedFrames);
+    assert_greater_than(metadata.processingDuration, 0);
 }, "Validate callbacks and metadata for peer connection tracks");
         </script>

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-01-07  Youenn Fablet  <youenn@apple.com>
+
+        Expose rvfc processingDuration for the WebRTC code path
+        https://bugs.webkit.org/show_bug.cgi?id=234949
+
+        Reviewed by Eric Carlson.
+
+        This processing duration is the time it took for an assembled frame to be decoded and sent to RealtimIncomingVideoSource.
+        This duration can be approximately retrieved from WebRTC encoded transform (time for the assembled frame, aka time just before decoding)
+        and the time at which it is exposed by requestVideoFrameCallback (aka time just after decoding).
+        The processing duration is rounded in milliseconds.
+
+        Covered by updated test.
+
+        * platform/mediastream/RealtimeIncomingVideoSource.cpp:
+
 2022-01-07  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/platform/mediastream/RealtimeIncomingVideoSource.cpp

@@ -116 +116 @@
     });
     metadata.receiveTime = Seconds::fromMicroseconds(lastPacketTimestamp->receive_time().us());
+    if (frame.processing_time())
+        metadata.processingDuration = Seconds::fromMilliseconds(frame.processing_time()->Elapsed().ms()).value();
+
     return metadata;
 }