Changeset 287837 in webkit

Timestamp:

Jan 10, 2022, 9:09:17 AM (4 years ago)

Author:

commit-queue@webkit.org

Message:

postprocess-headers.sh: Avoid redundant processing to speed up incremental Xcode builds
​https://bugs.webkit.org/show_bug.cgi?id=234941

Patch by Elliott Williams <Elliott Williams> on 2022-01-10
Reviewed by Jonathan Bedard.

Source/JavaScriptCore:

On builds made with the legacy build system (currently any CLI build for Apple platforms),
postprocess-headers.sh always runs, even when no headers have been copied. PBXBuild doesn't
have the necessary granularity to let us avoid running it when there are no headers to copy,
however, this patch improves execution time by only running the postprocess rule when a
header has changed since the last time it ran.

This change reduces JavaScriptCore's null build time from ~18.3s to ~5.32s.

• postprocess-headers.sh: Added timestamp check

Source/WebKitLegacy/mac:

• postprocess-headers.sh:

Location:

trunk/Source

Files:

• JavaScriptCore/ChangeLog (modified) (1 diff)
• JavaScriptCore/postprocess-headers.sh (modified) (2 diffs)
• WebKitLegacy/mac/ChangeLog (modified) (1 diff)
• WebKitLegacy/mac/postprocess-headers.sh (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2022-01-10  Elliott Williams  <emw@apple.com>
+
+        postprocess-headers.sh: Avoid redundant processing to speed up incremental Xcode builds
+        https://bugs.webkit.org/show_bug.cgi?id=234941
+
+        Reviewed by Jonathan Bedard.
+
+        On builds made with the legacy build system (currently any CLI build for Apple platforms),
+        postprocess-headers.sh always runs, even when no headers have been copied. PBXBuild doesn't
+        have the necessary granularity to let us avoid running it when there are no headers to copy,
+        however, this patch improves execution time by only running the postprocess rule when a
+        header has changed since the last time it ran.
+
+        This change reduces JavaScriptCore's null build time from ~18.3s to ~5.32s.
+
+        * postprocess-headers.sh: Added timestamp check
+
 2022-01-09  Sam Weinig  <weinig@apple.com>
 

trunk/Source/JavaScriptCore/postprocess-headers.sh

@@ -27 +27 @@
 POSTPROCESS_HEADER_RULE="${SRCROOT}/Scripts/postprocess-header-rule"
 [[ -x "${POSTPROCESS_HEADER_RULE}" ]] || { echo "### Unable to find ${POSTPROCESS_HEADER_RULE}"; exit 1; }
+TIMESTAMP="${TARGET_TEMP_DIR}/postprocess-headers-timestamp"
 
 function rewrite_headers ()
 {
     for HEADER_PATH in "${1}/"*.h; do
+        [ "${TIMESTAMP}" -nt "${HEADER_PATH}" ] || \
         SCRIPT_HEADER_VISIBILITY="${2}" \
         SCRIPT_INPUT_FILE="${HEADER_PATH}" \
@@ -40 +42 @@
 rewrite_headers "${TARGET_BUILD_DIR}/${PUBLIC_HEADERS_FOLDER_PATH}" Public
 rewrite_headers "${TARGET_BUILD_DIR}/${PRIVATE_HEADERS_FOLDER_PATH}" Private
+touch "${TIMESTAMP}"

trunk/Source/WebKitLegacy/mac/ChangeLog

@@ +1 @@
+2022-01-10  Elliott Williams  <emw@apple.com>
+
+        postprocess-headers.sh: Avoid redundant processing to speed up incremental Xcode builds
+        https://bugs.webkit.org/show_bug.cgi?id=234941
+
+        Reviewed by Jonathan Bedard.
+
+        * postprocess-headers.sh:
+
 2022-01-07  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKitLegacy/mac/postprocess-headers.sh

@@ -27 +27 @@
 POSTPROCESS_HEADER_RULE="${SRCROOT}/scripts/postprocess-header-rule"
 [[ -x "${POSTPROCESS_HEADER_RULE}" ]] || { echo "### Unable to find ${POSTPROCESS_HEADER_RULE}"; exit 1; }
+TIMESTAMP="${TARGET_TEMP_DIR}/postprocess-headers-timestamp"
 
 function rewrite_headers ()
@@ -39 +40 @@
 
 rewrite_headers "${TARGET_BUILD_DIR}/${PRIVATE_HEADERS_FOLDER_PATH}" Private
+touch "${TIMESTAMP}"