Changeset 289915 in webkit


Ignore:
Timestamp:
Feb 16, 2022, 10:49:49 AM (3 years ago)
Author:
Russell Epstein
Message:

Cherry-pick r289869. rdar://problem/88927346

[ iOS ] fast/text/ch-unit-synthetic-bold.html is failing constantly on iOS
​https://bugs.webkit.org/show_bug.cgi?id=236610

Turns out iOS doesn't have Monaco. It's fine though; we can use local() to create
a font that doesn't have a bold family member.

Unreviewed.

  • fast/text/ch-unit-synthetic-bold-expected.html:
  • fast/text/ch-unit-synthetic-bold.html:
  • fast/text/tab-width-synthetic-bold-complex-expected.html:
  • fast/text/tab-width-synthetic-bold-complex.html:
  • fast/text/tab-width-synthetic-bold-expected.html:
  • fast/text/tab-width-synthetic-bold.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@289869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:
branches/safari-614.1.4-branch/LayoutTests
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • branches/safari-614.1.4-branch/LayoutTests/ChangeLog

    r289914 r289915  
     12022-02-16  Russell Epstein  <repstein@apple.com>
     2
     3        Cherry-pick r289869. rdar://problem/88927346
     4
     5    [ iOS ] fast/text/ch-unit-synthetic-bold.html is failing constantly on iOS
     6    https://bugs.webkit.org/show_bug.cgi?id=236610
     7   
     8    Turns out iOS doesn't have Monaco. It's fine though; we can use local() to create
     9    a font that doesn't have a bold family member.
     10   
     11    Unreviewed.
     12   
     13    * fast/text/ch-unit-synthetic-bold-expected.html:
     14    * fast/text/ch-unit-synthetic-bold.html:
     15    * fast/text/tab-width-synthetic-bold-complex-expected.html:
     16    * fast/text/tab-width-synthetic-bold-complex.html:
     17    * fast/text/tab-width-synthetic-bold-expected.html:
     18    * fast/text/tab-width-synthetic-bold.html:
     19   
     20    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289869 268f45cc-cd09-0410-ab3c-d52691b4dbfc
     21
     22    2022-02-15  Myles C. Maxfield  <mmaxfield@apple.com>
     23
     24            [ iOS ] fast/text/ch-unit-synthetic-bold.html is failing constantly on iOS
     25            https://bugs.webkit.org/show_bug.cgi?id=236610
     26
     27            Turns out iOS doesn't have Monaco. It's fine though; we can use local() to create
     28            a font that doesn't have a bold family member.
     29
     30            Unreviewed.
     31
     32            * fast/text/ch-unit-synthetic-bold-expected.html:
     33            * fast/text/ch-unit-synthetic-bold.html:
     34            * fast/text/tab-width-synthetic-bold-complex-expected.html:
     35            * fast/text/tab-width-synthetic-bold-complex.html:
     36            * fast/text/tab-width-synthetic-bold-expected.html:
     37            * fast/text/tab-width-synthetic-bold.html:
     38
    1392022-02-16  Russell Epstein  <repstein@apple.com>
    240

  • branches/safari-614.1.4-branch/LayoutTests/fast/text/ch-unit-synthetic-bold-expected.html

    r289609 r289915  
    22<html>
    33<head>
     4<style>
     5@font-face {
     6    font-family: DoesNotHaveBold;
     7    src: local("Times");
     8}
     9</style>
    410</head>
    511<body>
    612This test makes sure that the <code>ch</code> unit, which is supposed to be as wide as the <code>0</code> character, is in fact that wide, even if the font is using synthetic bold. The test passes if the width of the green box matches in both cases.
    713<div>
    8 <div style="font: bold 16px 'Monaco'; display: inline-block; background: green; color: transparent;">0000000000</div>
     14<div style="font: bold 16px 'DoesNotHaveBold'; display: inline-block; background: green; color: transparent;">0000000000</div>
    915</div>
    1016</body>

  • branches/safari-614.1.4-branch/LayoutTests/fast/text/ch-unit-synthetic-bold.html

    r289609 r289915  
    22<html>
    33<head>
     4<style>
     5@font-face {
     6    font-family: DoesNotHaveBold;
     7    src: local("Times");
     8}
     9</style>
    410</head>
    511<body>
    612This test makes sure that the <code>ch</code> unit, which is supposed to be as wide as the <code>0</code> character, is in fact that wide, even if the font is using synthetic bold. The test passes if the width of the green box matches in both cases.
    7 <div style="font: bold 16px 'Monaco'; background: green; width: 10ch; color: transparent;">a</div>
     13<div style="font: bold 16px 'DoesNotHaveBold'; background: green; width: 10ch; color: transparent;">a</div>
    814</body>
    915</html>

  • branches/safari-614.1.4-branch/LayoutTests/fast/text/tab-width-synthetic-bold-complex-expected.html

    r289609 r289915  
    22<html>
    33<head>
     4<style>
     5@font-face {
     6    font-family: DoesNotHaveBold;
     7    src: local("Times");
     8}
     9</style>
    410</head>
    511<body>
    612This test makes sure that, when the width of a tab is set to be a multiple of the space width, that the space width includes the synthetic bold expansion. The test passes if the width of the green box matches in both cases.
    713<div>
    8 <pre style="font: bold 16px 'Monaco'; display: inline-block; background: green; tab-size: 16;">                </pre>
     14<pre style="font: bold 16px 'DoesNotHaveBold'; display: inline-block; background: green; tab-size: 16;">                </pre>
    915</div>
    1016</body>

  • branches/safari-614.1.4-branch/LayoutTests/fast/text/tab-width-synthetic-bold-complex.html

    r289609 r289915  
    22<html>
    33<head>
     4<style>
     5@font-face {
     6    font-family: DoesNotHaveBold;
     7    src: local("Times");
     8}
     9</style>
    410</head>
    511<body>
    612This test makes sure that, when the width of a tab is set to be a multiple of the space width, that the space width includes the synthetic bold expansion. The test passes if the width of the green box matches in both cases.
    713<div>
    8 <pre style="font: bold 16px 'Monaco'; font-feature-settings: 'ABCD'; display: inline-block; background: green; tab-size: 16;">&#x9;</pre>
     14<pre style="font: bold 16px 'DoesNotHaveBold'; font-feature-settings: 'ABCD'; display: inline-block; background: green; tab-size: 16;">&#x9;</pre>
    915</div>
    1016</body>

  • branches/safari-614.1.4-branch/LayoutTests/fast/text/tab-width-synthetic-bold-expected.html

    r289609 r289915  
    22<html>
    33<head>
     4<style>
     5@font-face {
     6    font-family: DoesNotHaveBold;
     7    src: local("Times");
     8}
     9</style>
    410</head>
    511<body>
    612This test makes sure that, when the width of a tab is set to be a multiple of the space width, that the space width includes the synthetic bold expansion. The test passes if the width of the green box matches in both cases.
    713<div>
    8 <pre style="font: bold 16px 'Monaco'; display: inline-block; background: green; tab-size: 16;">                </pre>
     14<pre style="font: bold 16px 'DoesNotHaveBold'; display: inline-block; background: green; tab-size: 16;">                </pre>
    915</div>
    1016</body>

  • branches/safari-614.1.4-branch/LayoutTests/fast/text/tab-width-synthetic-bold.html

    r289609 r289915  
    22<html>
    33<head>
     4<style>
     5@font-face {
     6    font-family: DoesNotHaveBold;
     7    src: local("Times");
     8}
     9</style>
    410</head>
    511<body>
    612This test makes sure that, when the width of a tab is set to be a multiple of the space width, that the space width includes the synthetic bold expansion. The test passes if the width of the green box matches in both cases.
    713<div>
    8 <pre style="font: bold 16px 'Monaco'; display: inline-block; background: green; tab-size: 16;">&#x9;</pre>
     14<pre style="font: bold 16px 'DoesNotHaveBold'; display: inline-block; background: green; tab-size: 16;">&#x9;</pre>
    915</div>
    1016</body>
Note: See TracChangeset for help on using the changeset viewer.