Changeset 289966 in webkit

Timestamp:

Feb 16, 2022, 2:50:09 PM (4 years ago)

Author:

Jonathan Bedard

Message:

[EWS] Rename 'patch' to 'change' in JSC steps
​https://bugs.webkit.org/show_bug.cgi?id=236679
<rdar://problem/88993957>

Reviewed by Aakash Jain.

• Tools/CISupport/ews-build/steps.py:

(AnalyzeJSCTestsResults.start): Rename 'patch' in variables and log messages to 'change'.
(AnalyzeJSCTestsResults.report_failure): Ditto.

• Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: ​https://commits.webkit.org/247354@main

Location:

trunk/Tools

Files:

• CISupport/ews-build/steps.py (modified) (3 diffs)
• CISupport/ews-build/steps_unittest.py (modified) (2 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/CISupport/ews-build/steps.py

@@ -2405 +2405 @@
 
     def start(self):
-        stress_failures_with_patch = set(self.getProperty('jsc_stress_test_failures', []))
-        binary_failures_with_patch = set(self.getProperty('jsc_binary_failures', []))
+        stress_failures_with_change = set(self.getProperty('jsc_stress_test_failures', []))
+        binary_failures_with_change = set(self.getProperty('jsc_binary_failures', []))
         clean_tree_stress_failures = set(self.getProperty('jsc_clean_tree_stress_test_failures', []))
         clean_tree_binary_failures = set(self.getProperty('jsc_clean_tree_binary_failures', []))
@@ -2412 +2412 @@
         clean_tree_failures_string = ', '.join(clean_tree_failures[:self.NUM_FAILURES_TO_DISPLAY])
 
-        flaky_stress_failures_with_patch = set(self.getProperty('jsc_flaky_and_passed', {}).keys())
+        flaky_stress_failures_with_change = set(self.getProperty('jsc_flaky_and_passed', {}).keys())
         clean_tree_flaky_stress_failures = set(self.getProperty('jsc_clean_tree_flaky_and_passed', {}).keys())
-        flaky_stress_failures = sorted(list(flaky_stress_failures_with_patch) + list(clean_tree_flaky_stress_failures))[:self.NUM_FAILURES_TO_DISPLAY]
+        flaky_stress_failures = sorted(list(flaky_stress_failures_with_change) + list(clean_tree_flaky_stress_failures))[:self.NUM_FAILURES_TO_DISPLAY]
         flaky_failures_string = ', '.join(flaky_stress_failures)
 
-        new_stress_failures = stress_failures_with_patch - clean_tree_stress_failures
-        new_binary_failures = binary_failures_with_patch - clean_tree_binary_failures
+        new_stress_failures = stress_failures_with_change - clean_tree_stress_failures
+        new_binary_failures = binary_failures_with_change - clean_tree_binary_failures
         self.new_stress_failures_to_display = ', '.join(sorted(list(new_stress_failures))[:self.NUM_FAILURES_TO_DISPLAY])
         self.new_binary_failures_to_display = ', '.join(sorted(list(new_binary_failures))[:self.NUM_FAILURES_TO_DISPLAY])
 
-        self._addToLog('stderr', '\nFailures with patch: {}'.format(list(binary_failures_with_patch) + list(stress_failures_with_patch))[:self.NUM_FAILURES_TO_DISPLAY])
-        self._addToLog('stderr', '\nFlaky Tests with patch: {}'.format(', '.join(flaky_stress_failures_with_patch)))
+        self._addToLog('stderr', '\nFailures with change: {}'.format(list(binary_failures_with_change) + list(stress_failures_with_change))[:self.NUM_FAILURES_TO_DISPLAY])
+        self._addToLog('stderr', '\nFlaky Tests with change: {}'.format(', '.join(flaky_stress_failures_with_change)))
         self._addToLog('stderr', '\nFailures on clean tree: {}'.format(clean_tree_failures_string))
         self._addToLog('stderr', '\nFlaky Tests on clean tree: {}'.format(', '.join(clean_tree_flaky_stress_failures)))
 
-        if (not stress_failures_with_patch) and (not binary_failures_with_patch):
+        if (not stress_failures_with_change) and (not binary_failures_with_change):
             # If we've made it here, then jsc-tests and re-run-jsc-tests failed, which means
             # there should have been some test failures. Otherwise there is some unexpected issue.
@@ -2468 +2468 @@
         message = ''
         if (not new_binary_failures) and (not new_stress_failures):
-            message = 'Found unexpected failure with patch'
+            message = 'Found unexpected failure with change'
         if new_binary_failures:
             pluralSuffix = 's' if len(new_binary_failures) > 1 else ''

trunk/Tools/CISupport/ews-build/steps_unittest.py

@@ -1725 +1725 @@
         return self.runStep()
 
-    def test_patch_breaking_jsc_test_suite(self):
+    def test_change_breaking_jsc_test_suite(self):
         self.configureStep()
         self.setProperty('jsc_stress_test_failures', [])
@@ -1732 +1732 @@
         self.setProperty('jsc_clean_tree_flaky_and_passed', {})
         self.setProperty('clean_tree_run_status', SUCCESS)
-        self.expectOutcome(result=FAILURE, state_string='Found unexpected failure with patch (failure)')
+        self.expectOutcome(result=FAILURE, state_string='Found unexpected failure with change (failure)')
         return self.runStep()
 

trunk/Tools/ChangeLog

@@ +1 @@
+2022-02-15  Jonathan Bedard  <jbedard@apple.com>
+
+        [EWS] Rename 'patch' to 'change' in JSC steps
+        https://bugs.webkit.org/show_bug.cgi?id=236679
+        <rdar://problem/88993957>
+
+        Reviewed by Aakash Jain.
+
+        * CISupport/ews-build/steps.py:
+        (AnalyzeJSCTestsResults.start): Rename 'patch' in variables and log messages to 'change'.
+        (AnalyzeJSCTestsResults.report_failure): Ditto.
+        * CISupport/ews-build/steps_unittest.py:
+
 2022-02-15  Jonathan Bedard  <jbedard@apple.com>