Changeset 290014 in webkit

Timestamp:

Feb 17, 2022, 5:38:12 AM (4 years ago)

Author:

Angelos Oikonomopoulos

Message:

[JSC] Increase timeout to account for MIPS slowness
​https://bugs.webkit.org/show_bug.cgi?id=236763

Reviewed by Adrian Perez de Castro.

Commit ​https://commits.webkit.org/247272@main parallelized the
status fetching but also introduced a timeout. Unfortunately, the
MIPS boards used in the build.webkit.org buildbot are not fast
enough to gather the test results in this timeout, so the bot can
never complete its testing. This wasn't caught in EWS as the
buildbots use faster MIPS hardware there.

Significantly bump the timeout when fetching results.

• Scripts/run-jsc-stress-tests:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/run-jsc-stress-tests (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2022-02-17  Angelos Oikonomopoulos  <angelos@igalia.com>
+
+        [JSC] Increase timeout to account for MIPS slowness
+        https://bugs.webkit.org/show_bug.cgi?id=236763
+
+        Reviewed by Adrian Perez de Castro.
+
+        Commit https://commits.webkit.org/247272@main parallelized the
+        status fetching but also introduced a timeout. Unfortunately, the
+        MIPS boards used in the build.webkit.org buildbot are not fast
+        enough to gather the test results in this timeout, so the bot can
+        never complete its testing. This wasn't caught in EWS as the
+        buildbots use faster MIPS hardware there.
+
+        Significantly bump the timeout when fetching results.
+
+        * Scripts/run-jsc-stress-tests:
+
 2022-02-16  Sihui Liu  <sihui_liu@apple.com>
 

trunk/Tools/Scripts/run-jsc-stress-tests

@@ -2770 +2770 @@
         # (note, the test results are tagged with a run ID, so we'll
         # ignore any stale results from a previous run).
-        forEachRemote($remoteHosts, :dropOnFailure => true, :timeout => REMOTE_TIMEOUT) { |_, host|
+        forEachRemote($remoteHosts, :dropOnFailure => true, :timeout => 8 * REMOTE_TIMEOUT) { |_, host|
             runnerDir = "#{host.remoteDirectory}/#{$outputDir.basename}/.runner"
             output = sshRead("if test -d #{runnerDir}; then cd #{runnerDir}; else false; fi && " + find_cmd, host, :ignoreFailure => true)