Changeset 290445 in webkit

Timestamp:

Feb 24, 2022, 11:41:30 AM (4 years ago)

Author:

Chris Dumez

Message:

Fix bad logging in SharedWorkerObjectConnection::notifyWorkerObjectOfLoadCompletion()
​https://bugs.webkit.org/show_bug.cgi?id=237146

Reviewed by Geoffrey Garen.

Fix bad logging in SharedWorkerObjectConnection::notifyWorkerObjectOfLoadCompletion().
It was logging an error even when the load succeeded.

• workers/shared/SharedWorkerObjectConnection.cpp:

(WebCore::SharedWorkerObjectConnection::notifyWorkerObjectOfLoadCompletion):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• workers/shared/SharedWorkerObjectConnection.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-02-24  Chris Dumez  <cdumez@apple.com>
+
+        Fix bad logging in SharedWorkerObjectConnection::notifyWorkerObjectOfLoadCompletion()
+        https://bugs.webkit.org/show_bug.cgi?id=237146
+
+        Reviewed by Geoffrey Garen.
+
+        Fix bad logging in SharedWorkerObjectConnection::notifyWorkerObjectOfLoadCompletion().
+        It was logging an error even when the load succeeded.
+
+        * workers/shared/SharedWorkerObjectConnection.cpp:
+        (WebCore::SharedWorkerObjectConnection::notifyWorkerObjectOfLoadCompletion):
+
 2022-02-24  Kate Cheney  <katherine_cheney@apple.com>
 

trunk/Source/WebCore/workers/shared/SharedWorkerObjectConnection.cpp

@@ -73 +73 @@
     ASSERT(isMainThread());
     auto* workerObject = SharedWorker::fromIdentifier(sharedWorkerObjectIdentifier);
-    CONNECTION_RELEASE_LOG_ERROR("notifyWorkerObjectOfLoadCompletion: sharedWorkerObjectIdentifier=%{public}s, worker=%p, success=%d", sharedWorkerObjectIdentifier.toString().utf8().data(), workerObject, error.isNull());
+    if (error.isNull())
+        CONNECTION_RELEASE_LOG("notifyWorkerObjectOfLoadCompletion: sharedWorkerObjectIdentifier=%{public}s, worker=%p, load succeeded", sharedWorkerObjectIdentifier.toString().utf8().data(), workerObject);
+    else
+        CONNECTION_RELEASE_LOG_ERROR("notifyWorkerObjectOfLoadCompletion: sharedWorkerObjectIdentifier=%{public}s, worker=%p, load failed", sharedWorkerObjectIdentifier.toString().utf8().data(), workerObject);
     if (workerObject)
         workerObject->didFinishLoading(error);