Changeset 293332 in webkit


Ignore:
Timestamp:
Apr 25, 2022, 11:19:48 AM (3 years ago)
Author:
ntim@apple.com
Message:

Unprefix modern-media-controls CSS properties
​https://bugs.webkit.org/show_bug.cgi?id=239726

Reviewed by Eric Carlson.

  • Modules/modern-media-controls/controls/button.css:

(button):
(button > picture):

  • Modules/modern-media-controls/controls/button.js:

(Button.prototype.commitProperty):

  • Modules/modern-media-controls/controls/media-controls.css:

(.media-controls > *):

  • Modules/modern-media-controls/controls/slider.css:

(.slider > input):
(.ios .slider > input):
(.slider > input::-webkit-slider-thumb):

  • Modules/modern-media-controls/controls/text-tracks.css:

(video::-webkit-media-text-track-container):

  • Modules/modern-media-controls/controls/watchos-activity-indicator.css:

(button.watchos-activity-indicator > picture):

Location:
trunk/Source/WebCore
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r293330 r293332  
     12022-04-25  Tim Nguyen  <ntim@apple.com>
     2
     3        Unprefix modern-media-controls CSS properties
     4        https://bugs.webkit.org/show_bug.cgi?id=239726
     5
     6        Reviewed by Eric Carlson.
     7
     8        * Modules/modern-media-controls/controls/button.css:
     9        (button):
     10        (button > picture):
     11        * Modules/modern-media-controls/controls/button.js:
     12        (Button.prototype.commitProperty):
     13        * Modules/modern-media-controls/controls/media-controls.css:
     14        (.media-controls > *):
     15        * Modules/modern-media-controls/controls/slider.css:
     16        (.slider > input):
     17        (.ios .slider > input):
     18        (.slider > input::-webkit-slider-thumb):
     19        * Modules/modern-media-controls/controls/text-tracks.css:
     20        (video::-webkit-media-text-track-container):
     21        * Modules/modern-media-controls/controls/watchos-activity-indicator.css:
     22        (button.watchos-activity-indicator > picture):
     23
    1242022-04-25  Claudio Saavedra  <csaavedra@igalia.com>
    225

  • trunk/Source/WebCore/Modules/modern-media-controls/controls/button.css

    r282273 r293332  
    3333    justify-content: center;
    3434    background-color: transparent !important;
    35     -webkit-appearance: none;
    36     -webkit-user-select: none;
     35    appearance: none;
     36    user-select: none;
    3737    -webkit-tap-highlight-color: transparent;
    3838}
    … …  
    4343    background-color: var(--secondary-glyph-color);
    4444    mix-blend-mode: plus-lighter;
    45     -webkit-mask-size: 100% 100%;
    46     -webkit-mask-repeat: no-repeat;
     45    mask-size: 100% 100%;
     46    mask-repeat: no-repeat;
    4747    transition: transform 150ms;
    4848    will-change: transform;

  • trunk/Source/WebCore/Modules/modern-media-controls/controls/button.js

    r282273 r293332  
    158158    {
    159159        if (propertyName === "maskImage")
    160             this.image.element.style.webkitMaskImage = `url(${this._imageSource.src})`;
     160            this.image.element.style.maskImage = `url(${this._imageSource.src})`;
    161161        else
    162162            super.commitProperty(propertyName);

  • trunk/Source/WebCore/Modules/modern-media-controls/controls/media-controls.css

    r285609 r293332  
    9393.media-controls > * {
    9494    /* We always want to avoid showing the text selection magnifier on iOS. */
    95     -webkit-user-select: none;
     95    user-select: none;
    9696    transition: opacity 0.1s linear;
    9797}

  • trunk/Source/WebCore/Modules/modern-media-controls/controls/slider.css

    r280477 r293332  
    103103    height: 100%;
    104104    background-color: transparent;
    105     -webkit-appearance: none !important;
     105    appearance: none !important;
    106106    /* Disabling this for now because the outline is visualy inconsistent with the button
    107107       focus state. Tracking at https://bugs.webkit.org/show_bug.cgi?id=174906 */
    … …  
    115115
    116116    /* Make sure we don't show any UI as we drag the scrubber on iOS. */
    117     -webkit-user-select: none !important;
     117    user-select: none !important;
    118118    -webkit-touch-callout: none !important;
    119119    -webkit-tap-highlight-color: transparent;
    … …  
    126126    box-shadow: none;
    127127    background-color: transparent;
    128     -webkit-appearance: none !important;
     128    appearance: none !important;
    129129    pointer-events: all;
    130130}

  • trunk/Source/WebCore/Modules/modern-media-controls/controls/text-tracks.css

    r274810 r293332  
    3838    text-decoration: none;
    3939    pointer-events: none;
    40     -webkit-user-select: none;
     40    user-select: none;
    4141
    4242    flex: 1 1 auto;

  • trunk/Source/WebCore/Modules/modern-media-controls/controls/watchos-activity-indicator.css

    r274299 r293332  
    3333    height: 29.5px !important;
    3434
    35     -webkit-mask-size: calc(var(--number-of-frames) * 100%) 100%;
     35    mask-size: calc(var(--number-of-frames) * 100%) 100%;
    3636
    3737    /* We apply two animations in sequence, first the intro which goes for 8 frames (0 - 7) and whichs
Note: See TracChangeset for help on using the changeset viewer.