Changeset 29370 in webkit

Timestamp:

Jan 10, 2008, 1:33:19 PM (18 years ago)

Author:

ap@webkit.org

Message:

Reviewed by Adam Roben.

<rdar://problem/5667003> fast/dom/xmlhttprequest-html-response-encoding.html is failing

• xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send): Do not disable sniffing for ​file:// requests, as CFNetwork doesn't perform extension to MIME type mapping then.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/win/Skipped (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/xml/XMLHttpRequest.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2008-01-10  Alexey Proskuryakov  <ap@webkit.org>
+
+        Reviewed by Adam Roben.
+
+        <rdar://problem/5667003> fast/dom/xmlhttprequest-html-response-encoding.html is failing
+
+        * platform/win/Skipped: Remove the fixed test.
+
 2008-01-10  Kevin McCullough  <kmccullough@apple.com>
 

trunk/LayoutTests/platform/win/Skipped

@@ -365 +365 @@
 svg/custom/use-css-no-effect-on-shadow-tree.svg
 
-# <rdar://5667003> Undefined value exception
-fast/dom/xmlhttprequest-html-response-encoding.html
-
 # <rdar://5667007> 2 SVG text tests failing (due to bad rounding?)
 svg/batik/text/textOnPath.svg

trunk/WebCore/ChangeLog

@@ +1 @@
+2008-01-10  Alexey Proskuryakov  <ap@webkit.org>
+
+        Reviewed by Adam Roben.
+
+        <rdar://problem/5667003> fast/dom/xmlhttprequest-html-response-encoding.html is failing
+
+        * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send): Do not disable sniffing for file://
+        requests, as CFNetwork doesn't perform extension to MIME type mapping then.
+
 2008-01-10  Adam Roben  <aroben@apple.com>
 

trunk/WebCore/xml/XMLHttpRequest.cpp

@@ -475 +475 @@
     }
   
-    // create can return null here, for example if we're no longer attached to a page.
-    // this is true while running onunload handlers
-    // FIXME: Maybe create can return false for other reasons too?
-    m_loader = SubresourceLoader::create(m_doc->frame(), this, request, false, true, false);
+    // SubresourceLoader::create can return null here, for example if we're no longer attached to a page.
+    // This is true while running onunload handlers.
+    // FIXME: We need to be able to send XMLHttpRequests from onunload, <http://bugs.webkit.org/show_bug.cgi?id=10904>.
+    // FIXME: Maybe create can return null for other reasons too?
+    // We need to keep content sniffing enabled for local files due to CFNetwork not providing a MIME type
+    // for local files otherwise, <rdar://problem/5671813>.
+    m_loader = SubresourceLoader::create(m_doc->frame(), this, request, false, true, request.url().isLocalFile());
 }