Changeset 293922 in webkit

Timestamp:

May 6, 2022, 2:03:27 PM (3 years ago)

Author:

gnavamarino@apple.com

Message:

null ptr deref in WebCore::Frame::setPrinting
​https://bugs.webkit.org/show_bug.cgi?id=240173

Reviewed by Wenson Hsieh.

Check m_doc in Frame::setPrinting before access, as it is a RefPtr that can become null.

• page/Frame.cpp:

(WebCore::Frame::setPrinting):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/Frame.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-05-06  Gabriel Nava Marino  <gnavamarino@apple.com>
+
+        null ptr deref in WebCore::Frame::setPrinting
+        https://bugs.webkit.org/show_bug.cgi?id=240173
+
+        Reviewed by Wenson Hsieh.
+
+        Check m_doc in Frame::setPrinting before access, as it is a RefPtr that can become null.
+
+        * page/Frame.cpp:
+        (WebCore::Frame::setPrinting):
+
 2022-05-05  Ben Nham  <nham@apple.com>
         

trunk/Source/WebCore/page/Frame.cpp

@@ -603 +603 @@
 void Frame::setPrinting(bool printing, const FloatSize& pageSize, const FloatSize& originalPageSize, float maximumShrinkRatio, AdjustViewSizeOrNot shouldAdjustViewSize)
 {
-    if (!view())
+    if (!view() || !document())
         return;
     // In setting printing, we should not validate resources already cached for the document.