Changeset 294691 in webkit

Timestamp:

May 23, 2022, 3:53:13 PM (3 years ago)

Author:

commit-queue@webkit.org

Message:

Null check split node parent in outdentParagraph
​https://bugs.webkit.org/show_bug.cgi?id=240806

Patch by Rob Buis <​rbuis@igalia.com> on 2022-05-23
Reviewed by Wenson Hsieh.

The split node parent needs an extra null check to access its parent
before safely calling hasEditableStyle.

• Source/WebCore/editing/IndentOutdentCommand.cpp:

(WebCore::IndentOutdentCommand::outdentParagraph):

Canonical link: ​https://commits.webkit.org/250895@main

File:

• trunk/Source/WebCore/editing/IndentOutdentCommand.cpp (modified) (1 diff)

trunk/Source/WebCore/editing/IndentOutdentCommand.cpp

@@ -165 +165 @@
                 if (splitPointParent->hasTagName(blockquoteTag)
                     && !splitPoint->hasTagName(blockquoteTag)
+                    && splitPointParent->parentNode()
                     && splitPointParent->parentNode()->hasEditableStyle()) // We can't outdent if there is no place to go!
                     splitElement(downcast<Element>(*splitPointParent), *splitPoint);