Changeset 295115 in webkit

Timestamp:

Jun 1, 2022, 8:22:21 PM (3 years ago)

Author:

achristensen@apple.com

Message:

Set PluginView::Stream::m_loader before calling NetscapePlugInStreamLoader::cancel
​https://bugs.webkit.org/show_bug.cgi?id=241210

Reviewed by Chris Dumez.

• ../../Source/WebKit/WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::Stream::cancel):

Canonical link: ​https://commits.webkit.org/251206@main

File:

• trunk/Source/WebKit/WebProcess/Plugins/PluginView.cpp (modified) (1 diff)

trunk/Source/WebKit/WebProcess/Plugins/PluginView.cpp

@@ -142 +142 @@
 
     m_streamWasCancelled = true;
-    m_loader->cancel(m_loader->cancelledError());
-    m_loader = nullptr;
+
+    auto loader = std::exchange(m_loader, nullptr);
+    loader->cancel(loader->cancelledError());
 }