Changeset 73386 in webkit


Ignore:
Timestamp:
Dec 6, 2010, 12:32:57 PM (15 years ago)
Author:
aa@chromium.org
Message:

Merge 73245 - 2010-12-02 Aaron Boodman <​aa@chromium.org>

Reviewed by David Hyatt.

Reduce the number of cases where we end up with a stale value for
minimumPreferredLogicalWidth(). This isn't a complete fix, but fixes a
large number of cases.

RenderObject::minimumPreferredLogicalWidth() sometimes reports wrong value.
​https://bugs.webkit.org/show_bug.cgi?id=50119

  • rendering/RenderBox.cpp: (WebCore::RenderBox::styleDidChange):

TBR=​aa@chromium.org
Review URL: ​http://codereview.chromium.org/5661001

Location:
branches/chromium/597/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • branches/chromium/597/WebCore/ChangeLog

    r73371 r73386  
    1 2010-12-03  Dimitri Glazkov  <dglazkov@chromium.org>
    2 
    3         Reviewed by Darin Adler.
    4 
    5         REGRESSION(r71934): input event fires twice when editing text inside a text input.
    6         https://bugs.webkit.org/show_bug.cgi?id=50477
    7 
    8         Now that events escape the shadow DOM boundary, the input event is fired twice
    9         for each input, once triggered by editing, once triggered by value change.
    10 
    11         Test: fast/forms/text-input-event.html
    12 
    13         * dom/InputElement.cpp:
    14         (WebCore::InputElement::setValueFromRenderer): Added a check to ensure editable fields
    15             don't fire an extra input event.
    16 
    17 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
    18 
    19         Unreviewed, rolling out r73302.
    20         http://trac.webkit.org/changeset/73302
    21         https://bugs.webkit.org/show_bug.cgi?id=50499
    22 
    23         Causes crashes in debug LayoutTests (Requested by xan_ on
    24         #webkit).
    25 
    26         * accessibility/AccessibilityRenderObject.cpp:
    27         (WebCore::AccessibilityRenderObject::renderParentObject):
    28         (WebCore::AccessibilityRenderObject::addChildren):
    29         * accessibility/AccessibilityRenderObject.h:
    30         * accessibility/chromium/AccessibilityObjectChromium.cpp:
    31         (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
    32 
    33 2010-12-01  Ilya Tikhonovsky  <loislo@chromium.org>
    34 
    35         Reviewed by Pavel Feldman.
    36 
    37         Web Inspector: Inspector protocol cleanup task.
    38 
    39         The patch has just small renames and adjustments for the protocol things.
    40         'handler' keyword in idl file was replaced with 'domain'.
    41         'domain' property was assigned for the each backend to frontend messages.
    42         At the next step WebInspector wrapper functions will be removed and 'agents' will be called directly.
    43 
    44         https://bugs.webkit.org/show_bug.cgi?id=50337
    45 
    46         * inspector/CodeGeneratorInspector.pm:
    47         * inspector/Inspector.idl:
    48         * inspector/front-end/inspector.js:
    49         (WebInspector_syncDispatch):
    50 
    51 2010-12-03  Alexander Pavlov  <apavlov@chromium.org>
    52 
    53         Reviewed by Yury Semikhatsky.
    54 
    55         Web Inspector: Duplicate "!important" for !important properties displayed in the Styles pane
    56         https://bugs.webkit.org/show_bug.cgi?id=50460
    57 
    58         * inspector/front-end/StylesSidebarPane.js:
    59         * inspector/front-end/inspector.css:
    60 
    61 2010-12-03  Xan Lopez  <xlopez@igalia.com>
    62 
    63         Unreviewed build fix.
    64 
    65         The JS code generator includes headers unconditionally, so we need
    66         to generate them unconditionally and disable the feature. The
    67         WebAudio files hadn't been added to our sources list.
    68 
    69         * GNUmakefile.am:
    70 
    71 2010-12-03  Patrick Gansterer  <paroga@webkit.org>
    72 
    73         Unreviewed build fix.
    74 
    75         Try to fix EFL build after r73273.
    76 
    77         * CMakeLists.txt:
    78 
    79 2010-12-03  Chris Guillory  <chris.guillory@google.com>
    80 
    81         Reviewed by Chris Fleizach.
    82 
    83         Include the FrameView widget of a RenderWidget in the accessibility tree.
    84         https://bugs.webkit.org/show_bug.cgi?id=49106
    85 
    86         Include render widget children in the accessibility tree for not mac webkit ports.
    87 
    88         * accessibility/AccessibilityRenderObject.cpp:
    89         (WebCore::AccessibilityRenderObject::renderParentObject):
    90         (WebCore::AccessibilityRenderObject::addChildren):
    91         (WebCore::AccessibilityRenderObject::addRenderWidgetChildren):
    92         * accessibility/AccessibilityRenderObject.h:
    93         * accessibility/chromium/AccessibilityObjectChromium.cpp:
    94         (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
    95 
    96 2010-11-30  Abhishek Arya  <inferno@chromium.org>
    97 
    98         Reviewed by Dave Hyatt.
    99 
    100         Don't clone an anonymous block, instead create a new one in splitBlocks. Also,
    101         when beforeChild is not in one of our children, then do the processing first
    102         to get its anonymous container before calling splitBlocks.
    103         https://bugs.webkit.org/show_bug.cgi?id=49928
    104 
    105         Tests: fast/multicol/span/anonymous-before-child-parent-crash.html
    106                fast/multicol/span/anonymous-split-block-crash.html
    107 
    108         * rendering/RenderBlock.cpp:
    109         (WebCore::RenderBlock::splitBlocks):
    110         (WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
    111 
    112 2010-12-03  Mark Rowe  <mrowe@apple.com>
    113 
    114         Reviewed by Eric Seidel.
    115 
    116         Animated GIF animates much more slowly in Safari than Firefox
    117         <rdar://problem/7689300> / <http://webkit.org/b/26455>
    118 
    119         Adopt Firefox's behavior for frame duration clamping. Images that specify a frame duration
    120         of <= 10ms are treated as having a frame duration of 100ms, while all other images use the
    121         frame duration that they specify.
    122 
    123         ImageIO currently implements its own clamping of frame durations (<rdar://problem/7689297>)
    124         which will result in this change having no observable effect on platforms where it is used
    125         until an updated version of ImageIO becomes available.
    126 
    127         * platform/graphics/ImageSource.cpp:
    128         (WebCore::ImageSource::frameDurationAtIndex): Update the formatting of the comment and style
    129         of the code to match that in ImageSourceCG.
    130         * platform/graphics/cg/ImageSourceCG.cpp:
    131         (WebCore::ImageSource::frameDurationAtIndex):
    132 
    133 2010-12-03  Chris Rogers  <crogers@google.com>
    134 
    135         Unreviewed build fix.
    136 
    137         Fix M_E compile error on Chromium Win
    138         https://bugs.webkit.org/show_bug.cgi?id=50479
    139 
    140         * platform/audio/AudioUtilities.cpp:
    141         (WebCore::AudioUtilities::discreteTimeConstantForSampleRate):
    142 
    143 2010-12-03  Chris Rogers  <crogers@google.com>
    144 
    145         Unreviewed build fix.
    146 
    147         Try to fix GTK build due to recent web audio makefile changes (disable ENABLE_WEB_AUDIO explicitly)
    148         https://bugs.webkit.org/show_bug.cgi?id=50478
    149 
    150         * GNUmakefile.am:
    151 
    152 2010-12-03  Simon Fraser  <simon.fraser@apple.com>
    153 
    154         Reviewed by Dirk Schulze.
    155 
    156         Clean up some text-related code on GraphicsContext
    157         https://bugs.webkit.org/show_bug.cgi?id=50464
    158 
    159         Save 8 bytes in GraphicsContextState by rearranging the
    160         data members to reduce padding.
    161 
    162         * platform/graphics/GraphicsContextPrivate.h:
    163         (WebCore::GraphicsContextState::GraphicsContextState):
    164 
    165 2010-12-03  Simon Fraser  <simon.fraser@apple.com>
    166 
    167         Another Chromium build fix.
    168 
    169         * platform/graphics/skia/GraphicsContextSkia.cpp:
    170         (WebCore::GraphicsContext::setPlatformTextDrawingMode):
    171 
    172 2010-12-03  Simon Fraser  <simon.fraser@apple.com>
    173 
    174         Fix Chromium build.
    175 
    176         * platform/graphics/skia/PlatformContextSkia.h:
    177 
    178 2010-12-03  Patrick Gansterer  <paroga@webkit.org>
    179 
    180         Reviewed by Andreas Kling.
    181 
    182         [CMake] Remove WebCore_IDL_PURE_FILES
    183         https://bugs.webkit.org/show_bug.cgi?id=50445
    184 
    185         * CMakeLists.txt:
    186 
    187 2010-12-03  Jia Pu  <jpu@apple.com>
    188 
    189         Reviewed by Darin Adler.
    190 
    191         Need to move all code that applies correction into correction panel callback.
    192         https://bugs.webkit.org/show_bug.cgi?id=50426
    193         <rdar://problem/8720832>
    194 
    195         No new test, since there's no behavioral change.
    196 
    197         This patch is to prepare WebKit to work with upcoming AppKit changes. The main changes are:
    198         1. Moved all calls to applyCorrectionPanelInfo() into handleCorrectionPanelResult().
    199         2. Added more user dictionary learning code.
    200         3. Removed m_ prefix in all member variables of CorrectionPanelInfo.
    201 
    202         * editing/CorrectionPanelInfo.h: Remove m_ prefix on member variables. Added ReasonForDismissingCorrectionPanel enum type.
    203 
    204         * editing/Editor.cpp: Moved all calls to applyCorrectionPanelInfo() into handleCorrectionPanelResult().
    205           Adopted new member variable naming in class CorrectionPanelInfo.
    206         (WebCore::Editor::respondToChangedSelection):
    207         (WebCore::Editor::~Editor):
    208         (WebCore::Editor::markMisspellingsAfterTypingToWord):
    209         (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
    210         (WebCore::Editor::correctionPanelTimerFired):
    211         (WebCore::Editor::handleCorrectionPanelResult):
    212         (WebCore::Editor::startCorrectionPanelTimer):
    213         (WebCore::Editor::stopCorrectionPanelTimer):
    214         (WebCore::Editor::handleCancelOperation):
    215         (WebCore::Editor::dismissCorrectionPanel):
    216         (WebCore::Editor::applyCorrectionPanelInfo):
    217 
    218         * editing/Editor.h: Changed signature of dismissCorrectionPanel to use ReasonForDismissingCorrectionPanel.
    219 
    220         * loader/EmptyClients.h: Ditto.
    221         (WebCore::EmptyEditorClient::dismissCorrectionPanel):
    222 
    223         * page/EditorClient.h: Ditto.
    224 
    225 2010-12-03  Pavel Feldman  <pfeldman@chromium.org>
    226 
    227         Reviewed by Yury Semikhatsky.
    228 
    229         Web Inspector: reveal in elements panel does not switch the panel itself.
    230         https://bugs.webkit.org/show_bug.cgi?id=50408
    231 
    232         * inspector/front-end/ElementsTreeOutline.js:
    233         (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired.focusElement):
    234         (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired):
    235         * inspector/front-end/ObjectPropertiesSection.js:
    236         (WebInspector.ObjectPropertyTreeElement.prototype._contextMenuEventFired):
    237 
    238 2010-12-03  Simon Fraser  <simon.fraser@apple.com>
    239 
    240         Reviewed by Nikolas Zimmermann.
    241 
    242         Clean up some text-related code on GraphicsContext
    243         https://bugs.webkit.org/show_bug.cgi?id=50464
    244 
    245         Use defined types for textDrawingMode and it's associated flags.
    246 
    247         * html/canvas/CanvasRenderingContext2D.cpp:
    248         (WebCore::CanvasRenderingContext2D::drawTextInternal):
    249         * platform/graphics/GraphicsContext.cpp:
    250         (WebCore::GraphicsContext::textDrawingMode):
    251         (WebCore::GraphicsContext::setTextDrawingMode):
    252         (WebCore::GraphicsContext::setPlatformTextDrawingMode):
    253         * platform/graphics/GraphicsContext.h:
    254         * platform/graphics/GraphicsContextPrivate.h:
    255         (WebCore::GraphicsContextState::GraphicsContextState):
    256         * platform/graphics/cairo/FontCairo.cpp:
    257         (WebCore::drawGlyphsShadow):
    258         (WebCore::Font::drawGlyphs):
    259         * platform/graphics/cg/GraphicsContextCG.cpp:
    260         (WebCore::GraphicsContext::setPlatformTextDrawingMode):
    261         * platform/graphics/chromium/FontLinux.cpp:
    262         (WebCore::Font::drawGlyphs):
    263         (WebCore::Font::drawComplexText):
    264         * platform/graphics/gtk/FontGtk.cpp:
    265         (WebCore::drawGlyphsShadow):
    266         (WebCore::Font::drawComplexText):
    267         * platform/graphics/mac/FontMac.mm:
    268         (WebCore::Font::drawGlyphs):
    269         * platform/graphics/openvg/PainterOpenVG.cpp:
    270         (WebCore::PlatformPainterState::PlatformPainterState):
    271         (WebCore::PainterOpenVG::textDrawingMode):
    272         (WebCore::PainterOpenVG::setTextDrawingMode):
    273         (WebCore::PainterOpenVG::drawText):
    274         * platform/graphics/qt/FontQt.cpp:
    275         (WebCore::drawTextCommon):
    276         * platform/graphics/skia/PlatformContextSkia.cpp:
    277         (WebCore::PlatformContextSkia::State::State):
    278         (WebCore::PlatformContextSkia::getTextDrawingMode):
    279         (WebCore::PlatformContextSkia::setTextDrawingMode):
    280         * platform/graphics/skia/SkiaFontWin.cpp:
    281         (WebCore::windowsCanHandleTextDrawing):
    282         (WebCore::paintSkiaText):
    283         * platform/graphics/texmap/TextureMapper.h:
    284         (WebCore::TextureMapper::setTextDrawingMode):
    285         (WebCore::TextureMapper::textDrawingMode):
    286         (WebCore::TextureMapper::TextureMapper):
    287         * platform/graphics/win/FontCGWin.cpp:
    288         (WebCore::drawGDIGlyphs):
    289         (WebCore::Font::drawGlyphs):
    290         * platform/graphics/wince/GraphicsContextWinCE.cpp:
    291         (WebCore::GraphicsContext::drawText):
    292         * rendering/InlineTextBox.cpp:
    293         (WebCore::updateGraphicsContext):
    294         * rendering/RenderSVGResourceGradient.cpp:
    295         (WebCore::RenderSVGResourceGradient::applyResource):
    296         * rendering/RenderSVGResourcePattern.cpp:
    297         (WebCore::RenderSVGResourcePattern::applyResource):
    298         * rendering/RenderSVGResourceSolidColor.cpp:
    299         (WebCore::RenderSVGResourceSolidColor::applyResource):
    300         * svg/SVGFont.cpp:
    301         (WebCore::Font::drawTextUsingSVGFont):
    302 
    303 2010-12-03  Chris Rogers  <crogers@google.com>
    304 
    305         Reviewed by Kenneth Russell.
    306 
    307         First steps to adding web audio files to build systems
    308         https://bugs.webkit.org/show_bug.cgi?id=49952
    309 
    310         No new tests since audio API is not yet implemented.
    311 
    312         * CMakeLists.txt:
    313         * DerivedSources.make:
    314         * ForwardingHeaders/wtf/Complex.h: Added.
    315         * GNUmakefile.am:
    316         * WebCore.gyp/WebCore.gyp:
    317         * WebCore.gypi:
    318         * WebCore.pri:
    319         * WebCore.pro:
    320         * bindings/js/JSDOMWindowCustom.cpp:
    321         (WebCore::JSDOMWindow::audioContext):
    322         * features.pri:
    323         * page/DOMWindow.idl:
    324         * platform/audio/HRTFElevation.cpp:
    325 
    326 2010-12-03  Patrick Gansterer  <paroga@webkit.org>
    327 
    328         Reviewed by David Levin.
    329 
    330         Use String::adopt in TextCodecWinCE::decode
    331         https://bugs.webkit.org/show_bug.cgi?id=50319
    332 
    333         * platform/text/wince/TextCodecWinCE.cpp:
    334         (WebCore::TextCodecWinCE::decode):
    335 
    336 2010-12-03  Brady Eidson  <beidson@apple.com>
    337 
    338         Reviewed by Anders Carlsson.
    339 
    340         Groundwork for <rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191
    341         WebKit2 Authentication Support
    342 
    343         * WebCore.exp.in:
    344 
    345         Expose the AuthenticationClient for WK2 platforms (Windows already does this):
    346         * platform/network/mac/AuthenticationChallenge.h:
    347         * platform/network/mac/AuthenticationMac.mm:
    348         (-[WebCoreAuthenticationClientAsChallengeSender client]):
    349         (WebCore::AuthenticationChallenge::authenticationClient):
    350 
    351         * platform/network/qt/AuthenticationChallenge.h:
    352         (WebCore::AuthenticationChallenge::authenticationClient):
    353 
    354 2010-12-03  Ryosuke Niwa  <rniwa@webkit.org>
    355 
    356         Reviewed by Darin Adler.
    357 
    358         REGRESSION: Crash when deleting text after textarea's value is modified on input event
    359         https://bugs.webkit.org/show_bug.cgi?id=49962
    360 
    361         The crash was caused by TypingCommand::deleteKeyPressed's reusing a typing command for
    362         textarea's shadow DOM after its input event handler rewrote the value set by the typing command.
    363         Because the reused typing command's ending selection was pointing at a shadow node
    364         that has been detached from the document when the event handler set the new value,
    365         rootEditableElement of the ending selection was null and caused the crash.
    366 
    367         Fixed the bug by updating the ending selection of the last typing command when it differsfrom
    368         that of the current selection held by the SelectionController in TypingCommand::deleteKeyPressed.
    369         Also fixed similar bugs in forwardDeleteKeyPressed and insertText, and insertTextRunWithoutNewlines.
    370 
    371         Tests: editing/input/set-value-on-input-and-delete.html
    372                editing/input/set-value-on-input-and-forward-delete.html
    373                editing/input/set-value-on-input-and-type-input.html
    374                editing/input/set-value-on-input-and-type-textarea.html
    375 
    376         * editing/InsertTextCommand.h: Added TypingCommand as a friend because it needs to update selection.
    377         * editing/TypingCommand.cpp:
    378         (WebCore::TypingCommand::deleteKeyPressed): Updates the last typing command's selection as needed.
    379         (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
    380         (WebCore::TypingCommand::insertText): Ditto.
    381         (WebCore::TypingCommand::updateSelectionIfDifferentFromCurrentSelection): Added.
    382         (WebCore::TypingCommand::insertTextRunWithoutNewlines): Updates InsertTextCommand's selection as needed.
    383         * editing/TypingCommand.h:
    384 
    385 2010-12-03  Daniel Cheng  <dcheng@chromium.org>
    386 
    387         Reviewed by Tony Chang.
    388 
    389         Dragging and dropping into an empty document crashes WebKit.
    390         https://bugs.webkit.org/show_bug.cgi?id=48793
    391 
    392         Remove the assert and update callers to check for a null return value.
    393 
    394         Test: manual-tests/drop-in-empty-doc.html
    395 
    396         * manual-tests/drop-in-empty-doc.html: Added.
    397         * manual-tests/resources/drop-in-empty-doc.xhtml: Added.
    398         * page/DragController.cpp:
    399         (WebCore::elementUnderMouse):
    400         (WebCore::DragController::tryDocumentDrag):
    401         (WebCore::DragController::concludeEditDrag):
    402 
    403 2010-12-03  Patrick Gansterer  <paroga@webkit.org>
    404 
    405         Reviewed by Andreas Kling.
    406 
    407         Move Inspector generator logic into main CMakeLists.txt file
    408         https://bugs.webkit.org/show_bug.cgi?id=50445
    409 
    410         * CMakeLists.txt:
    411 
    412 2010-12-03 Patrick Gansterer <paroga@webkit.org>
    413 
    414         Reviewed by Andreas Kling.
    415 
    416         Move StringWx.cpp into wtf directory
    417         https://bugs.webkit.org/show_bug.cgi?id=50060
    418 
    419         * WebCore.gypi:
    420         * platform/text/wx/StringWx.cpp: Removed.
    421 
    422 2010-12-03  Dimitri Glazkov  <dglazkov@chromium.org>
    423 
    424         Reviewed by Darin Adler.
    425 
    426         REGRESSION(r72783): DOMActivate fires multiple times from input type=file
    427         https://bugs.webkit.org/show_bug.cgi?id=50396
    428 
    429         Test: fast/events/shadow-boundary-crossing-2.html
    430 
    431         * dom/EventContext.cpp: Reverted changes made in r72783.
    432         * dom/EventContext.h: Ditto.
    433         * dom/Node.cpp:
    434         (WebCore::Node::containsIncludingShadowDOM): Added.
    435         (WebCore::Node::dispatchGenericEvent): Reverted changes made in r72783.
    436         * dom/Node.h: Added decl.
    437         * html/HTMLLabelElement.cpp:
    438         (WebCore::HTMLLabelElement::defaultEventHandler): Reverted changes made in r72783.
    439 
    440 2010-12-03  Patrick Gansterer  <paroga@webkit.org>
    441 
    442         Reviewed by Andreas Kling.
    443 
    444         Move StringBrew.cpp into wtf directory
    445         https://bugs.webkit.org/show_bug.cgi?id=50058
    446 
    447         * platform/text/brew/StringBrew.cpp: Removed.
    448 
    449 2010-12-03  Patrick Gansterer  <paroga@webkit.org>
    450 
    451         Reviewed by Andreas Kling.
    452 
    453         Move StringHaiku.cpp into wtf directory
    454         https://bugs.webkit.org/show_bug.cgi?id=50057
    455 
    456         * platform/text/haiku/StringHaiku.cpp: Removed.
    457 
    458 2010-12-03  Jessie Berlin  <jberlin@apple.com>
    459 
    460         Reviewed by Sam Weinig.
    461 
    462         Need a WebKit2 Equivalent of WebSecurityOrigin
    463         https://bugs.webkit.org/show_bug.cgi?id=50170
    464 
    465         * WebCore.exp.in:
    466         Export the symbol for SecurityOrigin::createFromDatabaseIdentifier.
    467 
    468 2010-12-03  Andras Becsi  <abecsi@inf.u-szeged.hu>
    469 
    470         Unreviewed build fix after r73254.
    471 
    472         [Qt][V8] Add missing headers to $headerIncludes rather than $implIncludes
    473         because headers are needed by the generated .h files.
    474 
    475         No new tests needed.
    476 
    477         * bindings/scripts/CodeGeneratorV8.pm:
    478 
    479 2010-12-03  Nikolas Zimmermann  <nzimmermann@rim.com>
    480 
    481         Reviewed by Dirk Schulze.
    482 
    483         1336 files in WebCore rebuild when you touch SVGNames
    484         https://bugs.webkit.org/show_bug.cgi?id=42025
    485 
    486         Remove global SVGNames.h dependency, as SVGAnimatedPropertyMacros.h included it.
    487         This requires to add the SVGNames.h include to lots of cpp files.
    488 
    489         No functional changes, thus no new tests.
    490 
    491         * css/CSSCursorImageValue.cpp:
    492         * css/CSSFontFaceSource.cpp:
    493         * dom/Node.cpp:
    494         * loader/cache/CachedFont.cpp:
    495         * rendering/RenderSVGResourceClipper.cpp:
    496         * rendering/RenderSVGResourceFilter.cpp:
    497         * rendering/RenderSVGTransformableContainer.cpp:
    498         * rendering/RenderSVGViewportContainer.cpp:
    499         * rendering/SVGRenderTreeAsText.cpp:
    500         * rendering/SVGResources.cpp:
    501         * rendering/svg/RenderSVGTextPath.cpp:
    502         * rendering/svg/SVGRootInlineBox.cpp:
    503         * svg/SVGAnimateElement.cpp:
    504         * svg/SVGAnimateMotionElement.cpp:
    505         * svg/SVGAnimateTransformElement.cpp:
    506         * svg/SVGDefsElement.cpp:
    507         * svg/SVGFEBlendElement.cpp:
    508         * svg/SVGFEDisplacementMapElement.cpp:
    509         * svg/SVGFEMergeElement.cpp:
    510         * svg/SVGFEMergeNodeElement.cpp:
    511         * svg/SVGFEOffsetElement.cpp:
    512         * svg/SVGFETileElement.cpp:
    513         * svg/SVGFETurbulenceElement.cpp:
    514         * svg/SVGFont.cpp:
    515         * svg/SVGGElement.cpp:
    516         * svg/SVGImageElement.cpp:
    517         * svg/SVGLength.cpp:
    518         * svg/SVGMPathElement.cpp:
    519         * svg/SVGPathElement.cpp:
    520         * svg/SVGPathSegList.cpp:
    521         * svg/SVGStyledTransformableElement.cpp:
    522         * svg/SVGSymbolElement.cpp:
    523         * svg/SVGTextContentElement.cpp:
    524         * svg/SVGTextElement.cpp:
    525         * svg/SVGTextPathElement.cpp:
    526         * svg/SVGUseElement.cpp:
    527         * svg/SVGViewSpec.cpp:
    528         * svg/animation/SMILTimeContainer.cpp:
    529         * svg/properties/SVGAnimatedPropertyMacros.h:
    530         * svg/properties/SVGPathSegListPropertyTearOff.cpp:
    531 
    532 2010-12-02  Philippe Normand  <pnormand@igalia.com>
    533 
    534         Reviewed by Martin Robinson.
    535 
    536         [GStreamer] hasVideo/Audio return false until the pipeline reaches PAUSED
    537         https://bugs.webkit.org/show_bug.cgi?id=50382
    538 
    539         Go to PAUSED even if preload is deactivated. In that case don't
    540         process the GStreamer state changes until commitLoad() has been
    541         called. This patch also fixes hasVideo and hasAudio methods,
    542         making them reactive to the playbin2 audio/video tags-changed
    543         signals.
    544 
    545         Test: media/controls-without-preload.html
    546 
    547         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
    548         (WebCore::mediaPlayerPrivateMessageCallback):
    549         (WebCore::mediaPlayerPrivateVideoTagsChangedCallback):
    550         (WebCore::mediaPlayerPrivateAudioTagsChangedCallback):
    551         (WebCore::mediaPlayerPrivateAudioTagsChangeTimeoutCallback):
    552         (WebCore::mediaPlayerPrivateVideoTagsChangeTimeoutCallback):
    553         (WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
    554         (WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
    555         (WebCore::MediaPlayerPrivateGStreamer::load):
    556         (WebCore::MediaPlayerPrivateGStreamer::commitLoad):
    557         (WebCore::MediaPlayerPrivateGStreamer::videoTagsChanged):
    558         (WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideoTags):
    559         (WebCore::MediaPlayerPrivateGStreamer::audioTagsChanged):
    560         (WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudioTags):
    561         (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
    562         * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
    563         (WebCore::MediaPlayerPrivateGStreamer::hasVideo):
    564         (WebCore::MediaPlayerPrivateGStreamer::hasAudio):
    565         (WebCore::MediaPlayerPrivateGStreamer::loadDelayed):
    566 
    567 2010-12-03  Nikolas Zimmermann  <nzimmermann@rim.com>
    568 
    569         Reviewed by Dirk Schulze.
    570 
    571         Finish splitting DECLARE_ANIMATED_PROPERTY* in DECLARE/DEFINE parts for the remaining SVGAnimated* types
    572         https://bugs.webkit.org/show_bug.cgi?id=50440
    573 
    574         Continuing the work on bug 42025: Introduce (DECLARE|DEFINE)_ANIMATED_(ANGLE|BOOLEAN|INTEGER|PRESERVEASPECTRATIO|RECT).
    575         The animated property declaration lives in the header, the definition in the cpp file, to avoid the dependency on SVGNames.h in all headers.
    576 
    577         No functional changes, thus no new tests.
    578 
    579         * svg/SVGAElement.cpp:
    580         * svg/SVGAElement.h:
    581         * svg/SVGAnimatedAngle.h:
    582         * svg/SVGAnimatedBoolean.h:
    583         * svg/SVGAnimatedInteger.h:
    584         * svg/SVGAnimatedPreserveAspectRatio.h:
    585         * svg/SVGAnimatedRect.h:
    586         * svg/SVGAnimationElement.cpp:
    587         * svg/SVGAnimationElement.h:
    588         (WebCore::SVGAnimationElement::calculateDistance):
    589         (WebCore::SVGAnimationElement::animationPath):
    590         * svg/SVGCircleElement.cpp:
    591         * svg/SVGCircleElement.h:
    592         * svg/SVGClipPathElement.cpp:
    593         * svg/SVGClipPathElement.h:
    594         * svg/SVGCursorElement.cpp:
    595         * svg/SVGCursorElement.h:
    596         * svg/SVGDefsElement.cpp:
    597         * svg/SVGDefsElement.h:
    598         * svg/SVGEllipseElement.cpp:
    599         * svg/SVGEllipseElement.h:
    600         * svg/SVGFEConvolveMatrixElement.cpp:
    601         * svg/SVGFEConvolveMatrixElement.h:
    602         * svg/SVGFEImageElement.cpp:
    603         * svg/SVGFEImageElement.h:
    604         * svg/SVGFETurbulenceElement.cpp:
    605         * svg/SVGFETurbulenceElement.h:
    606         * svg/SVGFilterElement.cpp:
    607         * svg/SVGFilterElement.h:
    608         * svg/SVGFilterPrimitiveStandardAttributes.h:
    609         * svg/SVGFontElement.cpp:
    610         (WebCore::SVGFontElement::firstMissingGlyphElement):
    611         (WebCore::SVGFontElement::ensureGlyphCache):
    612         * svg/SVGFontElement.h:
    613         * svg/SVGForeignObjectElement.cpp:
    614         * svg/SVGForeignObjectElement.h:
    615         * svg/SVGGElement.cpp:
    616         * svg/SVGGElement.h:
    617         (WebCore::SVGGElement::isShadowTreeContainerElement):
    618         (WebCore::SVGGElement::isValid):
    619         * svg/SVGGradientElement.cpp:
    620         * svg/SVGGradientElement.h:
    621         * svg/SVGImageElement.cpp:
    622         * svg/SVGImageElement.h:
    623         * svg/SVGLineElement.cpp:
    624         * svg/SVGLineElement.h:
    625         * svg/SVGLinearGradientElement.h:
    626         * svg/SVGMPathElement.cpp:
    627         * svg/SVGMPathElement.h:
    628         * svg/SVGMarkerElement.cpp:
    629         * svg/SVGMarkerElement.h:
    630         * svg/SVGMaskElement.cpp:
    631         * svg/SVGMaskElement.h:
    632         * svg/SVGPathElement.cpp:
    633         * svg/SVGPathElement.h:
    634         * svg/SVGPatternElement.cpp:
    635         * svg/SVGPatternElement.h:
    636         * svg/SVGPolyElement.cpp:
    637         * svg/SVGPolyElement.h:
    638         * svg/SVGRadialGradientElement.h:
    639         * svg/SVGRectElement.cpp:
    640         * svg/SVGRectElement.h:
    641         * svg/SVGSVGElement.cpp:
    642         (WebCore::SVGSVGElement::contentScriptType):
    643         (WebCore::SVGSVGElement::contentStyleType):
    644         (WebCore::SVGSVGElement::parseMappedAttribute):
    645         * svg/SVGSVGElement.h:
    646         * svg/SVGScriptElement.cpp:
    647         * svg/SVGScriptElement.h:
    648         * svg/SVGSwitchElement.cpp:
    649         * svg/SVGSwitchElement.h:
    650         (WebCore::SVGSwitchElement::isValid):
    651         * svg/SVGSymbolElement.cpp:
    652         * svg/SVGSymbolElement.h:
    653         (WebCore::SVGSymbolElement::rendererIsNeeded):
    654         * svg/SVGTextContentElement.cpp:
    655         * svg/SVGTextContentElement.h:
    656         * svg/SVGUseElement.cpp:
    657         * svg/SVGUseElement.h:
    658         * svg/SVGViewElement.cpp:
    659         * svg/SVGViewElement.h:
    660         (WebCore::SVGViewElement::viewTarget):
    661         (WebCore::SVGViewElement::rendererIsNeeded):
    662         * svg/SVGViewSpec.cpp:
    663         * svg/SVGViewSpec.h:
    664         (WebCore::SVGViewSpec::transform):
    665         (WebCore::SVGViewSpec::viewTargetString):
    666         (WebCore::SVGViewSpec::contextElement):
    667         * svg/properties/SVGAnimatedPropertyMacros.h:
    668 
    669 2010-12-03  Noel Gordon  <noel.gordon@gmail.com>
    670 
    671         Reviewed by Darin Fisher.
    672 
    673         [chromium] PNG encoder leaks memory on png_write_row errors.
    674         https://bugs.webkit.org/show_bug.cgi?id=50439
    675 
    676         Move the creation of needed C++ objects before the setjmp() point so
    677         those objects have their destructors called if libpng errors invoke
    678         the setjmp() return path.
    679    
    680         Other minor cleanup: use the skia bitmap locker class, and remove the
    681         PNGDestroyer class - instead directly call png_destroy_write_struct()
    682         at each of the encodeImpl() return points.
    683 
    684         No change in behaviour, so no new tests.
    685 
    686         * platform/image-encoders/skia/PNGImageEncoder.cpp:
    687         (WebCore::encodeImpl):
    688         (WebCore::PNGImageEncoder::encode):
    689 
    690 2010-12-02  Philippe Normand  <pnormand@igalia.com>
    691 
    692         Reviewed by Eric Carlson.
    693 
    694         Theme not updated when MediaPlayer m_private engine changes
    695         https://bugs.webkit.org/show_bug.cgi?id=50228
    696 
    697         Trigger a new rendering of the media element when the private
    698         media-player backend is updated.
    699 
    700         * html/HTMLMediaElement.cpp:
    701         (WebCore::HTMLMediaElement::mediaPlayerEngineUpdated):
    702         * html/HTMLMediaElement.h:
    703         * platform/graphics/MediaPlayer.cpp:
    704         (WebCore::MediaPlayer::MediaPlayer):
    705         (WebCore::MediaPlayer::load):
    706         * platform/graphics/MediaPlayer.h:
    707         (WebCore::MediaPlayerClient::mediaPlayerEngineUpdated):
    708 
    709 2010-12-03  Yonathan Randolph  <yonathan@gmail.com>
    710 
    711         Reviewed by Alexey Proskuryakov.
    712 
    713         XPath lexer misinterprets expression starting with "div".
    714         https://bugs.webkit.org/show_bug.cgi?id=50366
    715 
    716         * xml/XPathParser.cpp:
    717         * xml/XPathParser.h:
    718         (WebCore::XPath::Parser::isOperatorContext): removed (renamed)
    719         (WebCore::XPath::Parser::isBinaryOperatorContext): added
    720 
    721 2010-12-02  Rob Buis  <rwlbuis@gmail.com>
    722 
    723         Reviewed by Alexey Proskuryakov.
    724 
    725         CSS 2.1 failure: at-import-*
    726         https://bugs.webkit.org/show_bug.cgi?id=47153
    727 
    728         Fix at-import-010.htm by only setting m_allowImportRules
    729         to false when creating valid style or page rules.
    730  
    731          Test: css2.1/t040105-import-10-b.html
    732 
    733         * css/CSSParser.cpp:
    734         (WebCore::CSSParser::createStyleRule):
    735 
    73612010-12-02  Aaron Boodman  <aa@chromium.org>
    7372

  • branches/chromium/597/WebCore/rendering/RenderBox.cpp

    r72235 r73386  
    307307    if (isBodyRenderer)
    308308        document()->setTextColor(style()->visitedDependentColor(CSSPropertyColor));
    309    
    310     if ((isRootRenderer || isBodyRenderer) && (!oldStyle || oldStyle->writingMode() != style()->writingMode() || oldStyle->direction() != style()->direction())) {
     309
     310    if (isRootRenderer || isBodyRenderer) {
    311311        // Propagate the new writing mode and direction up to the RenderView.
    312312        RenderView* viewRenderer = view();
    313313        RenderStyle* viewStyle = viewRenderer->style();
    314         if (isRootRenderer || !document()->directionSetOnDocumentElement()) {
     314        if (viewStyle->direction() != style()->direction() && (isRootRenderer || !document()->directionSetOnDocumentElement())) {
    315315            viewStyle->setDirection(style()->direction());
    316316            if (isBodyRenderer)
    317317                document()->documentElement()->renderer()->style()->setDirection(style()->direction());
    318         }
    319        
    320         if (isRootRenderer || !document()->writingModeSetOnDocumentElement()) {
     318            setNeedsLayoutAndPrefWidthsRecalc();
     319        }
     320
     321        if (viewStyle->writingMode() != style()->writingMode() && (isRootRenderer || !document()->writingModeSetOnDocumentElement())) {
    321322            viewStyle->setWritingMode(style()->writingMode());
    322323            if (isBodyRenderer)
    323324                document()->documentElement()->renderer()->style()->setWritingMode(style()->writingMode());
    324         }
    325         setNeedsLayoutAndPrefWidthsRecalc();
     325            setNeedsLayoutAndPrefWidthsRecalc();
     326        }
    326327    }
    327328}
Note: See TracChangeset for help on using the changeset viewer.