Changeset 79656 in webkit

Timestamp:

Feb 24, 2011, 6:21:20 PM (15 years ago)

Author:

mitz@apple.com

Message:

REGRESSION (r79629): Non-expanding ruby base is start-aligned rather than centered
​https://bugs.webkit.org/show_bug.cgi?id=55197

Reviewed by Simon Fraser.

• rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Adjust the line boundaries even
if there are no expansion opportunities. This allows RenderRubyBase to center itself.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderBlockLineLayout.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-02-24  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Simon Fraser.
+
+        REGRESSION (r79629): Non-expanding ruby base is start-aligned rather than centered
+        https://bugs.webkit.org/show_bug.cgi?id=55197
+
+        * rendering/RenderBlockLineLayout.cpp:
+        (WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Adjust the line boundaries even
+        if there are no expansion opportunities. This allows RenderRubyBase to center itself.
+
 2011-02-24  Darin Adler  <darin@apple.com>
 

trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp

@@ -413 +413 @@
             break;
         case JUSTIFY:
+            adjustInlineDirectionLineBounds(expansionOpportunityCount, logicalLeft, availableLogicalWidth);
             if (expansionOpportunityCount) {
-                adjustInlineDirectionLineBounds(expansionOpportunityCount, logicalLeft, availableLogicalWidth);
                 if (trailingSpaceRun) {
                     totalLogicalWidth -= trailingSpaceRun->m_box->logicalWidth();
@@ -423 +423 @@
             // fall through
         case TAAUTO:
-            expansionOpportunityCount = 0;
             // for right to left fall through to right aligned
             if (style()->isLeftToRightDirection()) {