Changeset 87837 in webkit

Timestamp:

Jun 1, 2011, 12:52:13 PM (14 years ago)

Author:

kbr@google.com

Message:

2011-06-01 Kenneth Russell <​kbr@google.com>

Reviewed by Nate Chapin.

[V8] Optimize fetches of indexed properties in custom bindings
​https://bugs.webkit.org/show_bug.cgi?id=61821

Avoid allocating garbage in affected custom bindings. This speeds
up one test case by at least a factor of two. No new tests;
covered by existing layout tests (typed array and otherwise).

• bindings/v8/custom/V8ArrayBufferViewCustom.h: (WebCore::constructWebGLArray): (WebCore::setWebGLArrayHelper):
• bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: (WebCore::V8InspectorFrontendHost::showContextMenuCallback):
• bindings/v8/custom/V8MessagePortCustom.cpp: (WebCore::getMessagePortArray):
• bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::jsArrayToFloatArray): (WebCore::jsArrayToIntArray):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/v8/custom/V8ArrayBufferViewCustom.h (modified) (2 diffs)
• bindings/v8/custom/V8InspectorFrontendHostCustom.cpp (modified) (1 diff)
• bindings/v8/custom/V8MessagePortCustom.cpp (modified) (1 diff)
• bindings/v8/custom/V8WebGLRenderingContextCustom.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-06-01  Kenneth Russell  <kbr@google.com>
+
+        Reviewed by Nate Chapin.
+
+        [V8] Optimize fetches of indexed properties in custom bindings
+        https://bugs.webkit.org/show_bug.cgi?id=61821
+
+        Avoid allocating garbage in affected custom bindings. This speeds
+        up one test case by at least a factor of two. No new tests;
+        covered by existing layout tests (typed array and otherwise).
+
+        * bindings/v8/custom/V8ArrayBufferViewCustom.h:
+        (WebCore::constructWebGLArray):
+        (WebCore::setWebGLArrayHelper):
+        * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
+        (WebCore::V8InspectorFrontendHost::showContextMenuCallback):
+        * bindings/v8/custom/V8MessagePortCustom.cpp:
+        (WebCore::getMessagePortArray):
+        * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
+        (WebCore::jsArrayToFloatArray):
+        (WebCore::jsArrayToIntArray):
+
 2011-06-01  Andras Becsi  <abecsi@webkit.org>
 

trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h

@@ -150 +150 @@
         // Need to copy the incoming array into the newly created ArrayBufferView.
         for (unsigned i = 0; i < len; i++) {
-            v8::Local<v8::Value> val = srcArray->Get(v8::Integer::NewFromUnsigned(i));
+            v8::Local<v8::Value> val = srcArray->Get(i);
             array->set(i, val->NumberValue());
         }
@@ -197 +197 @@
         else
             for (uint32_t i = 0; i < length; i++)
-                impl->set(offset + i, array->Get(v8::Integer::NewFromUnsigned(i))->NumberValue());
+                impl->set(offset + i, array->Get(i)->NumberValue());
 
         return v8::Undefined();

trunk/Source/WebCore/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp

@@ -84 +84 @@
 
     for (size_t i = 0; i < array->Length(); ++i) {
-        v8::Local<v8::Object> item = v8::Local<v8::Object>::Cast(array->Get(v8::Integer::New(i)));
+        v8::Local<v8::Object> item = v8::Local<v8::Object>::Cast(array->Get(i));
         v8::Local<v8::Value> type = item->Get(v8::String::New("type"));
         v8::Local<v8::Value> id = item->Get(v8::String::New("id"));

trunk/Source/WebCore/bindings/v8/custom/V8MessagePortCustom.cpp

@@ -90 +90 @@
     // Validate the passed array of ports.
     for (unsigned int i = 0; i < length; ++i) {
-        v8::Local<v8::Value> port = ports->Get(v8::Integer::New(i));
+        v8::Local<v8::Value> port = ports->Get(i);
         // Validation of non-null objects, per HTML5 spec 8.3.3.
         if (isUndefinedOrNull(port)) {

trunk/Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp

@@ -78 +78 @@
         return 0;
     for (uint32_t i = 0; i < len; i++) {
-        v8::Local<v8::Value> val = array->Get(v8::Integer::New(i));
+        v8::Local<v8::Value> val = array->Get(i);
         if (!val->IsNumber()) {
             fastFree(data);
@@ -97 +97 @@
         return 0;
     for (uint32_t i = 0; i < len; i++) {
-        v8::Local<v8::Value> val = array->Get(v8::Integer::New(i));
+        v8::Local<v8::Value> val = array->Get(i);
         bool ok;
         int ival = toInt32(val, ok);