Changeset 88020 in webkit
- Timestamp:
- Jun 3, 2011, 8:45:27 AM (14 years ago)
- Location:
- trunk
- Files:
-
- 15 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r88018 r88020 1 2011-06-03 Rob Buis <rbuis@rim.com> 2 3 Reviewed by Nikolas Zimmermann. 4 5 Creating <animateMotion> elements via javascript do not execute 6 https://bugs.webkit.org/show_bug.cgi?id=34301 7 8 Update test results. 9 10 * fast/dom/Window/window-properties-expected.txt: 11 * fast/dom/Window/window-property-descriptors-expected.txt: 12 * fast/dom/prototype-inheritance-2-expected.txt: 13 * fast/dom/prototype-inheritance-expected.txt: 14 * fast/js/global-constructors-expected.txt: 15 * svg/custom/global-constructors-expected.txt: 16 1 17 2011-06-03 Marcus Bulach <bulach@chromium.org> 2 18 -
trunk/LayoutTests/fast/dom/Window/window-properties-expected.txt
r86732 r88020 1418 1418 window.SVGAnimateElement [object SVGAnimateElementConstructor] 1419 1419 window.SVGAnimateElement.prototype [printed above as window.Element.prototype] 1420 window.SVGAnimateMotionElement [object SVGAnimateMotionElementConstructor] 1421 window.SVGAnimateMotionElement.prototype [printed above as window.Element.prototype] 1420 1422 window.SVGAnimateTransformElement [object SVGAnimateTransformElementConstructor] 1421 1423 window.SVGAnimateTransformElement.prototype [printed above as window.Element.prototype] … … 1646 1648 window.SVGLinearGradientElement [object SVGLinearGradientElementConstructor] 1647 1649 window.SVGLinearGradientElement.prototype [printed above as window.Element.prototype] 1650 window.SVGMPathElement [object SVGMPathElementConstructor] 1651 window.SVGMPathElement.prototype [printed above as window.Element.prototype] 1648 1652 window.SVGMarkerElement [object SVGMarkerElementConstructor] 1649 1653 window.SVGMarkerElement.SVG_MARKERUNITS_STROKEWIDTH [number] -
trunk/LayoutTests/fast/dom/Window/window-property-descriptors-expected.txt
r86315 r88020 168 168 PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGAnimateColorElement') is 'object' 169 169 PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGAnimateElement') is 'object' 170 PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGAnimateMotionElement') is 'object' 170 171 PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGAnimateTransformElement') is 'object' 171 172 PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGAnimatedAngle') is 'object' … … 236 237 PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGLineElement') is 'object' 237 238 PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGLinearGradientElement') is 'object' 239 PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGMPathElement') is 'object' 238 240 PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGMarkerElement') is 'object' 239 241 PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGMaskElement') is 'object' -
trunk/LayoutTests/fast/dom/prototype-inheritance-2-expected.txt
r85348 r88020 295 295 Never found SVGAnimateColorElement 296 296 Never found SVGAnimateElement 297 Never found SVGAnimateMotionElement 297 298 Never found SVGAnimateTransformElement 298 299 Never found SVGAnimatedAngle … … 362 363 Never found SVGLineElement 363 364 Never found SVGLinearGradientElement 365 Never found SVGMPathElement 364 366 Never found SVGMarkerElement 365 367 Never found SVGMaskElement -
trunk/LayoutTests/fast/dom/prototype-inheritance-expected.txt
r86315 r88020 328 328 PASS inner.SVGAnimateElement.isInner is true 329 329 PASS inner.SVGAnimateElement.constructor.isInner is true 330 PASS inner.SVGAnimateMotionElement.isInner is true 331 PASS inner.SVGAnimateMotionElement.constructor.isInner is true 330 332 PASS inner.SVGAnimateTransformElement.isInner is true 331 333 PASS inner.SVGAnimateTransformElement.constructor.isInner is true … … 464 466 PASS inner.SVGLinearGradientElement.isInner is true 465 467 PASS inner.SVGLinearGradientElement.constructor.isInner is true 468 PASS inner.SVGMPathElement.isInner is true 469 PASS inner.SVGMPathElement.constructor.isInner is true 466 470 PASS inner.SVGMarkerElement.isInner is true 467 471 PASS inner.SVGMarkerElement.constructor.isInner is true -
trunk/LayoutTests/fast/js/global-constructors-expected.txt
r86315 r88020 153 153 PASS SVGAnimateColorElement.toString() is '[object SVGAnimateColorElementConstructor]' 154 154 PASS SVGAnimateElement.toString() is '[object SVGAnimateElementConstructor]' 155 PASS SVGAnimateMotionElement.toString() is '[object SVGAnimateMotionElementConstructor]' 155 156 PASS SVGAnimateTransformElement.toString() is '[object SVGAnimateTransformElementConstructor]' 156 157 PASS SVGAnimatedAngle.toString() is '[object SVGAnimatedAngleConstructor]' … … 221 222 PASS SVGLineElement.toString() is '[object SVGLineElementConstructor]' 222 223 PASS SVGLinearGradientElement.toString() is '[object SVGLinearGradientElementConstructor]' 224 PASS SVGMPathElement.toString() is '[object SVGMPathElementConstructor]' 223 225 PASS SVGMarkerElement.toString() is '[object SVGMarkerElementConstructor]' 224 226 PASS SVGMaskElement.toString() is '[object SVGMaskElementConstructor]' -
trunk/LayoutTests/svg/custom/global-constructors-expected.txt
r62092 r88020 144 144 PASS SVGAnimateElement.toString() is '[object SVGAnimateElementConstructor]' 145 145 PASS SVGSetElement.toString() is '[object SVGSetElementConstructor]' 146 FAIL SVGAnimateMotionElement.toString() should be [object SVGAnimateMotionElementConstructor]. Threw exception ReferenceError: Can't find variable: SVGAnimateMotionElement 147 FAIL SVGMPathElement.toString() should be [object SVGMPathElementConstructor]. Threw exception ReferenceError: Can't find variable: SVGMPathElement 146 PASS SVGAnimateMotionElement.toString() is '[object SVGAnimateMotionElementConstructor]' 147 PASS SVGMPathElement.toString() is '[object SVGMPathElementConstructor]' 148 148 PASS SVGAnimateColorElement.toString() is '[object SVGAnimateColorElementConstructor]' 149 149 PASS SVGAnimateTransformElement.toString() is '[object SVGAnimateTransformElementConstructor]' -
trunk/Source/WebCore/ChangeLog
r88019 r88020 1 2011-06-03 Rob Buis <rbuis@rim.com> 2 3 Reviewed by Nikolas Zimmermann. 4 5 Creating <animateMotion> elements via javascript do not execute 6 https://bugs.webkit.org/show_bug.cgi?id=34301 7 8 Enable constructors for SVGMPathElement and SVGAnimateMotionElement. 9 10 * DerivedSources.cpp: 11 * DerivedSources.make: 12 * GNUmakefile.list.am: 13 * WebCore.gypi: 14 * WebCore.vcproj/WebCore.vcproj: 15 * WebCore.xcodeproj/project.pbxproj: 16 * page/DOMWindow.idl: 17 1 18 2011-06-03 Hans Wennborg <hans@chromium.org> 2 19 … … 2598 2615 Include '+' in the list of valid characters. 2599 2616 2600 >>>>>>> .r877782601 2617 2011-05-30 Andrey Petrov <andrey.petrov@gmail.com> 2602 2618 -
trunk/Source/WebCore/DerivedSources.cpp
r87961 r88020 314 314 #include "JSSVGAnimatedTransformList.cpp" 315 315 #include "JSSVGAnimateElement.cpp" 316 #include "JSSVGAnimateMotionElement.cpp" 316 317 #include "JSSVGAnimateTransformElement.cpp" 317 318 #include "JSSVGAnimationElement.cpp" … … 371 372 #include "JSSVGLinearGradientElement.cpp" 372 373 #include "JSSVGLineElement.cpp" 374 #include "JSSVGMPathElement.cpp" 373 375 #include "JSSVGMarkerElement.cpp" 374 376 #include "JSSVGMaskElement.cpp" -
trunk/Source/WebCore/DerivedSources.make
r87961 r88020 372 372 SVGAnimateColorElement \ 373 373 SVGAnimateElement \ 374 SVGAnimateMotionElement \ 374 375 SVGAnimateTransformElement \ 375 376 SVGAnimatedAngle \ … … 451 452 SVGMetadataElement \ 452 453 SVGMissingGlyphElement \ 454 SVGMPathElement \ 453 455 SVGNumber \ 454 456 SVGNumberList \ -
trunk/Source/WebCore/GNUmakefile.list.am
r87961 r88020 4156 4156 DerivedSources/WebCore/JSSVGAnimateElement.cpp \ 4157 4157 DerivedSources/WebCore/JSSVGAnimateElement.h \ 4158 DerivedSources/WebCore/JSSVGAnimateMotionElement.cpp \ 4159 DerivedSources/WebCore/JSSVGAnimateMotionElement.h \ 4158 4160 DerivedSources/WebCore/JSSVGAnimateTransformElement.cpp \ 4159 4161 DerivedSources/WebCore/JSSVGAnimateTransformElement.h \ … … 4274 4276 DerivedSources/WebCore/JSSVGLineElement.h \ 4275 4277 DerivedSources/WebCore/JSSVGLocatable.h \ 4278 DerivedSources/WebCore/JSSVGMPathElement.cpp \ 4279 DerivedSources/WebCore/JSSVGMPathElement.h \ 4276 4280 DerivedSources/WebCore/JSSVGMarkerElement.cpp \ 4277 4281 DerivedSources/WebCore/JSSVGMarkerElement.h \ -
trunk/Source/WebCore/WebCore.gypi
r87961 r88020 7504 7504 '<(PRODUCT_DIR)/DerivedSources/WebCore/JSSVGAnimateElement.cpp', 7505 7505 '<(PRODUCT_DIR)/DerivedSources/WebCore/JSSVGAnimateElement.h', 7506 '<(PRODUCT_DIR)/DerivedSources/WebCore/JSSVGAnimateMotionElement.cpp', 7507 '<(PRODUCT_DIR)/DerivedSources/WebCore/JSSVGAnimateMotionElement.h', 7506 7508 '<(PRODUCT_DIR)/DerivedSources/WebCore/JSSVGAnimateTransformElement.cpp', 7507 7509 '<(PRODUCT_DIR)/DerivedSources/WebCore/JSSVGAnimateTransformElement.h', … … 7684 7686 '<(PRODUCT_DIR)/DerivedSources/WebCore/JSSVGLocatable.cpp', 7685 7687 '<(PRODUCT_DIR)/DerivedSources/WebCore/JSSVGLocatable.h', 7688 '<(PRODUCT_DIR)/DerivedSources/WebCore/JSSVGMPathElement.cpp', 7689 '<(PRODUCT_DIR)/DerivedSources/WebCore/JSSVGMPathElement.h', 7686 7690 '<(PRODUCT_DIR)/DerivedSources/WebCore/JSSVGMarkerElement.cpp', 7687 7691 '<(PRODUCT_DIR)/DerivedSources/WebCore/JSSVGMarkerElement.dep', -
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj
r87961 r88020 14831 14831 </File> 14832 14832 <File 14833 RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSSVGAnimateMotionElement.cpp" 14834 > 14835 <FileConfiguration 14836 Name="Debug|Win32" 14837 ExcludedFromBuild="true" 14838 > 14839 <Tool 14840 Name="VCCLCompilerTool" 14841 /> 14842 </FileConfiguration> 14843 <FileConfiguration 14844 Name="Release|Win32" 14845 ExcludedFromBuild="true" 14846 > 14847 <Tool 14848 Name="VCCLCompilerTool" 14849 /> 14850 </FileConfiguration> 14851 <FileConfiguration 14852 Name="Debug_Cairo_CFLite|Win32" 14853 ExcludedFromBuild="true" 14854 > 14855 <Tool 14856 Name="VCCLCompilerTool" 14857 /> 14858 </FileConfiguration> 14859 <FileConfiguration 14860 Name="Release_Cairo_CFLite|Win32" 14861 ExcludedFromBuild="true" 14862 > 14863 <Tool 14864 Name="VCCLCompilerTool" 14865 /> 14866 </FileConfiguration> 14867 <FileConfiguration 14868 Name="Debug_All|Win32" 14869 ExcludedFromBuild="true" 14870 > 14871 <Tool 14872 Name="VCCLCompilerTool" 14873 /> 14874 </FileConfiguration> 14875 <FileConfiguration 14876 Name="Production|Win32" 14877 ExcludedFromBuild="true" 14878 > 14879 <Tool 14880 Name="VCCLCompilerTool" 14881 /> 14882 </FileConfiguration> 14883 </File> 14884 <File 14885 RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSSVGAnimateMotionElement.h" 14886 > 14887 </File> 14888 <File 14833 14889 RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSSVGAnimateTransformElement.cpp" 14834 14890 > … … 17980 18036 <File 17981 18037 RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSSVGLineElement.h" 18038 > 18039 </File> 18040 <File 18041 RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSSVGMPathElement.cpp" 18042 > 18043 <FileConfiguration 18044 Name="Debug|Win32" 18045 ExcludedFromBuild="true" 18046 > 18047 <Tool 18048 Name="VCCLCompilerTool" 18049 /> 18050 </FileConfiguration> 18051 <FileConfiguration 18052 Name="Release|Win32" 18053 ExcludedFromBuild="true" 18054 > 18055 <Tool 18056 Name="VCCLCompilerTool" 18057 /> 18058 </FileConfiguration> 18059 <FileConfiguration 18060 Name="Debug_Cairo_CFLite|Win32" 18061 ExcludedFromBuild="true" 18062 > 18063 <Tool 18064 Name="VCCLCompilerTool" 18065 /> 18066 </FileConfiguration> 18067 <FileConfiguration 18068 Name="Release_Cairo_CFLite|Win32" 18069 ExcludedFromBuild="true" 18070 > 18071 <Tool 18072 Name="VCCLCompilerTool" 18073 /> 18074 </FileConfiguration> 18075 <FileConfiguration 18076 Name="Debug_All|Win32" 18077 ExcludedFromBuild="true" 18078 > 18079 <Tool 18080 Name="VCCLCompilerTool" 18081 /> 18082 </FileConfiguration> 18083 <FileConfiguration 18084 Name="Production|Win32" 18085 ExcludedFromBuild="true" 18086 > 18087 <Tool 18088 Name="VCCLCompilerTool" 18089 /> 18090 </FileConfiguration> 18091 </File> 18092 <File 18093 RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSSVGMPathElement.h" 17982 18094 > 17983 18095 </File> -
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
r87961 r88020 1003 1003 448A29C00A46D9CB0030759F /* JSHTMLOptionsCollection.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 448A29BE0A46D9CB0030759F /* JSHTMLOptionsCollection.cpp */; }; 1004 1004 448AD27C0A48137A0023D179 /* JSHTMLOptionsCollectionCustom.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 448AD27A0A4813790023D179 /* JSHTMLOptionsCollectionCustom.cpp */; }; 1005 4496E39D1398136C003EE32A /* JSSVGAnimateMotionElement.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 4496E39B1398136C003EE32A /* JSSVGAnimateMotionElement.cpp */; }; 1006 4496E39E1398136C003EE32A /* JSSVGAnimateMotionElement.h in Headers */ = {isa = PBXBuildFile; fileRef = 4496E39C1398136C003EE32A /* JSSVGAnimateMotionElement.h */; }; 1007 4496E3A0139813A5003EE32A /* JSSVGMPathElement.h in Headers */ = {isa = PBXBuildFile; fileRef = 4496E39F139813A5003EE32A /* JSSVGMPathElement.h */; }; 1008 4496E3A2139813CB003EE32A /* JSSVGMPathElement.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 4496E3A1139813CB003EE32A /* JSSVGMPathElement.cpp */; }; 1005 1009 449B19F50FA72ECE0015CA4A /* HTMLParserQuirks.h in Headers */ = {isa = PBXBuildFile; fileRef = 449B19F30FA72ECE0015CA4A /* HTMLParserQuirks.h */; settings = {ATTRIBUTES = (Private, ); }; }; 1006 1010 44A28AAC12DFB8AC00AE923B /* MathMLElementFactory.h in Headers */ = {isa = PBXBuildFile; fileRef = 44A28AAB12DFB8AC00AE923B /* MathMLElementFactory.h */; }; … … 7580 7584 448AD27A0A4813790023D179 /* JSHTMLOptionsCollectionCustom.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSHTMLOptionsCollectionCustom.cpp; sourceTree = "<group>"; }; 7581 7585 449098B10F8F82520076A327 /* FeatureDefines.xcconfig */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.xcconfig; path = FeatureDefines.xcconfig; sourceTree = "<group>"; }; 7586 4496E39B1398136C003EE32A /* JSSVGAnimateMotionElement.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = JSSVGAnimateMotionElement.cpp; path = ../../WebKitBuild/Release/DerivedSources/WebCore/JSSVGAnimateMotionElement.cpp; sourceTree = SOURCE_ROOT; }; 7587 4496E39C1398136C003EE32A /* JSSVGAnimateMotionElement.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = JSSVGAnimateMotionElement.h; path = ../../WebKitBuild/Release/DerivedSources/WebCore/JSSVGAnimateMotionElement.h; sourceTree = SOURCE_ROOT; }; 7588 4496E39F139813A5003EE32A /* JSSVGMPathElement.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = JSSVGMPathElement.h; path = ../../WebKitBuild/Release/DerivedSources/WebCore/JSSVGMPathElement.h; sourceTree = SOURCE_ROOT; }; 7589 4496E3A1139813CB003EE32A /* JSSVGMPathElement.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; name = JSSVGMPathElement.cpp; path = ../../WebKitBuild/Release/DerivedSources/WebCore/JSSVGMPathElement.cpp; sourceTree = SOURCE_ROOT; }; 7582 7590 449B19F30FA72ECE0015CA4A /* HTMLParserQuirks.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = HTMLParserQuirks.h; sourceTree = "<group>"; }; 7583 7591 44A28AAB12DFB8AC00AE923B /* MathMLElementFactory.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = MathMLElementFactory.h; sourceTree = "<group>"; }; … … 16702 16710 isa = PBXGroup; 16703 16711 children = ( 16712 4496E3A1139813CB003EE32A /* JSSVGMPathElement.cpp */, 16713 4496E39F139813A5003EE32A /* JSSVGMPathElement.h */, 16714 4496E39B1398136C003EE32A /* JSSVGAnimateMotionElement.cpp */, 16715 4496E39C1398136C003EE32A /* JSSVGAnimateMotionElement.h */, 16704 16716 B20111050AB7740500DB0E68 /* JSSVGAElement.cpp */, 16705 16717 B20111060AB7740500DB0E68 /* JSSVGAElement.h */, … … 23119 23131 8C0E334D138A92C7008DA94F /* LevelDBTransaction.h in Headers */, 23120 23132 8C0E334F138A92C7008DA94F /* LevelDBWriteBatch.h in Headers */, 23133 4496E39E1398136C003EE32A /* JSSVGAnimateMotionElement.h in Headers */, 23134 4496E3A0139813A5003EE32A /* JSSVGMPathElement.h in Headers */, 23121 23135 2E2445F71395893A004B6C19 /* OperationNotAllowedException.h in Headers */, 23122 23136 2E24476913959173004B6C19 /* JSOperationNotAllowedException.h in Headers */, … … 25846 25860 8C0E334C138A92C7008DA94F /* LevelDBTransaction.cpp in Sources */, 25847 25861 8C0E334E138A92C7008DA94F /* LevelDBWriteBatch.cpp in Sources */, 25862 4496E39D1398136C003EE32A /* JSSVGAnimateMotionElement.cpp in Sources */, 25863 4496E3A2139813CB003EE32A /* JSSVGMPathElement.cpp in Sources */, 25848 25864 2E24476813959173004B6C19 /* JSOperationNotAllowedException.cpp in Sources */, 25849 25865 ); -
trunk/Source/WebCore/page/DOMWindow.idl
r87197 r88020 717 717 attribute SVGAnimateColorElementConstructor SVGAnimateColorElement; 718 718 attribute SVGAnimateElementConstructor SVGAnimateElement; 719 //attribute SVGAnimateMotionElementConstructor SVGAnimateMotionElement;719 attribute SVGAnimateMotionElementConstructor SVGAnimateMotionElement; 720 720 attribute SVGAnimateTransformElementConstructor SVGAnimateTransformElement; 721 //attribute SVGMPathElementConstructor SVGMPathElement;721 attribute SVGMPathElementConstructor SVGMPathElement; 722 722 attribute SVGSetElementConstructor SVGSetElement; 723 723 #endif
Note:
See TracChangeset
for help on using the changeset viewer.