Changeset 88203 in webkit


Ignore:
Timestamp:
Jun 6, 2011, 5:03:16 PM (14 years ago)
Author:
thakis@chromium.org
Message:

2011-06-06 Nico Weber <​thakis@chromium.org>

Reviewed by James Robinson.

[chromium] Make WebViewImpl's destructor virtual
​https://bugs.webkit.org/show_bug.cgi?id=62155

This is _not_ to fix a real bug, just to make clang's
-Wdelete-non-virtual-dtor happy. As discussed at
​http://codereview.chromium.org/7094005/, we prefer making leaf class
destructors virtual over making the leaf classes final.

  • src/WebViewImpl.h:
Location:
trunk/Source/WebKit/chromium
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/chromium/ChangeLog

    r88192 r88203  
     12011-06-06  Nico Weber  <thakis@chromium.org>
     2
     3        Reviewed by James Robinson.
     4
     5        [chromium] Make WebViewImpl's destructor virtual
     6        https://bugs.webkit.org/show_bug.cgi?id=62155
     7
     8        This is _not_ to fix a real bug, just to make clang's
     9        -Wdelete-non-virtual-dtor happy. As discussed at
     10        http://codereview.chromium.org/7094005/, we prefer making leaf class
     11        destructors virtual over making the leaf classes final.
     12
     13        * src/WebViewImpl.h:
     14
    1152011-06-06  Daniel Cheng  <dcheng@chromium.org>
    216

  • trunk/Source/WebKit/chromium/src/WebViewImpl.h

    r87417 r88203  
    383383
    384384    WebViewImpl(WebViewClient*);
    385     ~WebViewImpl();
     385    virtual ~WebViewImpl();
    386386
    387387    // Returns true if the event was actually processed.
Note: See TracChangeset for help on using the changeset viewer.