Changeset 88598 in webkit

Timestamp:

Jun 10, 2011, 11:04:28 PM (14 years ago)

Author:

rniwa@webkit.org

Message:

2011-06-10 Ryosuke Niwa <​rniwa@webkit.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: 'images' links on results.html don't work
​https://bugs.webkit.org/show_bug.cgi?id=62194

Use relative path when generating images-diffs.html

• Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Added _output_testname.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-06-10  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Reviewed by Ojan Vafai.
+
+        new-run-webkit-tests: 'images' links on results.html don't work
+        https://bugs.webkit.org/show_bug.cgi?id=62194
+
+        Use relative path when generating images-diffs.html
+
+        * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
+        Added _output_testname.
+
 2011-06-10  Lucas Forschler  <lforschler@apple.com>
 

trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py

@@ -133 +133 @@
         return fs.splitext(output_filename)[0] + modifier
 
+    def _output_testname(self, modifier):
+        fs = self._port._filesystem
+        return fs.splitext(fs.basename(self._testname))[0] + modifier
+
     def write_output_files(self, file_type, output, expected):
         """Writes the test output, the expected output in the results directory.
@@ -242 +246 @@
     setInterval(toggleImages, 2000)
 </script>
-""" % { 'title': self._testname, 'diff_filename': self.output_filename('-diff.png'), 'prefix': self.output_filename('') }
+""" % { 'title': self._testname, 'diff_filename': self._output_testname('-diff.png'), 'prefix': self._output_testname('') }
         self._port._filesystem.write_binary_file(diffs_html_filename, html)