Changeset 88987 in webkit


Ignore:
Timestamp:
Jun 15, 2011, 6:09:05 PM (14 years ago)
Author:
inferno@chromium.org
Message:

2011-06-15 Abhishek Arya <​inferno@chromium.org>

Reviewed by Antti Koivisto.

Tests that accessing the parent stylesheet in nodes (not in document)
do not result in crash when document is cleared.
​https://bugs.webkit.org/show_bug.cgi?id=62586

  • fast/dom/body-clone-link-decl-parent-crash-expected.txt: Added.
  • fast/dom/body-clone-link-decl-parent-crash.html: Added.
  • fast/dom/styled-clone-inline-style-decl-parent-crash-expected.txt: Added.
  • fast/dom/styled-clone-inline-style-decl-parent-crash.html: Added.
  • fast/dom/styled-not-in-document-clone-inline-style-decl-parent-crash-expected.txt: Added.
  • fast/dom/styled-not-in-document-clone-inline-style-decl-parent-crash.html: Added.

2011-06-15 Abhishek Arya <​inferno@chromium.org>

Reviewed by Antti Koivisto.

Revert speculative fix in r84151. It caused some issues with
stylesheet lifetimes.
​https://bugs.webkit.org/show_bug.cgi?id=62586

Tests: fast/dom/body-clone-link-decl-parent-crash.html

fast/dom/styled-clone-inline-style-decl-parent-crash.html
fast/dom/styled-not-in-document-clone-inline-style-decl-parent-crash.html

  • dom/Document.cpp: (WebCore::Document::removedLastRef):
Location:
trunk
Files:
6 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r88981 r88987  
     12011-06-15  Abhishek Arya  <inferno@chromium.org>
     2
     3        Reviewed by Antti Koivisto.
     4
     5        Tests that accessing the parent stylesheet in nodes (not in document)
     6        do not result in crash when document is cleared.
     7        https://bugs.webkit.org/show_bug.cgi?id=62586
     8
     9        * fast/dom/body-clone-link-decl-parent-crash-expected.txt: Added.
     10        * fast/dom/body-clone-link-decl-parent-crash.html: Added.
     11        * fast/dom/styled-clone-inline-style-decl-parent-crash-expected.txt: Added.
     12        * fast/dom/styled-clone-inline-style-decl-parent-crash.html: Added.
     13        * fast/dom/styled-not-in-document-clone-inline-style-decl-parent-crash-expected.txt: Added.
     14        * fast/dom/styled-not-in-document-clone-inline-style-decl-parent-crash.html: Added.
     15
    1162011-06-15  Stephen White  <senorblanco@chromium.org>
    217

  • trunk/Source/WebCore/ChangeLog

    r88985 r88987  
     12011-06-15  Abhishek Arya  <inferno@chromium.org>
     2
     3        Reviewed by Antti Koivisto.
     4
     5        Revert speculative fix in r84151. It caused some issues with
     6        stylesheet lifetimes.
     7        https://bugs.webkit.org/show_bug.cgi?id=62586
     8
     9        Tests: fast/dom/body-clone-link-decl-parent-crash.html
     10               fast/dom/styled-clone-inline-style-decl-parent-crash.html
     11               fast/dom/styled-not-in-document-clone-inline-style-decl-parent-crash.html
     12
     13        * dom/Document.cpp:
     14        (WebCore::Document::removedLastRef):
     15
    1162011-06-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
    217

  • trunk/Source/WebCore/dom/Document.cpp

    r88982 r88987  
    572572        m_fullScreenElement = 0;
    573573#endif
    574         m_styleSelector.clear();
    575         m_styleSheets.clear();
    576         m_elemSheet.clear();
    577         m_mappedElementSheet.clear();
    578         m_pageUserSheet.clear();
    579         m_pageGroupUserSheets.clear();
    580574
    581575        // removeAllChildren() doesn't always unregister IDs,
Note: See TracChangeset for help on using the changeset viewer.