Changeset 89196 in webkit

Timestamp:

Jun 18, 2011, 12:33:28 PM (14 years ago)

Author:

commit-queue@webkit.org

Message:

2011-06-18 Berend-Jan Wever <​skylined@chromium.org>

Reviewed by Eric Seidel.

Some names with spaces are incorrectly reported as not containing spaces
while running prepare-ChangeLog
​https://bugs.webkit.org/show_bug.cgi?id=55572

• Scripts/VCSUtils.pm: Updated CHANGE_LOG_NAME check for spaces to allow non-alphanumeric characters in names.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/VCSUtils.pm (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-06-18  Berend-Jan Wever  <skylined@chromium.org>
+
+        Reviewed by Eric Seidel.
+
+        Some names with spaces are incorrectly reported as not containing spaces
+        while running prepare-ChangeLog
+        https://bugs.webkit.org/show_bug.cgi?id=55572
+
+        * Scripts/VCSUtils.pm: Updated CHANGE_LOG_NAME check for spaces to allow
+          non-alphanumeric characters in names.
+
 2011-06-18  Michael Saboff  <msaboff@apple.com>
 

trunk/Tools/Scripts/VCSUtils.pm

@@ -1766 +1766 @@
     changeLogNameError("Failed to determine ChangeLog name.") unless $name;
     # getpwuid seems to always succeed on windows, returning the username instead of the full name.  This check will catch that case.
-    changeLogNameError("'$name' does not contain a space!  ChangeLogs should contain your full name.") unless ($name =~ /\w \w/);
+    changeLogNameError("'$name' does not contain a space!  ChangeLogs should contain your full name.") unless ($name =~ /\S\s\S/);
 
     return $name;