Changeset 90206 in webkit

Timestamp:

Jun 30, 2011, 11:06:59 PM (14 years ago)

Author:

commit-queue@webkit.org

Message:

2011-06-30 Noel Gordon <​noel.gordon@gmail.com>

Reviewed by Hajime Morita.

[Chromium] Remove WebBindings::makeNode.
​https://bugs.webkit.org/show_bug.cgi?id=63613

Dead code elimination. No change in behaviour, so no new tests.

• public/WebBindings.h:
• src/WebBindings.cpp:

Location:

trunk/Source/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• public/WebBindings.h (modified) (2 diffs)
• src/WebBindings.cpp (modified) (3 diffs)

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2011-06-30  Noel Gordon  <noel.gordon@gmail.com>
+
+        Reviewed by Hajime Morita.
+
+        [Chromium] Remove WebBindings::makeNode.
+        https://bugs.webkit.org/show_bug.cgi?id=63613
+
+        Dead code elimination. No change in behaviour, so no new tests.
+
+        * public/WebBindings.h:
+        * src/WebBindings.cpp:
+
 2011-06-30  Kent Tamura  <tkent@chromium.org>
 

trunk/Source/WebKit/chromium/public/WebBindings.h

@@ -129 +129 @@
     WEBKIT_API static void extractIdentifierData(const NPIdentifier&, const NPUTF8*& string, int32_t& number, bool& isString);
 
+    // DumpRenderTree support -------------------------------------------------
+
     // Return true (success) if the given npobj is a range object.
     // If so, return that range as a WebRange object.
@@ -139 +141 @@
     WEBKIT_API static NPObject* makeIntArray(const WebVector<int>&);
     WEBKIT_API static NPObject* makeStringArray(const WebVector<WebString>&);
-    WEBKIT_API static NPObject* makeNode(const WebNode&);
 
     // Exceptions -------------------------------------------------------------

trunk/Source/WebKit/chromium/src/WebBindings.cpp

@@ -42 +42 @@
 #include "V8Element.h"
 #include "V8NPUtils.h"
-#include "V8Node.h"
 #include "V8Proxy.h"
 #include "V8Range.h"
@@ -258 +257 @@
 }
 
-static NPObject* makeNodeImpl(WebNode data)
-{
-    v8::HandleScope handleScope;
-    if (data.isNull())
-        return 0;
-    v8::Handle<v8::Object> result = V8Node::wrap(data.unwrap<Node>());
-    WebCore::DOMWindow* window = WebCore::V8Proxy::retrieveWindow(WebCore::V8Proxy::currentContext());
-    return npCreateV8ScriptObject(0, result, window);
-}
-
 #endif
 
@@ -310 +299 @@
 }
 
-NPObject* WebBindings::makeNode(const WebNode& data)
-{
-#if USE(V8)
-    return makeNodeImpl(data);
-#else
-    // Not supported on other ports (JSC, etc.).
-    return 0;
-#endif
-}
-
 void WebBindings::pushExceptionHandler(ExceptionHandler handler, void* data)
 {