Changeset 90425 in webkit

Timestamp:

Jul 5, 2011, 6:20:27 PM (14 years ago)

Author:

commit-queue@webkit.org

Message:

2011-07-05 Zoltan Herczeg <​zherczeg@inf.u-szeged.hu>

Make "Add optimised paths for a few maths functions" work on Qt
​https://bugs.webkit.org/show_bug.cgi?id=63893

Reviewed by Oliver Hunt.

Move the generated code to the .text section instead of .data section.
Fix alignment for the 32 bit thunk code.

• jit/ThunkGenerators.cpp:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• jit/ThunkGenerators.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2011-07-05  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
+
+        Make "Add optimised paths for a few maths functions" work on Qt
+        https://bugs.webkit.org/show_bug.cgi?id=63893
+
+        Reviewed by Oliver Hunt.
+
+        Move the generated code to the .text section instead of .data section.
+        Fix alignment for the 32 bit thunk code.
+
+        * jit/ThunkGenerators.cpp:
+
 2011-07-05  Filip Pizlo  <fpizlo@apple.com>
 

trunk/Source/JavaScriptCore/jit/ThunkGenerators.cpp

@@ -133 +133 @@
 }
     
-#if CPU(X86_64) && COMPILER(GCC) && PLATFORM(MAC)
+#if CPU(X86_64) && COMPILER(GCC) && (PLATFORM(MAC) || OS(LINUX))
 
 #define defineUnaryDoubleOpWrapper(function) \
     asm( \
+        ".text\n" \
         ".globl " SYMBOL_STRING(function##Thunk) "\n" \
         SYMBOL_STRING(function##Thunk) ":" "\n" \
@@ -147 +148 @@
     static MathThunk UnaryDoubleOpWrapper(function) = &function##Thunk;
 
-#elif CPU(X86) && COMPILER(GCC) && PLATFORM(MAC)
+#elif CPU(X86) && COMPILER(GCC) && (PLATFORM(MAC) || OS(LINUX))
 #define defineUnaryDoubleOpWrapper(function) \
     asm( \
-         ".globl " SYMBOL_STRING(function##Thunk) "\n" \
-         SYMBOL_STRING(function##Thunk) ":" "\n" \
-         "subl $8, %esp\n" \
-         "movsd %xmm0, (%esp) \n" \
-         "call " SYMBOL_STRING_RELOCATION(function) "\n" \
-         "fstpl (%esp) \n" \
-         "movsd (%esp), %xmm0 \n" \
-         "addl $8, %esp\n" \
-         "ret\n" \
+        ".text\n" \
+        ".globl " SYMBOL_STRING(function##Thunk) "\n" \
+        SYMBOL_STRING(function##Thunk) ":" "\n" \
+        "subl $8, %esp\n" \
+        "movsd %xmm0, (%esp) \n" \
+        "call " SYMBOL_STRING_RELOCATION(function) "\n" \
+        "fstpl (%esp) \n" \
+        "movsd (%esp), %xmm0 \n" \
+        "addl $8, %esp\n" \
+        "ret\n" \
     );\
     extern "C" { \