Changeset 90818 in webkit


Ignore:
Timestamp:
Jul 12, 2011, 7:49:33 AM (14 years ago)
Author:
podivilov@chromium.org
Message:

Web Inspector: make TextViewerDelegate methods implementations public in SourceFrame.
​https://bugs.webkit.org/show_bug.cgi?id=64353

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.beforeTextChanged):
(WebInspector.SourceFrame.prototype.afterTextChanged):
(WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):
(WebInspector.SourceFrame.prototype.suggestedFileName):
(WebInspector.SourceFrame.prototype.doubleClick):
(WebInspector.SourceFrame.prototype.cancelEditing):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.doubleClick):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.beforeTextChanged):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.afterTextChanged):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.commitEditing):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.cancelEditing):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.populateLineGutterContextMenu):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.populateTextAreaContextMenu):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.suggestedFileName):

LayoutTests:

  • inspector/debugger/live-edit.html:
Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r90816 r90818  
     12011-07-12  Pavel Podivilov  <podivilov@chromium.org>
     2
     3        Web Inspector: make TextViewerDelegate methods implementations public in SourceFrame.
     4        https://bugs.webkit.org/show_bug.cgi?id=64353
     5
     6        Reviewed by Pavel Feldman.
     7
     8        * inspector/debugger/live-edit.html:
     9
    1102011-07-12  Adam Roben  <aroben@apple.com>
    211

  • trunk/LayoutTests/inspector/debugger/live-edit.html

    r90743 r90818  
    113113        InspectorTest.addSniffer(WebInspector.debuggerModel, "_didEditScriptSource", callback);
    114114        sourceFrame._textViewer._mainPanel.readOnly = false;
    115         sourceFrame._beforeTextChanged();
     115        sourceFrame.beforeTextChanged();
    116116        var oldRange, newRange;
    117117        var lines = sourceFrame._textModel._lines;
    … …  
    127127            break;
    128128        }
    129         sourceFrame._afterTextChanged(oldRange, newRange);
     129        sourceFrame.afterTextChanged(oldRange, newRange);
    130130        sourceFrame._textViewer._commitEditing();
    131131    }

  • trunk/Source/WebCore/ChangeLog

    r90815 r90818  
     12011-07-12  Pavel Podivilov  <podivilov@chromium.org>
     2
     3        Web Inspector: make TextViewerDelegate methods implementations public in SourceFrame.
     4        https://bugs.webkit.org/show_bug.cgi?id=64353
     5
     6        Reviewed by Pavel Feldman.
     7
     8        * inspector/front-end/SourceFrame.js:
     9        (WebInspector.SourceFrame.prototype.beforeTextChanged):
     10        (WebInspector.SourceFrame.prototype.afterTextChanged):
     11        (WebInspector.SourceFrame.prototype.populateTextAreaContextMenu):
     12        (WebInspector.SourceFrame.prototype.suggestedFileName):
     13        (WebInspector.SourceFrame.prototype.doubleClick):
     14        (WebInspector.SourceFrame.prototype.cancelEditing):
     15        (WebInspector.TextViewerDelegateForSourceFrame.prototype.doubleClick):
     16        (WebInspector.TextViewerDelegateForSourceFrame.prototype.beforeTextChanged):
     17        (WebInspector.TextViewerDelegateForSourceFrame.prototype.afterTextChanged):
     18        (WebInspector.TextViewerDelegateForSourceFrame.prototype.commitEditing):
     19        (WebInspector.TextViewerDelegateForSourceFrame.prototype.cancelEditing):
     20        (WebInspector.TextViewerDelegateForSourceFrame.prototype.populateLineGutterContextMenu):
     21        (WebInspector.TextViewerDelegateForSourceFrame.prototype.populateTextAreaContextMenu):
     22        (WebInspector.TextViewerDelegateForSourceFrame.prototype.suggestedFileName):
     23
    1242011-07-12  Andrey Kosyakov  <caseq@chromium.org>
    225

  • trunk/Source/WebCore/inspector/front-end/SourceFrame.js

    r90743 r90818  
    238238    },
    239239
    240     _beforeTextChanged: function()
     240    beforeTextChanged: function()
    241241    {
    242242        if (!this._viewerState) {
    … …  
    249249    },
    250250
    251     _afterTextChanged: function(oldRange, newRange)
     251    afterTextChanged: function(oldRange, newRange)
    252252    {
    253253        if (!oldRange || !newRange)
    … …  
    594594    },
    595595
    596     _populateLineGutterContextMenu: function(lineNumber, contextMenu)
     596    populateLineGutterContextMenu: function(lineNumber, contextMenu)
    597597    {
    598598        contextMenu.appendItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Continue to here" : "Continue to Here"), this._delegate.continueToLine.bind(this._delegate, lineNumber));
    … …  
    639639    },
    640640
    641     _populateTextAreaContextMenu: function(contextMenu)
    642     {
    643     },
    644 
    645     _suggestedFileName: function()
     641    populateTextAreaContextMenu: function(contextMenu)
     642    {
     643    },
     644
     645    suggestedFileName: function()
    646646    {
    647647        return this._delegate.suggestedFileName();
    … …  
    873873    },
    874874
    875     _doubleClick: function(lineNumber)
     875    doubleClick: function(lineNumber)
    876876    {
    877877        if (!this._delegate.canEditScriptSource())
    … …  
    884884    },
    885885
    886     _commitEditing: function()
     886    commitEditing: function()
    887887    {
    888888        if (!this._viewerState) {
    … …  
    932932    },
    933933
    934     _cancelEditing: function()
     934    cancelEditing: function()
    935935    {
    936936        this._restoreViewerState();
    … …  
    958958    doubleClick: function(lineNumber)
    959959    {
    960         this._sourceFrame._doubleClick(lineNumber);
     960        this._sourceFrame.doubleClick(lineNumber);
    961961    },
    962962
    963963    beforeTextChanged: function()
    964964    {
    965         this._sourceFrame._beforeTextChanged();
     965        this._sourceFrame.beforeTextChanged();
    966966    },
    967967
    968968    afterTextChanged: function(oldRange, newRange)
    969969    {
    970         this._sourceFrame._afterTextChanged(oldRange, newRange);
     970        this._sourceFrame.afterTextChanged(oldRange, newRange);
    971971    },
    972972
    973973    commitEditing: function()
    974974    {
    975         this._sourceFrame._commitEditing();
     975        this._sourceFrame.commitEditing();
    976976    },
    977977
    978978    cancelEditing: function()
    979979    {
    980         this._sourceFrame._cancelEditing();
     980        this._sourceFrame.cancelEditing();
    981981    },
    982982
    983983    populateLineGutterContextMenu: function(lineNumber, contextMenu)
    984984    {
    985         this._sourceFrame._populateLineGutterContextMenu(lineNumber, contextMenu);
     985        this._sourceFrame.populateLineGutterContextMenu(lineNumber, contextMenu);
    986986    },
    987987
    988988    populateTextAreaContextMenu: function(contextMenu)
    989989    {
    990         this._sourceFrame._populateTextAreaContextMenu(contextMenu);
     990        this._sourceFrame.populateTextAreaContextMenu(contextMenu);
    991991    },
    992992
    993993    suggestedFileName: function()
    994994    {
    995         return this._sourceFrame._suggestedFileName();
     995        return this._sourceFrame.suggestedFileName();
    996996    }
    997997};
Note: See TracChangeset for help on using the changeset viewer.