Changeset 90918 in webkit

Timestamp:

Jul 13, 2011, 7:52:07 AM (14 years ago)

Author:

xan@webkit.org

Message:

2011-07-13 Xan Lopez <​xlopez@igalia.com>

[GTK] Do not grab focus too early in DRT.

Reviewed by Gustavo Noronha.

It causes a layout to happen and a progress signal to be emitted
since r90900, but at this point we don't have a
LayoutTestController object and we'll eventually crash. Since we
already grab focus at the beginning of runTest() this is
redundant, so get rid of it to fix the crash.

• DumpRenderTree/gtk/DumpRenderTree.cpp: (main): remove call to grab_focus

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• DumpRenderTree/gtk/DumpRenderTree.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-07-13  Xan Lopez  <xlopez@igalia.com>
+
+        [GTK] Do not grab focus too early in DRT.
+
+        Reviewed by Gustavo Noronha.
+
+        It causes a layout to happen and a progress signal to be emitted
+        since r90900, but at this point we don't have a
+        LayoutTestController object and we'll eventually crash. Since we
+        already grab focus at the beginning of runTest() this is
+        redundant, so get rid of it to fix the crash.
+
+        * DumpRenderTree/gtk/DumpRenderTree.cpp:
+        (main): remove call to grab_focus
+
 2011-07-13  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp

@@ -1173 +1173 @@
     gtk_widget_realize(GTK_WIDGET(webView));
     gtk_widget_show_all(container);
-    gtk_widget_grab_focus(GTK_WIDGET(webView));
     mainFrame = webkit_web_view_get_main_frame(webView);