Changeset 91178 in webkit

Timestamp:

Jul 18, 2011, 5:40:35 AM (14 years ago)

Author:

jchaffraix@webkit.org

Message:

Remove RenderObject::addLayers second argument
​https://bugs.webkit.org/show_bug.cgi?id=64649

Reviewed by Benjamin Poulain.

No change in behavior.

The code was always passing |this| as the second argument. Thus just
removed the argument for clarity.

• rendering/RenderObject.h:
• rendering/RenderObject.cpp:

(WebCore::RenderObject::addLayers): Removed the argument, replaced
by |this|.

• rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::appendChildNode):
(WebCore::RenderObjectChildList::insertChildNode):
Removed the second argument at those 2 call sites.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderObject.cpp (modified) (1 diff)
• rendering/RenderObject.h (modified) (1 diff)
• rendering/RenderObjectChildList.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-07-18  Julien Chaffraix  <jchaffraix@webkit.org>
+
+        Remove RenderObject::addLayers second argument
+        https://bugs.webkit.org/show_bug.cgi?id=64649
+
+        Reviewed by Benjamin Poulain.
+
+        No change in behavior.
+
+        The code was always passing |this| as the second argument. Thus just
+        removed the argument for clarity.
+
+        * rendering/RenderObject.h:
+        * rendering/RenderObject.cpp:
+        (WebCore::RenderObject::addLayers): Removed the argument, replaced
+        by |this|.
+
+        * rendering/RenderObjectChildList.cpp:
+        (WebCore::RenderObjectChildList::appendChildNode):
+        (WebCore::RenderObjectChildList::insertChildNode):
+        Removed the second argument at those 2 call sites.
+
 2011-07-18  Pavel Feldman  <pfeldman@google.com>
 

trunk/Source/WebCore/rendering/RenderObject.cpp

@@ -443 +443 @@
 }
 
-void RenderObject::addLayers(RenderLayer* parentLayer, RenderObject* newObject)
+void RenderObject::addLayers(RenderLayer* parentLayer)
 {
     if (!parentLayer)
         return;
 
-    RenderObject* object = newObject;
+    RenderObject* object = this;
     RenderLayer* beforeChild = 0;
     WebCore::addLayers(this, parentLayer, object, beforeChild);

trunk/Source/WebCore/rendering/RenderObject.h

@@ -177 +177 @@
     // can contain a mixture of boxes and other object types, these functions need to be in the base class.
     RenderLayer* enclosingLayer() const;
-    void addLayers(RenderLayer* parentLayer, RenderObject* newObject);
+    void addLayers(RenderLayer* parentLayer);
     void removeLayers(RenderLayer* parentLayer);
     void moveLayers(RenderLayer* oldParent, RenderLayer* newParent);

trunk/Source/WebCore/rendering/RenderObjectChildList.cpp

@@ -161 +161 @@
         if (newChild->firstChild() || newChild->hasLayer()) {
             layer = owner->enclosingLayer();
-            newChild->addLayers(layer, newChild);
+            newChild->addLayers(layer);
         }
 
@@ -221 +221 @@
         if (child->firstChild() || child->hasLayer()) {
             layer = owner->enclosingLayer();
-            child->addLayers(layer, child);
+            child->addLayers(layer);
         }