Changeset 91324 in webkit

Timestamp:

Jul 19, 2011, 5:46:57 PM (14 years ago)

Author:

Simon Fraser

Message:

2011-07-19 Simon Fraser <Simon Fraser>

REGRESSION (r91136-r91146): 40 tests failing on Windows 7 Release (Tests)
​https://bugs.webkit.org/show_bug.cgi?id=64808

Reviewed by Adam Roben.

Initializing m_uncommittedChanges to a non-zero value
caused the first call to noteLayerPropertyChanged() to
not call m_client->notifySyncRequired(). This resulted in
animations never getting committed on Windows, which broke
a lot of tests.

• platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::GraphicsLayerCA):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/ca/GraphicsLayerCA.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-07-19  Simon Fraser  <simon.fraser@apple.com>
+
+        REGRESSION (r91136-r91146): 40 tests failing on Windows 7 Release (Tests)
+        https://bugs.webkit.org/show_bug.cgi?id=64808
+
+        Reviewed by Adam Roben.
+
+        Initializing m_uncommittedChanges to a non-zero value
+        caused the first call to noteLayerPropertyChanged() to
+        not call m_client->notifySyncRequired(). This resulted in
+        animations never getting committed on Windows, which broke
+        a lot of tests.
+
+        * platform/graphics/ca/GraphicsLayerCA.cpp:
+        (WebCore::GraphicsLayerCA::GraphicsLayerCA):
+
 2011-07-19  James Robinson  <jamesr@chromium.org>
 

trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp

@@ -251 +251 @@
     , m_contentsLayerHasBackgroundColor(false)
     , m_allowTiledLayer(true)
-    , m_uncommittedChanges(ContentsScaleChanged)
+    , m_uncommittedChanges(0)
 {
     m_layer = PlatformCALayer::create(PlatformCALayer::LayerTypeWebLayer, this);
@@ -260 +260 @@
 
     updateDebugIndicators();
+    noteLayerPropertyChanged(ContentsScaleChanged);
 }