Changeset 91477 in webkit


Ignore:
Timestamp:
Jul 21, 2011, 9:48:06 AM (14 years ago)
Author:
sjl@chromium.org
Message:

Merge 91337 - [chromium] Media player controls do not fade out.
​https://bugs.webkit.org/show_bug.cgi?id=64837

Media controls were not fading out when the mouse leaves the video
due to underlying changes in webkit media controls.
Fix was to copy missing code from MediaControlRootElement to
MediaControlRootElementChromium.

Reviewed by Dimitri Glazkov.

  • html/shadow/MediaControlRootElementChromium.cpp:

(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
(WebCore::MediaControlRootElementChromium::playbackProgressed):
(WebCore::MediaControlRootElementChromium::containsRelatedTarget):
(WebCore::MediaControlRootElementChromium::defaultEventHandler):

  • html/shadow/MediaControlRootElementChromium.h:

TBR=​sjl@chromium.org
Review URL: ​http://codereview.chromium.org/7472040

Location:
branches/chromium/782/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • branches/chromium/782/Source/WebCore/ChangeLog

    r91397 r91477  
    1 2011-07-20  James Robinson  <jamesr@chromium.org>
    2 
    3         Speculative null pointer check to fix crashes seen in the field.
    4         BUG=89193, cros bug 17121
     12011-07-19  Steve Lacey  <sjl@chromium.org>
     2
     3        [chromium] Media player controls do not fade out.
     4        https://bugs.webkit.org/show_bug.cgi?id=64837
     5
     6        Media controls were not fading out when the mouse leaves the video
     7        due to underlying changes in webkit media controls.
     8        Fix was to copy missing code from MediaControlRootElement to
     9        MediaControlRootElementChromium.
     10
     11        Reviewed by Dimitri Glazkov.
     12
     13        * html/shadow/MediaControlRootElementChromium.cpp:
     14        (WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
     15        (WebCore::MediaControlRootElementChromium::playbackProgressed):
     16        (WebCore::MediaControlRootElementChromium::containsRelatedTarget):
     17        (WebCore::MediaControlRootElementChromium::defaultEventHandler):
     18        * html/shadow/MediaControlRootElementChromium.h:
     19
     202011-07-19  Luke Macpherson   <macpherson@chromium.org>
     21
     22        Implement CSSPropertyCounterIncrement and CounterReset in CSSStyleApplyProperty.
     23        https://bugs.webkit.org/show_bug.cgi?id=64846
     24
     25        Reviewed by Dimitri Glazkov.
     26
     27        No new tests / refactoring only.
     28
     29        * css/CSSStyleApplyProperty.cpp:
     30        (WebCore::ApplyPropertyCounter
     31        Added class to handle counter properties.
     32        (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
     33        Initialize counter property handlers.
     34        * css/CSSStyleSelector.cpp:
     35        (WebCore::CSSStyleSelector::applyProperty):
     36        Remove old handlers.
     37
     382011-07-19  Kent Tamura  <tkent@chromium.org>
     39
     40        REGRESSION(r89004): Video pauses and never resumes playing if scrubbed during playback.
     41        https://bugs.webkit.org/show_bug.cgi?id=64314
     42
     43        Reviewed by Sam Weinig.
     44
     45        No new tests because it's hard to make a non-flaky test for this behavior.
     46
     47        * html/RangeInputType.cpp:
     48        (WebCore::RangeInputType::handleMouseDownEvent):
     49        Don't call SliderThumbElement::dragFrom() for events on the thumb.
     50        * html/shadow/SliderThumbElement.cpp:
     51        (WebCore::SliderThumbElement::defaultEventHandler):
     52        Do not call setDefaultHandled() for mouse events in order to
     53        propagate them to ancestor elements.
     54
     552011-07-19  Matthew Delaney  <mdelaney@apple.com>
     56
     57        Add fast path for ImageBuffer::draw
     58        https://bugs.webkit.org/show_bug.cgi?id=64535
     59
     60        Reviewed by Simon Fraser.
     61
     62        No new tests. This patch doesn't change behavior; current tests are sufficient.
     63
     64        * platform/graphics/GraphicsContext.cpp:
     65        (WebCore::GraphicsContext::drawImage): Moved the main method version next to wrapper versions.
     66
     67        * platform/graphics/ImageBuffer.h:
     68        1) Added BackingStoreCopy enum for choosing to copy backing store or not in copyImage().
     69        2) Added copyNativeImage() behind USE(CG) - same as copyImage() but gives NativeImagePtr.
     70        * platform/graphics/cg/ImageBufferCG.cpp: Added new methods described above.
     71
     72        * platform/graphics/GraphicsContext.h: Adding drawNativeImage() for fast draw path.
     73        * platform/graphics/cg/GraphicsContextCG.cpp:
     74        (WebCore::GraphicsContext::drawNativeImage): Added. Draws a nativeImagePtr into context.
     75
     76        * platform/graphics/Image.h: Added imageWithColorSpace behind CG platform ifdef
     77        * platform/graphics/cg/ImageCG.cpp:
     78        (WebCore::BitmapImage::draw): Refactored out actual image drawing code into GraphicsContext,
     79        so that it can be used by more than just BitmapImage without having to copy code.
     80        (WebCore::Image::imageWithColorSpace): Made into an Image class function.
     81
     82        Updated copyImage() to for BackingStoreCopy:
     83        * platform/graphics/qt/ImageBufferQt.cpp
     84        * platform/graphics/filters/FETile.cpp
     85        * platform/graphics/cairo/ImageBufferCairo.cpp
     86        * platform/graphics/skia/ImageBufferSkia.cpp
     87        * platform/graphics/wx/ImageBufferWx.cpp
     88        * platform/graphics/wince/ImageBufferWinCE.cpp
     89        * svg/SVGFEImageElement.cpp
     90        * svg/graphics/SVGImage.cpp
     91        * html/HTMLCanvasElement.cpp
     92        * html/canvas/WebGLRenderingContext.cpp
     93        * rendering/svg/RenderSVGResourcePattern.cpp
     94
     952011-07-19  Leo Yang  <leoyang.webkit@gmail.com>
     96
     97        SVG: Missing implementation of <altGlyphDef>, <altGlyphItem> and <glyphRef>
     98        https://bugs.webkit.org/show_bug.cgi?id=60850
     99
     100        Reviewed by Nikolas Zimmermann.
     101
     102        SVG spec: http://www.w3.org/TR/SVG/text.html#AlternateGlyphDefinitions.
     103        This patch is to implement SVG <altGlyphDef>, <altGlyphItem> and <glyphRef>
     104        elements for alternative glyph features.
     105
     106        NOTE: x, y, dx, dy, format and glyphRef attributes on <glyphRef> are not
     107        honored yet, so neither are the reaction of dynamic change of them. They
     108        will be honored in separated patches.
     109
     110        Test: svg/W3C-SVG-1.1/text-altglyph-01-b.svg
     111        With this patch this test works as expected.
     112
     113        * CMakeLists.txt:
     114        * CodeGenerators.pri:
     115        * DerivedSources.cpp:
     116        * DerivedSources.make:
     117        * GNUmakefile.list.am:
     118        * WebCore.exp.in:
     119        * WebCore.gypi:
     120        * WebCore.pro:
     121        * WebCore.vcproj/WebCore.vcproj:
     122        * WebCore.xcodeproj/project.pbxproj:
     123        * bindings/objc/DOM.mm:
     124        (WebCore::createElementClassMap):
     125        * bindings/objc/DOMSVG.h:
     126        * page/DOMWindow.idl:
     127        * svg/SVGAllInOne.cpp:
     128        * svg/SVGAltGlyphDefElement.cpp: Added.
     129        (WebCore::SVGAltGlyphDefElement::SVGAltGlyphDefElement):
     130        (WebCore::SVGAltGlyphDefElement::create):
     131        (WebCore::SVGAltGlyphDefElement::hasValidGlyphElements):
     132        * svg/SVGAltGlyphDefElement.h: Added.
     133        * svg/SVGAltGlyphDefElement.idl: Added.
     134        * svg/SVGAltGlyphElement.cpp:
     135        (WebCore::SVGAltGlyphElement::hasValidGlyphElements):
     136        * svg/SVGAltGlyphElement.h:
     137        * svg/SVGAltGlyphItemElement.cpp: Added.
     138        (WebCore::SVGAltGlyphItemElement::SVGAltGlyphItemElement):
     139        (WebCore::SVGAltGlyphItemElement::create):
     140        (WebCore::SVGAltGlyphItemElement::hasValidGlyphElements):
     141        * svg/SVGAltGlyphItemElement.h: Added.
     142        * svg/SVGAltGlyphItemElement.idl: Added.
     143        * svg/SVGFontData.cpp:
     144        (WebCore::SVGFontData::applySVGGlyphSelection):
     145        * svg/SVGGlyphRefElement.cpp: Added.
     146        (WebCore::SVGGlyphRefElement::SVGGlyphRefElement):
     147        (WebCore::SVGGlyphRefElement::create):
     148        (WebCore::SVGGlyphRefElement::hasValidGlyphElement):
     149        (WebCore::SVGGlyphRefElement::parseMappedAttribute):
     150        (WebCore::SVGGlyphRefElement::glyphRef):
     151        (WebCore::SVGGlyphRefElement::setGlyphRef):
     152        (WebCore::SVGGlyphRefElement::setX):
     153        (WebCore::SVGGlyphRefElement::setY):
     154        (WebCore::SVGGlyphRefElement::setDx):
     155        (WebCore::SVGGlyphRefElement::setDy):
     156        * svg/SVGGlyphRefElement.h: Added.
     157        * svg/SVGGlyphRefElement.idl: Added.
     158        * svg/svgtags.in:
     159
     1602011-07-19  Adam Roben  <aroben@apple.com>
     161
     162        Remove some unused code in FormDataStreamCFNet
     163
     164        Rubber-stamped by Steve Falkenburg.
     165
     166        * platform/network/cf/FormDataStreamCFNet.cpp:
     167
     1682011-07-19  Simon Fraser  <simon.fraser@apple.com>
     169
     170        REGRESSION (r91136-r91146): 40 tests failing on Windows 7 Release (Tests)
     171        https://bugs.webkit.org/show_bug.cgi?id=64808
     172
     173        Reviewed by Adam Roben.
     174
     175        Initializing m_uncommittedChanges to a non-zero value
     176        caused the first call to noteLayerPropertyChanged() to
     177        not call m_client->notifySyncRequired(). This resulted in
     178        animations never getting committed on Windows, which broke
     179        a lot of tests.
     180
     181        * platform/graphics/ca/GraphicsLayerCA.cpp:
     182        (WebCore::GraphicsLayerCA::GraphicsLayerCA):
     183
     1842011-07-19  James Robinson  <jamesr@chromium.org>
     185
     186        [chromium] LayerRendererChromium shouldn't be a friend of RenderSurfaceChromium
     187        https://bugs.webkit.org/show_bug.cgi?id=64834
     188
     189        Reviewed by Kenneth Russell.
     190
     191        Uses setters and getters to access RenderSurfaceChromium's private member variables instead of directly
     192        accessing them via a friend declaration. This cleans up a minor code smell and will be helpful for future
     193        refactoring.
     194
     195        Refactor only, no change in behavior.  Tested by compositing/ tests.
    5196
    6197        * platform/graphics/chromium/LayerRendererChromium.cpp:
    7         (WebCore::LayerRendererChromium::transferRootLayer):
     198        (WebCore::LayerRendererChromium::updateLayers):
     199        (WebCore::LayerRendererChromium::paintLayerContents):
     200        (WebCore::LayerRendererChromium::drawLayers):
     201        (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
     202        (WebCore::LayerRendererChromium::updateCompositorResources):
     203        (WebCore::LayerRendererChromium::getOffscreenLayerTexture):
     204        (WebCore::LayerRendererChromium::copyOffscreenTextureToDisplay):
     205        (WebCore::LayerRendererChromium::useRenderSurface):
     206        (WebCore::LayerRendererChromium::drawLayer):
     207        (WebCore::LayerRendererChromium::setScissorToRect):
     208        * platform/graphics/chromium/RenderSurfaceChromium.cpp:
     209        (WebCore::RenderSurfaceChromium::clearLayerList):
     210        * platform/graphics/chromium/RenderSurfaceChromium.h:
     211        (WebCore::RenderSurfaceChromium::layerList):
     212        (WebCore::RenderSurfaceChromium::contentRect):
     213        (WebCore::RenderSurfaceChromium::setContentRect):
     214        (WebCore::RenderSurfaceChromium::drawOpacity):
     215        (WebCore::RenderSurfaceChromium::setDrawOpacity):
     216        (WebCore::RenderSurfaceChromium::drawTransform):
     217        (WebCore::RenderSurfaceChromium::setDrawTransform):
     218        (WebCore::RenderSurfaceChromium::maskLayer):
     219        (WebCore::RenderSurfaceChromium::setMaskLayer):
     220        (WebCore::RenderSurfaceChromium::originTransform):
     221        (WebCore::RenderSurfaceChromium::setOriginTransform):
     222        (WebCore::RenderSurfaceChromium::replicaDrawTransform):
     223        (WebCore::RenderSurfaceChromium::setReplicaDrawTransform):
     224        (WebCore::RenderSurfaceChromium::scissorRect):
     225        (WebCore::RenderSurfaceChromium::setScissorRect):
     226        (WebCore::RenderSurfaceChromium::skipsDraw):
     227        (WebCore::RenderSurfaceChromium::setSkipsDraw):
     228        (WebCore::RenderSurfaceChromium::contentsTexture):
     229
     2302011-07-19  Jessie Berlin  <jberlin@apple.com>
     231
     232        GTK + QT build fix.
     233
     234        Rubber-stamped by Daniel Bates and Alexey Proskuryakov.
     235
     236        * loader/ResourceLoader.cpp:
     237        (WebCore::ResourceLoader::willSendRequest):
     238        (WebCore::ResourceLoader::didSendData):
     239        (WebCore::ResourceLoader::didReceiveResponse):
     240        (WebCore::ResourceLoader::didReceiveData):
     241        (WebCore::ResourceLoader::didFinishLoading):
     242        (WebCore::ResourceLoader::didFail):
     243        (WebCore::ResourceLoader::wasBlocked):
     244        (WebCore::ResourceLoader::cannotShowURL):
     245        (WebCore::ResourceLoader::shouldUseCredentialStorage):
     246        (WebCore::ResourceLoader::willCacheResponse):
     247
     2482011-07-19  Chris Rogers  <crogers@google.com>
     249
     250        Fix web audio compile on mac port
     251        https://bugs.webkit.org/show_bug.cgi?id=64836
     252
     253        Unreviewed build fix.
     254
     255        * bindings/js/JSAudioContextCustom.cpp:
     256        (WebCore::JSAudioContextConstructor::constructJSAudioContext):
     257        (WebCore::JSAudioContext::createBuffer):
     258
     2592011-07-19  Jessie Berlin  <jberlin@apple.com>
     260
     261        Work towards determining the cause of frequent crashes due to null frame below
     262        ApplicationCacheHost::scheduleLoadFallbackResourceFromApplicationCache.
     263        https://bugs.webkit.org/show_bug.cgi?id=62764
     264
     265        Reviewed by Alexey Proskuryakov.
     266
     267        Make these unexpected cases crash in the WebKit nightlies so we can gather more
     268        information and potentially find a repro case.
     269
     270        * loader/ResourceLoader.cpp:
     271        (WebCore::ResourceLoader::willSendRequest):
     272        (WebCore::ResourceLoader::didSendData):
     273        (WebCore::ResourceLoader::didReceiveResponse):
     274        (WebCore::ResourceLoader::didReceiveData):
     275        (WebCore::ResourceLoader::didFinishLoading):
     276        (WebCore::ResourceLoader::didFail):
     277        (WebCore::ResourceLoader::wasBlocked):
     278        (WebCore::ResourceLoader::cannotShowURL):
     279        (WebCore::ResourceLoader::shouldUseCredentialStorage):
     280        (WebCore::ResourceLoader::willCacheResponse):
     281
     2822011-07-19  Dan Bernstein  <mitz@apple.com>
     283
     284        Nothing printed when specifying a very large maximum layout width
     285        https://bugs.webkit.org/show_bug.cgi?id=64831
     286
     287        Reviewed by Beth Dakin.
     288
     289        I am not adding a test because the DumpRenderTree printing test machinery is based on PrintContext,
     290        which does not exercise the code path on which this bug lies.
     291
     292        * page/FrameView.cpp:
     293        (WebCore::FrameView::forceLayoutForPagination): Fixed an integer overflow.
     294
     2952011-07-19  Nate Chapin  <japhet@chromium.org>
     296
     297        [V8] Wait until no v8 context is on the stack before
     298        cancelling pending indexed db transactions.
     299        https://bugs.webkit.org/show_bug.cgi?id=64552
     300
     301        Reviewed by Adam Barth.
     302
     303        Test: storage/indexeddb/transaction-abort-with-js-recursion.html
     304
     305        * bindings/v8/V8Proxy.cpp:
     306        (WebCore::V8Proxy::didLeaveScriptContext):
     307
     3082011-07-19  MORITA Hajime  <morrita@google.com>
     309
     310        Crash in CompositeEditCommand::replaceTextInNodePreservingMarkers.
     311        https://bugs.webkit.org/show_bug.cgi?id=64738
     312
     313        Reviewed by Ryosuke Niwa.
     314
     315        Test: editing/undo/replace-text-in-node-preserving-markers-crash.html
     316
     317        * editing/CompositeEditCommand.cpp:
     318        (WebCore::copyMarkers):
     319        (WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):
     320
     3212011-07-19  Mike West  <mkwst@chromium.org>
     322
     323        Sending a `Ping-From` header for cross-origin pings from non-HTTPS documents.
     324        https://bugs.webkit.org/show_bug.cgi?id=64789
     325
     326        Also a drive-by cleanup of whitespace.
     327
     328        Reviewed by Nate Chapin.
     329
     330        * loader/PingLoader.cpp:
     331        (WebCore::PingLoader::loadImage):
     332        (WebCore::PingLoader::sendPing):
     333
     3342011-07-15  Luke Zarko  <lukezarko@gmail.com>
     335
     336       Bring V8's SerializedScriptValue implementation up to date.
     337
     338        https://bugs.webkit.org/show_bug.cgi?id=63481
     339
     340        Reviewed by David Levin.
     341       
     342        The HTML5 Structured Clone algorithm (http://www.whatwg.org/specs/web-apps/current-work/multipage/urls.html#safe-passing-of-structured-data) has been updated since the V8 version of SerializedScriptValue was first implemented. This patch aims to bring this implementation up to date. It:
     343       
     344        - Introduces the new HTML5 DOM error codes for TIMEOUT_ERR, INVALID_NODE_TYPE_ERR, DATA_CLONE_ERR
     345        - Handles cyclic structures and equality of reference preservation for cloned values
     346        - Allows DataViews to be constructed on the native side using the existing wrapper techniques
     347        - Amends tests and introduces new ones to check for correctness (the bulk of the patch)
     348        - Tolerates the old version of the serialized object format
     349       
     350        The patch permits the cloning of JavaScript typed arrays. This functionality is in active use already and was supported (somewhat inefficiently) by the existing code through an artifact of implementation.
     351
     352        Tests: fast/dom/Window/window-postmessage-clone-deep-array.html
     353               fast/dom/Window/window-postmessage-clone-really-deep-array.html
     354               fast/dom/Window/window-postmessage-clone.html
     355               fast/canvas/webgl/array-message-passing.html
     356
     357        * bindings/v8/SerializedScriptValue.cpp:
     358        (WebCore::V8ObjectMap::Writer::writeVersion):
     359        (WebCore::V8ObjectMap::Writer::writeArrayBuffer):
     360        (WebCore::V8ObjectMap::Writer::writeArrayBufferView):
     361        (WebCore::V8ObjectMap::Writer::writeObjectReference):
     362        (WebCore::V8ObjectMap::Writer::writeReferenceCount):
     363        (WebCore::V8ObjectMap::Writer::writeGenerateFreshObject):
     364        (WebCore::V8ObjectMap::Writer::writeGenerateFreshArray):
     365        (WebCore::V8ObjectMap::Writer::doWriteArrayBuffer):
     366        (WebCore::V8ObjectMap::Serializer::Serializer):
     367        (WebCore::V8ObjectMap::Serializer::serialize):
     368        (WebCore::V8ObjectMap::Serializer::StateBase::execDepth):
     369        (WebCore::V8ObjectMap::Serializer::AbstractObjectState::AbstractObjectState):
     370        (WebCore::V8ObjectMap::Serializer::AbstractObjectState::advance):
     371        (WebCore::V8ObjectMap::Serializer::AbstractObjectState::execDepth):
     372        (WebCore::V8ObjectMap::Serializer::execDepth):
     373        (WebCore::V8ObjectMap::Serializer::push):
     374        (WebCore::V8ObjectMap::Serializer::pop):
     375        (WebCore::V8ObjectMap::Serializer::handleError):
     376        (WebCore::V8ObjectMap::Serializer::writeAndGreyArrayBufferView):
     377        (WebCore::V8ObjectMap::Serializer::writeArrayBuffer):
     378        (WebCore::V8ObjectMap::Serializer::greyObject):
     379        (WebCore::V8ObjectMap::Serializer::doSerialize):
     380        (WebCore::V8ObjectMap::Reader::Reader):
     381        (WebCore::V8ObjectMap::Reader::read):
     382        (WebCore::V8ObjectMap::Reader::readVersion):
     383        (WebCore::V8ObjectMap::Reader::setVersion):
     384        (WebCore::V8ObjectMap::Reader::undoReadTag):
     385        (WebCore::V8ObjectMap::Reader::readArrayBufferViewSubTag):
     386        (WebCore::V8ObjectMap::Reader::doReadArrayBuffer):
     387        (WebCore::V8ObjectMap::Reader::readArrayBuffer):
     388        (WebCore::V8ObjectMap::Reader::readArrayBufferView):
     389        (WebCore::V8ObjectMap::Deserializer::Deserializer):
     390        (WebCore::V8ObjectMap::Deserializer::deserialize):
     391        (WebCore::V8ObjectMap::Deserializer::newArray):
     392        (WebCore::V8ObjectMap::Deserializer::consumeTopOfStack):
     393        (WebCore::V8ObjectMap::Deserializer::completeArray):
     394        (WebCore::V8ObjectMap::Deserializer::newObject):
     395        (WebCore::V8ObjectMap::Deserializer::completeObject):
     396        (WebCore::V8ObjectMap::Deserializer::completeSparseArray):
     397        (WebCore::V8ObjectMap::Deserializer::pushObjectReference):
     398        (WebCore::V8ObjectMap::Deserializer::tryGetObjectFromObjectReference):
     399        (WebCore::V8ObjectMap::Deserializer::objectReferenceCount):
     400        (WebCore::V8ObjectMap::Deserializer::openComposite):
     401        (WebCore::V8ObjectMap::Deserializer::closeComposite):
     402        (WebCore::SerializedScriptValue::SerializedScriptValue):
     403        * bindings/v8/V8Binding.cpp:
     404        (WebCore::isHostObject):
     405        * bindings/v8/V8Binding.h:
     406        * bindings/v8/custom/V8DataViewCustom.cpp:
     407        (WebCore::V8DataView::constructorCallback):
     408        * dom/DOMCoreException.idl:
     409        * dom/ExceptionCode.cpp:
     410        * dom/ExceptionCode.h:
     411        * html/canvas/ArrayBuffer.cpp:
     412        (WebCore::ArrayBuffer::create):
     413        * html/canvas/ArrayBuffer.h:
     414        * html/canvas/DataView.cpp:
     415        (WebCore::DataView::create):
     416        * html/canvas/DataView.h:
     417
     4182011-07-19  Simon Fraser  <simon.fraser@apple.com>
     419
     420        Possible recursion in GraphicsLayerCA::updateGeometry()
     421        https://bugs.webkit.org/show_bug.cgi?id=64815
     422
     423        Reviewed by Sam Weinig.
     424       
     425        It was possible to recurse via updateGeometry/swapFromOrToTiledLayer/
     426        updateContentsScale because updateGeometry() and updateContentsScale()
     427        used different sizes; updateGeometry() used the scaled size, while
     428        updateContentsScale() used the unscaled size.
     429       
     430        Always use the unscaled size; the scaled size will be at most a couple
     431        of pixels bigger, and our threshold is not close to the max texture
     432        size limit, so using the slightly smaller size is OK.
     433
     434        Test: compositing/scaling/tiled-layer-recursion.html
     435
     436        * platform/graphics/ca/GraphicsLayerCA.cpp:
     437        (WebCore::GraphicsLayerCA::updateGeometry):
     438        (WebCore::GraphicsLayerCA::updateLayerDrawsContent):
     439        (WebCore::GraphicsLayerCA::updateContentsScale):
     440        (WebCore::GraphicsLayerCA::requiresTiledLayer):
     441        * platform/graphics/ca/GraphicsLayerCA.h:
     442
     4432011-07-19  Mihnea Ovidenie  <mihnea@adobe.com>
     444
     445        [CSSRegions]Parse -webkit-region-overflow property
     446        https://bugs.webkit.org/show_bug.cgi?id=64444
     447
     448        Reviewed by David Hyatt.
     449
     450        Test: fast/regions/webkit-region-overflow-parsing.html
     451
     452        * css/CSSComputedStyleDeclaration.cpp:
     453        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
     454        * css/CSSParser.cpp:
     455        (WebCore::CSSParser::parseValue):
     456        * css/CSSPrimitiveValueMappings.h:
     457        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
     458        (WebCore::CSSPrimitiveValue::operator RegionOverflow):
     459        * css/CSSPropertyNames.in:
     460        * css/CSSStyleSelector.cpp:
     461        (WebCore::CSSStyleSelector::applyProperty):
     462        * css/CSSValueKeywords.in:
     463        * rendering/style/RenderStyle.cpp:
     464        (WebCore::RenderStyle::diff):
     465        * rendering/style/RenderStyle.h:
     466        (WebCore::InheritedFlags::regionOverflow):
     467        (WebCore::InheritedFlags::setRegionOverflow):
     468        (WebCore::InheritedFlags::initialRegionOverflow):
     469        * rendering/style/RenderStyleConstants.h:
     470        * rendering/style/StyleRareNonInheritedData.cpp:
     471        (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
     472        (WebCore::StyleRareNonInheritedData::operator==):
     473        * rendering/style/StyleRareNonInheritedData.h:
     474
     4752011-07-19  Mihnea Ovidenie  <mihnea@adobe.com>
     476
     477        hover then un-hover makes state change
     478        https://bugs.webkit.org/show_bug.cgi?id=56401
     479
     480        When a 'before' pseudo-element is re-added, we should check whether the insertion point is an anonymous
     481        block with inline children. If it is, then we should change the insertion point to the first child of the
     482        anonymous block, otherwise the 'before' pseudo-element ends up in a different block.
     483
     484        Reviewed by David Hyatt.
     485
     486        Test: fast/dynamic/hover-before-position-after-style-change.html
     487
     488        * rendering/RenderObjectChildList.cpp:
     489        (WebCore::RenderObjectChildList::updateBeforeAfterContent):
     490
     4912011-07-19  Luke Macpherson   <macpherson@chromium.org>
     492
     493        Implement CSSPropertyWebkitPerspectiveOrigin in CSSStyleApplyProperty.
     494        https://bugs.webkit.org/show_bug.cgi?id=64784
     495
     496        Reviewed by Simon Fraser.
     497
     498        No new tests / refactoring.
     499
     500        * css/CSSStyleApplyProperty.cpp:
     501        (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
     502        * css/CSSStyleSelector.cpp:
     503        (WebCore::CSSStyleSelector::applyProperty):
     504
     5052011-07-19  Chris Rogers  <crogers@google.com>
     506
     507        Implement WaveShaperNode for Web Audio API
     508        https://bugs.webkit.org/show_bug.cgi?id=64644
     509
     510        Reviewed by Kenneth Russell.
     511       
     512        No new tests since audio API is not yet implemented.
     513
     514        * DerivedSources.make:
     515        * WebCore.gypi:
     516        * WebCore.xcodeproj/project.pbxproj:
     517        * bindings/js/JSWaveShaperNodeCustom.cpp: Added.
     518        (WebCore::JSWaveShaperNode::setCurve):
     519        * webaudio/AudioContext.cpp:
     520        (WebCore::AudioContext::createWaveShaper):
     521        * webaudio/AudioContext.h:
     522        * webaudio/AudioContext.idl:
     523        * webaudio/AudioNode.h:
     524        * webaudio/WaveShaperDSPKernel.cpp: Added.
     525        (WebCore::WaveShaperDSPKernel::process):
     526        * webaudio/WaveShaperDSPKernel.h: Added.
     527        (WebCore::WaveShaperDSPKernel::WaveShaperDSPKernel):
     528        (WebCore::WaveShaperDSPKernel::reset):
     529        (WebCore::WaveShaperDSPKernel::waveShaperProcessor):
     530        * webaudio/WaveShaperNode.cpp: Added.
     531        (WebCore::WaveShaperNode::WaveShaperNode):
     532        (WebCore::WaveShaperNode::setCurve):
     533        (WebCore::WaveShaperNode::curve):
     534        * webaudio/WaveShaperNode.h: Added.
     535        (WebCore::WaveShaperNode::create):
     536        (WebCore::WaveShaperNode::waveShaperProcessor):
     537        * webaudio/WaveShaperNode.idl: Added.
     538        * webaudio/WaveShaperProcessor.cpp: Added.
     539        (WebCore::WaveShaperProcessor::WaveShaperProcessor):
     540        (WebCore::WaveShaperProcessor::~WaveShaperProcessor):
     541        (WebCore::WaveShaperProcessor::createKernel):
     542        (WebCore::WaveShaperProcessor::setCurve):
     543        (WebCore::WaveShaperProcessor::process):
     544        * webaudio/WaveShaperProcessor.h: Added.
     545        (WebCore::WaveShaperProcessor::curve):
     546
     5472011-07-19  Robert Hogan  <robert@webkit.org>
     548
     549        REGRESSION: Incorrect layout at recline-online.com
     550        https://bugs.webkit.org/show_bug.cgi?id=64030
     551
     552        Reviewed by David Hyatt.
     553
     554        http://trac.webkit.org/changeset/68362 dropped the check for cases
     555        where the render box is floating or inline. When the box is left or right
     556        aligned it is considered to be floating and needs to its margins set appropriately.
     557
     558        Test: fast/table/align-right-within-left-aligned-div.html
     559              created by Dominic Cooney <dominicc@chromium.org>
     560
     561        * rendering/RenderBox.cpp:
     562        (WebCore::RenderBox::computeInlineDirectionMargins):
     563
     5642011-07-19  Abhishek Arya  <inferno@chromium.org>
     565
     566        Crash when removing unrenderered nodes in replacement fragment.
     567        https://bugs.webkit.org/show_bug.cgi?id=64801
     568
     569        Reviewed by Ryosuke Niwa.
     570
     571        Test: editing/pasteboard/replacement-fragment-remove-unrendered-node-crash.html
     572
     573        * editing/ReplaceSelectionCommand.cpp:
     574        (WebCore::ReplacementFragment::removeUnrenderedNodes):
     575
     5762011-07-19  Rob Buis  <rbuis@rim.com>
     577
     578        https://bugs.webkit.org/show_bug.cgi?id=64673
     579        REGRESSION (Safari 5.0.5 - ToT): crash in SVG test http://dev.w3.org/SVG/profiles/1.1F2/test/harness/htmlObjectApproved/styling-pres-02-f.html
     580
     581        Reviewed by Nikolas Zimmermann.
     582
     583        Prevent calling back to the owning SVGTRefElement upon handling DOMSubtreeModified events.
     584
     585        Test: svg/W3C-SVG-1.1-SE/styling-pres-02-f.svg
     586
     587        * svg/SVGTRefElement.cpp:
     588        (WebCore::SubtreeModificationEventListener::handleEvent):
     589
     5902011-07-19  Tony Chang  <tony@chromium.org>
     591
     592        use more specific types in CSSFlexValue
     593        https://bugs.webkit.org/show_bug.cgi?id=64763
     594
     595        Reviewed by Ojan Vafai.
     596
     597        No new tests because no change in functionality.
     598
     599        * css/CSSFlexValue.h:
     600        (WebCore::CSSFlexValue::create):
     601        (WebCore::CSSFlexValue::isFlexValue): Make it possible to tell if
     602            we're a flex value or not.  Will be needed when we're copying
     603            values to RenderStyle.
     604        (WebCore::CSSFlexValue::positiveFlex): Use floats for positive and
     605            negative flex because in the render code, we use floats.
     606        (WebCore::CSSFlexValue::negativeFlex): Add accessors for these since
     607            we'll need it when reading the flex values.
     608        (WebCore::CSSFlexValue::preferredSize):
     609        (WebCore::CSSFlexValue::CSSFlexValue):
     610        * css/CSSParser.cpp:
     611        (WebCore::CSSParser::parseValidPrimitive): Make the type more
     612            specific.
     613        (WebCore::CSSParser::parseFlex):
     614        * css/CSSParser.h:
     615        * css/CSSValue.h:
     616        (WebCore::CSSValue::isFlexValue):
     617
     6182011-07-19  Chris Fleizach  <cfleizach@apple.com>
     619
     620        If the control associated with a <label> is hidden, the label is also hidden (incorrectly)
     621        https://bugs.webkit.org/show_bug.cgi?id=64752
     622
     623        Reviewed by Darin Adler.
     624
     625        Test: platform/mac/accessibility/label-element-with-hidden-control.html
     626
     627        * accessibility/AccessibilityRenderObject.cpp:
     628        (WebCore::AccessibilityRenderObject::exposesTitleUIElement):
     629
     6302011-07-19  Vsevolod Vlasov  <vsevik@chromium.org>
     631
     632        Web Inspector: Backend should provide network resource identifiers that are unique across navigation.
     633        https://bugs.webkit.org/show_bug.cgi?id=64746
     634
     635        Reviewed by Pavel Feldman.
     636
     637        * inspector/ConsoleMessage.cpp:
     638        (WebCore::ConsoleMessage::ConsoleMessage):
     639        (WebCore::ConsoleMessage::addToFrontend):
     640        * inspector/ConsoleMessage.h:
     641        * inspector/IdentifiersFactory.cpp:
     642        (WebCore::IdentifiersFactory::createIdentifier):
     643        (WebCore::IdentifiersFactory::resourceId):
     644        (WebCore::IdentifiersFactory::addProcessIdPrefixTo):
     645        * inspector/IdentifiersFactory.h:
     646        * inspector/Inspector.json:
     647        * inspector/InspectorConsoleAgent.cpp:
     648        (WebCore::InspectorConsoleAgent::didReceiveResponse):
     649        (WebCore::InspectorConsoleAgent::didFailLoading):
     650        * inspector/InspectorPageAgent.h:
     651        * inspector/InspectorResourceAgent.cpp:
     652        (WebCore::InspectorResourceAgent::willSendRequest):
     653        (WebCore::InspectorResourceAgent::markResourceAsCached):
     654        (WebCore::InspectorResourceAgent::didReceiveResponse):
     655        (WebCore::InspectorResourceAgent::didReceiveData):
     656        (WebCore::InspectorResourceAgent::didFinishLoading):
     657        (WebCore::InspectorResourceAgent::didFailLoading):
     658        (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
     659        (WebCore::InspectorResourceAgent::setInitialScriptContent):
     660        (WebCore::InspectorResourceAgent::setInitialXHRContent):
     661        (WebCore::InspectorResourceAgent::didReceiveXHRResponse):
     662        (WebCore::InspectorResourceAgent::didCreateWebSocket):
     663        (WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
     664        (WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
     665        (WebCore::InspectorResourceAgent::didCloseWebSocket):
     666        (WebCore::InspectorResourceAgent::getResourceContent):
     667        * inspector/InspectorResourceAgent.h:
     668        * inspector/InspectorTimelineAgent.cpp:
     669        (WebCore::InspectorTimelineAgent::willSendResourceRequest):
     670        (WebCore::InspectorTimelineAgent::willReceiveResourceData):
     671        (WebCore::InspectorTimelineAgent::willReceiveResourceResponse):
     672        (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
     673        * inspector/NetworkResourcesData.cpp:
     674        (WebCore::NetworkResourcesData::ResourceData::ResourceData):
     675        (WebCore::NetworkResourcesData::resourceCreated):
     676        (WebCore::NetworkResourcesData::responseReceived):
     677        (WebCore::NetworkResourcesData::setResourceType):
     678        (WebCore::NetworkResourcesData::resourceType):
     679        (WebCore::NetworkResourcesData::setResourceContent):
     680        (WebCore::NetworkResourcesData::maybeAddResourceData):
     681        (WebCore::NetworkResourcesData::maybeDecodeDataToContent):
     682        (WebCore::NetworkResourcesData::addCachedResource):
     683        (WebCore::NetworkResourcesData::addResourceSharedBuffer):
     684        (WebCore::NetworkResourcesData::data):
     685        (WebCore::NetworkResourcesData::clear):
     686        (WebCore::NetworkResourcesData::ensureNoDataForResourceId):
     687        (WebCore::NetworkResourcesData::ensureFreeSpace):
     688        * inspector/NetworkResourcesData.h:
     689        (WebCore::NetworkResourcesData::ResourceData::resourceId):
     690        * inspector/TimelineRecordFactory.cpp:
     691        (WebCore::TimelineRecordFactory::createResourceSendRequestData):
     692        (WebCore::TimelineRecordFactory::createResourceReceiveResponseData):
     693        (WebCore::TimelineRecordFactory::createResourceFinishData):
     694        (WebCore::TimelineRecordFactory::createReceiveResourceData):
     695        * inspector/TimelineRecordFactory.h:
     696
     6972011-07-19  Jessie Berlin  <jberlin@apple.com>
     698
     699        Fix assertion failure seen in plugins/return-npobject.html on Windows XP Debug bots.
     700
     701        Rubber-stamped by Adam Roben.
     702
     703        * loader/ResourceLoader.cpp:
     704        (WebCore::ResourceLoader::didReceiveData):
     705        It is possible for a subclass to cancel the load from within didReceiveData, which would
     706        set m_documentLoader to 0.
     707        Remove the assertion I added that the DocumentLoader's frame is non-null.
     708
     7092011-07-19  Steve Block  <steveblock@google.com>
     710
     711        REGRESSION (r82194): jvalueToJavaValue() does not correctly set length of String property
     712        https://bugs.webkit.org/show_bug.cgi?id=64730
     713
     714        Reviewed by Alexey Proskuryakov.
     715
     716        Covered by existing tests.
     717
     718        * bridge/jni/v8/JNIUtilityPrivate.cpp:
     719        (JSC::Bindings::jvalueToJavaValue):
     720
     7212011-07-19  Vitaly Repeshko  <vitalyr@chromium.org>
     722
     723        [V8] Don't put CSSRuleLists in object groups.
     724        https://bugs.webkit.org/show_bug.cgi?id=64798
     725
     726        Reviewed by Pavel Feldman.
     727
     728        Retention of CSSRuleLists should be implemented using hidden
     729        references from holder objects. By putting lists in groups we
     730        artificially extend their lifetimes much more than necessary.
     731
     732        * bindings/v8/V8GCController.cpp:
     733        (WebCore::GrouperVisitor::visitDOMWrapper):
     734
     7352011-07-19  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
     736
     737        [EFL] Add ewk_network.cpp|h files.
     738        https://bugs.webkit.org/show_bug.cgi?id=63315
     739
     740        Enable setOnLine(bool) on EFL port as well as Android and Chromium.
     741
     742        Reviewed by Antonio Gomes.
     743
     744        * platform/network/NetworkStateNotifier.cpp:
     745        * platform/network/NetworkStateNotifier.h:
     746
     7472011-07-19  Ilya Tikhonovsky  <loislo@chromium.org>
     748
     749        Web Inspector: implement import/export for timeline data.
     750        https://bugs.webkit.org/show_bug.cgi?id=64601
     751
     752        Reviewed by Yury Semikhatsky.
     753
     754        Test: inspector/timeline/timeline-load.html
     755
     756        * English.lproj/localizedStrings.js:
     757        * inspector/InspectorFrontendHost.cpp:
     758        (WebCore::FrontendMenuProvider::contextMenuItemSelected):
     759        * inspector/front-end/TimelinePanel.js:
     760        (WebInspector.TimelinePanel):
     761        (WebInspector.TimelinePanel.prototype._createFileSelector):
     762        (WebInspector.TimelinePanel.prototype._contextMenu):
     763        (WebInspector.TimelinePanel.prototype._exportToFile):
     764        (WebInspector.TimelinePanel.prototype._importFromFile):
     765        (WebInspector.TimelinePanel.prototype._addRecordToTimeline):
     766        (WebInspector.TimelinePanel.prototype._clearPanel):
     767        (WebInspector.TimelineModel):
     768        (WebInspector.TimelineModel.prototype._addRecord):
     769        (WebInspector.TimelineModel.prototype._importNextChunk):
     770        (WebInspector.TimelineModel.prototype._importFromFile):
     771        (WebInspector.TimelineModel.prototype._importFromFile.onError):
     772        (WebInspector.TimelineModel.prototype._exportToFile):
     773        (WebInspector.TimelineModel.prototype._reset):
     774        * inspector/front-end/utilities.js:
     775        ():
     776
     7772011-07-19  Vsevolod Vlasov  <vsevik@chromium.org>
     778
     779        Web Inspector: Rename agentIdentifierPrefix to processId, move out from page agent and make static.
     780        https://bugs.webkit.org/show_bug.cgi?id=64729
     781
     782        Reviewed by Pavel Feldman.
     783
     784        * CMakeLists.txt:
     785        * GNUmakefile.list.am:
     786        * WebCore.gypi:
     787        * WebCore.pro:
     788        * WebCore.vcproj/WebCore.vcproj:
     789        * WebCore.xcodeproj/project.pbxproj:
     790        * inspector/IdentifiersFactory.cpp: Added.
     791        (WebCore::IdentifiersFactory::createIdentifier):
     792        * inspector/IdentifiersFactory.h: Added.
     793        (WebCore::IdentifiersFactory::setProcessId):
     794        * inspector/InspectorController.cpp:
     795        (WebCore::InspectorController::setProcessId):
     796        * inspector/InspectorController.h:
     797        * inspector/InspectorPageAgent.cpp:
     798        (WebCore::InspectorPageAgent::frameId):
     799        (WebCore::InspectorPageAgent::loaderId):
     800        * inspector/InspectorPageAgent.h:
    8801
    98022011-07-19  Jeremy Moskovich  <jeremy@chromium.org>

  • branches/chromium/782/Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp

    r87671 r91477  
    3131
    3232#include "MediaControlElements.h"
     33#include "MouseEvent.h"
    3334#include "Page.h"
    3435#include "RenderTheme.h"
    … …  
    5051    , m_panel(0)
    5152    , m_opaque(true)
     53    , m_isMouseOverControls(false)
    5254{
    5355}
    … …  
    210212    m_timeline->setPosition(m_mediaElement->currentTime());
    211213    updateTimeDisplay();
     214
     215    if (!m_isMouseOverControls && m_mediaElement->hasVideo())
     216        makeTransparent();
    212217}
    213218
    … …  
    260265}
    261266
     267bool MediaControlRootElementChromium::containsRelatedTarget(Event* event)
     268{
     269    if (!event->isMouseEvent())
     270        return false;
     271    EventTarget* relatedTarget = static_cast<MouseEvent*>(event)->relatedTarget();
     272    if (!relatedTarget)
     273        return false;
     274    return contains(relatedTarget->toNode());
     275}
     276
     277void MediaControlRootElementChromium::defaultEventHandler(Event* event)
     278{
     279    MediaControls::defaultEventHandler(event);
     280
     281    if (event->type() == eventNames().mouseoverEvent) {
     282        if (!containsRelatedTarget(event)) {
     283            m_isMouseOverControls = true;
     284            if (!m_mediaElement->canPlay())
     285                makeOpaque();
     286        }
     287    } else if (event->type() == eventNames().mouseoutEvent) {
     288        if (!containsRelatedTarget(event))
     289            m_isMouseOverControls = false;
     290    }
     291}
     292
    262293void MediaControlRootElementChromium::changedClosedCaptionsVisibility()
    263294{

  • branches/chromium/782/Source/WebCore/html/shadow/MediaControlRootElementChromium.h

    r87671 r91477  
    9090    MediaControlRootElementChromium(HTMLMediaElement*);
    9191
     92    virtual void defaultEventHandler(Event*);
     93
    9294    virtual const AtomicString& shadowPseudoId() const;
     95
     96    bool containsRelatedTarget(Event*);
    9397
    9498    HTMLMediaElement* m_mediaElement;
    … …  
    104108
    105109    bool m_opaque;
     110    bool m_isMouseOverControls;
    106111};
    107112
Note: See TracChangeset for help on using the changeset viewer.