Changeset 91494 in webkit

Timestamp:

Jul 21, 2011, 1:23:41 PM (14 years ago)

Author:

ddkilzer@apple.com

Message:

<​http://webkit.org/b/64972> Clean up generated HTMLEntityTable.cpp output

Reviewed by Eric Seidel.

• html/parser/create-html-entity-table:
• Fix duplicate "EntityName" suffix on local variables (changes fooSemicolonEntityNameEntityName to fooSemicolonEntityName) for all 2138 symbols.
• Add newlines to make source file human-readable (as originally intended).
• Add static (const) keywords to local variables that are never referenced externally.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/parser/create-html-entity-table (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-07-21  David Kilzer  <ddkilzer@apple.com>
+
+        <http://webkit.org/b/64972> Clean up generated HTMLEntityTable.cpp output
+
+        Reviewed by Eric Seidel.
+
+        * html/parser/create-html-entity-table:
+        - Fix duplicate "EntityName" suffix on local variables (changes
+          fooSemicolonEntityNameEntityName to fooSemicolonEntityName)
+          for all 2138 symbols.
+        - Add newlines to make source file human-readable (as originally
+          intended).
+        - Add static (const) keywords to local variables that are never
+          referenced externally.
+
 2011-07-21  Mark Pilgrim  <pilgrim@chromium.org>
 

trunk/Source/WebCore/html/parser/create-html-entity-table

@@ -112 +112 @@
 
 for entry in entries:
-    output_file.write("const UChar %sEntityName[] = %s;" % (
+    output_file.write("static const UChar %s[] = %s;\n" % (
         convert_entity_to_cpp_name(entry[ENTITY]),
         convert_entity_to_uchar_array(entry[ENTITY])))
 
 output_file.write("""
-HTMLEntityTableEntry staticEntityTable[%s] = {""" % entity_count)
+static const HTMLEntityTableEntry staticEntityTable[%s] = {\n""" % entity_count)
 
 index = {}
@@ -125 +125 @@
     if not index.get(letter):
         index[letter] = offset
-    output_file.write('    { %sEntityName, %s, %s },' % (
+    output_file.write('    { %s, %s, %s },\n' % (
         convert_entity_to_cpp_name(entry[ENTITY]),
         len(entry[ENTITY]),
@@ -132 +132 @@
 
 output_file.write("""};
+
 """)
 
-output_file.write("const HTMLEntityTableEntry* uppercaseOffset[] = {")
+output_file.write("static const HTMLEntityTableEntry* uppercaseOffset[] = {\n")
 for letter in string.ascii_uppercase:
-    output_file.write(offset_table_entry(index[letter]))
-output_file.write(offset_table_entry(index['a']))
+    output_file.write("%s\n" % offset_table_entry(index[letter]))
+output_file.write("%s\n" % offset_table_entry(index['a']))
 output_file.write("""};
 
-const HTMLEntityTableEntry* lowercaseOffset[] = {""")
+static const HTMLEntityTableEntry* lowercaseOffset[] = {\n""")
 for letter in string.ascii_lowercase:
-    output_file.write(offset_table_entry(index[letter]))
-output_file.write(offset_table_entry(entity_count))
+    output_file.write("%s\n" % offset_table_entry(index[letter]))
+output_file.write("%s\n" % offset_table_entry(entity_count))
 output_file.write("""};