Changeset 91600 in webkit

Timestamp:

Jul 22, 2011, 1:17:44 PM (14 years ago)

Author:

commit-queue@webkit.org

Message:

DocumentLoader keeps a reference to all URL strings ever loaded in m_resourcesClientKnowsAbout leading to lots of memory waste
​https://bugs.webkit.org/show_bug.cgi?id=61894

Patch by Scott Graham <​scottmg@chromium.org> on 2011-07-22
Reviewed by James Robinson.

DocumentLoader::m_resourcesClientKnowsAbout is a set of all the URLs
that have passed through FrameLoader::dispatchWillSendRequest() and is
used by FrameLoader::loadedResourceFromMemoryCached to decide whether
to inform the FrameLoader's m_client about this load. Unfortunately,
this set holds a reference to the URL string for every resource
loaded, so on pages that use data URLs to "load" large amounts of data
this leaks lots of memory. The cache improves performance going through
FrameLoader::loadResourceFromMemoryCache, so rather than removing it,
simply exclude 'data:' urls from the cache to save the majority of
memory that is held for too long.

• loader/DocumentLoader.h:

(WebCore::DocumentLoader::didTellClientAboutLoad):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• loader/DocumentLoader.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-07-22  Scott Graham  <scottmg@chromium.org>
+
+        DocumentLoader keeps a reference to all URL strings ever loaded in m_resourcesClientKnowsAbout leading to lots of memory waste
+        https://bugs.webkit.org/show_bug.cgi?id=61894
+
+        Reviewed by James Robinson.
+
+        DocumentLoader::m_resourcesClientKnowsAbout is a set of all the URLs
+        that have passed through FrameLoader::dispatchWillSendRequest() and is
+        used by FrameLoader::loadedResourceFromMemoryCached to decide whether
+        to inform the FrameLoader's m_client about this load.  Unfortunately,
+        this set holds a reference to the URL string for every resource
+        loaded, so on pages that use data URLs to "load" large amounts of data
+        this leaks lots of memory. The cache improves performance going through
+        FrameLoader::loadResourceFromMemoryCache, so rather than removing it,
+        simply exclude 'data:' urls from the cache to save the majority of
+        memory that is held for too long.
+
+        * loader/DocumentLoader.h:
+        (WebCore::DocumentLoader::didTellClientAboutLoad):
+
 2011-07-22  Alok Priyadarshi  <alokp@chromium.org>
 

trunk/Source/WebCore/loader/DocumentLoader.h

@@ -231 +231 @@
         void didTellClientAboutLoad(const String& url)
         { 
+#if !PLATFORM(MAC)
+            // Don't include data urls here, as if a lot of data is loaded
+            // that way, we hold on to the (large) url string for too long.
+            if (protocolIs(url, "data"))
+                return;
+#endif
             if (!url.isEmpty())
                 m_resourcesClientKnowsAbout.add(url);