Changeset 91648 in webkit


Ignore:
Timestamp:
Jul 24, 2011, 11:48:54 AM (14 years ago)
Author:
abarth@webkit.org
Message:

Rename garden-o-matic "alert" to "infobar" and increase the width to 100%.

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
Location:
trunk/Tools
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js

    r91618 r91648  
    3737config.kFailureCountAttr = 'data-failure-count';
    3838config.kFailureTypesAttr = 'data-failure-types';
    39 config.kAlertTypeAttr = 'data-alert-type';
     39config.kInfobarTypeAttr = 'data-infobar-type';
    4040
    4141var kTenMinutesInMilliseconds = 10 * 60 * 1000;

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html

    r91619 r91648  
    1212<body>
    1313<div class="butterbar"><span class="status">Loading...</span></div>
    14 <div class="alert"><span class="status"></span></div>
     14<div class="infobar"><span class="status"></span></div>
    1515<div class="recent-history"></div>
    1616<div class="results">

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css

    r91618 r91648  
    105105}
    106106
    107 /*** alert ***/
    108 
    109 .alert {
     107/*** infobar ***/
     108
     109.infobar {
    110110    display: none;
    111111    background-color: Cornsilk;
    … …  
    114114    margin: 5px auto;
    115115    font-size: 15px;
    116     width: 75%;
     116    width: 100%;
    117117    text-align: center;
    118118}
    119119
    120 .alert .status a {
    121     font-weight: normal;
    122 }
    123 
    124 .alert .status ul {
     120.infobar .status a {
     121    font-weight: normal;
     122}
     123
     124.infobar .status ul {
    125125    margin: 0;
    126126    padding: 0;
    … …  
    130130}
    131131
    132 .alert .status li {
     132.infobar .status li {
    133133    display: inline-block;
    134134    margin: 0px 5px;

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js

    r91618 r91648  
    66var g_resultsDetailsIterator = null;
    77
    8 var kBuildFailedAlertType = 'build-failed';
     8var kBuildFailedInfobarType = 'build-failed';
    99var kCommitLogLength = 20;
    1010
    … …  
    2020}
    2121
    22 function hideAlert()
    23 {
    24     $('.alert').animate({
     22function hideInfobar()
     23{
     24    $('.infobar').animate({
    2525        opacity: 'toggle',
    2626        height: 'toggle',
    … …  
    2828}
    2929
    30 function hideAlertIfOfType(type)
    31 {
    32     if (!$('.alert .status').is(':visible'))
     30function hideInfobarIfOfType(type)
     31{
     32    if (!$('.infobar .status').is(':visible'))
    3333        return;
    34     if ($('.alert .status').attr(config.kAlertTypeAttr) != type)
     34    if ($('.infobar .status').attr(config.kInfobarTypeAttr) != type)
    3535        return;
    36     hideAlert();
    37 }
    38 
    39 function displayAlert(message, type)
    40 {
    41     $('.alert .status').empty().attr(config.kAlertTypeAttr, type).append(message);
    42     $('.alert').animate({
     36    hideInfobar();
     37}
     38
     39function displayInfobar(message, type)
     40{
     41    $('.infobar .status').empty().attr(config.kInfobarTypeAttr, type).append(message);
     42    $('.infobar').animate({
    4343        opacity: 'toggle',
    4444        height: 'toggle',
    … …  
    303303    results.fetchBuildersWithCompileErrors(function(builderNameList) {
    304304        if (!builderNameList.length) {
    305             hideAlertIfOfType(kBuildFailedAlertType);
     305            hideInfobarIfOfType(kBuildFailedInfobarType);
    306306            return;
    307307        }
    308         displayAlert(ui.alertMessageForCompileErrors(builderNameList), kBuildFailedAlertType);
     308        displayInfobar(ui.infobarMessageForCompileErrors(builderNameList), kBuildFailedInfobarType);
    309309    });
    310310}

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js

    r91618 r91648  
    8787};
    8888
    89 ui.alertMessageForCompileErrors = function(builderNameList)
     89ui.infobarMessageForCompileErrors = function(builderNameList)
    9090{
    9191    var block = $('<div class="compile-errors">Build Failed:<ul></ul></div>');

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js

    r91519 r91648  
    6464});
    6565
    66 test("alertMessageForCompileErrors", 1, function() {
    67     var message = ui.alertMessageForCompileErrors(['Mock Builder', 'Another Builder']);
     66test("infobarMessageForCompileErrors", 1, function() {
     67    var message = ui.infobarMessageForCompileErrors(['Mock Builder', 'Another Builder']);
    6868    message.wrap('<wrapper></wrapper>');
    6969    equal(message.parent().html(),

  • trunk/Tools/ChangeLog

    r91642 r91648  
     12011-07-24  Adam Barth  <abarth@webkit.org>
     2
     3        Rename garden-o-matic "alert" to "infobar" and increase the width to 100%.
     4
     5        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
     6        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
     7        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
     8        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
     9        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
     10        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
     11
    1122011-07-23  Dimitri Glazkov  <dglazkov@chromium.org>
    213
Note: See TracChangeset for help on using the changeset viewer.