Changeset 91901 in webkit

Timestamp:

Jul 27, 2011, 9:34:10 PM (14 years ago)

Author:

vsevik@chromium.org

Message:

Web Inspector: [REGRESSION] [Chromium] Opening link in new tab does not work properly.
​https://bugs.webkit.org/show_bug.cgi?id=65279

Reviewed by Pavel Feldman.

• inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::open):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/InspectorPageAgent.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-07-27  Vsevolod Vlasov  <vsevik@chromium.org>
+
+        Web Inspector: [REGRESSION] [Chromium] Opening link in new tab does not work properly.
+        https://bugs.webkit.org/show_bug.cgi?id=65279
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/InspectorPageAgent.cpp:
+        (WebCore::InspectorPageAgent::open):
+
 2011-07-27  Adam Klein  <adamk@chromium.org>
 

trunk/Source/WebCore/inspector/InspectorPageAgent.cpp

@@ -300 +300 @@
 void InspectorPageAgent::open(ErrorString*, const String& url, const bool* const inNewWindow)
 {
+    UserGestureIndicator indicator(DefinitelyProcessingUserGesture);
+
     Frame* mainFrame = m_page->mainFrame();
     Frame* frame;
@@ -316 +318 @@
         frame = mainFrame;
 
-    UserGestureIndicator indicator(DefinitelyProcessingUserGesture);
     // FIXME: Why does one use mainFrame and the other frame?
     frame->loader()->changeLocation(mainFrame->document()->securityOrigin(), frame->document()->completeURL(url), "", false, false);