Changeset 92799 in webkit

Timestamp:

Aug 10, 2011, 2:51:53 PM (14 years ago)

Author:

commit-queue@webkit.org

Message:

[Qt][WK2] MiniBrowser is firing twice the QDesktopWebView::mousePressEvent method
​https://bugs.webkit.org/show_bug.cgi?id=65875

Patch by Benjamin Poulain <​benjamin@webkit.org> on 2011-08-10
Reviewed by Kenneth Rohde Christiansen.

For some reason, QWidget send fake mouse event on some platform, under certains conditions.

This causes mouse events to be sent twice in some cases. We work around the problem
by defining the first touch point to be a primary touch point (case which hit some
weird condition in QWidget, skipping the generation of fake mouse events).

• MiniBrowser/qt/MiniBrowserApplication.cpp:

(MiniBrowserApplication::notify):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• MiniBrowser/qt/MiniBrowserApplication.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-08-10  Benjamin Poulain  <benjamin@webkit.org>
+
+        [Qt][WK2] MiniBrowser is firing twice the QDesktopWebView::mousePressEvent method
+        https://bugs.webkit.org/show_bug.cgi?id=65875
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        For some reason, QWidget send fake mouse event on some platform, under certains conditions.
+
+        This causes mouse events to be sent twice in some cases. We work around the problem
+        by defining the first touch point to be a primary touch point (case which hit some
+        weird condition in QWidget, skipping the generation of fake mouse events).
+
+        * MiniBrowser/qt/MiniBrowserApplication.cpp:
+        (MiniBrowserApplication::notify):
+
 2011-08-10  David Hyatt  <hyatt@apple.com>
 

trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.cpp

@@ -130 +130 @@
         }
 
+        QList<QTouchEvent::TouchPoint> touchPoints = m_touchPoints.values();
+        QTouchEvent::TouchPoint& firstPoint = touchPoints.first();
+        firstPoint.setState(firstPoint.state() | Qt::TouchPointPrimary);
         m_sendingFakeTouchEvent = true;
-        qt_translateRawTouchEvent(0, QTouchEvent::TouchScreen, m_touchPoints.values());
+        qt_translateRawTouchEvent(0, QTouchEvent::TouchScreen, touchPoints);
         m_sendingFakeTouchEvent = false;