Changeset 93021 in webkit

Timestamp:

Aug 13, 2011, 11:51:05 AM (14 years ago)

Author:

weinig@apple.com

Message:

Fix incorrect objective-c initialize in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=66191

Reviewed by David Kilzer.

• accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper initWithAccessibilityObject:]):

• rendering/RenderThemeMac.mm:

(-[WebCoreRenderThemeNotificationObserver initWithTheme:WebCore::]):
Correctly initialize by assigning to self and nil checking the result.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• accessibility/mac/AccessibilityObjectWrapper.mm (modified) (1 diff)
• rendering/RenderThemeMac.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-08-13  Sam Weinig  <sam@webkit.org>
+
+        Fix incorrect objective-c initialize in WebCore
+        https://bugs.webkit.org/show_bug.cgi?id=66191
+
+        Reviewed by David Kilzer.
+
+        * accessibility/mac/AccessibilityObjectWrapper.mm:
+        (-[AccessibilityObjectWrapper initWithAccessibilityObject:]):
+        * rendering/RenderThemeMac.mm:
+        (-[WebCoreRenderThemeNotificationObserver initWithTheme:WebCore::]):
+        Correctly initialize by assigning to self and nil checking the result.
+
 2011-08-13  Adam Barth  <abarth@webkit.org>
 

trunk/Source/WebCore/accessibility/mac/AccessibilityObjectWrapper.mm

@@ -339 +339 @@
 - (id)initWithAccessibilityObject:(AccessibilityObject*)axObject
 {
-    [super init];
+    if (!(self = [super init]))
+        return nil;
 
     m_object = axObject;

trunk/Source/WebCore/rendering/RenderThemeMac.mm

@@ -89 +89 @@
 - (id)initWithTheme:(WebCore::RenderTheme *)theme
 {
-    [super init];
-    _theme = theme;
-    
+    if (!(self = [super init]))
+        return nil;
+
+    _theme = theme;    
     return self;
 }