Changeset 93047 in webkit

Timestamp:

Aug 15, 2011, 10:41:34 AM (14 years ago)

Author:

jeffm@apple.com

Message:

MediaPlayerPrivateAVFoundationCF::playerItemStatus() should return MediaPlayerAVPlayerItemStatusDoesNotExist if there is no AVPlayerItem
​https://bugs.webkit.org/show_bug.cgi?id=66171

MediaPlayerPrivateAVFoundationCF::playerItemStatus() should return MediaPlayerAVPlayerItemStatusDoesNotExist if there is no AVPlayerItem
to match the Mac implementation in MediaPlayerPrivateAVFoundationObjC. I also added better logging to notificationCallback().

Reviewed by Jon Honeycutt.

No new tests, uses existing media tests.

• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::MediaPlayerPrivateAVFoundationCF::playerItemStatus): Return MediaPlayerAVPlayerItemStatusDoesNotExist if no AVPlayerItem.
(WebCore::AVFWrapper::notificationCallback): Log the name of the received notification.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-08-12  Jeff Miller  <jeffm@apple.com>
+
+        MediaPlayerPrivateAVFoundationCF::playerItemStatus() should return MediaPlayerAVPlayerItemStatusDoesNotExist if there is no AVPlayerItem
+        https://bugs.webkit.org/show_bug.cgi?id=66171
+        
+        MediaPlayerPrivateAVFoundationCF::playerItemStatus() should return MediaPlayerAVPlayerItemStatusDoesNotExist if there is no AVPlayerItem
+        to match the Mac implementation in MediaPlayerPrivateAVFoundationObjC.  I also added better logging to notificationCallback().
+
+        Reviewed by Jon Honeycutt.
+
+        No new tests, uses existing media tests.
+
+        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp:
+        (WebCore::MediaPlayerPrivateAVFoundationCF::playerItemStatus): Return MediaPlayerAVPlayerItemStatusDoesNotExist if no AVPlayerItem.
+        (WebCore::AVFWrapper::notificationCallback): Log the name of the received notification.
+
 2011-08-15  Adam Roben  <aroben@apple.com>
 

trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp

@@ -389 +389 @@
 {
     if (!avPlayerItem(m_avfWrapper))
-        return MediaPlayerPrivateAVFoundation::MediaPlayerAVPlayerItemStatusUnknown;
+        return MediaPlayerPrivateAVFoundation::MediaPlayerAVPlayerItemStatusDoesNotExist;
 
     AVCFPlayerItemStatus status = AVCFPlayerItemGetStatus(avPlayerItem(m_avfWrapper), 0);
@@ -1042 +1042 @@
     }
 
-    LOG(Media, "AVFWrapper::notificationCallback(%p)", self);
+#if !LOG_DISABLED
+    char notificationName[256];
+    CFStringGetCString(propertyName, notificationName, sizeof(notificationName), kCFStringEncodingASCII);
+    LOG(Media, "AVFWrapper::notificationCallback(%p) %s", self, notificationName);
+#endif
 
     if (CFEqual(propertyName, AVCFPlayerItemDidPlayToEndTimeNotification))