Changeset 93524 in webkit
- Timestamp:
- Aug 22, 2011, 11:28:28 AM (14 years ago)
- Location:
- branches/chromium/835
- Files:
-
- 4 edited
-
LayoutTests/ChangeLog (modified) (1 diff)
-
LayoutTests/inspector/styles/styles-commit-editing.html (modified) (1 diff)
-
Source/WebCore/ChangeLog (modified) (1 diff)
-
Source/WebCore/inspector/front-end/StylesSidebarPane.js (modified) (11 diffs)
Legend:
- Unmodified
- Added
- Removed
-
branches/chromium/835/LayoutTests/ChangeLog
r92738 r93524 1 2011-08-10 Alexander Pavlov <apavlov@chromium.org> 2 3 Web Inspector: [REGRESSION] Editor lost after committing a CSS property value for inline style 4 https://bugs.webkit.org/show_bug.cgi?id=65918 5 6 Reviewed by Pavel Feldman. 7 8 * inspector/styles/styles-commit-editing.html: 9 10 2011-08-10 Kent Tamura <tkent@chromium.org> 11 12 Move <input type=datetime> tests to fast/forms/datetime/ 13 https://bugs.webkit.org/show_bug.cgi?id=65970 14 15 Reviewed by Hajime Morita. 16 17 * fast/forms/ValidityState-rangeOverflow-expected.txt: Removed "datetime" part. 18 * fast/forms/ValidityState-rangeUnderflow-expected.txt: ditto. 19 * fast/forms/ValidityState-stepMismatch-expected.txt: ditto. 20 * fast/forms/ValidityState-typeMismatch-datetime-expected.txt: Removed. 21 * fast/forms/ValidityState-typeMismatch-datetime.html: Removed. 22 * fast/forms/date-input-visible-strings-expected.txt: Removed "datetime" part. 23 * fast/forms/date-input-visible-strings.html: ditto. 24 * fast/forms/datetime: Added. 25 * fast/forms/datetime/ValidityState-rangeOverflow-datetime-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-rangeOverflow-expected.txt. 26 * fast/forms/datetime/ValidityState-rangeOverflow-datetime.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeOverflow.js. 27 * fast/forms/datetime/ValidityState-rangeUnderflow-datetime-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-rangeUnderflow-expected.txt. 28 * fast/forms/datetime/ValidityState-rangeUnderflow-datetime.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeUnderflow.js. 29 * fast/forms/datetime/ValidityState-stepMismatch-datetime-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-stepMismatch-expected.txt. 30 * fast/forms/datetime/ValidityState-stepMismatch-datetime.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-stepMismatch.js. 31 * fast/forms/datetime/ValidityState-typeMismatch-datetime-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-typeMismatch-datetime-expected.txt. 32 * fast/forms/datetime/ValidityState-typeMismatch-datetime.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-typeMismatch-datetime.js. 33 * fast/forms/datetime/datetime-input-type-expected.txt: Copied from LayoutTests/fast/forms/week/week-input-type-expected.txt. 34 * fast/forms/datetime/datetime-input-type.html: Copied from LayoutTests/fast/forms/week/week-input-type.html. 35 * fast/forms/datetime/datetime-input-visible-string-expected.txt: Copied from LayoutTests/fast/forms/week/week-input-visible-string-expected.txt. 36 * fast/forms/datetime/datetime-input-visible-string.html: Copied from LayoutTests/fast/forms/week/week-input-visible-string.html. 37 * fast/forms/datetime/datetime-stepup-stepdown-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-expected.txt. 38 * fast/forms/datetime/datetime-stepup-stepdown-from-renderer-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-from-renderer-expected.txt. 39 * fast/forms/datetime/datetime-stepup-stepdown-from-renderer.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown-from-renderer.js. 40 * fast/forms/datetime/datetime-stepup-stepdown.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown.js. 41 * fast/forms/datetime/input-valueasdate-datetime-expected.txt: Copied from LayoutTests/fast/forms/input-valueasdate-datetime-expected.txt. 42 * fast/forms/datetime/input-valueasdate-datetime.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasdate-datetime.js. 43 * fast/forms/datetime/input-valueasnumber-datetime-expected.txt: Copied from LayoutTests/fast/forms/input-valueasnumber-datetime-expected.txt. 44 * fast/forms/datetime/input-valueasnumber-datetime.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasnumber-datetime.js. 45 * fast/forms/input-stepup-stepdown-expected.txt: Removed "datetime" part. 46 * fast/forms/input-stepup-stepdown-from-renderer-expected.txt: ditto. 47 * fast/forms/input-type-change3-expected.txt: ditto. 48 * fast/forms/input-valueasdate-datetime-expected.txt: Removed. 49 * fast/forms/input-valueasdate-datetime.html: Removed. 50 * fast/forms/input-valueasnumber-datetime-expected.txt: Removed. 51 * fast/forms/input-valueasnumber-datetime.html: Removed. 52 * fast/forms/script-tests/ValidityState-rangeOverflow.js: Removed "datetime" part. 53 * fast/forms/script-tests/ValidityState-rangeUnderflow.js: ditto. 54 * fast/forms/script-tests/ValidityState-stepMismatch.js: ditto. 55 * fast/forms/script-tests/ValidityState-typeMismatch-datetime.js: Removed. 56 * fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: Removed "datetime" part. 57 * fast/forms/script-tests/input-stepup-stepdown.js: ditto. 58 * fast/forms/script-tests/input-type-change3.js: ditto. 59 * fast/forms/script-tests/input-valueasdate-datetime.js: Removed. 60 * fast/forms/script-tests/input-valueasnumber-datetime.js: Removed. 61 62 2011-08-10 Csaba Osztrogonác <ossy@webkit.org> 63 64 [Qt] http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm fails intermittently 65 https://bugs.webkit.org/show_bug.cgi?id=65969 66 67 Unreviewed gardening. 68 69 * platform/qt-4.8/Skipped: Remove http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm, because it isn't Qt 4.8 specific bug. 70 * platform/qt/Skipped: Skip http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm. 71 * platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt: Update to the correct results. 72 * platform/qt/test_expectations.txt: Remove http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm. 73 74 2011-08-10 Andrey Kosyakov <caseq@chromium.org> 75 76 Unreviewed test fix. 77 78 * inspector/network-status-non-http-expected.txt: 79 * inspector/network-status-non-http.html: 80 81 2011-08-10 Yuta Kitamura <yutak@chromium.org> 82 83 WebSocket: Add binaryType attribute 84 https://bugs.webkit.org/show_bug.cgi?id=65967 85 86 Reviewed by Kent Tamura. 87 88 * http/tests/websocket/tests/hixie76/undefined-attributes-expected.txt: Added. 89 * http/tests/websocket/tests/hixie76/undefined-attributes.html: Added. 90 * http/tests/websocket/tests/hybi/binary-type-expected.txt: Added. 91 * http/tests/websocket/tests/hybi/binary-type.html: Added. 92 93 2011-08-10 Yuta Kitamura <yutak@chromium.org> 94 95 WebSocket: Accept multiple subprotocols 96 https://bugs.webkit.org/show_bug.cgi?id=65247 97 98 Reviewed by Kent Tamura. 99 100 Add tests to check whether WebSocket accepts multiple subprotocols in constructor. 101 102 * http/tests/websocket/tests/hybi/accept-first-subprotocol_wsh.py: Added. 103 * http/tests/websocket/tests/hybi/invalid-subprotocol-characters-expected.txt: Added. 104 * http/tests/websocket/tests/hybi/invalid-subprotocol-characters.html: Added. 105 * http/tests/websocket/tests/hybi/invalid-subprotocols-expected.txt: Added. 106 * http/tests/websocket/tests/hybi/invalid-subprotocols.html: Added. 107 * http/tests/websocket/tests/hybi/multiple-subprotocols-expected.txt: Renamed from LayoutTests/http/tests/websocket/tests/hybi/sub-protocol-with-space-expected.txt. 108 * http/tests/websocket/tests/hybi/multiple-subprotocols.html: Added. 109 * http/tests/websocket/tests/hybi/sub-protocol-with-space-expected.txt: Removed. 110 * http/tests/websocket/tests/hybi/sub-protocol-with-space.html: 111 Removed because hybi-10 does not allow subprotocols containing a space. 112 * http/tests/websocket/tests/hybi/workers/multiple-subprotocols-expected.txt: Added. 113 * http/tests/websocket/tests/hybi/workers/multiple-subprotocols.html: Added. 114 * http/tests/websocket/tests/hybi/workers/resources/multiple-subprotocols.js: Added. 115 (ws.onopen): 116 (ws.onmessage): 117 (ws.onclose): 118 * http/tests/websocket/tests/hybi/workers/resources/protocol-test_wsh.py: Copied from http/tests/websocket/tests/hybi/protocol-test_wsh.py. 119 120 2011-08-10 Noel Gordon <noel.gordon@gmail.com> 121 122 [Chromium] plugins/mouse-events.html should pass on the mac. 123 https://bugs.webkit.org/show_bug.cgi?id=65957 124 125 Reviewed by Kent Tamura. 126 127 Cocoa plugins do not generate adjustCursorEvents. Rebaseline this test result for the 128 chromium Mac port. Note the WebKit Mac/Win ports report 0 for the line number for all 129 console.log() events. The Chromium port reports the actual line number, and hence the 130 need for separate test results for Chromium. Following bug 61721, this test now runs, 131 and passes on all the Chromium ports. The test confirms user-plugin interactivity, so 132 we don't regress sites like youtube.com. Refer to bug 11517. 133 134 * platform/chromium-mac/plugins/mouse-events-expected.txt: 135 * platform/chromium/test_expectations.txt: 136 137 2011-08-10 Andrey Kosyakov <caseq@chromium.org> 138 139 Web Inspector: Network panel always displays file:// resources as "(pending)" 140 https://bugs.webkit.org/show_bug.cgi?id=65784 141 142 Reviewed by Pavel Feldman. 143 144 * inspector/network-status-non-http-expected.txt: Added. 145 * inspector/network-status-non-http.html: Added. 146 147 2011-08-09 Kent Tamura <tkent@chromium.org> 148 149 Move <input type=datetime-local> tests to fast/forms/datetimelocal/ 150 https://bugs.webkit.org/show_bug.cgi?id=65958 151 152 Reviewed by Hajime Morita. 153 154 * fast/forms/ValidityState-rangeOverflow-expected.txt: Removed datetime-local part. 155 * fast/forms/ValidityState-rangeUnderflow-expected.txt: ditto. 156 * fast/forms/ValidityState-stepMismatch-expected.txt: ditto. 157 * fast/forms/ValidityState-typeMismatch-datetimelocal-expected.txt: Removed. 158 * fast/forms/ValidityState-typeMismatch-datetimelocal.html: Removed. 159 * fast/forms/date-input-visible-strings-expected.txt: Removed datetime-local and time parts. 160 * fast/forms/date-input-visible-strings.html: ditto. 161 * fast/forms/datetimelocal: Added. 162 * fast/forms/datetimelocal/ValidityState-rangeOverflow-datetimelocal-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-rangeOverflow-expected.txt. 163 * fast/forms/datetimelocal/ValidityState-rangeOverflow-datetimelocal.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeOverflow.js. 164 * fast/forms/datetimelocal/ValidityState-rangeUnderflow-datetimelocal-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-rangeUnderflow-expected.txt. 165 * fast/forms/datetimelocal/ValidityState-rangeUnderflow-datetimelocal.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeUnderflow.js. 166 * fast/forms/datetimelocal/ValidityState-stepMismatch-datetimelocal-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-stepMismatch-expected.txt. 167 * fast/forms/datetimelocal/ValidityState-stepMismatch-datetimelocal.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-stepMismatch.js. 168 * fast/forms/datetimelocal/ValidityState-typeMismatch-datetimelocal-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-typeMismatch-datetimelocal-expected.txt. 169 * fast/forms/datetimelocal/ValidityState-typeMismatch-datetimelocal.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-typeMismatch-datetimelocal.js. 170 * fast/forms/datetimelocal/datetimelocal-input-type-expected.txt: Copied from LayoutTests/fast/forms/week/week-input-type-expected.txt. 171 * fast/forms/datetimelocal/datetimelocal-input-type.html: Copied from LayoutTests/fast/forms/week/week-input-type.html. 172 * fast/forms/datetimelocal/datetimelocal-input-visible-string-expected.txt: Copied from LayoutTests/fast/forms/week/week-input-visible-string-expected.txt. 173 * fast/forms/datetimelocal/datetimelocal-input-visible-string.html: Copied from LayoutTests/fast/forms/week/week-input-visible-string.html. 174 * fast/forms/datetimelocal/datetimelocal-stepup-stepdown-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-expected.txt. 175 * fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-from-renderer-expected.txt. 176 * fast/forms/datetimelocal/datetimelocal-stepup-stepdown-from-renderer.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown-from-renderer.js. 177 * fast/forms/datetimelocal/datetimelocal-stepup-stepdown.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown.js. 178 * fast/forms/datetimelocal/input-valueasdate-datetimelocal-expected.txt: Copied from LayoutTests/fast/forms/input-valueasdate-datetimelocal-expected.txt. 179 * fast/forms/datetimelocal/input-valueasdate-datetimelocal.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasdate-datetimelocal.js. 180 * fast/forms/datetimelocal/input-valueasnumber-datetimelocal-expected.txt: Copied from LayoutTests/fast/forms/input-valueasnumber-datetimelocal-expected.txt. 181 * fast/forms/datetimelocal/input-valueasnumber-datetimelocal.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasnumber-datetimelocal.js. 182 * fast/forms/input-stepup-stepdown-expected.txt: Removed datetime-local part. 183 * fast/forms/input-stepup-stepdown-from-renderer-expected.txt: ditto. 184 * fast/forms/input-type-change3-expected.txt: ditto. 185 * fast/forms/input-valueasdate-datetimelocal-expected.txt: Removed. 186 * fast/forms/input-valueasdate-datetimelocal.html: Removed. 187 * fast/forms/input-valueasnumber-datetimelocal-expected.txt: Removed. 188 * fast/forms/input-valueasnumber-datetimelocal.html: Removed. 189 * fast/forms/script-tests/ValidityState-rangeOverflow.js: Removed datetime-local part. 190 * fast/forms/script-tests/ValidityState-rangeUnderflow.js: ditto. 191 * fast/forms/script-tests/ValidityState-stepMismatch.js: ditto. 192 * fast/forms/script-tests/ValidityState-typeMismatch-datetimelocal.js: Removed. 193 * fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: Removed datetime-local part. 194 * fast/forms/script-tests/input-stepup-stepdown.js: Removed datetime-local part. 195 * fast/forms/script-tests/input-type-change3.js: Removed datetime-local part. 196 * fast/forms/script-tests/input-valueasdate-datetimelocal.js: Removed. 197 * fast/forms/script-tests/input-valueasnumber-datetimelocal.js: Removed. 198 199 2011-08-10 Adam Barth <abarth@webkit.org> 200 201 Updated results after http://trac.webkit.org/changeset/92744. 202 203 * platform/chromium-linux/fast/css-generated-content/table-row-before-after-child-add-expected.png: 204 * platform/chromium-linux/fast/css-generated-content/table-table-before-after-child-add-expected.png: 205 * platform/chromium-mac-leopard/fast/css-generated-content/table-row-before-after-child-add-expected.png: 206 * platform/chromium-mac-leopard/fast/css-generated-content/table-table-before-after-child-add-expected.png: 207 * platform/chromium-mac/fast/css-generated-content/table-row-before-after-child-add-expected.png: 208 * platform/chromium-mac/fast/css-generated-content/table-table-before-after-child-add-expected.png: 209 * platform/chromium-win/fast/css-generated-content/table-row-before-after-child-add-expected.png: 210 * platform/chromium-win/fast/css-generated-content/table-table-before-after-child-add-expected.png: 211 212 2011-08-09 Dominic Cooney <dominicc@chromium.org> 213 214 [V8] The prototype property of DOM constructors should be read-only. 215 https://bugs.webkit.org/show_bug.cgi?id=39655 216 217 Reviewed by Dimitri Glazkov. 218 219 * platform/chromium/test_expectations.txt: Unskip test for prototypes. 220 221 2011-08-09 Kent Tamura <tkent@chromium.org> 222 223 Move <input type=time> tests to fast/forms/time/ 224 https://bugs.webkit.org/show_bug.cgi?id=65955 225 226 Reviewed by Hajime Morita. 227 228 * fast/forms/ValidityState-rangeOverflow-expected.txt: Removed 'time' part. 229 * fast/forms/ValidityState-rangeUnderflow-expected.txt: ditto. 230 * fast/forms/ValidityState-stepMismatch-expected.txt: ditto. 231 * fast/forms/ValidityState-typeMismatch-time-expected.txt: Removed. 232 * fast/forms/ValidityState-typeMismatch-time.html: Removed. 233 * fast/forms/input-stepup-stepdown-expected.txt: Removed 'time' part. 234 * fast/forms/input-stepup-stepdown-from-renderer-expected.txt: ditto. 235 * fast/forms/input-type-change3-expected.txt: ditto. 236 * fast/forms/input-valueasdate-time-expected.txt: Removed. 237 * fast/forms/input-valueasdate-time.html: Removed. 238 * fast/forms/input-valueasnumber-time-expected.txt: Removed. 239 * fast/forms/input-valueasnumber-time.html: Removed. 240 * fast/forms/script-tests/ValidityState-rangeOverflow.js: Removed 'time' part. 241 * fast/forms/script-tests/ValidityState-rangeUnderflow.js: ditto. 242 * fast/forms/script-tests/ValidityState-stepMismatch.js: ditto. 243 * fast/forms/script-tests/ValidityState-typeMismatch-time.js: Removed. 244 * fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: Removed 'time' part. 245 * fast/forms/script-tests/input-stepup-stepdown.js: ditto. 246 * fast/forms/script-tests/input-type-change3.js: ditto. 247 * fast/forms/script-tests/input-valueasdate-time.js: Removed. 248 * fast/forms/script-tests/input-valueasnumber-time.js: Removed. 249 * fast/forms/time: Added. 250 * fast/forms/time/ValidityState-rangeOverflow-time-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-rangeOverflow-expected.txt. 251 * fast/forms/time/ValidityState-rangeOverflow-time.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeOverflow.js. 252 * fast/forms/time/ValidityState-rangeUnderflow-time-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-rangeUnderflow-expected.txt. 253 * fast/forms/time/ValidityState-rangeUnderflow-time.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeUnderflow.js. 254 * fast/forms/time/ValidityState-stepMismatch-time-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-stepMismatch-expected.txt. 255 * fast/forms/time/ValidityState-stepMismatch-time.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-stepMismatch.js. 256 * fast/forms/time/ValidityState-typeMismatch-time-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-typeMismatch-time-expected.txt. 257 * fast/forms/time/ValidityState-typeMismatch-time.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-typeMismatch-time.js. 258 * fast/forms/time/input-valueasdate-time-expected.txt: Copied from LayoutTests/fast/forms/input-valueasdate-time-expected.txt. 259 * fast/forms/time/input-valueasdate-time.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasdate-time.js. 260 * fast/forms/time/input-valueasnumber-time-expected.txt: Copied from LayoutTests/fast/forms/input-valueasnumber-time-expected.txt. 261 * fast/forms/time/input-valueasnumber-time.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasnumber-time.js. 262 * fast/forms/time/time-input-type-expected.txt: Copied from LayoutTests/fast/forms/week/week-input-type-expected.txt. 263 * fast/forms/time/time-input-type.html: Copied from LayoutTests/fast/forms/week/week-input-type.html. 264 * fast/forms/time/time-input-visible-string-expected.txt: Copied from LayoutTests/fast/forms/week/week-input-visible-string-expected.txt. 265 * fast/forms/time/time-input-visible-string.html: Copied from LayoutTests/fast/forms/week/week-input-visible-string.html. 266 * fast/forms/time/time-stepup-stepdown-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-expected.txt. 267 * fast/forms/time/time-stepup-stepdown-from-renderer-expected.txt: Copied from LayoutTests/fast/forms/input-stepup-stepdown-from-renderer-expected.txt. 268 * fast/forms/time/time-stepup-stepdown-from-renderer.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown-from-renderer.js. 269 * fast/forms/time/time-stepup-stepdown.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown.js. 270 271 2011-08-09 Abhishek Arya <inferno@chromium.org> 272 273 Fix functional bug where style change was not getting propogated to before, after 274 content. 275 https://bugs.webkit.org/show_bug.cgi?id=51862 276 277 Reviewed by Simon Fraser. 278 279 * platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.png: 280 * platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.png: 281 282 2011-08-09 Kent Tamura <tkent@chromium.org> 283 284 Another follow-up for r92728. 285 https://bugs.webkit.org/show_bug.cgi?id=65916 286 287 * fast/forms/month/ValidityState-stepMismatch-month-expected.txt: Updated. 288 289 2011-08-09 Kent Tamura <tkent@chromium.org> 290 291 Add a missing </script> for r92728. 292 293 * fast/forms/month/ValidityState-stepMismatch-month.html: 294 295 2011-08-09 Jian Li <jianli@chromium.org> 296 297 Unreviewed, mark 2 webaudio tests as failed on chromium win. 298 299 * platform/chromium/test_expectations.txt: 300 301 2011-08-09 Kent Tamura <tkent@chromium.org> 302 303 Move <input type=month> tests to fast/forms/month/ 304 https://bugs.webkit.org/show_bug.cgi?id=65916 305 306 Reviewed by Tony Chang. 307 308 * fast/forms/ValidityState-rangeOverflow-expected.txt: Removed month part. 309 * fast/forms/ValidityState-rangeUnderflow-expected.txt: Removed month part. 310 * fast/forms/ValidityState-stepMismatch-expected.txt: Removed month part. 311 * fast/forms/ValidityState-typeMismatch-month-expected.txt: Removed. 312 * fast/forms/ValidityState-typeMismatch-month.html: Removed. 313 * fast/forms/date-input-visible-strings-expected.txt: Removed month part. 314 * fast/forms/date-input-visible-strings.html: Removed month part. 315 * fast/forms/input-stepup-stepdown-expected.txt: Removed month part. 316 * fast/forms/input-stepup-stepdown-from-renderer-expected.txt: Removed month part. 317 * fast/forms/input-type-change3-expected.txt: Removed month part. 318 * fast/forms/input-valueasdate-expected.txt: Removed. 319 * fast/forms/input-valueasdate-month-expected.txt: Removed. 320 * fast/forms/input-valueasdate-month.html: Removed. 321 * fast/forms/input-valueasdate.html: Removed. 322 * fast/forms/input-valueasnumber-month-expected.txt: Removed. 323 * fast/forms/input-valueasnumber-month.html: Removed. 324 * fast/forms/month: Added. 325 * fast/forms/month/ValidityState-rangeOverflow-month-expected.txt: Added. 326 * fast/forms/month/ValidityState-rangeOverflow-month.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeOverflow.js. 327 * fast/forms/month/ValidityState-rangeUnderflow-month-expected.txt: Added. 328 * fast/forms/month/ValidityState-rangeUnderflow-month.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-rangeUnderflow.js. 329 * fast/forms/month/ValidityState-stepMismatch-month-expected.txt: Added. 330 * fast/forms/month/ValidityState-stepMismatch-month.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-stepMismatch.js. 331 * fast/forms/month/ValidityState-typeMismatch-month-expected.txt: Copied from LayoutTests/fast/forms/ValidityState-typeMismatch-month-expected.txt. 332 * fast/forms/month/ValidityState-typeMismatch-month.html: Copied from LayoutTests/fast/forms/script-tests/ValidityState-typeMismatch-month.js. 333 * fast/forms/month/input-valueasdate-expected.txt: Copied from LayoutTests/fast/forms/input-valueasdate-expected.txt. 334 * fast/forms/month/input-valueasdate-month-expected.txt: Copied from LayoutTests/fast/forms/input-valueasdate-month-expected.txt. 335 * fast/forms/month/input-valueasdate-month.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasdate-month.js. 336 * fast/forms/month/input-valueasdate.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasdate.js. 337 * fast/forms/month/input-valueasnumber-month-expected.txt: Copied from LayoutTests/fast/forms/input-valueasnumber-month-expected.txt. 338 * fast/forms/month/input-valueasnumber-month.html: Copied from LayoutTests/fast/forms/script-tests/input-valueasnumber-month.js. 339 * fast/forms/month/month-input-type-expected.txt: Added. 340 * fast/forms/month/month-input-type.html: Copied from LayoutTests/fast/forms/week/week-input-type.html. 341 * fast/forms/month/month-input-visible-string-expected.txt: Added. 342 * fast/forms/month/month-input-visible-string.html: Copied from LayoutTests/fast/forms/week/week-input-visible-string.html. 343 * fast/forms/month/month-stepup-stepdown-expected.txt: Added. 344 * fast/forms/month/month-stepup-stepdown-from-renderer-expected.txt: Added. 345 * fast/forms/month/month-stepup-stepdown-from-renderer.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown-from-renderer.js. 346 * fast/forms/month/month-stepup-stepdown.html: Copied from LayoutTests/fast/forms/script-tests/input-stepup-stepdown.js. 347 * fast/forms/script-tests/ValidityState-rangeOverflow.js: Removed month part. 348 * fast/forms/script-tests/ValidityState-rangeUnderflow.js: Removed month part. 349 * fast/forms/script-tests/ValidityState-stepMismatch.js: Removed month part. 350 * fast/forms/script-tests/ValidityState-typeMismatch-month.js: Removed. 351 * fast/forms/script-tests/input-stepup-stepdown-from-renderer.js: Removed month part. 352 * fast/forms/script-tests/input-stepup-stepdown.js: Removed month part. 353 * fast/forms/script-tests/input-type-change3.js: Removed month part. 354 * fast/forms/script-tests/input-valueasdate-month.js: Removed. 355 * fast/forms/script-tests/input-valueasdate.js: Removed. 356 * fast/forms/script-tests/input-valueasnumber-month.js: Removed. 357 358 2011-08-09 Anders Carlsson <andersca@apple.com> 359 360 Add the final batch of Lion specific SVG test results. 361 362 * platform/mac-snowleopard/svg/W3C-SVG-1.1: Added. 363 * platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Copied from platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png. 364 * platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Copied from platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt. 365 * platform/mac-snowleopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.png: Copied from platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.png. 366 * platform/mac-snowleopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Copied from platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt. 367 * platform/mac-snowleopard/svg/text: Added. 368 * platform/mac-snowleopard/svg/text/text-intro-05-t-expected.png: Copied from platform/mac/svg/text/text-intro-05-t-expected.png. 369 * platform/mac-snowleopard/svg/text/text-intro-05-t-expected.txt: Copied from platform/mac/svg/text/text-intro-05-t-expected.txt. 370 * platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: 371 * platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: 372 * platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.png: 373 * platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: 374 * platform/mac/svg/text/text-intro-05-t-expected.png: 375 * platform/mac/svg/text/text-intro-05-t-expected.txt: 376 377 2011-08-09 Anders Carlsson <andersca@apple.com> 378 379 Skip a couple of SVG tests that are missing parts of the content for some odd reason. 380 381 * platform/mac-lion/Skipped: 382 383 2011-08-09 Anders Carlsson <andersca@apple.com> 384 385 Add Lion tests results for a couple of bidi SVG tests. 386 387 * platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt. 388 * platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt. 389 * platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt. 390 * platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt. 391 * platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt. 392 * platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt. 393 * platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt. 394 * platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt. 395 * platform/mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt. 396 * platform/mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt. 397 * platform/mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt. 398 * platform/mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt. 399 * platform/mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt. 400 * platform/mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt. 401 * platform/mac-snowleopard/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.txt. 402 * platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: 403 * platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: 404 * platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: 405 * platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: 406 * platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: 407 * platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: 408 * platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: 409 * platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: 410 * platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: 411 * platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: 412 * platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: 413 * platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: 414 * platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: 415 * platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: 416 * platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.txt: 417 418 2011-08-09 Andy Estes <aestes@apple.com> 419 420 Add a Radar number to a skipped test. 421 422 * platform/mac-lion/Skipped: 423 424 2011-08-09 Anders Carlsson <andersca@apple.com> 425 426 Add an expected result for svg/W3C-I18N/text-anchor-dirLTR-anchorEnd.svg and check if it's 427 possible to have a pixel test result in a different platform directory from a text result. 428 429 * platform/mac-snowleopard/svg/W3C-I18N: Added. 430 * platform/mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Copied from platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt. 431 * platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: 432 433 2011-08-09 Anders Carlsson <andersca@apple.com> 434 435 Tweak an expected result. 436 437 * platform/mac-snowleopard/fast/loader/file-url-mimetypes-expected.txt: 438 439 2011-08-09 Filip Pizlo <fpizlo@apple.com> 440 441 DFG JIT failure loading web site 442 https://bugs.webkit.org/show_bug.cgi?id=65930 443 444 Reviewed by Oliver Hunt. 445 446 Reproduced the failure seen in 447 http://www.skinnytaste.com/2011/06/ricotta-cheese-chocolate-chip-muffins.html 448 449 * fast/js/boxed-double-to-int-expected.txt: Added. 450 * fast/js/boxed-double-to-int.html: Added. 451 * fast/js/script-tests/boxed-double-to-int.js: Added. 452 (boxedDoubleToInt): 453 454 2011-08-09 Anders Carlsson <andersca@apple.com> 455 456 Add updated media test results for Lion. 457 458 * platform/mac-snowleopard/media: Added. 459 * platform/mac-snowleopard/media/controls-strict-expected.png: Copied from platform/mac/media/controls-strict-expected.png. 460 * platform/mac-snowleopard/media/controls-strict-expected.txt: Copied from platform/mac/media/controls-strict-expected.txt. 461 * platform/mac-snowleopard/media/video-controls-rendering-expected.png: Copied from platform/mac/media/video-controls-rendering-expected.png. 462 * platform/mac-snowleopard/media/video-controls-rendering-expected.txt: Copied from platform/mac/media/video-controls-rendering-expected.txt. 463 * platform/mac-snowleopard/media/video-display-toggle-expected.png: Copied from platform/mac/media/video-display-toggle-expected.png. 464 * platform/mac-snowleopard/media/video-display-toggle-expected.txt: Copied from platform/mac/media/video-display-toggle-expected.txt. 465 * platform/mac-snowleopard/media/video-layer-crash-expected.png: Copied from platform/mac/media/video-layer-crash-expected.png. 466 * platform/mac-snowleopard/media/video-layer-crash-expected.txt: Copied from platform/mac/media/video-layer-crash-expected.txt. 467 * platform/mac-snowleopard/media/video-no-audio-expected.png: Copied from platform/mac/media/video-no-audio-expected.png. 468 * platform/mac-snowleopard/media/video-no-audio-expected.txt: Copied from platform/mac/media/video-no-audio-expected.txt. 469 * platform/mac/media/controls-strict-expected.png: 470 * platform/mac/media/controls-strict-expected.txt: 471 * platform/mac/media/video-controls-rendering-expected.png: 472 * platform/mac/media/video-controls-rendering-expected.txt: 473 * platform/mac/media/video-display-toggle-expected.png: 474 * platform/mac/media/video-display-toggle-expected.txt: 475 * platform/mac/media/video-layer-crash-expected.png: 476 * platform/mac/media/video-no-audio-expected.png: 477 * platform/mac/media/video-no-audio-expected.txt: 478 479 2011-08-09 Chris Rogers <crogers@google.com> 480 481 Add more Web Audio layout tests 482 https://bugs.webkit.org/show_bug.cgi?id=65786 483 484 Reviewed by Kenneth Russell. 485 486 * webaudio/audiobuffersource-expected.wav: Added. 487 * webaudio/audiobuffersource-playbackrate-expected.wav: Added. 488 * webaudio/audiobuffersource-playbackrate.html: Added. 489 * webaudio/audiobuffersource.html: Added. 490 * webaudio/mixing-expected.wav: Added. 491 * webaudio/mixing.html: Added. 492 * webaudio/resources/hyper-reality: Added. 493 * webaudio/resources/hyper-reality/br-jam-loop.wav: Added. 494 * webaudio/resources/hyper-reality/laughter.wav: Added. 495 * webaudio/sample-accurate-scheduling-expected.txt: Added. 496 * webaudio/sample-accurate-scheduling.html: Added. 497 498 2011-08-09 Anders Carlsson <andersca@apple.com> 499 500 More Lion skipped list goodness. 501 502 * platform/mac-lion/Skipped: 503 1 504 2011-08-09 Vsevolod Vlasov <vsevik@chromium.org> 2 505 -
branches/chromium/835/LayoutTests/inspector/styles/styles-commit-editing.html
r89813 r93524 35 35 function step2() 36 36 { 37 if (!WebInspector.isEditingAnyField()) { 38 InspectorTest.addResult("No new property editor active!"); 39 InspectorTest.completeTest(); 40 } 37 41 InspectorTest.selectNodeWithId("other"); 38 42 InspectorTest.runAfterPendingDispatches(step3); -
branches/chromium/835/Source/WebCore/ChangeLog
r93493 r93524 1 2011-08-19 James Robinson <jamesr@chromium.org>2 3 REGRESSION(r91628): 3 canvas tests crash on Chromium Linux and one test fail on Chromium Mac4 https://bugs.webkit.org/show_bug.cgi?id=650635 6 Reviewed by Darin Fisher.7 8 Fixes crashes due to a bad cast from Image to BitmapImage on skia ports9 that use BitmapImageSingleFrameSkia. In the skia port10 Image::isBitmapImage() returning true does not necessarily mean that11 Image is of type BitmapImage.12 13 Covered by fast/canvas/canvas-as-image.html and many other canvas14 tests.15 16 Patch originally by Tom Hudson.17 18 * platform/graphics/BitmapImage.h:19 (WebCore::BitmapImage::currentFrameHasAlpha):20 (WebCore::BitmapImage::notSolidColor):21 * platform/graphics/Image.cpp:22 (WebCore::Image::drawTiled):23 * platform/graphics/Image.h:24 (WebCore::Image::currentFrameHasAlpha):25 (WebCore::Image::notSolidColor):26 * platform/graphics/skia/BitmapImageSingleFrameSkia.h:27 (WebCore::BitmapImageSingleFrameSkia::currentFrameHasAlpha):28 (WebCore::BitmapImageSingleFrameSkia::notSolidColor):29 * rendering/RenderImage.cpp:30 (WebCore::RenderImage::backgroundIsObscured):31 32 2011-08-19 Emil A Eklund <eae@chromium.org>33 34 Switch clipping for svg to to new layout types35 https://bugs.webkit.org/show_bug.cgi?id=6658636 37 Reviewed by Eric Seidel.38 39 No new tests as no new functionality.40 41 * rendering/svg/RenderSVGForeignObject.h:42 * rendering/svg/RenderSVGGradientStop.h:43 (WebCore::RenderSVGGradientStop::clippedOverflowRectForRepaint):44 * rendering/svg/RenderSVGHiddenContainer.h:45 (WebCore::RenderSVGHiddenContainer::clippedOverflowRectForRepaint):46 * rendering/svg/RenderSVGInline.cpp:47 (WebCore::RenderSVGInline::clippedOverflowRectForRepaint):48 (WebCore::RenderSVGInline::computeRectForRepaint):49 * rendering/svg/RenderSVGInline.h:50 * rendering/svg/RenderSVGModelObject.cpp:51 (WebCore::RenderSVGModelObject::clippedOverflowRectForRepaint):52 (WebCore::RenderSVGModelObject::computeRectForRepaint):53 * rendering/svg/RenderSVGModelObject.h:54 * rendering/svg/RenderSVGText.cpp:55 (WebCore::RenderSVGText::clippedOverflowRectForRepaint):56 (WebCore::RenderSVGText::computeRectForRepaint):57 * rendering/svg/RenderSVGText.h:58 * svg/SVGSVGElement.cpp:59 (WebCore::SVGSVGElement::localCoordinateSpaceTransform):60 * svg/SVGSVGElement.h:61 (WebCore::SVGSVGElement::setContainerSize):62 (WebCore::SVGSVGElement::containerSize):63 * svg/graphics/SVGImage.cpp:64 (WebCore::SVGImageChromeClient::invalidateContentsAndWindow):65 (WebCore::SVGImage::setContainerSize):66 * svg/graphics/SVGImage.h:67 68 2011-08-19 Sheriff Bot <webkit.review.bot@gmail.com>69 70 Unreviewed, rolling out r93425.71 http://trac.webkit.org/changeset/9342572 https://bugs.webkit.org/show_bug.cgi?id=6659173 74 "The newly-added ASSERT is being triggered on several bots"75 (Requested by jchaffraix on #webkit).76 77 * html/HTMLLinkElement.cpp:78 (WebCore::HTMLLinkElement::HTMLLinkElement):79 (WebCore::HTMLLinkElement::setDisabled):80 (WebCore::HTMLLinkElement::sheetLoaded):81 (WebCore::HTMLLinkElement::disabled):82 * html/HTMLLinkElement.h:83 (WebCore::HTMLLinkElement::isEnabledViaScript):84 85 2011-08-18 Adrienne Walker <enne@google.com>86 87 [chromium] Refactor updateCompositorResources to take an explicit GraphicsContext3D88 https://bugs.webkit.org/show_bug.cgi?id=6643289 90 Reviewed by James Robinson.91 92 Covered by existing tests.93 94 * platform/graphics/chromium/Canvas2DLayerChromium.cpp:95 (WebCore::Canvas2DLayerChromium::updateCompositorResources):96 * platform/graphics/chromium/Canvas2DLayerChromium.h:97 * platform/graphics/chromium/LayerChromium.h:98 (WebCore::LayerChromium::updateCompositorResources):99 * platform/graphics/chromium/LayerRendererChromium.cpp:100 (WebCore::LayerRendererChromium::updateCompositorResources):101 * platform/graphics/chromium/TiledLayerChromium.cpp:102 (WebCore::TiledLayerChromium::updateCompositorResources):103 * platform/graphics/chromium/TiledLayerChromium.h:104 * platform/graphics/chromium/VideoLayerChromium.cpp:105 (WebCore::VideoLayerChromium::updateCompositorResources):106 * platform/graphics/chromium/VideoLayerChromium.h:107 * platform/graphics/chromium/WebGLLayerChromium.cpp:108 (WebCore::WebGLLayerChromium::updateCompositorResources):109 * platform/graphics/chromium/WebGLLayerChromium.h:110 111 2011-08-19 Victoria Kirst <vrk@chromium.org>112 113 Tell media player to prepareToPlay() at end of HTMLMediaElement::load()114 https://bugs.webkit.org/show_bug.cgi?id=66414115 116 Reviewed by Eric Carlson.117 118 Test: media/video-load-preload-none.html119 120 * html/HTMLMediaElement.cpp:121 (WebCore::HTMLMediaElement::load):122 123 2011-08-19 Emil A Eklund <eae@chromium.org>124 125 Switch RenderBlock to to new layout types126 https://bugs.webkit.org/show_bug.cgi?id=66502127 128 Reviewed by Eric Seidel.129 130 Convert RenderBlock to new layout abstraction. Leave m_lineHight as a 30131 bit int for now to avoid unnecessarily increasing the memory usage.132 133 No new tests as no new functionality.134 135 * rendering/RenderBlock.cpp:136 * rendering/RenderBlock.h:137 138 2011-08-19 Emil A Eklund <eae@chromium.org>139 140 Switch RenderBoxModelObject to to new layout types141 https://bugs.webkit.org/show_bug.cgi?id=66534142 143 Reviewed by Eric Seidel.144 145 Convert RenderBoxModelObject to new layout abstraction.146 147 No new tests as no new functionality.148 149 * rendering/RenderBoxModelObject.cpp:150 (WebCore::ImageQualityController::set):151 (WebCore::ImageQualityController::shouldPaintAtLowQuality):152 (WebCore::RenderBoxModelObject::shouldPaintAtLowQuality):153 (WebCore::backgroundRectAdjustedForBleedAvoidance):154 (WebCore::RenderBoxModelObject::paintFillLayerExtended):155 (WebCore::RenderBoxModelObject::calculateFillTileSize):156 (WebCore::RenderBoxModelObject::BackgroundImageGeometry::useFixedAttachment):157 (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):158 (WebCore::RenderBoxModelObject::paintNinePieceImage):159 (WebCore::borderWillArcInnerEdge):160 (WebCore::RenderBoxModelObject::paintOneBorderSide):161 (WebCore::RenderBoxModelObject::paintBorderSides):162 (WebCore::RenderBoxModelObject::paintBorder):163 (WebCore::RenderBoxModelObject::drawBoxSideFromPath):164 (WebCore::RenderBoxModelObject::clipBorderSidePolygon):165 (WebCore::areaCastingShadowInHole):166 (WebCore::RenderBoxModelObject::paintBoxShadow):167 (WebCore::RenderBoxModelObject::containingBlockLogicalWidthForContent):168 * rendering/RenderBoxModelObject.h:169 170 2011-08-19 Mihnea Ovidenie <mihnea@adobe.com>171 172 [CSSRegions]Speed up RenderFlowThread repaint of regions173 https://bugs.webkit.org/show_bug.cgi?id=66566174 175 Reviewed by David Hyatt.176 177 When in printing or the repaint rectangle is empty, there is no need to iterate178 the render flow regions in order to repaint.179 Covered by existing tests.180 181 * rendering/RenderFlowThread.cpp:182 (WebCore::RenderFlowThread::shouldRepaint):183 (WebCore::RenderFlowThread::repaintRectangleInRegions):184 * rendering/RenderFlowThread.h:185 186 2011-08-19 Mihnea Ovidenie <mihnea@adobe.com>187 188 [CSSRegions]Parse -webkit-region-break(after, before, inside)189 https://bugs.webkit.org/show_bug.cgi?id=66559190 191 Reviewed by David Hyatt.192 193 * css/CSSComputedStyleDeclaration.cpp:194 (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):195 * css/CSSMutableStyleDeclaration.cpp:196 * css/CSSParser.cpp:197 (WebCore::CSSParser::parseValue):198 * css/CSSPropertyNames.in:199 * css/CSSStyleSelector.cpp:200 (WebCore::CSSStyleSelector::applyProperty):201 * rendering/style/RenderStyle.h:202 (WebCore::InheritedFlags::regionBreakBefore):203 (WebCore::InheritedFlags::regionBreakInside):204 (WebCore::InheritedFlags::regionBreakAfter):205 (WebCore::InheritedFlags::setRegionBreakBefore):206 (WebCore::InheritedFlags::setRegionBreakInside):207 (WebCore::InheritedFlags::setRegionBreakAfter):208 * rendering/style/StyleRareNonInheritedData.cpp:209 (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):210 (WebCore::StyleRareNonInheritedData::operator==):211 * rendering/style/StyleRareNonInheritedData.h:212 213 2011-08-19 Emil A Eklund <eae@chromium.org>214 215 Switch RenderLayer to to new layout types216 https://bugs.webkit.org/show_bug.cgi?id=66507217 218 Reviewed by Eric Seidel.219 220 Convert RenderLayer to new layout abstraction.221 222 No new tests as no new functionality.223 224 * rendering/LayoutTypes.h:225 (WebCore::flooredLayoutSize):226 * rendering/RenderLayer.cpp:227 * rendering/RenderLayer.h:228 * rendering/RenderLayerBacking.cpp:229 * rendering/RenderLayerBacking.h:230 * rendering/RenderLayerCompositor.cpp:231 * rendering/RenderLayerCompositor.h:232 233 2011-08-19 Mihnea Ovidenie <mihnea@adobe.com>234 235 [CSSRegions]Content displayed in regions should not be scrollable236 https://bugs.webkit.org/show_bug.cgi?id=66459237 238 Reviewed by Darin Adler.239 240 Initially, when creating the style for the RenderFlowThread, overflowX and overflowY were both set to hidden,241 so that RenderView did not display scrollbars when a RenderFlowThread exists. However, this allowed the possibility242 of scrolling the content displayed in region.243 244 Now, the RenderFlowThread objects are ignored in RenderBlock::insertPositionedObject and the style of the RenderFlowThread245 can be set to visible, thus preventing scrolling of the content displayed in regions.246 247 Test: fast/regions/content-flowed-into-regions-no-scroll.html248 249 * rendering/RenderFlowThread.cpp:250 (WebCore::RenderFlowThread::createFlowThreadStyle):251 252 2011-08-19 Julien Chaffraix <jchaffraix@webkit.org>253 254 REGRESSION (r84327-r84329): CSS stylesheets fail to load on www.flagstar.com login page255 https://bugs.webkit.org/show_bug.cgi?id=65140256 <rdar://problem/9835905>257 258 Reviewed by Antti Koivisto.259 260 Tests: fast/css/stylesheet-enable-first-alternate-on-load.html261 fast/css/stylesheet-enable-first-alternate.html262 fast/css/stylesheet-enable-second-alternate-on-load.html263 fast/css/stylesheet-enable-second-alternate.html264 http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html265 http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html266 267 The gist of the issue is that we were ignoring calls to HTMLLinkElement::setDisabled that would enable a268 style sheet when we were loading a stylesheet (m_sheet was 0 and thus ignored the call per the spec).269 270 FF goes against the CSS OM spec in this case and always keep an associated sheet as long as 'rel' hints271 at a stylesheet link and href is present. Instead of siding with FF, I continued to follow the272 specification and store the enabled via javascript state into m_scriptState (renamed from273 m_isEnabledViaScript). This information gets merged back into the style sheet disabled state when it is274 available.275 276 While debugging the case at hand, I found some cases that were not properly handled and were fixed as277 part of this change.278 279 * html/HTMLLinkElement.cpp:280 (WebCore::HTMLLinkElement::HTMLLinkElement): Updated after m_isEnabledViaScript rename.281 (WebCore::HTMLLinkElement::setDisabled): Always call setIsEnabledViaScript so that282 the information is properly stored (either for recalcStyleSelector or just to store283 the state during loading).284 285 (WebCore::HTMLLinkElement::sheetLoaded): Merge back the state from m_scriptState to286 the sheet's disabled state.287 288 (WebCore::HTMLLinkElement::disabled): Account for the temporary state and return the289 right value. It matches FF and what people would expect.290 291 (WebCore::HTMLLinkElement::areDisabledAndScriptStatesConsistent): Debug only method292 that checks that disabled() and isEnabledViaScript() are consistent with each other293 (under some circumstances).294 295 * html/HTMLLinkElement.h:296 (WebCore::HTMLLinkElement::isEnabledViaScript): Updated after m_isEnabledViaScript rename.297 (WebCore::HTMLLinkElement::setIsEnabledViaScript): Added setter.298 299 2011-08-17 Adrienne Walker <enne@google.com>300 301 [chromium] Split tiler into main thread / compositor thread versions302 https://bugs.webkit.org/show_bug.cgi?id=66065303 304 Reviewed by James Robinson.305 306 Covered by existing tests.307 308 LayerTilerChromium is renamed to be CCLayerTilingData. Invalidation309 and paint functionality is pushed into TiledLayerChromium and drawing310 with GL is pushed into CCTiledLayerImpl. During tree synchronization,311 the tiler properties and texture IDs are synchronized into312 CCTiledLayerImpl.313 314 * WebCore.gypi:315 * platform/graphics/chromium/ContentLayerChromium.cpp:316 (WebCore::ContentLayerChromium::paintContentsIfDirty):317 (WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded):318 * platform/graphics/chromium/ContentLayerChromium.h:319 * platform/graphics/chromium/ImageLayerChromium.cpp:320 (WebCore::ImageLayerChromium::paintContentsIfDirty):321 * platform/graphics/chromium/LayerRendererChromium.cpp:322 (WebCore::LayerRendererChromium::bestTextureFormat):323 (WebCore::LayerRendererChromium::initializeSharedObjects):324 (WebCore::LayerRendererChromium::tilerProgram):325 (WebCore::LayerRendererChromium::tilerProgramSwizzle):326 (WebCore::LayerRendererChromium::tilerProgramAA):327 (WebCore::LayerRendererChromium::tilerProgramSwizzleAA):328 * platform/graphics/chromium/LayerRendererChromium.h:329 * platform/graphics/chromium/LayerTextureUpdater.h:330 * platform/graphics/chromium/LayerTilerChromium.cpp: Removed.331 * platform/graphics/chromium/ManagedTexture.h:332 (WebCore::ManagedTexture::textureId):333 * platform/graphics/chromium/TiledLayerChromium.cpp:334 (WebCore::UpdatableTile::UpdatableTile):335 (WebCore::UpdatableTile::texture):336 (WebCore::UpdatableTile::dirty):337 (WebCore::UpdatableTile::clearDirty):338 (WebCore::TiledLayerChromium::TiledLayerChromium):339 (WebCore::TiledLayerChromium::cleanupResources):340 (WebCore::TiledLayerChromium::drawsContent):341 (WebCore::TiledLayerChromium::createTilerIfNeeded):342 (WebCore::TiledLayerChromium::updateCompositorResources):343 (WebCore::TiledLayerChromium::pushPropertiesTo):344 (WebCore::TiledLayerChromium::dumpLayerProperties):345 (WebCore::TiledLayerChromium::textureManager):346 (WebCore::TiledLayerChromium::tileAt):347 (WebCore::TiledLayerChromium::createTile):348 (WebCore::TiledLayerChromium::invalidateTiles):349 (WebCore::TiledLayerChromium::invalidateRect):350 (WebCore::TiledLayerChromium::protectVisibleTileTextures):351 (WebCore::TiledLayerChromium::protectTileTextures):352 (WebCore::TiledLayerChromium::prepareToUpdate):353 * platform/graphics/chromium/TiledLayerChromium.h:354 * platform/graphics/chromium/cc/CCLayerTilingData.cpp: Added.355 (WebCore::CCLayerTilingData::create):356 (WebCore::CCLayerTilingData::CCLayerTilingData):357 (WebCore::CCLayerTilingData::setTileSize):358 (WebCore::CCLayerTilingData::operator=):359 (WebCore::CCLayerTilingData::addTile):360 (WebCore::CCLayerTilingData::takeTile):361 (WebCore::CCLayerTilingData::tileAt):362 (WebCore::CCLayerTilingData::reset):363 (WebCore::CCLayerTilingData::contentRectToTileIndices):364 (WebCore::CCLayerTilingData::contentRectToLayerRect):365 (WebCore::CCLayerTilingData::layerRectToContentRect):366 (WebCore::CCLayerTilingData::tileContentRect):367 (WebCore::CCLayerTilingData::tileLayerRect):368 (WebCore::CCLayerTilingData::setLayerPosition):369 (WebCore::CCLayerTilingData::growLayerToContain):370 * platform/graphics/chromium/cc/CCLayerTilingData.h: Renamed from Source/WebCore/platform/graphics/chromium/LayerTilerChromium.h.371 (WebCore::CCLayerTilingData::numTiles):372 (WebCore::CCLayerTilingData::numTilesX):373 (WebCore::CCLayerTilingData::numTilesY):374 (WebCore::CCLayerTilingData::tileBounds):375 (WebCore::CCLayerTilingData::textureOffset):376 (WebCore::CCLayerTilingData::tileSize):377 (WebCore::CCLayerTilingData::hasBorderTexels):378 (WebCore::CCLayerTilingData::isEmpty):379 (WebCore::CCLayerTilingData::Tile::Tile):380 (WebCore::CCLayerTilingData::Tile::i):381 (WebCore::CCLayerTilingData::Tile::j):382 (WebCore::CCLayerTilingData::Tile::moveTo):383 (WebCore::CCLayerTilingData::TileMapKeyTraits::emptyValue):384 (WebCore::CCLayerTilingData::TileMapKeyTraits::constructDeletedValue):385 (WebCore::CCLayerTilingData::TileMapKeyTraits::isDeletedValue):386 (WebCore::CCLayerTilingData::tiles):387 * platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:388 (WebCore::DrawableTile::DrawableTile):389 (WebCore::DrawableTile::textureId):390 (WebCore::DrawableTile::setTextureId):391 (WebCore::CCTiledLayerImpl::CCTiledLayerImpl):392 (WebCore::CCTiledLayerImpl::bindContentsTexture):393 (WebCore::CCTiledLayerImpl::tileAt):394 (WebCore::CCTiledLayerImpl::createTile):395 (WebCore::CCTiledLayerImpl::draw):396 (WebCore::CCTiledLayerImpl::setTilingData):397 (WebCore::CCTiledLayerImpl::syncTextureId):398 (WebCore::isCCW):399 (WebCore::computeEdge):400 (WebCore::intersect):401 (WebCore::CCTiledLayerImpl::drawTiles):402 * platform/graphics/chromium/cc/CCTiledLayerImpl.h:403 (WebCore::CCTiledLayerImpl::setSkipsDraw):404 (WebCore::CCTiledLayerImpl::setTextureOrientation):405 (WebCore::CCTiledLayerImpl::setSampledTexelFormat):406 * platform/graphics/gpu/TilingData.h:407 408 2011-08-19 Dan Bernstein <mitz@apple.com>409 410 Better build fix after r93384.411 412 * rendering/RenderBlockLineLayout.cpp:413 (WebCore::RenderBlock::LineBreaker::nextLineBreak): Use WTF::Unicode wrapper instead of ICU.414 415 2011-08-19 Pavel Podivilov <podivilov@chromium.org>416 417 Web Inspector: update scope variables upon value changes via console.418 https://bugs.webkit.org/show_bug.cgi?id=54720419 420 Reviewed by Pavel Feldman.421 422 * inspector/front-end/ScriptsPanel.js:423 (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):424 425 2011-08-18 Pavel Podivilov <podivilov@chromium.org>426 427 Web Inspector: extract breakpoint management code to a separate class and add tests.428 https://bugs.webkit.org/show_bug.cgi?id=66224429 430 Reviewed by Pavel Feldman.431 432 Test: inspector/debugger/breakpoint-manager.html433 434 * WebCore.gypi:435 * WebCore.vcproj/WebCore.vcproj:436 * inspector/front-end/BreakpointManager.js: Added.437 (WebInspector.BreakpointManager):438 (WebInspector.BreakpointManager.prototype.uiSourceCodeAdded):439 (WebInspector.BreakpointManager.prototype.breakpointsForUISourceCode):440 (WebInspector.BreakpointManager.prototype.setBreakpoint):441 (WebInspector.BreakpointManager.prototype.removeBreakpoint):442 (WebInspector.BreakpointManager.prototype._materializeBreakpoint):443 (WebInspector.BreakpointManager.prototype._breakpointDebuggerLocationChanged):444 (WebInspector.BreakpointManager.prototype._addBreakpointToUI):445 (WebInspector.BreakpointManager.prototype._deleteBreakpointFromUI):446 (WebInspector.BreakpointManager.prototype._moveBreakpointInUI):447 (WebInspector.BreakpointManager.prototype._breakpoints):448 (WebInspector.BreakpointManager.prototype._breakpoint):449 (WebInspector.BreakpointManager.prototype._forEachBreakpoint):450 (WebInspector.BreakpointManager.prototype._setBreakpointInDebugger):451 (WebInspector.BreakpointManager.prototype._removeBreakpointFromDebugger):452 (WebInspector.BreakpointManager.prototype._breakpointResolved):453 (WebInspector.BreakpointManager.prototype.serializeBreakpoints):454 (WebInspector.BreakpointManager.prototype.reset):455 (WebInspector.BreakpointManager.prototype.debuggerReset):456 (WebInspector.Breakpoint):457 (WebInspector.Breakpoint.prototype.serialize):458 (WebInspector.Breakpoint.deserialize):459 * inspector/front-end/DebuggerModel.js:460 (WebInspector.DebuggerModel.prototype.setBreakpointByScriptLocation):461 * inspector/front-end/SourceFile.js:462 (WebInspector.RawSourceCode.prototype.get rawSourceCode):463 * inspector/front-end/WebKit.qrc:464 * inspector/front-end/inspector.html:465 466 2011-08-19 Adam Roben <aroben@apple.com>467 468 Fix typo469 470 * dom/DOMAllInOne.cpp:471 472 2011-08-19 Adam Roben <aroben@apple.com>473 474 Windows build fix after r93385475 476 * dom/DOMAllInOne.cpp: Added EventDispatcMediator.cpp.477 478 2011-08-19 Pavel Feldman <pfeldman@google.com>479 480 Web Inspector: getAttributes should work on a single node, not array.481 https://bugs.webkit.org/show_bug.cgi?id=66544482 483 Reviewed by Adam Roben.484 485 * inspector/Inspector.json:486 * inspector/InspectorDOMAgent.cpp:487 (WebCore::InspectorDOMAgent::getAttributes):488 * inspector/InspectorDOMAgent.h:489 * inspector/front-end/DOMAgent.js:490 (WebInspector.DOMAgent.prototype._loadNodeAttributes):491 492 2011-08-19 Anton Muhin <antonm@chromium.org>493 494 [v8] CSS wrapper objects retention495 https://bugs.webkit.org/show_bug.cgi?id=66377496 497 Reviewed by Pavel Feldman.498 499 Disable object grouping for CSS object wrappers.500 This logic leads to hard to debug use-after-free problems.501 502 * bindings/v8/V8GCController.cpp:503 (WebCore::GrouperVisitor::visitDOMWrapper):504 505 2011-08-19 Pavel Feldman <pfeldman@google.com>506 507 Web Inspector: introduce NodeId inherited from integer in the DOM domain description.508 https://bugs.webkit.org/show_bug.cgi?id=66491509 510 Drive-by rename of couple of DOM domain protocol methods.511 512 Reviewed by Adam Roben.513 514 * inspector/Inspector.json:515 * inspector/InspectorDOMAgent.cpp:516 (WebCore::InspectorDOMAgent::requestChildNodes):517 (WebCore::InspectorDOMAgent::getAttributes):518 (WebCore::InspectorDOMAgent::requestNode):519 (WebCore::InspectorDOMAgent::buildObjectForNode):520 * inspector/InspectorDOMAgent.h:521 * inspector/front-end/DOMAgent.js:522 (WebInspector.DOMNode):523 (WebInspector.DOMNode.prototype.getChildNodes):524 (WebInspector.DOMAgent.prototype.pushNodeToFrontend):525 (WebInspector.DOMAgent.prototype._loadNodeAttributes):526 (WebInspector.DOMAgent.prototype._setDocument):527 (WebInspector.DOMAgent.prototype._setDetachedRoot):528 * inspector/generate-inspector-idl:529 530 2011-08-19 Jochen Eisinger <jochen@chromium.org>531 532 IDBSQLiteBackingStore::deleteObjectStore should maintain referential integrity.533 https://bugs.webkit.org/show_bug.cgi?id=66470534 535 Reviewed by Tony Gentilcore.536 537 * storage/IDBSQLiteBackingStore.cpp:538 (WebCore::IDBSQLiteBackingStore::deleteObjectStore):539 540 2011-08-19 Takashi Toyoshima <toyoshim@chromium.org>541 542 [WebSocket] CloseEvent's code and reason properties support.543 https://bugs.webkit.org/show_bug.cgi?id=66362544 545 Reviewed by Kent Tamura.546 547 Current WebSocket implementation miss code and reason properties548 in CloseEvent. This change expose incoming closing frame's code549 and reason to JavaScript API.550 551 Tests: http/tests/websocket/tests/hybi/close-code-and-reason.html552 http/tests/websocket/tests/hybi/workers/close-code-and-reason.html553 554 * websockets/CloseEvent.h:555 (WebCore::CloseEvent::initCloseEvent):556 (WebCore::CloseEvent::code):557 (WebCore::CloseEvent::reason):558 (WebCore::CloseEvent::CloseEvent):559 * websockets/CloseEvent.idl:560 Add code and reason properies.561 * websockets/ThreadableWebSocketChannelClientWrapper.cpp:562 (WebCore::ThreadableWebSocketChannelClientWrapper::didClose):563 (WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):564 * websockets/ThreadableWebSocketChannelClientWrapper.h:565 * websockets/WebSocket.cpp:566 (WebCore::WebSocket::didConnect):567 (WebCore::WebSocket::didClose):568 * websockets/WebSocket.h:569 Add implement to handle code and reason.570 * websockets/WebSocketChannel.cpp:571 (WebCore::WebSocketChannel::WebSocketChannel):572 (WebCore::WebSocketChannel::didCloseSocketStream):573 (WebCore::WebSocketChannel::processFrame):574 * websockets/WebSocketChannel.h:575 Add closing frame payload parser.576 * websockets/WebSocketChannelClient.h:577 (WebCore::WebSocketChannelClient::didClose):578 * websockets/WorkerThreadableWebSocketChannel.cpp:579 (WebCore::workerContextDidClose):580 (WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):581 * websockets/WorkerThreadableWebSocketChannel.h:582 Add implement to handle code and reason.583 584 2011-08-19 MORITA Hajime <morrita@google.com>585 586 Spell-checking doesn't recognize word boundaries on contests inserted by execCommand('insertHTML')587 https://bugs.webkit.org/show_bug.cgi?id=65902588 589 Reviewed by Ryosuke Niwa.590 591 markMisspellingsAndBadGrammar() was using markSpelling() and markBadGrammar().592 But these are low-level API and caller should take care of word boundary.593 This change replaced these call with overloaded version of markMisspellingsAndBadGrammar(),594 which handles word boundary correctly.595 596 Test: editing/spelling/spelling-insert-html.html597 598 * WebCore.exp.in:599 * editing/Editor.cpp:600 (WebCore::Editor::markMisspellingsAndBadGrammar):601 * testing/Internals.cpp:602 (WebCore::Internals::markerCountOf): Added.603 (WebCore::Internals::markedRangeAt): Added.604 * testing/Internals.h:605 * testing/Internals.idl:606 607 2011-08-19 Nayan Kumar K <nayankk@motorola.com>608 609 Run-time error fix in WebKit-GTK with video support disabled.610 https://bugs.webkit.org/show_bug.cgi?id=66541611 612 Definition of the function extraFullScreenStyleSheet() in webkit-gtk613 lies outside ENABLE(VIDEO) guard, resulting in runtime error while614 trying to launch GtkLauncher with video support disabled.615 616 Reviewed by Philippe Normand.617 618 Run-time error fix. No test cases were added.619 620 * platform/gtk/RenderThemeGtk.h:621 622 2011-08-19 Shinya Kawanaka <shinyak@google.com>623 624 input[maxlength=0] should ignore text input.625 https://bugs.webkit.org/show_bug.cgi?id=65497626 627 Reviewed by Kent Tamura.628 629 Changed the valid range of maxlength.630 631 * html/HTMLInputElement.cpp:632 (WebCore::HTMLInputElement::parseMaxLengthAttribute):633 Changed maxlength check condition.634 635 2011-08-19 Ilya Tikhonovsky <loislo@chromium.org>636 637 Web Inspector: backend js api: an ability to skip optional arguments in the middle of the argument list is required.638 https://bugs.webkit.org/show_bug.cgi?id=66482639 640 There are functions in the API with multiple optional arguments.641 When we call it we have to specify an optional argument as 'undefined' if we want to pass non default value for the next one.642 This can be solved with passing the arguments as an object.643 644 Reviewed by Pavel Feldman.645 646 * inspector/CodeGeneratorInspector.pm:647 * inspector/front-end/RemoteObject.js:648 649 2011-08-19 Zoltan Horvath <zoltan@webkit.org>650 651 [Qt] Build fix after r93384.652 653 * rendering/RenderBlockLineLayout.cpp:654 (WebCore::RenderBlock::LineBreaker::nextLineBreak):655 656 2011-08-18 Shawn Singh <shawnsingh@chromium.org>657 658 Computing screen-space transform for LayerChromium and CCLayerImpl659 https://bugs.webkit.org/show_bug.cgi?id=66114660 661 Added a data member to LayerChromium and CCLayerImpl that holds662 the screen-space transform. The transform is computed in663 calculateDrawTransformsAndVisibility(), which is used during664 updating (LayerChromium) and drawing (CCLayerImpl).665 666 Also fixed a FIXME in LayerRendererChromium::drawLayer, which667 was not computing the entire hierarchy of transforms to determine668 back-face visibility. Now it simply uses the world space transform.669 670 Reviewed by James Robinson.671 672 Test: compositing/backface-visibility-hierarchical-transform.html673 674 * platform/graphics/chromium/LayerChromium.h:675 (WebCore::LayerChromium::screenSpaceTransform):676 (WebCore::LayerChromium::setScreenSpaceTransform):677 * platform/graphics/chromium/LayerRendererChromium.cpp:678 (WebCore::LayerRendererChromium::updateLayers):679 (WebCore::LayerRendererChromium::drawLayersInternal):680 (WebCore::LayerRendererChromium::drawLayer):681 * platform/graphics/chromium/cc/CCLayerImpl.h:682 (WebCore::CCLayerImpl::screenSpaceTransform):683 (WebCore::CCLayerImpl::setScreenSpaceTransform):684 685 2011-08-18 Ben Wells <benwells@chromium.org>686 687 [skia] -webkit-transform breaks -webkit-mask688 https://bugs.webkit.org/show_bug.cgi?id=66442689 690 The problem here is that in RenderBox::paintMaskImages, if we are in691 a transform with a rotation, scale or skew we set the composite mode to692 be DestinationIn and then create a transparency layer, then paint the693 mask with SourceOver and end the transparency layer. (The normal case694 is just to use DestinationIn to paint the mask.)695 696 In skia when we create transparency layers we don't pass on the composite697 mode, so when we end the transparency layer it is composited back using698 SourceOver. The fix is to pass on the composite mode when creating699 transparency layers in skia.700 701 Reviewed by Stephen White.702 703 * platform/graphics/skia/GraphicsContextSkia.cpp:704 (WebCore::GraphicsContext::beginTransparencyLayer):705 * platform/graphics/skia/PlatformContextSkia.cpp:706 (WebCore::PlatformContextSkia::getXfermodeMode):707 * platform/graphics/skia/PlatformContextSkia.h:708 709 2011-08-18 Hayato Ito <hayato@chromium.org>710 711 Isolate EventDispatchMediator into a separate file.712 https://bugs.webkit.org/show_bug.cgi?id=66458713 714 Reviewed by Ryosuke Niwa.715 716 Extracted EventDispatchMediator.h and EventDispatchMediator.cpp717 out of Event.h and Event.cpp Also moved FocusEventDispatchMediator718 and BlurEventDispatchMediator from Event.{h|cpp} to719 EventDispatchMediator.{h|cpp}.720 721 No new tests since this is just refactoring.722 723 * CMakeLists.txt:724 * GNUmakefile.list.am:725 * WebCore.gypi:726 * WebCore.pro:727 * WebCore.vcproj/WebCore.vcproj:728 * WebCore.xcodeproj/project.pbxproj:729 * dom/Event.cpp:730 * dom/Event.h:731 * dom/EventDispatchMediator.cpp: Added.732 (WebCore::EventDispatchMediator::create):733 (WebCore::EventDispatchMediator::EventDispatchMediator):734 (WebCore::EventDispatchMediator::dispatchEvent):735 (WebCore::FocusEventDispatchMediator::create):736 (WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):737 (WebCore::FocusEventDispatchMediator::dispatchEvent):738 (WebCore::BlurEventDispatchMediator::create):739 (WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):740 (WebCore::BlurEventDispatchMediator::dispatchEvent):741 * dom/EventDispatchMediator.h: Added.742 (WebCore::EventDispatchMediator::~EventDispatchMediator):743 (WebCore::EventDispatchMediator::event):744 (WebCore::EventDispatchMediator::EventDispatchMediator):745 (WebCore::EventDispatchMediator::setEvent):746 * dom/EventDispatcher.cpp:747 * dom/KeyboardEvent.h:748 * dom/MouseEvent.h:749 * dom/Node.cpp:750 * dom/ScopedEventQueue.cpp:751 * dom/UIEvent.h:752 * dom/WheelEvent.h:753 754 2011-08-18 Dan Bernstein <mitz@apple.com>755 756 Mid-word break can occur between a character and a combining mark757 https://bugs.webkit.org/show_bug.cgi?id=66529758 759 Reviewed by Simon Fraser.760 761 No test added because I could not find a combining mark with a non-zero advance in762 any of the system fonts and tests fonts.763 764 * rendering/RenderBlockLineLayout.cpp:765 (WebCore::RenderBlock::LineBreaker::nextLineBreak): Disallow a mid-word break before a766 combining mark.767 768 2011-08-18 Kent Tamura <tkent@chromium.org>769 770 REGRESSION(r90971): Null pointer dereference with placeholder and webkit-scrollbar-corner771 https://bugs.webkit.org/show_bug.cgi?id=66453772 773 Reviewed by Simon Fraser.774 775 Test: fast/forms/placeholder-crash-with-scrollbar-corner.html776 777 * rendering/RenderObjectChildList.cpp:778 (WebCore::RenderObjectChildList::removeChildNode): Add a NULL check for owner's layer.779 780 2011-08-18 Jeffrey Pfau <jpfau@apple.com>781 782 New XML parser: scripting support783 https://bugs.webkit.org/show_bug.cgi?id=66406784 785 Reviewed by Adam Barth.786 787 * xml/parser/NewXMLDocumentParser.cpp:788 (WebCore::NewXMLDocumentParser::NewXMLDocumentParser):789 (WebCore::NewXMLDocumentParser::resumeParsing):790 (WebCore::NewXMLDocumentParser::processScript):791 (WebCore::NewXMLDocumentParser::append): Add support for pausing the parsing792 (WebCore::NewXMLDocumentParser::finish): Add support for pausing the parsing793 (WebCore::NewXMLDocumentParser::notifyFinished):794 * xml/parser/NewXMLDocumentParser.h:795 (WebCore::NewXMLDocumentParser::pauseParsing):796 * xml/parser/XMLTreeBuilder.cpp: Add a shared function between self-closing and end tags797 (WebCore::XMLTreeBuilder::closeElement): Registers scripts and pops the stack798 (WebCore::XMLTreeBuilder::processStartTag):799 (WebCore::XMLTreeBuilder::processEndTag):800 * xml/parser/XMLTreeBuilder.h:801 802 2011-08-18 Mark Hahnenberg <mhahnenberg@apple.com>803 804 Move allocation in constructors into separate constructorBody() methods805 https://bugs.webkit.org/show_bug.cgi?id=66265806 807 Reviewed by Oliver Hunt.808 809 No new tests.810 811 Refactoring to put all allocations that need to be done after the object's812 initialization list has executed but before the object is ready for use813 into a separate constructorBody() method. This method is still called by the constructor,814 so the patch doesn't resolve any potential issues, it's just to set up the code for further refactoring.815 816 * bridge/objc/ObjCRuntimeObject.h:817 (JSC::Bindings::ObjCRuntimeObject::create):818 * bridge/objc/ObjCRuntimeObject.mm:819 * bridge/objc/objc_instance.mm:820 (ObjCRuntimeMethod::create):821 (ObjCRuntimeMethod::ObjCRuntimeMethod):822 * bridge/runtime_array.cpp:823 * bridge/runtime_array.h:824 (JSC::RuntimeArray::create):825 826 2011-08-18 Beth Dakin <bdakin@apple.com>827 828 https://bugs.webkit.org/show_bug.cgi?id=66495829 Lion-specific scroller SPIs can use forward declaration instead of830 WebKitSystemInterface831 832 Reviewed by Sam Weinig.833 834 * WebCore.exp.in:835 * WebCore.xcodeproj/project.pbxproj:836 * platform/mac/NSScrollerImpDetails.h: Added.837 * platform/mac/ScrollAnimatorMac.h:838 * platform/mac/ScrollAnimatorMac.mm:839 (-[ScrollbarPainterControllerDelegate scrollerImpPair:convertContentPoint:toScrollerImp:]):840 (-[ScrollbarPainterControllerDelegate scrollerImpPair:updateScrollerStyleForNewRecommendedScrollerStyle:]):841 (-[ScrollbarPartAnimation initWithScrollbarPainter:part:WebCore::scrollAnimator:WebCore::animateAlphaTo:duration:]):842 (-[ScrollbarPartAnimation setCurrentProgress:]):843 (-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):844 (-[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):845 (-[ScrollbarPainterDelegate scrollerImp:animateTrackAlphaTo:duration:]):846 (WebCore::ScrollAnimatorMac::ScrollAnimatorMac):847 (WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):848 (WebCore::ScrollAnimatorMac::notifyPositionChanged):849 (WebCore::ScrollAnimatorMac::contentAreaWillPaint):850 (WebCore::ScrollAnimatorMac::mouseEnteredContentArea):851 (WebCore::ScrollAnimatorMac::mouseExitedContentArea):852 (WebCore::ScrollAnimatorMac::mouseMovedInContentArea):853 (WebCore::ScrollAnimatorMac::willStartLiveResize):854 (WebCore::ScrollAnimatorMac::contentsResized):855 (WebCore::ScrollAnimatorMac::willEndLiveResize):856 (WebCore::ScrollAnimatorMac::contentAreaDidShow):857 (WebCore::ScrollAnimatorMac::contentAreaDidHide):858 (WebCore::ScrollAnimatorMac::didBeginScrollGesture):859 (WebCore::ScrollAnimatorMac::didEndScrollGesture):860 (WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):861 (WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):862 (WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):863 (WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):864 (WebCore::ScrollAnimatorMac::updateScrollerStyle):865 (WebCore::ScrollAnimatorMac::initialScrollbarPaintTimerFired):866 * platform/mac/ScrollbarThemeMac.h:867 * platform/mac/ScrollbarThemeMac.mm:868 (WebCore::ScrollbarThemeMac::registerScrollbar):869 (WebCore::ScrollbarThemeMac::scrollbarThickness):870 (WebCore::ScrollbarThemeMac::usesOverlayScrollbars):871 (WebCore::ScrollbarThemeMac::updateScrollbarOverlayStyle):872 (WebCore::ScrollbarThemeMac::hasThumb):873 (WebCore::ScrollbarThemeMac::minimumThumbLength):874 (WebCore::ScrollbarThemeMac::updateEnabledState):875 (WebCore::scrollbarPainterPaint):876 (WebCore::ScrollbarThemeMac::paint):877 * platform/mac/WebCoreSystemInterface.h:878 * platform/mac/WebCoreSystemInterface.mm:879 880 2011-08-18 Dan Bernstein <mitz@apple.com>881 882 <rdar://problem/9973194> Fonts that specify a positive descender value are treated as having descenders ending above the baseline883 https://bugs.webkit.org/show_bug.cgi?id=66515884 885 Reviewed by Darin Adler.886 887 No test because none of the system fonts and test fonts have an incorrectly-specified descender value.888 889 * platform/graphics/mac/SimpleFontDataMac.mm:890 (WebCore::SimpleFontData::platformInit): If the font specifies a positive descender, assume that it meant891 the same amount, but negative. This is consistent with what Core Text does.892 893 2011-08-18 Ryosuke Niwa <rniwa@webkit.org>894 895 positionForPoint returns wrong VisiblePosition at bidi boundaries896 https://bugs.webkit.org/show_bug.cgi?id=65356897 898 Reviewed by David Hyatt.899 900 The bug was caused by RenderText::positionForPoint's assuming that the position will always reside901 inside the inline box that contains the point, which is not true at the boundaries of bidi-runs.902 903 For example, in aDC12BAb where AB12CD is a RTL text, the offset on the right of A is 7 even though904 the inline box for "BA" only contains offsets 1, 2, and 3. We must traverse the bidi-run "DC12BA"905 until the end to obtain the offset 7 from the inline box for "DC".906 907 Fixed the bug by introducing createVisiblePositionAfterAdjustingOffsetForBiDi which traverses runs908 on the left or the right of the position to compute the appropriate offset following the NSTextView convention.909 910 This patch also fixes a regression from r74971 that caret is placed incorrectly between inline boxes of911 LTR or RTL text in a RTL or LTR block respectively.912 913 Test: editing/selection/caret-at-bidi-boundary.html914 915 * rendering/InlineTextBox.cpp:916 (WebCore::InlineTextBox::offsetForPosition):917 * rendering/RenderText.cpp:918 (WebCore::lineDirectionPointFitsInBox): Takes ShouldAffinityBeDownstream instead of EAfinity.919 (WebCore::createVisiblePositionForBox):920 (WebCore::createVisiblePositionAfterAdjustingOffsetForBiDi):921 (WebCore::RenderText::positionForPoint):922 923 2011-08-18 Xiaomei Ji <xji@chromium.org>924 925 --webkit-visual-word renaming right/leftWordPositionAcrossBoundary926 https://bugs.webkit.org/show_bug.cgi?id=66436927 928 Reviewed by Ryosuke Niwa.929 930 Rename them to right/leftWordPositionIgnoringEditingBoundary.931 932 * editing/visible_units.cpp:933 (WebCore::leftWordPositionIgnoringEditingBoundary):934 (WebCore::rightWordPositionIgnoringEditingBoundary):935 (WebCore::leftWordPosition):936 (WebCore::rightWordPosition):937 938 2011-08-18 Jeff Miller <jeffm@apple.com>939 940 Soft link against AVFoundationCF and CoreMedia941 https://bugs.webkit.org/show_bug.cgi?id=65725942 943 Add new macros to SoftLinking.h to support soft-linking to functions and variables decorated with __declspec(dllimport),944 and use them to soft-link to AVFoundationCF and CoreMedia. I verified that the WebProcess doesn't load these DLLs945 until a media element is used.946 947 Reviewed by Eric Carlson.948 949 No new tests as no change in functionality.950 951 * WebCore.vcproj/WebCore.vcproj: Added AVFoundationCFSoftLinking.h and CoreMediaSoftLinking.h.952 * WebCore.vcproj/WebCoreMediaQT.vsprops: Removed DelayLoadDLLs linker option which is no longer needed.953 * platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h: Added.954 * platform/graphics/avfoundation/cf/CoreMediaSoftLinking.h: Added.955 * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: Stop linking against AVFoundationCF.lib and CoreMedia.lib and include AVFoundationCFSoftLinking.h and CoreMediaSoftLinking.h.956 * platform/win/SoftLinking.h: Added SOFT_LINK_DLL_IMPORT() and SOFT_LINK_VARIABLE_DLL_IMPORT() macros.957 958 2011-08-18 Sailesh Agrawal <sail@chromium.org>959 960 Chromium Mac: Show scrollbar when doing search961 https://bugs.webkit.org/show_bug.cgi?id=66209962 963 Reviewed by James Robinson.964 965 Updated the Lion scrollbar drawing code to force the scrollbar to be visible when we have tickmarks for search results.966 967 No tests because there are no Mac 10.7 chromium bots yet.968 969 * platform/chromium/ScrollbarThemeChromiumMac.h:970 * platform/chromium/ScrollbarThemeChromiumMac.mm:971 (WebCore::ScrollbarThemeChromiumMac::paint):972 (WebCore::ScrollbarThemeChromiumMac::paintTickmarks):973 974 2011-08-18 James Robinson <jamesr@chromium.org>975 976 [chromium] Draw the root/"non-composited content" in compositor side977 https://bugs.webkit.org/show_bug.cgi?id=58834978 979 Reviewed by Kenneth Russell.980 981 Handle the root or non-composited content with a GraphicsLayer rather than special case logic in982 LayerRendererChromium. This layer's client is the NonCompositedContentHost, which routes the paint callbacks983 through the LayerPainterChromium interface out to the WebView. The root layer is special in two ways:984 *) The root layer has a scroll offset, which changes how the visibleLayerRect maps to content space and applies a985 draw-time transform.986 *) The root layer masks the alpha channel and disable blending when drawing because of concerns about subpixel987 AA trashing the alpha channel. The root layer is always opaque so this is fine.988 *) The root layer does not have border texels and does have subpixel AA for text.989 990 Covered by compositing/991 992 * WebCore.gypi:993 * platform/graphics/chromium/ContentLayerChromium.cpp:994 (WebCore::ContentLayerChromium::paintContentsIfDirty):995 * platform/graphics/chromium/ImageLayerChromium.cpp:996 (WebCore::ImageLayerChromium::paintContentsIfDirty):997 * platform/graphics/chromium/LayerChromium.cpp:998 (WebCore::LayerChromium::pushPropertiesTo):999 * platform/graphics/chromium/LayerChromium.h:1000 (WebCore::LayerChromium::scrollPosition):1001 (WebCore::LayerChromium::setScrollPosition):1002 * platform/graphics/chromium/LayerRendererChromium.cpp:1003 (WebCore::LayerRendererChromium::initialize):1004 (WebCore::LayerRendererChromium::releaseTextures):1005 (WebCore::LayerRendererChromium::viewportChanged):1006 (WebCore::LayerRendererChromium::updateLayers):1007 (WebCore::LayerRendererChromium::drawLayers):1008 (WebCore::LayerRendererChromium::drawLayersInternal):1009 (WebCore::LayerRendererChromium::getFramebufferPixels):1010 (WebCore::LayerRendererChromium::cleanupSharedObjects):1011 (WebCore::LayerRendererChromium::layerTreeAsText):1012 * platform/graphics/chromium/LayerRendererChromium.h:1013 (WebCore::LayerRendererChromium::rootLayer):1014 (WebCore::LayerRendererChromium::viewportSize):1015 (WebCore::LayerRendererChromium::viewportWidth):1016 (WebCore::LayerRendererChromium::viewportHeight):1017 * platform/graphics/chromium/NonCompositedContentHost.cpp: Added.1018 (WebCore::NonCompositedContentHost::NonCompositedContentHost):1019 (WebCore::NonCompositedContentHost::~NonCompositedContentHost):1020 (WebCore::NonCompositedContentHost::invalidateRect):1021 (WebCore::NonCompositedContentHost::invalidateEntireLayer):1022 (WebCore::NonCompositedContentHost::setScrollPosition):1023 (WebCore::NonCompositedContentHost::notifyAnimationStarted):1024 (WebCore::NonCompositedContentHost::notifySyncRequired):1025 (WebCore::NonCompositedContentHost::paintContents):1026 (WebCore::NonCompositedContentHost::showDebugBorders):1027 (WebCore::NonCompositedContentHost::showRepaintCounter):1028 * platform/graphics/chromium/NonCompositedContentHost.h: Added.1029 (WebCore::NonCompositedContentHost::create):1030 (WebCore::NonCompositedContentHost::graphicsLayer):1031 * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:1032 (WebCore::CCHeadsUpDisplay::draw):1033 * platform/graphics/chromium/cc/CCLayerImpl.h:1034 (WebCore::CCLayerImpl::scrollPosition):1035 (WebCore::CCLayerImpl::setScrollPosition):1036 * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:1037 (WebCore::CCLayerTreeHost::CCLayerTreeHost):1038 (WebCore::CCLayerTreeHost::initialize):1039 (WebCore::CCLayerTreeHost::invalidateRootLayerRect):1040 (WebCore::CCLayerTreeHost::setRootLayer):1041 (WebCore::CCLayerTreeHost::setViewport):1042 (WebCore::CCLayerTreeHost::reallocateRenderer):1043 * platform/graphics/chromium/cc/CCLayerTreeHost.h:1044 (WebCore::CCLayerTreeHost::rootLayer):1045 (WebCore::CCLayerTreeHost::viewportSize):1046 1047 2011-08-18 Sheriff Bot <webkit.review.bot@gmail.com>1048 1049 Unreviewed, rolling out r93354.1050 http://trac.webkit.org/changeset/933541051 https://bugs.webkit.org/show_bug.cgi?id=665031052 1053 "consensus was not reached" (Requested by senorblanco on1054 #webkit).1055 1056 * html/canvas/CanvasRenderingContext2D.cpp:1057 (WebCore::CanvasRenderingContext2D::drawImage):1058 * platform/graphics/cg/GraphicsContextCG.cpp:1059 (WebCore::GraphicsContext::drawNativeImage):1060 1061 2011-08-18 Sadrul Habib Chowdhury <sadrul@chromium.org>1062 1063 GestureRecognizer: Update how gesture-scroll works.1064 1065 Instead of just sending a series of 'GestureUpdate' events, send a1066 single 'GestureBegin' event, followed by a series of 'GestureUpdate' events,1067 and end with a 'GestureEnd' event.1068 https://bugs.webkit.org/show_bug.cgi?id=662671069 1070 Reviewed by Adam Barth.1071 1072 * page/EventHandler.cpp:1073 (WebCore::EventHandler::handleGestureEvent):1074 * platform/chromium/GestureRecognizerChromium.cpp:1075 (WebCore::InnerGestureRecognizer::InnerGestureRecognizer):1076 (WebCore::InnerGestureRecognizer::appendScrollGestureBegin):1077 (WebCore::InnerGestureRecognizer::appendScrollGestureEnd):1078 (WebCore::InnerGestureRecognizer::appendScrollGestureUpdate):1079 (WebCore::scrollEnd):1080 (WebCore::isClickOrScroll):1081 (WebCore::inScroll):1082 * platform/chromium/GestureRecognizerChromium.h:1083 (WebCore::InnerGestureRecognizer::firstTouchPosition):1084 1085 2011-08-18 Sailesh Agrawal <sail@chromium.org>1086 1087 Chromium: Update forked ScrollbarThemeChromiumMac.mm1088 https://bugs.webkit.org/show_bug.cgi?id=655551089 1090 Reviewed by James Robinson.1091 1092 Merge recent changes to ScrollbarThemeMac.mm to ScrollbarThemeChromiumMac.mm.1093 1094 * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:1095 * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:1096 (wkScrollbarPainterSetEnabled):1097 * platform/chromium/ScrollbarThemeChromiumMac.h:1098 (WebCore::ScrollbarThemeChromiumMac::maxOverlapBetweenPages):1099 * platform/chromium/ScrollbarThemeChromiumMac.mm:1100 (WebCore::ScrollbarThemeChromiumMac::registerScrollbar):1101 (WebCore::ScrollbarThemeChromiumMac::setNewPainterForScrollbar):1102 (WebCore::toScrollbarPainterKnobStyle):1103 (WebCore::ScrollbarThemeChromiumMac::updateScrollbarOverlayStyle):1104 (WebCore::ScrollbarThemeChromiumMac::updateEnabledState):1105 (WebCore::ScrollbarThemeChromiumMac::paint):1106 1107 2011-08-18 Justin Novosad <junov@chromium.org>1108 1109 Unwarranted DOM Exception when when canvas2D drawImage is called with src1110 rect out of bounds1111 https://bugs.webkit.org/show_bug.cgi?id=657091112 1113 Reviewed by Stephen White.1114 1115 Test: fast/canvas/drawImage-clipped-source.html1116 1117 * html/canvas/CanvasRenderingContext2D.cpp:1118 (WebCore::CanvasRenderingContext2D::drawImage):1119 Removed the unnecessary dom exceptions for out of bounds source rectangles1120 The overloads that receive video and image elements as source images1121 now use the normalized versions of the source rectangle, which1122 GraphicsContext (and its various platform flavors) can handle correctly.1123 The normalized rectangle is the equivalent rectangle with width and height1124 greater than 0. The canvas version of this method, which had better layout1125 test coverage, was already correctly using the normalized rectangle. The1126 newly added layout test verifies correct behavior with negative1127 source rectangle dimensions.1128 * platform/graphics/cg/GraphicsContextCG.cpp:1129 (WebCore::GraphicsContext::drawNativeImage):1130 Fixed algorithm that adjusts the destination rectangle to match the clipping1131 applied to the source rect. The case of scaled filtered images with source1132 rectangles that overlap the edge of the image was not being handled1133 correctly. This use case was previously unsupported and used to trigger1134 a DOM exception.1135 1136 2011-08-18 Sheriff Bot <webkit.review.bot@gmail.com>1137 1138 Unreviewed, rolling out r93329.1139 http://trac.webkit.org/changeset/933291140 https://bugs.webkit.org/show_bug.cgi?id=664971141 1142 Turned text on chromium win blue (Requested by jamesr_ on1143 #webkit).1144 1145 * WebCore.gypi:1146 * platform/graphics/chromium/ContentLayerChromium.cpp:1147 * platform/graphics/chromium/ContentLayerChromium.h:1148 * platform/graphics/chromium/ImageLayerChromium.cpp:1149 (WebCore::ImageLayerTextureUpdater::prepareToUpdate):1150 * platform/graphics/chromium/LayerChromium.cpp:1151 (WebCore::LayerChromium::LayerChromium):1152 (WebCore::LayerChromium::pushPropertiesTo):1153 (WebCore::LayerChromium::dumpLayerProperties):1154 * platform/graphics/chromium/LayerChromium.h:1155 * platform/graphics/chromium/LayerRendererChromium.cpp:1156 (WebCore::LayerRendererChromium::initialize):1157 (WebCore::LayerRendererChromium::releaseTextures):1158 (WebCore::LayerRendererChromium::updateRootLayerContents):1159 (WebCore::LayerRendererChromium::drawRootLayer):1160 (WebCore::LayerRendererChromium::invalidateRootLayerRect):1161 (WebCore::LayerRendererChromium::rootLayerChanged):1162 (WebCore::LayerRendererChromium::viewportChanged):1163 (WebCore::LayerRendererChromium::updateLayers):1164 (WebCore::LayerRendererChromium::drawLayers):1165 (WebCore::LayerRendererChromium::paintLayerContents):1166 (WebCore::LayerRendererChromium::drawLayersInternal):1167 (WebCore::LayerRendererChromium::getFramebufferPixels):1168 (WebCore::LayerRendererChromium::cleanupSharedObjects):1169 (WebCore::LayerRendererChromium::layerTreeAsText):1170 (WebCore::LayerRendererChromium::dumpRenderSurfaces):1171 * platform/graphics/chromium/LayerRendererChromium.h:1172 (WebCore::LayerRendererChromium::rootLayer):1173 * platform/graphics/chromium/NonCompositedContentHost.cpp: Removed.1174 * platform/graphics/chromium/NonCompositedContentHost.h: Removed.1175 * platform/graphics/chromium/RenderSurfaceChromium.cpp:1176 (WebCore::RenderSurfaceChromium::dumpSurface):1177 * platform/graphics/chromium/TiledLayerChromium.cpp:1178 (WebCore::TiledLayerChromium::createTilerIfNeeded):1179 (WebCore::TiledLayerChromium::tilingTransform):1180 * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:1181 (WebCore::CCHeadsUpDisplay::draw):1182 * platform/graphics/chromium/cc/CCLayerImpl.cpp:1183 (WebCore::CCLayerImpl::CCLayerImpl):1184 * platform/graphics/chromium/cc/CCLayerImpl.h:1185 * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:1186 (WebCore::CCLayerTreeHost::CCLayerTreeHost):1187 (WebCore::CCLayerTreeHost::initialize):1188 (WebCore::CCLayerTreeHost::createRootLayerPainter):1189 (WebCore::CCLayerTreeHost::invalidateRootLayerRect):1190 (WebCore::CCLayerTreeHost::setRootLayer):1191 (WebCore::CCLayerTreeHost::setViewport):1192 (WebCore::CCLayerTreeHost::reallocateRenderer):1193 * platform/graphics/chromium/cc/CCLayerTreeHost.h:1194 (WebCore::CCLayerTreeHost::rootLayer):1195 (WebCore::CCLayerTreeHost::viewportContentRect):1196 (WebCore::CCLayerTreeHost::viewportScrollPosition):1197 (WebCore::CCLayerTreeHost::viewportVisibleRect):1198 * platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:1199 (WebCore::CCTiledLayerImpl::draw):1200 1201 2011-08-18 Ryosuke Niwa <rniwa@webkit.org>1202 1203 SimplifiedBackwardsTextIterator returns incorrect offset with first-letter rule1204 https://bugs.webkit.org/show_bug.cgi?id=660861205 1206 Reviewed by Darin Adler.1207 1208 The bug was caused by SimplifiedBackwardsTextIterator's not taking care of first-letter at all.1209 Fixing the bug by detecting RenderTextFragment in handleTextNode.1210 1211 Also added m_shouldHandleFirstLetter to SimplifiedBackwardsTextIterator to keep track of whether or not1212 the next call to handleTextNode needs to process the first-letter part of the text fragment.1213 1214 Test: editing/text-iterator/backward-textiterator-first-letter-crash.html1215 1216 * editing/TextIterator.cpp:1217 (WebCore::firstRenderTextInFirstLetter): Extracted from handleTextNodeFirstLetter.1218 (WebCore::TextIterator::handleTextNodeFirstLetter): Calls firstRenderTextInFirstLetter.1219 (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):1220 (WebCore::SimplifiedBackwardsTextIterator::handleTextNode):1221 (WebCore::SimplifiedBackwardsTextIterator::handleFirstLetter): Added.1222 * editing/TextIterator.h:1223 1224 2011-08-18 Iain Merrick <husky@google.com>1225 1226 [chromium] Assert that main thread and compositor thread are used safely1227 https://bugs.webkit.org/show_bug.cgi?id=661451228 1229 CCLayerTreeHostImplProxy now has public static methods isMainThread()1230 and isImplThread(), and we ASSERT these in various places. If threaded1231 compositing is disabled, we fake isImplThread() by setting a flag for1232 the duration of compositing, so the assert is still valid.1233 1234 Reviewed by James Robinson.1235 1236 Covered by existing tests.1237 1238 * platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:1239 (WebCore::CCCanvasLayerImpl::draw):1240 * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:1241 (WebCore::CCLayerTreeHost::doComposite):1242 * platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp:1243 (WebCore::CCLayerTreeHostImplProxy::postDrawLayersTaskOnCCThread):1244 (WebCore::CCLayerTreeHostImplProxy::requestFrameAndCommitOnCCThread):1245 (WebCore::CCLayerTreeHostImplProxy::isMainThread):1246 (WebCore::CCLayerTreeHostImplProxy::isImplThread):1247 (WebCore::CCLayerTreeHostImplProxy::setImplThread):1248 (WebCore::CCLayerTreeHostImplProxy::commitOnCCThread):1249 (WebCore::CCLayerTreeHostImplProxy::drawLayersOnCCThread):1250 (WebCore::CCLayerTreeHostImplProxy::setNeedsCommitAndRedrawOnCCThread):1251 (WebCore::CCLayerTreeHostImplProxy::setNeedsRedrawOnCCThread):1252 (WebCore::CCLayerTreeHostImplProxy::initImplOnCCThread):1253 (WebCore::CCLayerTreeHostImplProxy::layerTreeHostClosedOnCCThread):1254 * platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.h:1255 * platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:1256 (WebCore::CCPluginLayerImpl::draw):1257 * platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:1258 (WebCore::CCTiledLayerImpl::draw):1259 * platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:1260 (WebCore::CCVideoLayerImpl::draw):1261 1262 2011-08-18 Alexey Proskuryakov <ap@apple.com>1263 1264 Regional indicator symbols that are combined should behave as a single character when editing1265 https://bugs.webkit.org/show_bug.cgi?id=653951266 1267 Reviewed by Dan Bernstein.1268 1269 Part two: make cursor movement iterator work. This fixes the problem for strings that don't1270 contain more than two flags in a row, as fixing it completely doesn't seem possible with ICU.1271 1272 Test: editing/selection/regional-indicators.html1273 1274 * platform/text/TextBreakIteratorICU.cpp: (WebCore::cursorMovementIterator): Added custom1275 rules for regional indicator symbols.1276 1277 2011-08-18 Cary Clark <caryclark@google.com>1278 1279 Fix rubber band gutter drawing for Skia on Chromium Mac1280 https://bugs.webkit.org/show_bug.cgi?id=664781281 1282 Reviewed by James Robinson.1283 1284 No new tests. The Skia on Chromium Mac platform has1285 not been enabled.1286 1287 This break was detected at compile time; there is no1288 behavior change.1289 1290 * platform/chromium/ScrollbarThemeChromiumMac.mm:1291 (WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):1292 Convert the CGImage into an SkBitmap if Skia is present.1293 1294 2011-08-18 Julien Chaffraix <jchaffraix@webkit.org>1295 1296 Implement a faster path for painting tables with overflowing cells1297 https://bugs.webkit.org/show_bug.cgi?id=654911298 1299 This change introduces a smarter way of painting if the table is big enough and we have a small amount1300 of overflowing cells in the table. The new path does a binary search of the cells to repaint but adds1301 the overflowing cells to the repainting cells.1302 1303 This saves ~50% when doing programmatic scrolling throught JS on a 500x100 table with some overflowing1304 cells. Also we cap the memory usage to a ratio of the total size of the table to avoid blowing up the1305 memory.1306 1307 Reviewed by David Hyatt.1308 1309 No new tests as the behavior should be the same.1310 1311 * rendering/RenderTableSection.cpp:1312 (WebCore::RenderTableSection::RenderTableSection):1313 (WebCore::RenderTableSection::layoutRows): Added some code to accumulate the overflowing cells1314 in an internal HashSet (we don't need to keep them sorted and it makes it easier to use them during1315 painting). If we hit the cap, flip the boolean value and clear the HashSet as the slow path does not1316 care about the cell's information. Make sure that the "has overflowing cells" information is still1317 properly encoded on our 2 values.1318 1319 (WebCore::compareCellPositionsWithOverflowingCells): Added this method as we are doing a more1320 complicated sort:1321 * the old path would sort one (mostly sorted) array by rows only as the stable sort would1322 take care of keeping the column ordering inside a row.1323 * the new path basically has to sort an unsorted array (taken partly from the HashSet).1324 1325 (WebCore::RenderTableSection::paintObject): Tweaked the logic to account for difference between1326 m_forceSlowPaintPathWithOverflowingCell and has some overflowing cells. Also we make sure we don't1327 repaint the same cell twice.1328 1329 (WebCore::RenderTableSection::nodeAtPoint): Changed to hasOverflowingCell(). We don't apply our1330 fast path optimization here.1331 1332 * rendering/RenderTableSection.h: Transformed our original boolean into1333 a HashSet and a boolean. The HashSet holds up the CellStruct that are overflowing1334 until we reach the memory threshold. After this is hit, we just set the boolean1335 to avoid using too much memory.1336 1337 (WebCore::RenderTableSection::hasOverflowingCell): This is the new way to determine1338 if we have any overflowing cell, used only for hit testing.1339 1340 2011-08-18 Kentaro Hara <haraken@google.com>1341 1342 An EventSource constructor should throw TypeError, when the number of arguments is not enough.1343 https://bugs.webkit.org/show_bug.cgi?id=664541344 1345 Reviewed by Adam Barth.1346 1347 The spec is here: http://www.w3.org/TR/WebIDL/#es-operations.1348 1349 Test: fast/eventsource/eventsource-constructor.html1350 1351 * bindings/js/JSEventSourceCustom.cpp:1352 (WebCore::JSEventSourceConstructor::constructJSEventSource): Changed SyntaxError to TypeError.1353 * bindings/v8/custom/V8EventSourceConstructor.cpp:1354 (WebCore::V8EventSource::constructorCallback): Changed SyntaxError to TypeError.1355 1356 2011-08-18 Kentaro Hara <haraken@google.com>1357 1358 A SharedWorker constructor should throw TypeError, when the number of arguments is not enough.1359 https://bugs.webkit.org/show_bug.cgi?id=664551360 1361 Reviewed by Adam Barth.1362 1363 The spec is here: http://www.w3.org/TR/WebIDL/#es-operations.1364 1365 Test: fast/workers/shared-worker-constructor.html1366 1367 * bindings/js/JSSharedWorkerCustom.cpp:1368 (WebCore::JSSharedWorkerConstructor::constructJSSharedWorker): Changed SyntaxError to TypeError.1369 * bindings/v8/custom/V8SharedWorkerCustom.cpp:1370 (WebCore::V8SharedWorker::constructorCallback): Changed SyntaxError to TypeError.1371 1372 2011-08-17 Alejandro G. Castro <alex@igalia.com>1373 1374 [GTK] Fix compilation problems with deprecations in gtk+1375 https://bugs.webkit.org/show_bug.cgi?id=660731376 1377 Reviewed by Martin Robinson.1378 1379 * platform/gtk/GtkAuthenticationDialog.cpp:1380 (WebCore::GtkAuthenticationDialog::GtkAuthenticationDialog): Added1381 gtk_box_new conditional compilation for gtk+-3.1382 * platform/gtk/RenderThemeGtk3.cpp:1383 (WebCore::RenderThemeGtk::adjustRepaintRect):1384 (WebCore::RenderThemeGtk::paintSliderTrack):1385 (WebCore::RenderThemeGtk::paintSliderThumb):1386 (WebCore::RenderThemeGtk::adjustSliderThumbSize): Now we have have1387 GTK_TYPE_SCALE in gtk+3.1388 1389 2011-08-18 Kentaro Hara <haraken@google.com>1390 1391 A Worker constructor should throw TypeError, when the number of arguments is not enough1392 https://bugs.webkit.org/show_bug.cgi?id=664561393 1394 Reviewed by Adam Barth.1395 1396 Spec is here: http://www.w3.org/TR/WebIDL/#es-operations.1397 1398 Test: fast/workers/worker-constructor.html1399 1400 * bindings/js/JSWorkerCustom.cpp:1401 (WebCore::JSWorkerConstructor::constructJSWorker): Changed SyntaxError to TypeError.1402 * bindings/v8/custom/V8WorkerCustom.cpp:1403 (WebCore::V8Worker::constructorCallback): Changed SyntaxError to TypeError.1404 1405 2011-08-18 John Bates <jbates@google.com>1406 1407 Fix logic error causing reverse of desired WebGL rate limiting behavior1408 https://bugs.webkit.org/show_bug.cgi?id=664451409 1410 Reviewed by Kenneth Russell.1411 1412 * platform/graphics/chromium/WebGLLayerChromium.cpp:1413 (WebCore::WebGLLayerChromium::setTextureUpdated):1414 1415 2011-08-18 Levi Weintraub <leviw@chromium.org>1416 1417 Switch RenderTextControl* to new layout types1418 https://bugs.webkit.org/show_bug.cgi?id=662501419 1420 Reviewed by Eric Seidel.1421 1422 Convertikng the RenderTextControl* classes to use the LayoutUnit abstraction.1423 1424 No new tests as no change in behavior.1425 1426 * rendering/LayoutTypes.h:1427 (WebCore::layoutMod): Added a function to perform the modulo operation on LayoutUnits.1428 * rendering/RenderTextControl.cpp:1429 (WebCore::RenderTextControl::hitInnerTextElement):1430 * rendering/RenderTextControl.h:1431 * rendering/RenderTextControlMultiLine.cpp:1432 (WebCore::RenderTextControlMultiLine::preferredContentWidth):1433 (WebCore::RenderTextControlMultiLine::baselinePosition):1434 * rendering/RenderTextControlMultiLine.h:1435 * rendering/RenderTextControlSingleLine.cpp:1436 (WebCore::RenderTextControlSingleLine::layout):1437 (WebCore::RenderTextControlSingleLine::controlClipRect):1438 (WebCore::RenderTextControlSingleLine::preferredContentWidth):1439 (WebCore::RenderTextControlSingleLine::scrollWidth):1440 (WebCore::RenderTextControlSingleLine::scrollHeight):1441 (WebCore::RenderTextControlSingleLine::scrollLeft):1442 (WebCore::RenderTextControlSingleLine::scrollTop):1443 (WebCore::RenderTextControlSingleLine::setScrollLeft):1444 (WebCore::RenderTextControlSingleLine::setScrollTop):1445 * rendering/RenderTextControlSingleLine.h:1446 1447 2011-08-18 Levi Weintraub <leviw@chromium.org>1448 1449 Switch Inline rendering classes to new layout types1450 https://bugs.webkit.org/show_bug.cgi?id=662391451 1452 Reviewed by Eric Seidel.1453 1454 Converting inline rendering classes to use the LayoutUnit abstraction from ints.1455 1456 No new tests as no change in functionality.1457 1458 * rendering/InlineBox.h:1459 (WebCore::InlineBox::logicalFrameRect):1460 (WebCore::InlineBox::baselinePosition):1461 (WebCore::InlineBox::lineHeight):1462 * rendering/InlineFlowBox.h:1463 * rendering/InlineTextBox.cpp:1464 (WebCore::InlineTextBox::logicalOverflowRect):1465 (WebCore::InlineTextBox::setLogicalOverflowRect):1466 (WebCore::InlineTextBox::baselinePosition):1467 (WebCore::InlineTextBox::lineHeight):1468 * rendering/InlineTextBox.h:1469 (WebCore::InlineTextBox::logicalTopVisualOverflow):1470 (WebCore::InlineTextBox::logicalBottomVisualOverflow):1471 (WebCore::InlineTextBox::logicalLeftVisualOverflow):1472 (WebCore::InlineTextBox::logicalRightVisualOverflow):1473 * rendering/RenderInline.cpp:1474 (WebCore::RenderInline::culledInlineAbsoluteRects):1475 (WebCore::computeMargin):1476 (WebCore::RenderInline::culledInlineBoundingBox):1477 (WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):1478 (WebCore::RenderInline::linesVisualOverflowBoundingBox):1479 (WebCore::RenderInline::clippedOverflowRectForRepaint):1480 (WebCore::RenderInline::rectWithOutlineForRepaint):1481 (WebCore::RenderInline::computeRectForRepaint):1482 (WebCore::RenderInline::mapLocalToContainer):1483 (WebCore::RenderInline::lineHeight):1484 (WebCore::RenderInline::baselinePosition):1485 (WebCore::RenderInline::addDashboardRegions):1486 * rendering/RenderInline.h:1487 1488 2011-08-18 Jeffrey Pfau <jpfau@apple.com>1489 1490 New XML parser: add doctype to DOM tree1491 https://bugs.webkit.org/show_bug.cgi?id=664081492 1493 Reviewed by Adam Barth.1494 1495 * xml/parser/XMLTreeBuilder.cpp:1496 (WebCore::XMLTreeBuilder::processDOCTYPE):1497 1498 2011-08-18 James Robinson <jamesr@chromium.org>1499 1500 [chromium] Draw the root/"non-composited content" in compositor side1501 https://bugs.webkit.org/show_bug.cgi?id=588341502 1503 Reviewed by Darin Fisher.1504 1505 Handle the root or non-composited content with a GraphicsLayer rather than special case logic in1506 LayerRendererChromium. This layer's client is the NonCompositedContentHost, which routes the paint callbacks1507 through the LayerPainterChromium interface out to the WebView. The root layer is special in two ways:1508 *) The root layer has a scroll offset, which changes how the visibleLayerRect maps to content space and applies a1509 draw-time transform.1510 *) The root layer masks the alpha channel when drawing because of concerns about subpixel AA trashing the alpha1511 channel. The root layer is always opaque so this is fine.1512 *) The root layer does not have border texels and does have subpixel AA for text.1513 1514 Covered by compositing/1515 1516 * WebCore.gypi:1517 * platform/graphics/chromium/ContentLayerChromium.cpp:1518 (WebCore::ContentLayerChromium::paintContentsIfDirty):1519 * platform/graphics/chromium/ImageLayerChromium.cpp:1520 (WebCore::ImageLayerChromium::paintContentsIfDirty):1521 * platform/graphics/chromium/LayerChromium.cpp:1522 (WebCore::LayerChromium::pushPropertiesTo):1523 * platform/graphics/chromium/LayerChromium.h:1524 (WebCore::LayerChromium::scrollPosition):1525 (WebCore::LayerChromium::setScrollPosition):1526 * platform/graphics/chromium/LayerRendererChromium.cpp:1527 (WebCore::LayerRendererChromium::initialize):1528 (WebCore::LayerRendererChromium::releaseTextures):1529 (WebCore::LayerRendererChromium::viewportChanged):1530 (WebCore::LayerRendererChromium::updateLayers):1531 (WebCore::LayerRendererChromium::drawLayers):1532 (WebCore::LayerRendererChromium::drawLayersInternal):1533 (WebCore::LayerRendererChromium::getFramebufferPixels):1534 (WebCore::LayerRendererChromium::cleanupSharedObjects):1535 (WebCore::LayerRendererChromium::layerTreeAsText):1536 * platform/graphics/chromium/LayerRendererChromium.h:1537 (WebCore::LayerRendererChromium::rootLayer):1538 (WebCore::LayerRendererChromium::viewportSize):1539 (WebCore::LayerRendererChromium::viewportWidth):1540 (WebCore::LayerRendererChromium::viewportHeight):1541 * platform/graphics/chromium/NonCompositedContentHost.cpp: Added.1542 (WebCore::NonCompositedContentHost::NonCompositedContentHost):1543 (WebCore::NonCompositedContentHost::~NonCompositedContentHost):1544 (WebCore::NonCompositedContentHost::invalidateRect):1545 (WebCore::NonCompositedContentHost::invalidateEntireLayer):1546 (WebCore::NonCompositedContentHost::setScrollPosition):1547 (WebCore::NonCompositedContentHost::notifyAnimationStarted):1548 (WebCore::NonCompositedContentHost::notifySyncRequired):1549 (WebCore::NonCompositedContentHost::paintContents):1550 (WebCore::NonCompositedContentHost::showDebugBorders):1551 (WebCore::NonCompositedContentHost::showRepaintCounter):1552 * platform/graphics/chromium/NonCompositedContentHost.h: Added.1553 (WebCore::NonCompositedContentHost::create):1554 (WebCore::NonCompositedContentHost::graphicsLayer):1555 * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:1556 (WebCore::CCHeadsUpDisplay::draw):1557 * platform/graphics/chromium/cc/CCLayerImpl.h:1558 (WebCore::CCLayerImpl::scrollPosition):1559 (WebCore::CCLayerImpl::setScrollPosition):1560 * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:1561 (WebCore::CCLayerTreeHost::CCLayerTreeHost):1562 (WebCore::CCLayerTreeHost::initialize):1563 (WebCore::CCLayerTreeHost::invalidateRootLayerRect):1564 (WebCore::CCLayerTreeHost::setRootLayer):1565 (WebCore::CCLayerTreeHost::setViewport):1566 (WebCore::CCLayerTreeHost::reallocateRenderer):1567 * platform/graphics/chromium/cc/CCLayerTreeHost.h:1568 (WebCore::CCLayerTreeHost::rootLayer):1569 (WebCore::CCLayerTreeHost::viewportSize):1570 1571 2011-08-18 Nico Weber <thakis@chromium.org>1572 1573 Fix "missing return" gcc warning in ScrollAnimatorNone1574 https://bugs.webkit.org/show_bug.cgi?id=664801575 1576 Reviewed by Tony Chang.1577 1578 * platform/ScrollAnimatorNone.cpp:1579 (WebCore::ScrollAnimatorNone::PerAxisData::curveAt):1580 (WebCore::ScrollAnimatorNone::PerAxisData::curveDerivativeAt):1581 1582 2011-08-18 James Simonsen <simonjam@chromium.org>1583 1584 Revalidate expired resources if they're requested after the initial document load1585 https://bugs.webkit.org/show_bug.cgi?id=521531586 1587 Reviewed by Antti Koivisto.1588 1589 Test: http/tests/cache/subresource-multiple-instances.html1590 1591 * loader/cache/CachedResourceLoader.cpp:1592 (WebCore::CachedResourceLoader::determineRevalidationPolicy):1593 1594 2011-08-18 Anders Carlsson <andersca@apple.com>1595 1596 Fix clang libc++ C++0x build1597 https://bugs.webkit.org/show_bug.cgi?id=664751598 1599 Reviewed by Adam Roben.1600 1601 Remove calls to isnan and isfinite with integer arguments.1602 1603 * css/CSSPrimitiveValue.cpp:1604 (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):1605 * html/canvas/WebGLRenderingContext.cpp:1606 (WebCore::WebGLRenderingContext::viewport):1607 1608 2011-08-18 Andrey Kosyakov <caseq@chromium.org>1609 1610 Web Inspector: [Extensions API] rename webInspector.resources to webInspector.network1611 https://bugs.webkit.org/show_bug.cgi?id=664601612 1613 Reviewed by Pavel Feldman.1614 1615 Tests: http/tests/inspector/extensions-network-redirect.html1616 inspector/extensions/extensions-network.html1617 1618 * inspector/front-end/ExtensionAPI.js:1619 (WebInspector.injectedExtensionAPI.InspectorExtensionAPI):1620 (WebInspector.injectedExtensionAPI.Network.requestDispatch):1621 (WebInspector.injectedExtensionAPI):1622 (WebInspector.injectedExtensionAPI.Network.prototype.getHAR):1623 (WebInspector.injectedExtensionAPI.defineDeprecatedProperty.getter):1624 (WebInspector.injectedExtensionAPI.defineDeprecatedProperty):1625 * inspector/front-end/ExtensionServer.js:1626 (WebInspector.ExtensionServer):1627 (WebInspector.ExtensionServer.prototype._inspectedURLChanged):1628 (WebInspector.ExtensionServer.prototype._notifyRequestFinished):1629 (WebInspector.ExtensionServer.prototype._onGetHAR):1630 (WebInspector.ExtensionServer.prototype._onGetResourceContent):1631 (WebInspector.ExtensionServer.prototype._requestId):1632 (WebInspector.ExtensionServer.prototype._requestById):1633 (WebInspector.ExtensionServer.prototype._onAddAuditCategory):1634 (WebInspector.ExtensionServer.prototype._onAddAuditResult):1635 (WebInspector.ExtensionServer.prototype._onStopAuditCategoryRun):1636 (WebInspector.ExtensionServer.prototype.initExtensions):1637 (WebInspector.ExtensionServer.prototype._onmessage):1638 1639 2011-08-18 Pavel Podivilov <podivilov@chromium.org>1640 1641 Web Inspector: extract content loading functions from RawSourceCode to ContentProvider implementations.1642 https://bugs.webkit.org/show_bug.cgi?id=662371643 1644 Reviewed by Pavel Feldman.1645 1646 Test: inspector/debugger/content-providers.html1647 1648 * inspector/front-end/SourceFile.js:1649 (WebInspector.RawSourceCode.prototype._loadResourceContent):1650 (WebInspector.RawSourceCode.prototype._loadScriptContent):1651 (WebInspector.RawSourceCode.prototype._loadAndConcatenateScriptsContent):1652 (WebInspector.ScriptContentProvider):1653 (WebInspector.ScriptContentProvider.prototype.requestContent):1654 (WebInspector.ConcatenatedScriptsContentProvider):1655 (WebInspector.ConcatenatedScriptsContentProvider.prototype.requestContent):1656 (WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent):1657 (WebInspector.ResourceContentProvider):1658 (WebInspector.ResourceContentProvider.prototype.requestContent):1659 1660 2011-08-18 Alexandru Chiculita <achicu@adobe.com>1661 1662 [CSSRegions] RenderRegion should not reference a parent RenderFlowThread1663 https://bugs.webkit.org/show_bug.cgi?id=661421664 1665 Added code that checks the parent RenderFlowThread of a RenderRegion and creates1666 a dependency for its referenced RenderFlowThread (from CSS style).1667 1668 There are two cases:1669 1. A RenderRegion tries to display the flow thread that laid it out. In this case1670 the region will be ignored and will not participate in the flow threads regions list.1671 2. A RenderRegion tries to display a flow thread that contains another region that1672 tries to display the first region's flow thread. This one can be generalized with any1673 number of intermediate flow threads. In this case the recursion is detected and only the1674 first added region will actually be selected. The other region will be ignored. However,1675 when the recursion is removed the invalid regions will be recovered.1676 1677 Reviewed by David Hyatt.1678 1679 Tests: fast/regions/flows-dependency-dynamic-remove.html1680 fast/regions/flows-dependency-same-flow.html1681 1682 * rendering/RenderBlock.cpp:1683 (WebCore::RenderBlock::insertPositionedObject):1684 * rendering/RenderFlowThread.cpp:1685 (WebCore::RenderFlowThread::dependsOn):1686 (WebCore::RenderFlowThread::addRegionToThread):1687 (WebCore::RenderFlowThread::removeRegionFromThread):1688 (WebCore::RenderFlowThread::checkInvalidRegions):1689 (WebCore::RenderFlowThread::addDependencyOnFlowThread):1690 (WebCore::RenderFlowThread::removeDependencyOnFlowThread):1691 (WebCore::RenderFlowThread::pushDependencies):1692 (WebCore::RenderFlowThread::layout):1693 (WebCore::RenderFlowThread::computeLogicalWidth):1694 (WebCore::RenderFlowThread::computeLogicalHeight):1695 (WebCore::RenderFlowThread::repaintRectangleInRegions):1696 * rendering/RenderFlowThread.h:1697 * rendering/RenderObjectChildList.cpp:1698 (WebCore::RenderObjectChildList::removeChildNode):1699 (WebCore::RenderObjectChildList::appendChildNode):1700 * rendering/RenderRegion.cpp:1701 (WebCore::RenderRegion::RenderRegion):1702 (WebCore::RenderRegion::~RenderRegion):1703 (WebCore::RenderRegion::paintReplaced):1704 (WebCore::RenderRegion::nodeAtPoint):1705 (WebCore::RenderRegion::attachRegion):1706 (WebCore::RenderRegion::detachRegion):1707 * rendering/RenderRegion.h:1708 (WebCore::RenderRegion::parentFlowThread):1709 (WebCore::RenderRegion::isValid):1710 (WebCore::RenderRegion::setIsValid):1711 * rendering/RenderTreeAsText.cpp:1712 (WebCore::writeRenderFlowThreads):1713 (WebCore::writeLayers):1714 * rendering/RenderView.cpp:1715 (WebCore::RenderView::RenderView):1716 (WebCore::RenderView::layout):1717 (WebCore::RenderView::renderFlowThreadWithName):1718 (WebCore::RenderView::layoutRenderFlowThreads):1719 * rendering/RenderView.h:1720 (WebCore::RenderView::hasRenderFlowThreads):1721 (WebCore::RenderView::isRenderFlowThreadOrderDirty):1722 (WebCore::RenderView::setIsRenderFlowThreadOrderDirty):1723 (WebCore::RenderView::renderFlowThreadList):1724 1725 2011-08-18 Pavel Podivilov <podivilov@chromium.org>1726 1727 Web Inspector: add UISourceCode class.1728 https://bugs.webkit.org/show_bug.cgi?id=662331729 1730 This is a next step towards splitting SourceFile into RawSourceCode and UISourceCode.1731 UISourceCode is a part of SourceFile's interface that is visible to ScriptsPanel.1732 UISourceCode represents a single entry in scripts panel's files select.1733 1734 Reviewed by Pavel Feldman.1735 1736 Test: inspector/debugger/ui-source-code.html1737 1738 * WebCore.gypi:1739 * WebCore.vcproj/WebCore.vcproj:1740 * inspector/front-end/UISourceCode.js: Added.1741 (WebInspector.UISourceCode):1742 (WebInspector.UISourceCode.prototype.get id):1743 (WebInspector.UISourceCode.prototype.get url):1744 (WebInspector.UISourceCode.prototype.get isContentScript):1745 (WebInspector.UISourceCode.prototype.requestContent):1746 (WebInspector.UISourceCode.prototype._didRequestContent):1747 (WebInspector.ContentProvider):1748 (WebInspector.ContentProvider.prototype.requestContent):1749 * inspector/front-end/WebKit.qrc:1750 * inspector/front-end/inspector.html:1751 1752 2011-08-17 Adam Roben <aroben@apple.com>1753 1754 Make WebCore keep track of the current device scale factor1755 1756 Fixes <http://webkit.org/b/66413> WebCore requires every WebKit port to keep track of the1757 device scale factor1758 1759 Reviewed by Darin Adler.1760 1761 * WebCore.exp.in: Removed Frame::deviceScaleFactorChanged, added Page::setDeviceScaleFactor.1762 1763 * css/MediaQueryEvaluator.cpp:1764 (WebCore::device_pixel_ratioMediaFeatureEval):1765 * html/HTMLCanvasElement.cpp:1766 (WebCore::HTMLCanvasElement::HTMLCanvasElement):1767 * page/DOMWindow.cpp:1768 (WebCore::DOMWindow::devicePixelRatio):1769 * rendering/RenderInline.cpp:1770 (WebCore::RenderInline::addDashboardRegions):1771 * rendering/RenderLayerCompositor.cpp:1772 (WebCore::RenderLayerCompositor::deviceScaleFactor):1773 * rendering/RenderObject.cpp:1774 (WebCore::RenderObject::addDashboardRegions):1775 Changed to get the device scale factor from Page.1776 1777 * loader/EmptyClients.h:1778 * page/Chrome.cpp:1779 * page/Chrome.h:1780 * page/ChromeClient.h:1781 Removed Chrome[Client]::deviceScaleFactor.1782 1783 * page/Frame.cpp:1784 * page/Frame.h:1785 Removed deviceScaleFactorChanged. Made deviceOrPageScaleFactorChanged public.1786 1787 * page/Page.cpp:1788 (WebCore::Page::Page): Initialize m_deviceScaleFactor.1789 (WebCore::Page::setDeviceScaleFactor): Added. Code came from1790 Frame::deviceScaleFactorChanged.1791 1792 * page/Page.h: Added m_deviceScaleFactor.1793 (WebCore::Page::deviceScaleFactor): Added simple getter.1794 1795 2011-08-18 Darin Adler <darin@apple.com>1796 1797 SVG and HTML editing have conflicting inline isWhitespace functions1798 https://bugs.webkit.org/show_bug.cgi?id=651451799 1800 Reviewed by Nikolas Zimmermann.1801 1802 Renamed the SVG-specific whitespace functions to call it "SVG space"1803 rather than just "whitespace". An alternative would have been to put1804 the functions into an SVG namespace instead of the top level WebCore1805 namespace.1806 1807 * svg/SVGAnimateMotionElement.cpp:1808 (WebCore::parsePoint): Call skipOptionalSVGSpaces.1809 * svg/SVGAnimationElement.cpp:1810 (WebCore::parseKeySplines): Ditto.1811 * svg/SVGFitToViewBox.cpp:1812 (WebCore::SVGFitToViewBox::parseViewBox): Ditto.1813 * svg/SVGLengthList.cpp:1814 (WebCore::SVGLengthList::parse): Call isSVGSpace and1815 skipOptionalSVGSpacesOrDelimiter.1816 * svg/SVGParserUtilities.cpp:1817 (WebCore::genericParseNumber): Call skipOptionalSVGSpacesOrDelimiter.1818 (WebCore::parseArcFlag): Ditto.1819 (WebCore::parseRect): Call skipOptionalSVGSpaces.1820 (WebCore::pointsListFromSVGData): Ditto.1821 (WebCore::parseGlyphName): Call skipOptionalSVGSpaces, isSVGSpace,1822 and skipOptionalSVGSpacesOrDelimiter.1823 (WebCore::parseDelimitedString): Call skipOptionalSVGSpaces.1824 1825 * svg/SVGParserUtilities.h:1826 (WebCore::isSVGSpace): Renamed from isWhitespace. This better matches1827 the comment which specifically talks about SVG.1828 (WebCore::skipOptionalSVGSpaces): Renamed from skipOptionalSpaces.1829 (WebCore::skipOptionalSVGSpacesOrDelimiter): Renamed from1830 skipOptionalSVGSpacesOrDelimiter.1831 1832 * svg/SVGPathStringSource.cpp:1833 (WebCore::SVGPathStringSource::moveToNextToken): Call skipOptionalSVGSpaces.1834 * svg/SVGPreserveAspectRatio.cpp:1835 (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio): Ditto.1836 * svg/SVGStringList.cpp:1837 (WebCore::SVGStringList::parse): Call isSVGSpace and1838 skipOptionalSVGSpacesOrDelimiter.1839 * svg/SVGTransformable.cpp:1840 (WebCore::parseTransformParamList): Call skipOptionalSVGSpaces and1841 skipOptionalSVGSpacesOrDelimiter.1842 (WebCore::SVGTransformable::parseTransformAttribute): Call skipOptionalSVGSpaces.1843 1844 2011-08-18 Gavin Peters <gavinp@chromium.org>1845 1846 Prepare frames for history navigation.1847 1848 Before beginning an explicit history navigation in a newly initialized1849 frame, it's important to give a "previous" item to avoid crashes, and1850 give a state to the state machine to avoid extra validating loads.1851 1852 https://bugs.webkit.org/show_bug.cgi?id=663221853 1854 Reviewed by Darin Fisher.1855 1856 No new tests, as history navigation is very difficult to test in1857 DumpRenderTree.1858 1859 * loader/FrameLoader.cpp:1860 (WebCore::FrameLoader::prepareForHistoryNavigation):1861 * loader/FrameLoader.h:1862 1863 2011-08-18 Jing Zhao <jingzhao@chromium.org>1864 1865 When changing the size of a menulist from x (x>1) to 1, the first item should be selected.1866 https://bugs.webkit.org/show_bug.cgi?id=662821867 1868 Reviewed by Kent Tamura.1869 1870 No new tests since it only changes the behavior in Android Browser.1871 1872 * html/HTMLSelectElement.cpp:1873 (WebCore::HTMLSelectElement::parseMappedAttribute):1874 1875 2011-08-18 Adam Klein <adamk@chromium.org>1876 1877 Handle "form" attribute updates in parseMappedAttribute() instead of attributeChanged() to better match HTMLElement practices1878 https://bugs.webkit.org/show_bug.cgi?id=663211879 1880 Reviewed by Darin Adler.1881 1882 This is simply a cleanup change: there's no need that I can see for1883 HTMLFormControlElement and HTMLObjectElement to override1884 Element::attributeChanged since they can properly handle form1885 attribute changes in parseMappedAttribute, which they also override.1886 1887 Though no change in behavior, I've added test coverage of the moved1888 code to an existing test (fast/forms/form-attribute.html) and added1889 a new test.1890 1891 Test: fast/forms/radio-remove-form-attr.html1892 1893 * html/HTMLFormControlElement.cpp:1894 (WebCore::HTMLFormControlElement::parseMappedAttribute):1895 * html/HTMLFormControlElement.h:1896 * html/HTMLObjectElement.cpp:1897 (WebCore::HTMLObjectElement::parseMappedAttribute):1898 * html/HTMLObjectElement.h:1899 1900 2011-08-18 Chang Shu <cshu@webkit.org>1901 1902 Add support of setPasswordEchoEnabled and setPasswordEchoDuration for password echo feature1903 https://bugs.webkit.org/show_bug.cgi?id=660521904 1905 Reviewed by Alexey Proskuryakov.1906 1907 Added runtime settings in WebCore.1908 Added support in window.internals for testing.1909 1910 Tests: editing/input/password-echo-passnode.html1911 editing/input/password-echo-passnode2.html1912 editing/input/password-echo-passnode3.html1913 editing/input/password-echo-textnode.html1914 1915 * page/Settings.cpp:1916 (WebCore::Settings::Settings):1917 * page/Settings.h:1918 (WebCore::Settings::setPasswordEchoEnabled):1919 (WebCore::Settings::passwordEchoEnabled):1920 (WebCore::Settings::setPasswordEchoDurationInSeconds):1921 (WebCore::Settings::passwordEchoDurationInSeconds):1922 * testing/Internals.cpp:1923 (WebCore::Internals::Internals):1924 (WebCore::Internals::setPasswordEchoEnabled):1925 (WebCore::Internals::setPasswordEchoDurationInSeconds):1926 (WebCore::Internals::reset):1927 * testing/Internals.h:1928 * testing/Internals.idl:1929 1930 2011-08-18 Wyatt Carss <wcarss@chromium.org>1931 1932 Selecting all and inserting text into a page with a frameset leads to a NULL ptr1933 https://bugs.webkit.org/show_bug.cgi?id=662881934 1935 Reviewed by Tony Chang.1936 1937 VisibleSelection returns a NoSelection to InsertTextCommand::doApply as1938 a new endingSelection, which isn't a sane state to be in. The code1939 tries to get a position on a higher node for a better selection, but1940 cannot go above the frameset (which exists in place of the body tag),1941 which lacks a renderer, and therefore cannot have a non-NoSelection1942 VisibleSelection.1943 1944 Because this is a rare corner case, it seemed more reasonable to bail1945 out in this circumstance than to change the way VisibleSelection1946 canonicalization works. The new behavior is to delete the content, but1947 insert nothing. I investigated the possibility of trying to move above1948 or below the frameset in this particular case, but there still isn't a1949 renderer, so it didn't prevent the crash.1950 1951 Test: editing/inserting/insert-text-into-empty-frameset-crash.html1952 1953 * editing/InsertTextCommand.cpp:1954 (WebCore::InsertTextCommand::doApply):1955 1956 2011-08-18 Takashi Toyoshima <toyoshim@chromium.org>1957 1958 Remove arguments from CloseEvent::create().1959 https://bugs.webkit.org/show_bug.cgi?id=662941960 1961 Reviewed by Kent Tamura.1962 1963 CloseEvent objects are initialized by initCloseEvent() in all cases.1964 Initialization in create() is redundant.1965 1966 No new tests for no functional difference.1967 1968 * websockets/CloseEvent.h:1969 (WebCore::CloseEvent::create):1970 (WebCore::CloseEvent::CloseEvent):1971 * websockets/WebSocket.cpp:1972 (WebCore::WebSocket::didClose):1973 1974 2011-08-18 Fady Samuel <fsamuel@chromium.org>1975 1976 iframe and frameset scaling is broken1977 https://bugs.webkit.org/show_bug.cgi?id=577851978 1979 Reviewed by Simon Fraser.1980 1981 Fixed two iframe and frameset scaling bugs:1982 #1 iframes and frameset backgrounds and scroll areas are doubly scaled when they are styled with -webkit-transform.1983 #2 frameset does not respect -webkit-transform-origin when scaled1984 1985 Tests: fast/frames/frame-set-scaling-3d.html1986 fast/frames/frame-set-scaling-centered.html1987 fast/frames/frame-set-scaling-rotate.html1988 fast/frames/frame-set-scaling-skew.html1989 fast/frames/frame-set-scaling.html1990 fast/frames/iframe-scaling-with-scroll.html1991 1992 * rendering/RenderFrameSet.cpp:1993 (WebCore::RenderFrameSet::layout):1994 Update the FrameSet's layer transform after we've computed size to correctly account for the transform origin.1995 * rendering/RenderLayer.cpp:1996 (WebCore::RenderLayer::childrenClipRect):1997 The dirty rect should be the document's unscaled size.1998 * rendering/RenderWidget.cpp:1999 (WebCore::RenderWidget::setWidget):2000 (WebCore::RenderWidget::updateWidgetPosition):2001 Don't scale the FrameView rect here. Scaling is done within the FrameView.2002 2003 2011-08-18 Csaba Osztrogonác <ossy@webkit.org>2004 2005 Unreviewed buildfix after r93268.2006 2007 * dom/Document.cpp:2008 (WebCore::disableRangeMutation):2009 2010 2011-08-17 Emil A Eklund <eae@chromium.org>2011 2012 Switch RenderBox to to new layout types2013 https://bugs.webkit.org/show_bug.cgi?id=661562014 2015 Reviewed by Eric Seidel.2016 2017 Convert RenderBox to new layout abstraction as a part of the ongoing2018 conversion work.2019 2020 No new tests as no new functionality.2021 2022 * rendering/RenderBox.cpp:2023 (WebCore::RenderBox::scrollWidth):2024 (WebCore::RenderBox::scrollHeight):2025 (WebCore::RenderBox::scrollLeft):2026 (WebCore::RenderBox::scrollTop):2027 (WebCore::RenderBox::setScrollLeft):2028 (WebCore::RenderBox::setScrollTop):2029 (WebCore::RenderBox::absoluteRects):2030 (WebCore::RenderBox::absoluteContentBox):2031 (WebCore::RenderBox::absoluteContentQuad):2032 (WebCore::RenderBox::outlineBoundsForRepaint):2033 (WebCore::RenderBox::reflectionBox):2034 (WebCore::RenderBox::reflectedRect):2035 (WebCore::RenderBox::verticalScrollbarWidth):2036 (WebCore::RenderBox::horizontalScrollbarHeight):2037 (WebCore::RenderBox::computeContentBoxLogicalWidth):2038 (WebCore::RenderBox::computeContentBoxLogicalHeight):2039 (WebCore::RenderBox::maskClipRect):2040 (WebCore::RenderBox::repaintLayerRectsForImage):2041 (WebCore::RenderBox::pushContentsClip):2042 (WebCore::RenderBox::overflowClipRect):2043 (WebCore::RenderBox::clipRect):2044 (WebCore::RenderBox::containingBlockLogicalWidthForContent):2045 (WebCore::RenderBox::perpendicularContainingBlockLogicalHeight):2046 (WebCore::RenderBox::positionLineBox):2047 (WebCore::RenderBox::clippedOverflowRectForRepaint):2048 (WebCore::RenderBox::computeRectForRepaint):2049 (WebCore::RenderBox::computeLogicalWidth):2050 (WebCore::RenderBox::computeInlineDirectionMargins):2051 (WebCore::RenderBox::computeLogicalHeight):2052 (WebCore::RenderBox::computeLogicalHeightUsing):2053 (WebCore::RenderBox::computePercentageLogicalHeight):2054 (WebCore::RenderBox::computeBlockDirectionMargins):2055 (WebCore::RenderBox::containingBlockLogicalWidthForPositioned):2056 (WebCore::RenderBox::containingBlockLogicalHeightForPositioned):2057 (WebCore::computeInlineStaticDistance):2058 (WebCore::RenderBox::computePositionedLogicalWidth):2059 (WebCore::computeLogicalLeftPositionedOffset):2060 (WebCore::RenderBox::computePositionedLogicalWidthUsing):2061 (WebCore::computeBlockStaticDistance):2062 (WebCore::RenderBox::computePositionedLogicalHeight):2063 (WebCore::computeLogicalTopPositionedOffset):2064 (WebCore::RenderBox::computePositionedLogicalHeightUsing):2065 (WebCore::RenderBox::computePositionedLogicalWidthReplaced):2066 (WebCore::RenderBox::computePositionedLogicalHeightReplaced):2067 (WebCore::RenderBox::localCaretRect):2068 (WebCore::RenderBox::lineHeight):2069 (WebCore::RenderBox::baselinePosition):2070 (WebCore::RenderBox::logicalVisualOverflowRectForPropagation):2071 (WebCore::RenderBox::visualOverflowRectForPropagation):2072 (WebCore::RenderBox::logicalLayoutOverflowRectForPropagation):2073 (WebCore::RenderBox::layoutOverflowRectForPropagation):2074 (WebCore::RenderBox::locationOffsetIncludingFlipping):2075 * rendering/RenderBox.h:2076 (WebCore::RenderBox::borderFitAdjust):2077 (WebCore::RenderBox::intrinsicSize):2078 (WebCore::RenderBox::intrinsicLogicalWidth):2079 (WebCore::RenderBox::intrinsicLogicalHeight):2080 (WebCore::RenderBox::scrollbarLogicalHeight):2081 (WebCore::RenderBox::controlClipRect):2082 (WebCore::RenderBox::firstLineBoxBaseline):2083 (WebCore::RenderBox::lastLineBoxBaseline):2084 2085 2011-08-17 Annie Sullivan <sullivan@chromium.org>2086 2087 Reduce usages of String::createUninitialized2088 https://bugs.webkit.org/show_bug.cgi?id=663992089 2090 Constructs Strings with StringBuilder instead of calling createUninitialized.2091 2092 Reviewed by Adam Barth.2093 2094 No new tests; no functional change.2095 2096 * dom/StyleElement.cpp:2097 (WebCore::StyleElement::process):2098 * dom/Text.cpp:2099 (WebCore::Text::wholeText):2100 * html/parser/HTMLSourceTracker.cpp:2101 (WebCore::HTMLSourceTracker::sourceForToken):2102 * platform/graphics/Font.cpp:2103 (WebCore::Font::normalizeSpaces):2104 * platform/text/TextCodecUserDefined.cpp:2105 (WebCore::TextCodecUserDefined::decode):2106 2107 2011-08-17 Emil A Eklund <eae@chromium.org>2108 2109 Switch FrameView to to new layout types2110 https://bugs.webkit.org/show_bug.cgi?id=661472111 2112 Reviewed by Eric Seidel.2113 2114 Convert Frame & FrameView to new layout abstraction as a part of the2115 ongoing conversion work.2116 2117 No new tests, no new functionality.2118 2119 * page/Frame.cpp:2120 (WebCore::Frame::visiblePositionForPoint):2121 (WebCore::Frame::documentAtPoint):2122 (WebCore::Frame::rangeForPoint):2123 (WebCore::Frame::setPageAndTextZoomFactors):2124 (WebCore::Frame::scalePage):2125 * page/Frame.h:2126 * page/FrameView.cpp:2127 (WebCore::FrameView::create):2128 (WebCore::FrameView::reset):2129 (WebCore::FrameView::init):2130 (WebCore::FrameView::invalidateRect):2131 (WebCore::FrameView::setFrameRect):2132 (WebCore::FrameView::setMarginWidth):2133 (WebCore::FrameView::setMarginHeight):2134 (WebCore::FrameView::setContentsSize):2135 (WebCore::FrameView::adjustViewSize):2136 (WebCore::FrameView::scrollXForFixedPosition):2137 (WebCore::FrameView::scrollYForFixedPosition):2138 (WebCore::FrameView::scrollOffsetForFixedPosition):2139 (WebCore::FrameView::currentMousePosition):2140 (WebCore::FrameView::scrollContentsFastPath):2141 (WebCore::FrameView::scrollContentsSlowPath):2142 (WebCore::FrameView::setScrollPosition):2143 (WebCore::FrameView::repaintContentRectangle):2144 (WebCore::FrameView::scrollToAnchor):2145 (WebCore::FrameView::performPostLayoutTasks):2146 (WebCore::FrameView::windowClipRect):2147 (WebCore::FrameView::windowClipRectForLayer):2148 (WebCore::FrameView::scrollTo):2149 (WebCore::FrameView::invalidateScrollbarRect):2150 (WebCore::FrameView::getTickmarks):2151 (WebCore::FrameView::windowResizerRect):2152 (WebCore::FrameView::setVisibleScrollerThumbRect):2153 (WebCore::FrameView::paintScrollCorner):2154 (WebCore::FrameView::paintContents):2155 (WebCore::FrameView::paintOverhangAreas):2156 (WebCore::FrameView::forceLayoutForPagination):2157 (WebCore::FrameView::convertFromRenderer):2158 (WebCore::FrameView::convertToRenderer):2159 (WebCore::FrameView::convertToContainingView):2160 (WebCore::FrameView::convertFromContainingView):2161 * page/FrameView.h:2162 (WebCore::FrameView::marginWidth):2163 (WebCore::FrameView::marginHeight):2164 * page/mac/FrameMac.mm:2165 (WebCore::Frame::snapshotDragImage):2166 (WebCore::Frame::nodeImage):2167 2168 2011-08-17 Emil A Eklund <eae@chromium.org>2169 2170 Switch html/* to to new layout types2171 https://bugs.webkit.org/show_bug.cgi?id=663472172 2173 Reviewed by Eric Seidel.2174 2175 Convert HTML* and shadow element to new layout abstraction as a part of2176 the ongoing conversion work.2177 2178 No new tests, no new functionality.2179 2180 * html/HTMLAreaElement.cpp:2181 (WebCore::HTMLAreaElement::invalidateCachedRegion):2182 (WebCore::HTMLAreaElement::mapMouseEvent):2183 (WebCore::HTMLAreaElement::computePath):2184 (WebCore::HTMLAreaElement::computeRect):2185 (WebCore::HTMLAreaElement::getRegion):2186 * html/HTMLAreaElement.h:2187 * html/HTMLCanvasElement.cpp:2188 (WebCore::HTMLCanvasElement::paint):2189 * html/HTMLCanvasElement.h:2190 * html/HTMLMapElement.cpp:2191 (WebCore::HTMLMapElement::mapMouseEvent):2192 * html/HTMLMapElement.h:2193 * html/ImageDocument.cpp:2194 (WebCore::ImageDocumentParser::finish):2195 (WebCore::ImageDocument::scale):2196 (WebCore::ImageDocument::resizeImageToFit):2197 (WebCore::ImageDocument::imageFitsInWindow):2198 * html/ValidationMessage.cpp:2199 (WebCore::adjustBubblePosition):2200 * html/canvas/CanvasRenderingContext2D.cpp:2201 (WebCore::size):2202 (WebCore::CanvasRenderingContext2D::drawImage):2203 * html/shadow/MediaControlElements.cpp:2204 (WebCore::MediaControlPanelElement::startDrag):2205 (WebCore::MediaControlPanelElement::continueDrag):2206 (WebCore::MediaControlPanelElement::setPosition):2207 (WebCore::MediaControlPanelElement::defaultEventHandler):2208 * html/shadow/MediaControlElements.h:2209 * html/shadow/SliderThumbElement.cpp:2210 (WebCore::SliderThumbElement::dragFrom):2211 (WebCore::SliderThumbElement::setPositionFromPoint):2212 * html/shadow/SliderThumbElement.h:2213 * rendering/RenderImage.cpp:2214 (WebCore::RenderImage::nodeAtPoint):2215 2216 2011-08-17 David Grogan <dgrogan@chromium.org>2217 2218 Change references to leveldb.gyp to leveldatabase.gyp as part of the2219 leveldb refactoring going on in chromium: crbug.com/893782220 https://bugs.webkit.org/show_bug.cgi?id=663322221 2222 Reviewed by Tony Gentilcore.2223 2224 Tests: new-run-webkit-tests --debug --chromium --no-retry-failures --build-directory=llvm storage/indexeddb2225 2226 * WebCore.gyp/WebCore.gyp:2227 2228 2011-08-17 Hayato Ito <hayato@chromium.org>2229 2230 Implement proper handling of focus/blur events in regard to shadow DOM boundaries.2231 https://bugs.webkit.org/show_bug.cgi?id=614212232 2233 Reviewed by Dimitri Glazkov.2234 2235 Introduces FocusEventDispatchMediator/BlurEventDispatchMediator so2236 that focus/blue events are stopped at the lowest common shadow boundary.2237 2238 * dom/Document.cpp:2239 (WebCore::Document::setFocusedNode):2240 * dom/Event.cpp:2241 (WebCore::FocusEventDispatchMediator::create):2242 (WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):2243 (WebCore::FocusEventDispatchMediator::dispatchEvent):2244 (WebCore::BlurEventDispatchMediator::create):2245 (WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):2246 (WebCore::BlurEventDispatchMediator::dispatchEvent):2247 * dom/Event.h:2248 * dom/Node.cpp:2249 (WebCore::Node::dispatchFocusEvent):2250 (WebCore::Node::dispatchBlurEvent):2251 * dom/Node.h:2252 * html/HTMLFormControlElement.cpp:2253 (WebCore::HTMLFormControlElement::dispatchBlurEvent):2254 * html/HTMLFormControlElement.h:2255 * html/HTMLSelectElement.cpp:2256 (WebCore::HTMLSelectElement::dispatchFocusEvent):2257 (WebCore::HTMLSelectElement::dispatchBlurEvent):2258 * html/HTMLSelectElement.h:2259 * html/HTMLTextFormControlElement.cpp:2260 (WebCore::HTMLTextFormControlElement::dispatchFocusEvent):2261 (WebCore::HTMLTextFormControlElement::dispatchBlurEvent):2262 * html/HTMLTextFormControlElement.h:2263 * page/FocusController.cpp:2264 (WebCore::dispatchEventsOnWindowAndFocusedNode):2265 2266 2011-08-17 Ben Wells <benwells@chromium.org>2267 2268 Canvas fill and fillRect with SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy have errors2269 https://bugs.webkit.org/show_bug.cgi?id=660362270 2271 These modes cannot be passed straight through to the underlying graphics context as the graphics context2272 and the HTML5 canvas spec have different interpretations to them. In the graphics context, the compositing2273 modes are applied just over the area being filled. In the HTML5 spec, the compositing modes are applied over2274 the entire canvas.2275 2276 The SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy modes all need some kind of extra action2277 to just performing the composited fill on the canvas, as they need t he canvas to be cleared outside of the2278 area being filled.2279 2280 Previous to this change the Copy mode did not do this clearing at all. The other modes did but if the2281 transformed path being filled contained anti-aliasing at its edges artifacts were introduced.2282 2283 With this change, Copy now does a complete erase of the canvas before performing a fill as per normal.2284 The other modes use a temporary buffer just big enough for the transformed path (in device coordinates).2285 The fill is first done there in SourceOver mode. Then this is drawn into the canvas context using the2286 appropriate mode, with any areas outside the draw area being cleared.2287 2288 Reviewed by James Robinson.2289 2290 Test: fast/canvas/canvas-composite-transformclip.html2291 2292 * html/HTMLCanvasElement.h:2293 * html/canvas/CanvasRenderingContext2D.cpp:2294 (WebCore::CanvasRenderingContext2D::fill):2295 (WebCore::CanvasRenderingContext2D::fillRect):2296 (WebCore::CanvasRenderingContext2D::clearCanvas):2297 (WebCore::CanvasRenderingContext2D::transformAreaToDevice):2298 (WebCore::CanvasRenderingContext2D::fillAndDisplayTransparencyElsewhere):2299 * html/canvas/CanvasRenderingContext2D.h:2300 * platform/graphics/skia/ImageBufferSkia.cpp:2301 (WebCore::ImageBuffer::ImageBuffer):2302 2303 2011-08-17 Emil A Eklund <eae@chromium.org>2304 2305 Switch inspector to to new layout types2306 https://bugs.webkit.org/show_bug.cgi?id=663582307 2308 Reviewed by Eric Seidel.2309 2310 Convert inspector code to new layout abstraction as a part of the ongoing2311 conversion work.2312 2313 No new tests, no new functionality.2314 2315 * inspector/DOMNodeHighlighter.cpp:2316 (WebCore::DOMNodeHighlighter::drawNodeHighlight):2317 * inspector/InspectorInstrumentation.cpp:2318 (WebCore::InspectorInstrumentation::willPaintImpl):2319 * inspector/InspectorInstrumentation.h:2320 (WebCore::InspectorInstrumentation::willPaint):2321 * inspector/InspectorTimelineAgent.cpp:2322 (WebCore::InspectorTimelineAgent::willPaint):2323 * inspector/InspectorTimelineAgent.h:2324 * inspector/TimelineRecordFactory.cpp:2325 (WebCore::TimelineRecordFactory::createPaintData):2326 * inspector/TimelineRecordFactory.h:2327 2328 2011-08-17 Levi Weintraub <leviw@chromium.org>2329 2330 Switch Editing code to new layout types2331 https://bugs.webkit.org/show_bug.cgi?id=663552332 2333 Reviewed by Eric Seidel.2334 2335 Converting remaining editing code to the LayoutUnit abstraction.2336 2337 No new tests, no change in functionality.2338 2339 * editing/Editor.cpp:2340 (WebCore::Editor::rangeForPoint):2341 (WebCore::Editor::insideVisibleArea):2342 (WebCore::Editor::countMatchesForText):2343 * editing/Editor.h:2344 * editing/mac/FrameSelectionMac.mm:2345 (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):2346 2347 2011-08-17 Levi Weintraub <leviw@chromium.org>2348 2349 Switch Accessibility code to new layout types2350 https://bugs.webkit.org/show_bug.cgi?id=663482351 2352 Reviewed by Eric Seidel.2353 2354 Converting remaining Accessibility code to the LayoutUnit abstraction.2355 2356 No new tests, no change in functionality2357 2358 * accessibility/AccessibilityImageMapLink.cpp:2359 (WebCore::AccessibilityImageMapLink::elementRect):2360 * accessibility/AccessibilityImageMapLink.h:2361 * accessibility/AccessibilityListBox.cpp:2362 (WebCore::AccessibilityListBox::elementAccessibilityHitTest):2363 * accessibility/AccessibilityListBox.h:2364 * accessibility/AccessibilityListBoxOption.cpp:2365 (WebCore::AccessibilityListBoxOption::elementRect):2366 * accessibility/AccessibilityListBoxOption.h:2367 * accessibility/AccessibilityMenuListOption.cpp:2368 (WebCore::AccessibilityMenuListOption::elementRect):2369 * accessibility/AccessibilityMenuListOption.h:2370 (WebCore::AccessibilityMenuListOption::size):2371 * accessibility/AccessibilityMenuListPopup.h:2372 (WebCore::AccessibilityMenuListPopup::elementRect):2373 (WebCore::AccessibilityMenuListPopup::size):2374 * accessibility/AccessibilityObject.cpp:2375 (WebCore::AccessibilityObject::clickPoint):2376 (WebCore::AccessibilityObject::orientation):2377 (WebCore::AccessibilityObject::elementAccessibilityHitTest):2378 * accessibility/AccessibilityObject.h:2379 (WebCore::AccessibilityObject::accessibilityHitTest):2380 (WebCore::AccessibilityObject::boundingBoxRect):2381 (WebCore::AccessibilityObject::size):2382 (WebCore::AccessibilityObject::boundsForVisiblePositionRange):2383 (WebCore::AccessibilityObject::doAXBoundsForRange):2384 * accessibility/AccessibilityRenderObject.cpp:2385 (WebCore::AccessibilityRenderObject::isOffScreen):2386 (WebCore::AccessibilityRenderObject::boundingBoxRect):2387 (WebCore::AccessibilityRenderObject::checkboxOrRadioRect):2388 (WebCore::AccessibilityRenderObject::elementRect):2389 (WebCore::AccessibilityRenderObject::size):2390 (WebCore::AccessibilityRenderObject::clickPoint):2391 (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):2392 (WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange):2393 (WebCore::AccessibilityRenderObject::visiblePositionForPoint):2394 (WebCore::AccessibilityRenderObject::doAXBoundsForRange):2395 * accessibility/AccessibilityRenderObject.h:2396 * accessibility/AccessibilityScrollView.cpp:2397 (WebCore::AccessibilityScrollView::accessibilityHitTest):2398 (WebCore::AccessibilityScrollView::elementRect):2399 * accessibility/AccessibilityScrollView.h:2400 * accessibility/AccessibilityScrollbar.cpp:2401 (WebCore::AccessibilityScrollbar::elementRect):2402 * accessibility/AccessibilityScrollbar.h:2403 * accessibility/AccessibilitySlider.cpp:2404 (WebCore::AccessibilitySliderThumb::elementRect):2405 (WebCore::AccessibilitySliderThumb::size):2406 * accessibility/AccessibilitySlider.h:2407 * accessibility/AccessibilityTableColumn.cpp:2408 (WebCore::AccessibilityTableColumn::elementRect):2409 (WebCore::AccessibilityTableColumn::size):2410 * accessibility/AccessibilityTableColumn.h:2411 * accessibility/AccessibilityTableHeaderContainer.cpp:2412 (WebCore::AccessibilityTableHeaderContainer::elementRect):2413 (WebCore::AccessibilityTableHeaderContainer::size):2414 * accessibility/AccessibilityTableHeaderContainer.h:2415 * accessibility/mac/AccessibilityObjectWrapper.mm:2416 (-[AccessibilityObjectWrapper position]):2417 (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):2418 (-[AccessibilityObjectWrapper accessibilityShowContextMenu]):2419 2420 2011-08-17 Emil A Eklund <eae@chromium.org>2421 2422 Switch focus handling to to new layout types2423 https://bugs.webkit.org/show_bug.cgi?id=663312424 2425 Reviewed by Eric Seidel.2426 2427 Convert FocusController and SpatialNavigation to new layout abstraction2428 as a part of the ongoing conversion work.2429 2430 No new tests, no new functionality.2431 2432 * page/FocusController.cpp:2433 (WebCore::updateFocusCandidateIfNeeded):2434 (WebCore::FocusController::findFocusCandidateInContainer):2435 (WebCore::FocusController::advanceFocusDirectionallyInContainer):2436 (WebCore::FocusController::advanceFocusDirectionally):2437 * page/FocusController.h:2438 * page/SpatialNavigation.cpp:2439 (WebCore::alignmentForRects):2440 (WebCore::start):2441 (WebCore::middle):2442 (WebCore::end):2443 (WebCore::areRectsFullyAligned):2444 (WebCore::areRectsPartiallyAligned):2445 (WebCore::areRectsMoreThanFullScreenApart):2446 (WebCore::below):2447 (WebCore::rightOf):2448 (WebCore::isRectInDirection):2449 (WebCore::hasOffscreenRect):2450 (WebCore::scrollInDirection):2451 (WebCore::deflateIfOverlapped):2452 (WebCore::canScrollInDirection):2453 (WebCore::rectToAbsoluteCoordinates):2454 (WebCore::nodeRectInAbsoluteCoordinates):2455 (WebCore::frameRectInAbsoluteCoordinates):2456 (WebCore::entryAndExitPointsForDirection):2457 (WebCore::distanceDataForNode):2458 (WebCore::canBeScrolledIntoView):2459 (WebCore::virtualRectForDirection):2460 (WebCore::virtualRectForAreaElementAndDirection):2461 * page/SpatialNavigation.h:2462 2463 2011-08-17 Levi Weintraub <leviw@chromium.org>2464 2465 Switch Document, DocumentMarker, Clipboard, and Range to new layout types2466 https://bugs.webkit.org/show_bug.cgi?id=663302467 2468 Reviewed by Eric Seidel.2469 2470 Converting the remaining DOM classes to use the LayoutUnit abstraction.2471 2472 No new tests, no new behavior.2473 2474 * dom/Clipboard.h:2475 (WebCore::Clipboard::dragLocation):2476 * dom/Document.cpp:2477 (WebCore::Document::nodesFromRect):2478 (WebCore::nodeFromPoint):2479 (WebCore::Document::caretRangeFromPoint):2480 (WebCore::Document::prepareMouseEvent):2481 * dom/Document.h:2482 * dom/DocumentMarkerController.cpp:2483 (WebCore::DocumentMarkerController::markerContainingPoint):2484 (WebCore::DocumentMarkerController::renderedRectsForMarkers):2485 (WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect):2486 * dom/DocumentMarkerController.h:2487 * dom/Range.cpp:2488 (WebCore::adjustFloatQuadsForScrollAndAbsoluteZoomAndPageScale):2489 * dom/RenderedDocumentMarker.h:2490 (WebCore::RenderedDocumentMarker::contains):2491 (WebCore::RenderedDocumentMarker::setRenderedRect):2492 (WebCore::RenderedDocumentMarker::renderedRect):2493 (WebCore::RenderedDocumentMarker::invalidMarkerRect):2494 (WebCore::RenderedDocumentMarker::invalidate):2495 2496 2011-08-17 Dan Bernstein <mitz@apple.com>2497 2498 Removed an unused setting.2499 2500 Reviewed by Anders Carlsson.2501 2502 * WebCore.exp.in:2503 * page/Settings.cpp:2504 (WebCore::Settings::Settings): Removed initializer for m_needsTigerMailQuirks.2505 * page/Settings.h: Removed accessors.2506 2507 2011-08-17 Oliver Hunt <oliver@apple.com>2508 2509 Move towards supporting user controlled prototypes on CanvasPixelArray2510 https://bugs.webkit.org/show_bug.cgi?id=664292511 2512 Reviewed by Gavin Barraclough.2513 2514 Start using a per-global object structure for canvas pixel array.2515 2516 * bindings/js/JSImageDataCustom.cpp:2517 (WebCore::toJS):2518 2519 2011-08-17 Luke Macpherson <macpherson@chromium.org>2520 2521 Support cast from CSSPrimitiveValue to unsigned, and use in appropriate places in CSSStyleSelector::applyProperty2522 https://bugs.webkit.org/show_bug.cgi?id=662812523 2524 Reviewed by Eric Seidel.2525 2526 No new tests - refactoring only.2527 2528 The return if type!=CSS_NUMBER case becomes an ASSERT because it is unreachable unless there is an error in the parser.2529 2530 * css/CSSPrimitiveValueMappings.h:2531 (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):2532 Support cast from unsigned to CSSPrimitiveValue2533 (WebCore::CSSPrimitiveValue::operator unsigned):2534 Support cast from CSSPrimitiveValue to unsigned2535 * css/CSSStyleSelector.cpp:2536 (WebCore::CSSStyleSelector::applyProperty):2537 Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro for CSSPropertyWebkitBoxFlex,2538 CSSPropertyWebkitBoxFlexGroup and CSSPropertyWebkitBoxOrdinalGroup properties.2539 2540 2011-08-17 Scott Byer <scottbyer@chromium.org>2541 2542 ScrollAnimatorNone: Remove unused field2543 https://bugs.webkit.org/show_bug.cgi?id=663122544 2545 Reviewed by Adam Barth.2546 2547 No functional change; no test needed.2548 2549 * platform/ScrollAnimatorNone.cpp:2550 (WebCore::ScrollAnimatorNone::PerAxisData::updateDataFromParameters):2551 (WebCore::ScrollAnimatorNone::scroll):2552 * platform/ScrollAnimatorNone.h:2553 2554 2011-08-17 Jeff Miller <jeffm@apple.com>2555 2556 Work-in-progress on Soft link against AVFoundationCF and CoreMedia2557 https://bugs.webkit.org/show_bug.cgi?id=657252558 2559 Don't bother with SOFT_LINK_LIBRARY(libdispatch), we're going to continue to statically link to it since2560 the DLL will have already been loaded by other parts of AAS and is guaranteed to be available if AVFoundation2561 is enabled.2562 2563 Reviewed by Anders Carlsson.2564 2565 No new tests; no functional change.2566 2567 * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: Removed SOFT_LINK_DEBUG_LIBRARY(libdispatch) and SOFT_LINK_LIBRARY(libdispatch).2568 (WebCore::MediaPlayerPrivateAVFoundationCF::isAvailable): Don't check for libdispatch.2569 2570 2011-08-17 Brady Eidson <beidson@apple.com>2571 2572 https://bugs.webkit.org/show_bug.cgi?id=66354 and <rdar://problem/9965209>2573 Regression: On Lion, redirects lose HTTP authentication headers2574 2575 Reviewed by Alexey Proskuryakov and Darin Adler.2576 2577 This changes makes WebCore try to apply basic credentials after a redirect if the redirect is to the same origin,2578 assuming the redirected URL did not contain credentials directly.2579 2580 Tests: http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin.html2581 http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin.html2582 http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html2583 2584 * platform/network/cf/ResourceHandleCFNet.cpp:2585 (WebCore::applyBasicAuthorizationHeader): Apply the user/password from a credential to the HTTP headers for a request.2586 (WebCore::ResourceHandle::createCFURLConnection): Use the applyBasicAuthorizationHeader helper.2587 (WebCore::ResourceHandle::willSendRequest): If this is a redirect within the same origin, apply any stored target credentials to the new request.2588 2589 * platform/network/mac/ResourceHandleMac.mm:2590 (WebCore::applyBasicAuthorizationHeader): Apply the user/password from a credential to the HTTP headers for a request.2591 (WebCore::ResourceHandle::createNSURLConnection): Use the applyBasicAuthorizationHeader helper.2592 (WebCore::ResourceHandle::willSendRequest): If this is a redirect within the same origin, apply any stored target credentials to the new request.2593 2594 2011-08-17 Chris Fleizach <cfleizach@apple.com>2595 2596 Accessibility stack exhaustion using role attribute2597 https://bugs.webkit.org/show_bug.cgi?id=651742598 2599 Reviewed by Darin Adler.2600 2601 Forgot to commit review comments.2602 2603 * accessibility/AccessibilityRenderObject.cpp:2604 (WebCore::AccessibilityRenderObject::remapAriaRoleDueToParent):2605 2606 2011-08-17 Chris Fleizach <cfleizach@apple.com>2607 2608 Accessibility stack exhaustion using role attribute2609 https://bugs.webkit.org/show_bug.cgi?id=651742610 2611 Make sure we do not call accessibilityIsIgnored() during the AccessibilityObject2612 creation flow. That can lead to loops.2613 2614 Reviewed by Darin Adler.2615 2616 Tests: accessibility/crash-determining-aria-role-when-label-present.html2617 2618 * accessibility/AccessibilityObject.cpp:2619 (WebCore::createARIARoleMap):2620 * accessibility/AccessibilityRenderObject.cpp:2621 (WebCore::AccessibilityRenderObject::remapAriaRoleDueToParent):2622 (WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):2623 * accessibility/AccessibilityRenderObject.h:2624 2625 2011-08-17 James Robinson <jamesr@chromium.org>2626 2627 [chromium] Crash if compositing is disabled during updateLayers()2628 https://bugs.webkit.org/show_bug.cgi?id=663532629 2630 Reviewed by Kenneth Russell.2631 2632 If compositing is turned off during LayerRendererChromium::updateLayers(), the rootLayer() will become null.2633 Sicne CCLayerTreeHost::doComposite() calls updateLayers() and then drawLayers() without checking for this case,2634 drawLayers() has to return without doing anything if the root layer is null.2635 2636 Crash fixed based on crash reports. No known reliably repro case, unfortunately.2637 2638 * platform/graphics/chromium/LayerRendererChromium.cpp:2639 (WebCore::LayerRendererChromium::drawLayers):2640 2641 2011-08-17 Dan Bernstein <mitz@apple.com>2642 2643 <rdar://problem/9971293> Mid-word breaks can occur in the middle of a surrogate pair2644 https://bugs.webkit.org/show_bug.cgi?id=664022645 2646 Reviewed by Dave Hyatt.2647 2648 Test: fast/text/midword-break-before-surrogate-pair-2.html2649 2650 * rendering/RenderBlockLineLayout.cpp:2651 (WebCore::RenderBlock::LineBreaker::nextLineBreak): Just never allow a mid-word2652 break before a trailing surrogate.2653 2654 2011-08-16 Chang Shu <cshu@webkit.org>2655 2656 Support reset in WebCore::Internals2657 https://bugs.webkit.org/show_bug.cgi?id=663072658 2659 Reviewed by Dimitri Glazkov.2660 2661 New tests will be added when function reset is implemented.2662 2663 Added framework code in WebCoreTestSupport. The real implementation of2664 Internals::reset() depends on the need from the settings that require a reset.2665 2666 * testing/Internals.cpp:2667 (WebCore::Internals::reset):2668 * testing/Internals.h:2669 * testing/js/WebCoreTestSupport.cpp:2670 (WebCoreTestSupport::resetInternalsObject):2671 * testing/js/WebCoreTestSupport.h:2672 * testing/v8/WebCoreTestSupport.cpp:2673 (WebCoreTestSupport::resetInternalsObject):2674 * testing/v8/WebCoreTestSupport.h:2675 2676 2011-08-17 Tony Chang <tony@chromium.org>2677 2678 Fix chromium mac compile. MediaPlayerPrivateAVFoundationObjC.* moved2679 and the WebCore.gypi file wasn't updated.2680 2681 * WebCore.gypi:2682 2683 2011-08-17 Abhishek Arya <inferno@chromium.org>2684 2685 Crash in Document::recalcStyleSelector2686 https://bugs.webkit.org/show_bug.cgi?id=663352687 2688 Reviewed by Simon Fraser.2689 2690 When node is getting destroyed and its removedFromDocument2691 is not called due to entire document structure torn down(using2692 removeAllChildren), make sure to clear out the stylesheet2693 candidate node from document's structures in its destructor.2694 2695 Test: svg/dom/stylesheet-candidate-node-crash-main.html2696 2697 * dom/ProcessingInstruction.cpp:2698 (WebCore::ProcessingInstruction::~ProcessingInstruction):2699 * html/HTMLLinkElement.cpp:2700 (WebCore::HTMLLinkElement::~HTMLLinkElement):2701 * html/HTMLStyleElement.cpp:2702 (WebCore::HTMLStyleElement::~HTMLStyleElement):2703 * svg/SVGStyleElement.cpp:2704 (WebCore::SVGStyleElement::~SVGStyleElement):2705 2706 2011-08-17 Sam White <samuel.white@rochester.edu>2707 2708 AccessibilityObject levels are inconsistent2709 https://bugs.webkit.org/show_bug.cgi?id=661802710 2711 Updated accessibilityTable to return level values consistent with other accessibilityObjects that2712 return level values. This means a value of 0 is now only returned when tableLevel() is called on a2713 non-table element.2714 2715 Reviewed by Chris Fleizach.2716 2717 Test: platform/mac/accessibility/element-level.html2718 2719 * accessibility/AccessibilityTable.cpp:2720 (WebCore::AccessibilityTable::tableLevel):2721 * accessibility/mac/AccessibilityObjectWrapper.mm:2722 (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):2723 2724 2011-08-17 Ryosuke Niwa <rniwa@webkit.org>2725 2726 An arrow key collapses directionless selection range in the wrong direction in BiDi2727 https://bugs.webkit.org/show_bug.cgi?id=646262728 2729 Reviewed by Darin Adler.2730 2731 The bug was caused by willBeModified's always using block direction to determine2732 the direction to which the selection is collapsed. Fixed the bug by calling directionOfSelection2733 in willBeModified, which will return the text direction of the surrounding context when2734 the start and the end have the same direction. When the text directions at the start and at the end2735 of selection do not match, it uses the block's text direction.2736 2737 Test: editing/selection/collapse-selection-in-bidi.html2738 2739 * editing/FrameSelection.cpp:2740 (WebCore::FrameSelection::directionOfSelection): Added.2741 (WebCore::FrameSelection::willBeModified): Calls directionOfSelection.2742 (WebCore::FrameSelection::modifyMovingRight): Ditto.2743 (WebCore::FrameSelection::modifyMovingLeft): Ditto.2744 * editing/FrameSelection.h:2745 2746 2011-08-17 Jeff Miller <jeffm@apple.com>2747 2748 Some AVFoundation source files should be in platform-specific directories2749 https://bugs.webkit.org/show_bug.cgi?id=663522750 2751 Moved platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.* files to platform/graphics/avfoundation/cf,2752 and moved platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.* files to platform/graphics/avfoundation/objc/.2753 2754 While I was at it, added svn:eol-style property to the MediaPlayerPrivateAVFoundationObjC.* files.2755 2756 Also, for some reason, Visual Studio decided to re-sort a couple files in \inspector\front-end\ in WebCore.vcproj, even though2757 I just re-sorted the project in r93215.2758 2759 Reviewed by Eric Carlson.2760 2761 No new tests; no functional change.2762 2763 * WebCore.vcproj/WebCore.vcproj: Moved platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.* files to platform/graphics/avfoundation/cf.2764 2765 * WebCore.vcproj/WebCoreMediaQT.vsprops: Added $(ProjectDir)..\platform\graphics\avfoundation\cf to include paths.2766 2767 * WebCore.xcodeproj/project.pbxproj: Moved platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.* files to platform/graphics/avfoundation/objc/.2768 2769 * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp: Removed.2770 * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.h: Removed.2771 * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h: Removed.2772 * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: Removed.2773 2774 * platform/graphics/avfoundation/cf: Added.2775 * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: Copied from Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp.2776 * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h: Copied from Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.h.2777 2778 * platform/graphics/avfoundation/objc: Added.2779 * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: Copied from Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h.2780 * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: Copied from Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm.2781 2782 2011-08-17 Luke Macpherson <macpherson@chromium.org>2783 2784 Only set m_fontDirty if TextSizeAdjust is actually changed.2785 https://bugs.webkit.org/show_bug.cgi?id=660222786 2787 Reviewed by Darin Adler.2788 2789 No new tests. Refactoring only.2790 2791 Reduces instances where the font information is dirtied to save recalculation where it is not necessary.2792 2793 * css/CSSStyleSelector.cpp:2794 (WebCore::CSSStyleSelector::applyProperty):2795 Call new setTextSizeAdjust function.2796 * css/CSSStyleSelector.h:2797 (WebCore::CSSStyleSelector::setTextSizeAdjust):2798 Add wrapper for RenderStyle::setTextSizeAdjust() that automatically updates m_fontDirty.2799 * rendering/style/RenderStyle.h:2800 (WebCore::RenderStyle::setTextSizeAdjust):2801 Make setTextSizeAdjust return true if the unlderlying value was changed.2802 2803 2011-08-17 Kenichi Ishibashi <bashi@chromium.org>2804 2805 [Chromium] Crash in HarfbuzzFace::~HarfbuzzFace2806 https://bugs.webkit.org/show_bug.cgi?id=662112807 2808 Holds Skia's unique font ID instead of FontPlatformData to avoid accessing freed FontPlatformData.2809 2810 Reviewed by Tony Chang.2811 2812 No new tests; no functional change.2813 2814 * platform/graphics/chromium/HarfbuzzSkia.cpp:2815 (WebCore::releaseCachedHarfbuzzFace): Changed the argument.2816 (WebCore::HarfbuzzFace::HarfbuzzFace): Changed to have Skia's font uniqueID instead of FontPlatformData.2817 (WebCore::HarfbuzzFace::~HarfbuzzFace): Uses m_uniqueID to call releaseCachedHarfbuzzFace.2818 * platform/graphics/chromium/HarfbuzzSkia.h:2819 2820 2011-08-17 Jeff Miller <jeffm@apple.com>2821 2822 Re-sort the WebCore project with Visual Studio after recent changes that I assume were done by manually editing the XML.2823 2824 * WebCore.vcproj/WebCore.vcproj:2825 2826 2011-08-17 Sailesh Agrawal <sail@chromium.org>2827 2828 Chromium Mac: Fix implementation of wkScrollbarMinimumTotalLengthNeededForThumb to match WebKitSystemInterface2829 https://bugs.webkit.org/show_bug.cgi?id=663112830 2831 Reviewed by Dimitri Glazkov.2832 2833 Updated wkScrollbarMinimumTotalLengthNeededForThumb() based on the latest disassembly of libWebKitSystemInterfaceLion.a.2834 2835 * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:2836 (wkScrollbarMinimumTotalLengthNeededForThumb):2837 2838 2011-08-17 Steve Block <steveblock@google.com>2839 2840 Unreviewed, rolling out r93186.2841 http://trac.webkit.org/changeset/931862842 https://bugs.webkit.org/show_bug.cgi?id=661142843 2844 Breaks LayoutTests on Chromium canary bots2845 2846 * platform/graphics/chromium/LayerChromium.h:2847 * platform/graphics/chromium/LayerRendererChromium.cpp:2848 (WebCore::LayerRendererChromium::updateLayers):2849 (WebCore::LayerRendererChromium::drawLayersInternal):2850 (WebCore::LayerRendererChromium::drawLayer):2851 * platform/graphics/chromium/cc/CCLayerImpl.h:2852 2853 2011-08-17 Ryosuke Niwa <rniwa@webkit.org>2854 2855 Get rid of calls to deprecatedNode and deprecatedEditingOffset in2856 AccessibilityRenderObject.cpp and InsertTextCommand.cpp2857 https://bugs.webkit.org/show_bug.cgi?id=660142858 2859 Reviewed by Hajime Morita.2860 2861 Removed calls to deprecatedNode and deprecatedEditingOffsets in the following files.2862 2863 * accessibility/AccessibilityRenderObject.cpp:2864 (WebCore::AccessibilityRenderObject::indexForVisiblePosition): Calls Position::rootEditableElement2865 and Range::setEnd(const Position&, ExceptionCode) instead of manually pulling deprecatedNode2866 and deprecatedEditingOffset.2867 (WebCore::AccessibilityRenderObject::index): Abstracted the logic to loop through render objects2868 from deprecatedNodes' renderer to m_renderer as renderObjectContainsPosition.2869 * dom/Position.h:2870 (WebCore::Position::rootEditableElement): Added.2871 * dom/Range.cpp:2872 (WebCore::Range::setStart): Added.2873 (WebCore::Range::setEnd): Added.2874 * dom/Range.h:2875 * editing/InsertTextCommand.cpp:2876 (WebCore::InsertTextCommand::insertTab):2877 * editing/RenderedPosition.cpp:2878 (WebCore::renderObjectContainsPosition): Extracted from AccessibilityRenderObject::index.2879 * editing/RenderedPosition.h:2880 2881 2011-08-17 Sailesh Agrawal <sail@chromium.org>2882 2883 Chromium Mac: Fix issue where scrollbar wouldn't be drawn until page finished loading2884 https://bugs.webkit.org/show_bug.cgi?id=662382885 2886 Reviewed by Dimitri Glazkov.2887 2888 Overlay scrollbars were not visible if the user scrolled a page while the page was loading. The sequence of events necessary to reproduce this bug were:2889 1. -[ScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:] is called2890 2. animation is delayed because shouldSuspendScrollAnimations() is true2891 3. ScrollAnimatorChromiumMac::scroll() is called before the ScrollAnimatorChromiumMac::m_initialScrollbarPaintTimer is fired.2892 4. At this point the scrollbar painter assumes the scrollbar is already visible (because of 1.) so the scrollbar's alpha stays at 0. Thus the scrollbar isn't visible until the page finishes loading.2893 It turns out that the root problem was that when the initialScrollbarPainterTimer fired I wasn't flashing the scrollbar correctly. My implementation of wkScrollbarPainterForceFlashScrollers() just called flashScrollers. The Safari implementation of this function also calls hideOverlayScrollers. Calling hideOverlayScrollers causes the alpha to change to 0 which prevents step 4 from happening.2894 2895 Also, now that wkScrollbarPainterForceFlashScrollers is working correctly I don't need the extra logic I added to the initialScrollbarPainterTimer handler. That logic restarted the timer if shouldSuspendScrollAnimations() was true. But this isn't necessary since calling wkScrollbarPainterForceFlashScrollers() causes -[ScrollbarPainterDelegate setUpAnimation:...] to be called which does the exact same thing. Removing the extra logic reverts http://trac.webkit.org/changeset/92316.2896 2897 * platform/chromium/ScrollAnimatorChromiumMac.mm:2898 (WebCore::ScrollAnimatorChromiumMac::initialScrollbarPaintTimerFired):2899 * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:2900 (wkScrollbarPainterForceFlashScrollers):2901 2902 2011-08-16 Andrey Kosyakov <caseq@chromium.org>2903 2904 Web Inspector: maintain visible view hierarchy and dispatch common view events automatically2905 https://bugs.webkit.org/show_bug.cgi?id=661312906 2907 Reviewed by Pavel Feldman.2908 2909 Test: inspector/view-events.html2910 2911 - added a notion of an optional parent to a View2912 - maintain a list of View children2913 - dispatch common view events, such as show/hide/resize automatically through the hierarchy of visible views.2914 - promoted Panel's logic of (re)storing scroll positions to view2915 - demoted inheritScrollPositionFromView to a couple of views that need it.2916 2917 * inspector/front-end/ApplicationCacheItemsView.js:2918 (WebInspector.ApplicationCacheItemsView.prototype.onResize):2919 * inspector/front-end/ConsoleView.js:2920 (WebInspector.ConsoleView.prototype.populateStatusBar):2921 (WebInspector.ConsoleView.prototype.elementsToRestoreScrollPositionsFor):2922 * inspector/front-end/CookieItemsView.js:2923 (WebInspector.CookieItemsView.prototype.onResize):2924 (WebInspector.SimpleCookiesTable.prototype.onResize):2925 * inspector/front-end/DOMStorageItemsView.js:2926 (WebInspector.DOMStorageItemsView.prototype.onResize):2927 * inspector/front-end/DetailedHeapshotView.js:2928 (WebInspector.DetailedHeapshotView.prototype.onResize):2929 * inspector/front-end/Drawer.js:2930 (WebInspector.Drawer.prototype.set visibleView):2931 (WebInspector.Drawer.prototype.show):2932 (WebInspector.Drawer.prototype.hide):2933 (WebInspector.Drawer.prototype.onResize):2934 (WebInspector.Drawer.prototype._animateDrawerHeight.animationFinished):2935 (WebInspector.Drawer.prototype._animateDrawerHeight):2936 (WebInspector.Drawer.prototype._statusBarDragging):2937 (WebInspector.Drawer.prototype._endStatusBarDragging):2938 * inspector/front-end/ElementsPanel.js:2939 (WebInspector.ElementsPanel.prototype.onResize):2940 * inspector/front-end/ExtensionPanel.js:2941 * inspector/front-end/FontView.js:2942 (WebInspector.FontView.prototype.onResize):2943 * inspector/front-end/IFrameView.js:2944 (WebInspector.IFrameView):2945 * inspector/front-end/NetworkItemView.js:2946 (WebInspector.NetworkItemView.prototype._installHighlightSupport):2947 * inspector/front-end/NetworkPanel.js:2948 (WebInspector.NetworkLogView):2949 (WebInspector.NetworkLogView.prototype.elementsToRestoreScrollPositionsFor):2950 (WebInspector.NetworkLogView.prototype.onResize):2951 (WebInspector.NetworkLogView.prototype.wasShown):2952 (WebInspector.NetworkLogView.prototype.willHide):2953 (WebInspector.NetworkPanel):2954 (WebInspector.NetworkPanel.prototype.show):2955 (WebInspector.NetworkPanel.prototype._showResource):2956 (WebInspector.NetworkPanel.prototype._closeVisibleResource):2957 * inspector/front-end/Panel.js:2958 (WebInspector.Panel.prototype.show):2959 (WebInspector.Panel.prototype.hide):2960 (WebInspector.Panel.prototype.performSearch.processChunk):2961 (WebInspector.Panel.prototype.performSearch):2962 (WebInspector.Panel.prototype.updateSidebarWidth):2963 * inspector/front-end/PanelEnablerView.js:2964 (WebInspector.PanelEnablerView.prototype.show):2965 (WebInspector.PanelEnablerView.prototype.onResize):2966 * inspector/front-end/ProfileView.js:2967 (WebInspector.CPUProfileView.prototype.onResize):2968 * inspector/front-end/ProfilesPanel.js:2969 (WebInspector.ProfilesPanel.prototype.updateMainViewWidth):2970 * inspector/front-end/ResourceCookiesView.js:2971 (WebInspector.ResourceCookiesView.prototype.onResize):2972 * inspector/front-end/ResourcePreviewView.js:2973 (WebInspector.ResourcePreviewView.prototype.contentLoaded):2974 * inspector/front-end/ResourceResponseView.js:2975 (WebInspector.ResourceResponseView.prototype.contentLoaded):2976 * inspector/front-end/ResourceTimingView.js:2977 (WebInspector.ResourceTimingView.prototype.show):2978 * inspector/front-end/ResourcesPanel.js:2979 (WebInspector.ResourcesPanel.prototype.show):2980 (WebInspector.ResourcesPanel.prototype._innerShowView):2981 (WebInspector.ResourcesPanel.prototype.closeVisibleView):2982 (WebInspector.ResourcesPanel.prototype.updateMainViewWidth):2983 (WebInspector.FrameResourceTreeElement.prototype._recreateSourceView):2984 * inspector/front-end/ScriptsPanel.js:2985 (WebInspector.ScriptsPanel.prototype.show):2986 (WebInspector.ScriptsPanel.prototype._createSourceFrame):2987 (WebInspector.ScriptsPanel.prototype._removeSourceFrame):2988 (WebInspector.ScriptsPanel.prototype.setSidebarWidth):2989 * inspector/front-end/SourceFrame.js:2990 (WebInspector.SourceFrame):2991 (WebInspector.SourceFrame.prototype.show):2992 (WebInspector.SourceFrame.prototype.willHide):2993 (WebInspector.SourceFrame.prototype.clearMessages):2994 (WebInspector.SourceFrame.prototype._setTextViewerDecorations):2995 (WebInspector.SourceFrame.prototype.inheritScrollPositions):2996 * inspector/front-end/TabbedPane.js:2997 (WebInspector.TabbedPane.prototype.appendTab):2998 * inspector/front-end/TextViewer.js:2999 (WebInspector.TextViewer.prototype.elementsToRestoreScrollPositionsFor):3000 (WebInspector.TextViewer.prototype.inheritScrollPositions):3001 (WebInspector.TextViewer.prototype.onResize):3002 * inspector/front-end/TimelinePanel.js:3003 (WebInspector.TimelinePanel.prototype.onResize):3004 (WebInspector.TimelinePanel.prototype.elementsToRestoreScrollPositionsFor):3005 (WebInspector.TimelinePanel.prototype.show):3006 * inspector/front-end/View.js:3007 (WebInspector.View):3008 (WebInspector.View.prototype.wasShown):3009 (WebInspector.View.prototype.willHide):3010 (WebInspector.View.prototype._innerShow):3011 (WebInspector.View.prototype.show):3012 (WebInspector.View.prototype._innerHide):3013 (WebInspector.View.prototype.hide):3014 (WebInspector.View.prototype._detach):3015 (WebInspector.View.prototype.elementsToRestoreScrollPositionsFor):3016 (WebInspector.View.prototype.storeScrollPositions):3017 (WebInspector.View.prototype.restoreScrollPositions):3018 (WebInspector.View.prototype.addChildView):3019 (WebInspector.View.prototype.removeChildView):3020 (WebInspector.View.prototype.onResize):3021 (WebInspector.View.prototype.doResize):3022 (WebInspector.View.prototype.dispatchToSelfAndVisibleChildren):3023 (WebInspector.View.prototype.dispatchToVisibleChildren):3024 * inspector/front-end/inspector.js:3025 (WebInspector.windowResize):3026 3027 2011-08-16 Luke Macpherson <macpherson@chromium.org>3028 3029 Represent RenderStyle::textOverflow property using an enum instead of a bool.3030 https://bugs.webkit.org/show_bug.cgi?id=663563031 3032 Reviewed by Dan Bernstein.3033 3034 No new tests - no behavioral changes.3035 3036 * css/CSSPrimitiveValueMappings.h:3037 (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):3038 Support cast from TextOverflow to CSSPrimitiveValue.3039 (WebCore::CSSPrimitiveValue::operator TextOverflow):3040 Support cast from CSSPrimitiveValue to TextOverflow.3041 * css/CSSStyleSelector.cpp:3042 (WebCore::CSSStyleSelector::applyProperty):3043 Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro for text overflow.3044 * rendering/style/RenderStyle.h:3045 (WebCore::InheritedFlags::textOverflow):3046 Return TextOverflow enum.3047 (WebCore::InheritedFlags::setTextOverflow):3048 Accept TextOverflow enum parameter.3049 (WebCore::InheritedFlags::initialTextOverflow):3050 Return TextOverflowClip.3051 * rendering/style/RenderStyleConstants.h:3052 Define TextOverflow enum.3053 * rendering/style/StyleRareNonInheritedData.h:3054 Change representation of text overflow from bool to one-bit unsigned.3055 3056 2011-08-16 Jeff Miller <jeffm@apple.com>3057 3058 Apple's Windows production build should fail to compile if AVFoundation is not enabled3059 https://bugs.webkit.org/show_bug.cgi?id=663393060 3061 Generate a compile-time error for Production builds if !USE(AVFOUNDATION).3062 3063 Reviewed by Darin Adler.3064 3065 * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp: Generate a compile-time error for Production builds if !USE(AVFOUNDATION).3066 3067 2011-08-16 David Levin <levin@chromium.org>3068 3069 REGRESSION (r89086): All worker xhr requests trigger preflight requests.3070 https://bugs.webkit.org/show_bug.cgi?id=663403071 3072 Reviewed by Adam Barth.3073 3074 Test coming in a more comprehensive patch shortly. This is just a very targetted3075 patch to allow for easier merging.3076 3077 * loader/CrossOriginAccessControl.cpp:3078 (WebCore::isOnAccessControlSimpleRequestHeaderWhitelist): Add referer to the list3079 of whitelisted headers. It can't be set by xhr so it is ok to whitelist it, but it is3080 set before calling this function. This is similar to what is done for "origin" in here.3081 3082 2011-08-16 Shawn Singh <shawnsingh@chromium.org>3083 3084 Computing screen-space transform for LayerChromium and CCLayerImpl3085 https://bugs.webkit.org/show_bug.cgi?id=661143086 3087 Reviewed by James Robinson.3088 3089 Test: compositing/backface-visibility-hierarchical-transform.html3090 3091 Added a data member to LayerChromium and CCLayerImpl that holds3092 the screen-space transform. The transform is computed in3093 calculateDrawTransformsAndVisibility(), which is used during3094 updating (LayerChromium) and drawing (CCLayerImpl). This transform3095 will also be used for other things, such as HUD drawing, in upcoming3096 patches.3097 3098 Also fixed a FIXME in LayerRendererChromium::drawLayer, which3099 was not computing the entire hierarchy of transforms to determine3100 back-face visibility. Now it simply uses the screen space transform.3101 3102 * platform/graphics/chromium/LayerChromium.h:3103 (WebCore::LayerChromium::screenSpaceDrawTransform):3104 (WebCore::LayerChromium::setScreenSpaceDrawTransform):3105 * platform/graphics/chromium/LayerRendererChromium.cpp:3106 (WebCore::LayerRendererChromium::updateLayers):3107 (WebCore::LayerRendererChromium::drawLayersInternal):3108 (WebCore::LayerRendererChromium::drawLayer):3109 (WebCore::calculateDrawTransformsAndVisibility):3110 * platform/graphics/chromium/cc/CCLayerImpl.h:3111 (WebCore::CCLayerImpl::screenSpaceDrawTransform):3112 (WebCore::CCLayerImpl::setScreenSpaceDrawTransform):3113 3114 2011-08-16 Hayato Ito <hayato@chromium.org>3115 3116 Implement proper handling of events which happen in children of shadow hosts.3117 https://bugs.webkit.org/show_bug.cgi?id=662853118 3119 Reviewed by Dimitri Glazkov.3120 3121 Fix the issue where a shadow host stops an event propagation if an3122 event happens at the children of shadow hosts, outside of the shadow root.3123 3124 Test: fast/dom/shadow/shadow-contents-event.html3125 3126 * dom/EventDispatcher.cpp:3127 (WebCore::EventDispatcher::adjustToShadowBoundaries):3128 3129 2011-08-16 Per-Erik Brodin <per-erik.brodin@ericsson.com>3130 3131 Make it possible to explicitly prevent a preflight via ThreadableLoaderOptions3132 https://bugs.webkit.org/show_bug.cgi?id=656943133 3134 Reviewed by Alexey Proskuryakov.3135 3136 No new tests since there is no change in behavior.3137 3138 * fileapi/FileReaderLoader.cpp:3139 (WebCore::FileReaderLoader::start):3140 * loader/DocumentThreadableLoader.cpp:3141 (WebCore::DocumentThreadableLoader::DocumentThreadableLoader):3142 (WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):3143 * loader/ThreadableLoader.h:3144 (WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions):3145 * notifications/Notification.cpp:3146 (WebCore::Notification::startLoading):3147 * xml/XMLHttpRequest.cpp:3148 (WebCore::XMLHttpRequest::createRequest):3149 3150 2011-08-16 Scott Byer <scottbyer@chromium.org>3151 3152 Fix spelling error.3153 https://bugs.webkit.org/show_bug.cgi?id=662613154 3155 Reviewed by Adam Barth.3156 3157 No functional change, no tests needed.3158 3159 * platform/ScrollAnimator.cpp:3160 (WebCore::ScrollAnimator::scroll):3161 (WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation):3162 (WebCore::ScrollAnimator::notifyPositionChanged):3163 * platform/ScrollAnimator.h:3164 * platform/ScrollAnimatorNone.cpp:3165 (WebCore::ScrollAnimatorNone::scrollToOffsetWithoutAnimation):3166 (WebCore::ScrollAnimatorNone::animationTimerFired):3167 * platform/ScrollAnimatorWin.cpp:3168 (WebCore::ScrollAnimatorWin::scrollToOffsetWithoutAnimation):3169 (WebCore::ScrollAnimatorWin::animateScroll):3170 * platform/chromium/ScrollAnimatorChromiumMac.h:3171 * platform/chromium/ScrollAnimatorChromiumMac.mm:3172 (WebCore::ScrollAnimatorChromiumMac::immediateScrollToPoint):3173 (WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaX):3174 (WebCore::ScrollAnimatorChromiumMac::immediateScrollByDeltaY):3175 (WebCore::ScrollAnimatorChromiumMac::notifyPositionChanged):3176 * platform/mac/ScrollAnimatorMac.h:3177 * platform/mac/ScrollAnimatorMac.mm:3178 (WebCore::ScrollAnimatorMac::immediateScrollToPoint):3179 (WebCore::ScrollAnimatorMac::immediateScrollByDeltaX):3180 (WebCore::ScrollAnimatorMac::immediateScrollByDeltaY):3181 (WebCore::ScrollAnimatorMac::notifyPositionChanged):3182 3183 2011-08-16 Joseph Pecoraro <joepeck@webkit.org>3184 3185 ASSERT in fast/css/custom-font-xheight.html3186 https://bugs.webkit.org/show_bug.cgi?id=663283187 3188 Reviewed by Dan Bernstein.3189 3190 In r93140 the temporary font created for a remote CSS font face3191 was created without being retained. We need to protect the3192 font from being purged while we hold onto it, so add a font cache3193 purge preventer.3194 3195 * css/CSSFontFaceSource.cpp:3196 (WebCore::CSSFontFaceSource::getFontData):3197 3198 2011-08-16 Joseph Pecoraro <joepeck@webkit.org>3199 3200 Unreviewed Chromium Windows build fix after r93140. Take 4.3201 Namespace the now public enum as FontCache::ShouldRetain.3202 3203 * platform/graphics/chromium/FontCacheChromiumWin.cpp:3204 (WebCore::GetLastResortFallbackFontProcData::GetLastResortFallbackFontProcData):3205 3206 2011-08-15 Stephen White <senorblanco@chromium.org>3207 3208 Canvas resizing can be slow3209 https://bugs.webkit.org/show_bug.cgi?id=662513210 3211 Canvas resizing was slow due to re-allocation of the ImageBuffer on3212 each size change (width or height). This was introduced inadvertently3213 by calls to isAccelerated() during canvas reset(). Since we won't3214 know if we have successfully accelerated until ImageBuffer creation,3215 move the compositor invalidation to createImageBuffer() as well.3216 This patch also attempts to unify the Skia and CG accelerated canvas3217 paths. The DrawingBuffer used by the Skia path is now owned by3218 ImageBuffer[Skia], similar to how the IOSurface is owned by3219 ImageBuffer[CG]. Some of the logic for when to accelerate was moved3220 into HTMLCanvasElement and unified with the CG path. Acceleration is3221 also now enabled by the same "Accelerated" ImageBuffer create flag3222 used by the CG path. DrawingBuffer is now re-created even for a3223 same-size change (same as the memory buffer), but we speed it up3224 by calling GraphicsContext3D::texImage2D() with a NULL pixels ptr3225 instead of GraphicsContext3D::teximage2DResourceSafe() (no need to3226 clear it, since it's done with a glClear anyway).3227 3228 Reviewed by Kenneth Russell.3229 3230 Covered by existing tests in fast/canvas and canvas/philip.3231 3232 * html/HTMLCanvasElement.cpp:3233 (WebCore::HTMLCanvasElement::reset):3234 Don't call isAccelerated() from reset(), since we don't want to3235 inadvertently create the ImageBuffer. Also, since we won't know if3236 we have successfully accelerated until createImageBuffer() is3237 called, defer the compositor invalidation to createImageBuffer() as3238 well.3239 (WebCore::HTMLCanvasElement::shouldAccelerate):3240 Unify the CG and Skia ports' logic for when to accelerate (Skia3241 logic moved in from CanvasRenderingContext2D).3242 (WebCore::HTMLCanvasElement::createImageBuffer):3243 Use the unified shouldAccelerate() logic, and pass it as a flag3244 to ImageBuffer. Do compositor invalidation as well.3245 * html/HTMLCanvasElement.h:3246 (WebCore::HTMLCanvasElement::hasCreatedImageBuffer):3247 Expose hasCreatedImageBuffer() publically, so3248 CanvasRenderingContext2D::isAccelerated() doesn't inadvertently create3249 it.3250 * html/canvas/CanvasRenderingContext2D.cpp:3251 (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):3252 (WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D):3253 Remove all acceleration setting and resetting, since it's now done3254 during ImageBuffer creation.3255 (WebCore::CanvasRenderingContext2D::isAccelerated):3256 Check if the image buffer was created, so we don't inadvertently3257 create it here.3258 (WebCore::CanvasRenderingContext2D::paintsIntoCanvasBuffer):3259 Don't call GraphicsContext3D::paintsIntoCanvasBuffer(), since its3260 WebViewImpl may be null. Ask the render tree instead.3261 (WebCore::CanvasRenderingContext2D::reset):3262 Don't reset acceleration here, since we don't own it anymore.3263 (WebCore::CanvasRenderingContext2D::platformLayer):3264 Call into the ImageBuffer to get our PlatformLayer.3265 * html/canvas/CanvasRenderingContext2D.h:3266 Remove m_drawingBuffer, and all acceleration-related calls.3267 * platform/graphics/GraphicsContext.cpp:3268 * platform/graphics/GraphicsContext.h:3269 Remove setGraphicsContext3D(), and paintsIntoImageBuffer().3270 * platform/graphics/ImageBuffer.cpp:3271 (WebCore::ImageBuffer::platformLayer):3272 Implement a dummy platformLayer() call for non-skia ports.3273 * platform/graphics/ImageBuffer.h:3274 Declare a platformLayer() call (USE(ACCELERATED_COMPOSITING) only).3275 * platform/graphics/chromium/ImageBufferDataSkia.h:3276 Add a DrawingBuffer data member.3277 * platform/graphics/gpu/DrawingBuffer.cpp:3278 (WebCore::DrawingBuffer::reset):3279 Use texImage2D() with a NULL ptr, not texImage2DResourceSafe().3280 Since we immediately clear the framebuffer via glClear(), this whole3281 resource safe business is overkill.3282 * platform/graphics/skia/GraphicsContextSkia.cpp:3283 Remove setGraphicsContext3D() and paintsIntoImageBuffer(). This3284 functionality is handled by ImageBuffer now.3285 * platform/graphics/skia/ImageBufferSkia.cpp:3286 (WebCore::ImageBuffer::ImageBuffer):3287 Give the ImageBufferData ownership of the DrawingBuffer.3288 (WebCore::ImageBuffer::platformLayer):3289 Implement an accessor for the DrawingBuffer's PlatformLayer.3290 * platform/graphics/skia/PlatformContextSkia.cpp:3291 (WebCore::PlatformContextSkia::setGraphicsContext3D):3292 * platform/graphics/skia/PlatformContextSkia.h:3293 Remove isPathSkiaSafe() extern (unused).3294 Remove paintsIntoImageBuffer() (now unused). Remove IntSize param3295 from setGraphicsContext3D() (unused).3296 3297 2011-08-16 Joseph Pecoraro <joepeck@webkit.org>3298 3299 Unreviewed Chromium Windows build fix after r93140. Take 3.3300 Include the proper includes!3301 3302 * platform/graphics/FontCache.h:3303 3304 2011-08-16 Mihnea Ovidenie <mihnea@adobe.com>3305 3306 Unmatrix algorithm implementation is wrong3307 https://bugs.webkit.org/show_bug.cgi?id=660803308 3309 Reviewed by Dean Jackson.3310 3311 Current version of the algorithm negates only the scaleX while3312 it should negate also scaleY and scaleZ when appropriate.3313 3314 Test: animations/animation-matrix-negative-scale-unmatrix.html3315 3316 * platform/graphics/transforms/TransformationMatrix.cpp:3317 (WebCore::decompose):3318 3319 2011-08-16 Joseph Pecoraro <joepeck@webkit.org>3320 3321 Unreviewed Chromium Windows build fix after r93140.3322 3323 This just makes the troublesome enum public. If this3324 fixes the build I will file a follow-up bug to clean-up3325 these build issues and either keep the enum public and3326 cleanup other functions or restore the enum to private.3327 There is no harm in making the enum public right now.3328 3329 * platform/graphics/FontCache.h:3330 3331 2011-08-16 Joseph Pecoraro <joepeck@webkit.org>3332 3333 Unreviewed Chromium Windows build fix after r93140.3334 3335 * platform/graphics/FontCache.h:3336 3337 2011-08-16 Joseph Pecoraro <joepeck@webkit.org>3338 3339 Unreviewed Windows and Chromium Windows build fix after r93140.3340 3341 * platform/graphics/FontCache.h:3342 * platform/graphics/chromium/FontCacheChromiumWin.cpp:3343 (WebCore::FontCache::fontDataFromDescriptionAndLogFont):3344 (WebCore::getLastResortFallbackFontProc):3345 (WebCore::FontCache::getLastResortFallbackFont):3346 * platform/graphics/win/FontCacheWin.cpp:3347 (WebCore::FontCache::fontDataFromDescriptionAndLogFont):3348 (WebCore::FontCache::getLastResortFallbackFont):3349 3350 2011-08-16 Adam Roben <aroben@apple.com>3351 3352 Make placeholder text remain visible until a character is typed on Windows3353 3354 Fixes <http://webkit.org/b/66319> Placeholder text in text fields disappears when the field3355 is focused on Windows, which doesn't match Lion or Windows native text fields3356 3357 Covered by existing tests (which are currently failing on the bots until this patch lands).3358 3359 Reviewed by Dave Hyatt.3360 3361 * rendering/RenderThemeSafari.h:3362 (WebCore::RenderThemeSafari::shouldShowPlaceholderWhenFocused):3363 * rendering/RenderThemeWin.h:3364 (WebCore::RenderThemeWin::shouldShowPlaceholderWhenFocused):3365 Added overrides to return true.3366 3367 2011-08-16 David Hyatt <hyatt@apple.com>3368 3369 https://bugs.webkit.org/show_bug.cgi?id=662543370 3371 Make region invalidation and repainting work properly. We do this by making RenderFlowThreads into3372 repaint containers and then issuing new repaints in the regions that contain the invalidated flow thread3373 content.3374 3375 Reviewed by Simon Fraser.3376 3377 Added new tests in fast/repaint.3378 3379 * rendering/RenderFlowThread.cpp:3380 (WebCore::RenderFlowThread::repaintRectangleInRegions):3381 * rendering/RenderFlowThread.h:3382 * rendering/RenderObject.cpp:3383 (WebCore::RenderObject::enclosingRenderFlowThread):3384 (WebCore::RenderObject::containerForRepaint):3385 (WebCore::RenderObject::repaintUsingContainer):3386 * rendering/RenderObject.h:3387 * rendering/RenderView.cpp:3388 (WebCore::RenderView::RenderView):3389 (WebCore::RenderView::renderFlowThreadWithName):3390 * rendering/RenderView.h:3391 (WebCore::RenderView::hasRenderFlowThreads):3392 3393 2011-08-16 Joseph Pecoraro <joepeck@webkit.org>3394 3395 Abandoned Memory: Temporary CSS Fonts May Never Be Purged3396 https://bugs.webkit.org/show_bug.cgi?id=661533397 3398 Reviewed by Dan Bernstein.3399 3400 While a remote CSS font face is loading we fallback to a3401 temporary font. We don't want to retain the fallback font3402 because noone takes ownership of the temporary font. This3403 patch adds a way to get an uncached fallback font, which3404 plumbs the ShouldRetain enum through the different platform3405 implementations of getLastResortFallbackFont.3406 3407 No new tests, no functional change.3408 3409 * css/CSSFontFaceSource.cpp:3410 (WebCore::CSSFontFaceSource::getFontData):3411 * platform/graphics/FontCache.cpp:3412 (WebCore::FontCache::getNonRetainedLastResortFallbackFont):3413 * platform/graphics/FontCache.h:3414 * platform/graphics/chromium/FontCacheChromiumWin.cpp:3415 (WebCore::fontDataFromDescriptionAndLogFont):3416 (WebCore::GetLastResortFallbackFontProcData::GetLastResortFallbackFontProcData):3417 (WebCore::getLastResortFallbackFontProc):3418 (WebCore::FontCache::getLastResortFallbackFont):3419 * platform/graphics/chromium/FontCacheLinux.cpp:3420 (WebCore::FontCache::getLastResortFallbackFont):3421 * platform/graphics/freetype/FontCacheFreeType.cpp:3422 (WebCore::FontCache::getLastResortFallbackFont):3423 * platform/graphics/haiku/FontCacheHaiku.cpp:3424 (WebCore::FontCache::getLastResortFallbackFont):3425 * platform/graphics/mac/FontCacheMac.mm:3426 (WebCore::FontCache::getLastResortFallbackFont):3427 * platform/graphics/pango/FontCachePango.cpp:3428 (WebCore::FontCache::getLastResortFallbackFont):3429 * platform/graphics/qt/FontCacheQt.cpp:3430 (WebCore::FontCache::getLastResortFallbackFont):3431 * platform/graphics/win/FontCacheWin.cpp:3432 (WebCore::fontDataFromDescriptionAndLogFont):3433 (WebCore::FontCache::getLastResortFallbackFont):3434 * platform/graphics/wince/FontCacheWinCE.cpp:3435 * platform/graphics/wx/FontCacheWx.cpp:3436 (WebCore::FontCache::getLastResortFallbackFont):3437 3438 2011-08-16 Alexei Svitkine <asvitkine@chromium.org>3439 3440 Chromium Mac: Rubber banding gutter drawing3441 https://bugs.webkit.org/show_bug.cgi?id=662263442 3443 Make ScrollView::paintOverhangAreas() use the ScrollbarTheme::nativeTheme() to3444 draw the overhang areas.3445 Move default implementation to ScrollbarThemeComposite::paintOverhangAreas().3446 Add a different implementation for Chromium Mac.3447 3448 Reviewed by Dimitri Glazkov.3449 3450 No new tests since this is just refactoring code and adding a Chromium-specific path for overhang drawing.3451 3452 * platform/ScrollView.cpp:3453 (WebCore::ScrollView::wheelEvent):3454 * platform/ScrollbarTheme.h:3455 (WebCore::ScrollbarTheme::paintOverhangAreas):3456 * platform/ScrollbarThemeComposite.cpp:3457 (WebCore::ScrollbarThemeComposite::paintOverhangAreas):3458 * platform/ScrollbarThemeComposite.h:3459 * platform/chromium/ScrollbarThemeChromiumMac.h:3460 * platform/chromium/ScrollbarThemeChromiumMac.mm:3461 (WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):3462 (WebCore::scrollbarStateToThemeState):3463 (WebCore::ScrollbarThemeChromiumMac::paintTickmarks):3464 (WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):3465 3466 2011-08-12 Wyatt Carss <wcarss@chromium.org>3467 3468 Programmatically set selection should not have direction on Mac3469 https://bugs.webkit.org/show_bug.cgi?id=605293470 3471 Reviewed by Ryosuke Niwa.3472 3473 Modified default value of VisibleSelection->m_isDirectional from 'true'3474 to 'false' by adding a defaulted argument to several VisibleSelection3475 constructors to make programmatic selection be directionless by default3476 on Mac. Also modified several calls to VisibleSelection's constructors3477 to correctly preserve directionality.3478 3479 Near the end of FrameSelection::modify (presently FrameSelection.cpp:869)3480 a call to setExtent triggers an editing delegate that uses the3481 FrameSelection. The direction here should have been preserved from before,3482 but setIsDirectional was not called until after FrameSelection.cpp:869. It3483 has been moved up to make things behave.3484 3485 * WebCore.exp.in:3486 * editing/ApplyBlockElementCommand.cpp:3487 (WebCore::ApplyBlockElementCommand::doApply):3488 (WebCore::ApplyBlockElementCommand::formatSelection):3489 * editing/ApplyStyleCommand.cpp:3490 (WebCore::ApplyStyleCommand::updateStartEnd):3491 * editing/BreakBlockquoteCommand.cpp:3492 (WebCore::BreakBlockquoteCommand::doApply):3493 * editing/CompositeEditCommand.cpp:3494 (WebCore::CompositeEditCommand::moveParagraphWithClones):3495 (WebCore::CompositeEditCommand::moveParagraphs):3496 (WebCore::CompositeEditCommand::breakOutOfEmptyListItem):3497 (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):3498 * editing/CreateLinkCommand.cpp:3499 (WebCore::CreateLinkCommand::doApply):3500 * editing/DeleteSelectionCommand.cpp:3501 (WebCore::DeleteSelectionCommand::setStartingSelectionOnSmartDelete):3502 (WebCore::DeleteSelectionCommand::doApply):3503 * editing/Editor.cpp:3504 (WebCore::Editor::selectionForCommand):3505 * editing/FrameSelection.cpp:3506 (WebCore::shouldAlwaysUseDirectionalSelection):3507 (WebCore::FrameSelection::FrameSelection):3508 (WebCore::FrameSelection::moveTo):3509 (WebCore::FrameSelection::setNonDirectionalSelectionIfNeeded):3510 (WebCore::FrameSelection::modify):3511 (WebCore::FrameSelection::setBase):3512 (WebCore::FrameSelection::setExtent):3513 * editing/FrameSelection.h:3514 * editing/InsertLineBreakCommand.cpp:3515 (WebCore::InsertLineBreakCommand::doApply):3516 * editing/InsertListCommand.cpp:3517 (WebCore::InsertListCommand::doApply):3518 * editing/InsertParagraphSeparatorCommand.cpp:3519 (WebCore::InsertParagraphSeparatorCommand::doApply):3520 * editing/InsertTextCommand.cpp:3521 (WebCore::InsertTextCommand::performTrivialReplace):3522 (WebCore::InsertTextCommand::doApply):3523 * editing/MoveSelectionCommand.cpp:3524 (WebCore::MoveSelectionCommand::doApply):3525 * editing/ReplaceSelectionCommand.cpp:3526 (WebCore::ReplaceSelectionCommand::completeHTMLReplacement):3527 * editing/TypingCommand.cpp:3528 (WebCore::TypingCommand::makeEditableRootEmpty):3529 (WebCore::TypingCommand::deleteKeyPressed):3530 (WebCore::TypingCommand::forwardDeleteKeyPressed):3531 * editing/VisibleSelection.cpp:3532 (WebCore::VisibleSelection::VisibleSelection):3533 * editing/VisibleSelection.h:3534 * page/EventHandler.cpp:3535 (WebCore::EventHandler::updateSelectionForMouseDownDispatchingSelectStart):3536 (WebCore::EventHandler::updateSelectionForMouseDrag):3537 3538 2011-08-16 Jeffrey Pfau <jpfau@apple.com>3539 3540 New XML parser: Add document fragment parser3541 https://bugs.webkit.org/show_bug.cgi?id=663173542 3543 Reviewed by Adam Barth.3544 3545 * dom/DocumentFragment.cpp:3546 (WebCore::DocumentFragment::parseXML):3547 * xml/parser/NewXMLDocumentParser.cpp:3548 (WebCore::NewXMLDocumentParser::NewXMLDocumentParser):3549 (WebCore::NewXMLDocumentParser::parseDocumentFragment):3550 * xml/parser/NewXMLDocumentParser.h:3551 (WebCore::NewXMLDocumentParser::create):3552 * xml/parser/XMLTokenizer.h:3553 * xml/parser/XMLTreeBuilder.cpp:3554 (WebCore::XMLTreeBuilder::XMLTreeBuilder):3555 (WebCore::XMLTreeBuilder::pushCurrentNode):3556 * xml/parser/XMLTreeBuilder.h:3557 (WebCore::XMLTreeBuilder::create):3558 (WebCore::XMLTreeBuilder::NodeStackItem::node):3559 3560 2011-08-16 Jeffrey Pfau <jpfau@apple.com>3561 3562 New XML parser: Replace assertions regarding character data in the prolog with proper checks3563 https://bugs.webkit.org/show_bug.cgi?id=662693564 3565 Reviewed by Adam Barth.3566 3567 This patch checks for character data in the prolog (which is illegal in XML) and discards it, instead of failing an assertion.3568 3569 * xml/parser/XMLTreeBuilder.cpp:3570 (WebCore::XMLTreeBuilder::processProcessingInstruction):3571 (WebCore::XMLTreeBuilder::processXMLDeclaration):3572 (WebCore::XMLTreeBuilder::processDOCTYPE):3573 (WebCore::XMLTreeBuilder::enterText):3574 (WebCore::XMLTreeBuilder::failOnText):3575 * xml/parser/XMLTreeBuilder.h:3576 3577 2011-08-16 Alexander Pavlov <apavlov@chromium.org>3578 3579 Web Inspector: word wrap long edits3580 https://bugs.webkit.org/show_bug.cgi?id=655123581 3582 Reviewed by Pavel Feldman.3583 3584 * inspector/front-end/inspector.css:3585 (.styles-section .properties li.child-editing):3586 3587 2011-08-16 Pavel Feldman <pfeldman@google.com>3588 3589 Web Inspector: convert DOM breakpoint types to strings.3590 https://bugs.webkit.org/show_bug.cgi?id=663043591 3592 Reviewed by Yury Semikhatsky.3593 3594 * inspector/Inspector.json:3595 * inspector/InspectorDOMDebuggerAgent.cpp:3596 (WebCore::domTypeForName):3597 (WebCore::InspectorDOMDebuggerAgent::setDOMBreakpoint):3598 (WebCore::InspectorDOMDebuggerAgent::removeDOMBreakpoint):3599 * inspector/InspectorDOMDebuggerAgent.h:3600 * inspector/front-end/DOMBreakpointsSidebarPane.js:3601 (WebInspector.DOMBreakpointsSidebarPane):3602 3603 2011-08-16 Pavel Feldman <pfeldman@google.com>3604 3605 Web Inspector: force pseudo element state when checking it in the styles sidebar.3606 https://bugs.webkit.org/show_bug.cgi?id=662923607 3608 This reverts http://trac.webkit.org/changeset/89132 and introduces InspectorInstrumentation3609 calls from the CSSStyleSelector for pseudo state processing. These calls are very fast:3610 they are guarded with the inline checks for the front-end count.3611 3612 Reviewed by David Hyatt.3613 3614 * css/CSSStyleSelector.cpp:3615 (WebCore::CSSStyleSelector::initForStyleResolve):3616 (WebCore::CSSStyleSelector::styleRulesForElement):3617 (WebCore::CSSStyleSelector::pseudoStyleRulesForElement):3618 (WebCore::CSSStyleSelector::checkSelector):3619 (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):3620 (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):3621 * css/CSSStyleSelector.h:3622 * inspector/InspectorCSSAgent.cpp:3623 (WebCore::computePseudoClassMask):3624 (WebCore::InspectorCSSAgent::InspectorCSSAgent):3625 (WebCore::InspectorCSSAgent::clearFrontend):3626 (WebCore::InspectorCSSAgent::forcePseudoState):3627 (WebCore::InspectorCSSAgent::getStylesForNode):3628 (WebCore::InspectorCSSAgent::didRemoveDocument):3629 (WebCore::InspectorCSSAgent::didRemoveDOMNode):3630 (WebCore::InspectorCSSAgent::clearPseudoState):3631 * inspector/InspectorCSSAgent.h:3632 * inspector/InspectorController.cpp:3633 (WebCore::InspectorController::disconnectFrontend):3634 * inspector/InspectorInstrumentation.cpp:3635 (WebCore::InspectorInstrumentation::forcePseudoStateImpl):3636 * inspector/InspectorInstrumentation.h:3637 (WebCore::InspectorInstrumentation::forcePseudoState):3638 3639 2011-08-16 Tony Chang <tony@chromium.org>3640 3641 Unreviewed, rolling out r93114.3642 http://trac.webkit.org/changeset/931143643 https://bugs.webkit.org/show_bug.cgi?id=662263644 3645 broke the chromium mac compile3646 3647 * platform/ScrollView.cpp:3648 (WebCore::ScrollView::wheelEvent):3649 * platform/ScrollbarTheme.h:3650 * platform/ScrollbarThemeComposite.cpp:3651 * platform/ScrollbarThemeComposite.h:3652 * platform/chromium/ScrollbarThemeChromiumMac.h:3653 * platform/chromium/ScrollbarThemeChromiumMac.mm:3654 (WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):3655 (WebCore::scrollbarStateToThemeState):3656 (WebCore::ScrollbarThemeChromiumMac::paintTickmarks):3657 * platform/mac/ScrollbarThemeMac.h:3658 3659 2011-08-16 Alexei Svitkine <asvitkine@chromium.org>3660 3661 Chromium Mac: Rubber banding gutter drawing3662 https://bugs.webkit.org/show_bug.cgi?id=662263663 3664 Make ScrollView::paintOverhangAreas() use the ScrollbarTheme::nativeTheme() to3665 draw the overhang areas.3666 Move default implementation to ScrollbarThemeComposite::paintOverhangAreas().3667 Add a different implementation for Chromium Mac.3668 3669 Reviewed by Dimitri Glazkov.3670 3671 No new tests since this is just refactoring code and adding a Chromium-specific path for overhang drawing.3672 3673 * platform/ScrollView.cpp:3674 (WebCore::ScrollView::wheelEvent):3675 * platform/ScrollbarTheme.h:3676 (WebCore::ScrollbarTheme::paintOverhangAreas):3677 * platform/ScrollbarThemeComposite.cpp:3678 (WebCore::ScrollbarThemeComposite::paintOverhangAreas):3679 * platform/ScrollbarThemeComposite.h:3680 * platform/chromium/ScrollbarThemeChromiumMac.h:3681 * platform/chromium/ScrollbarThemeChromiumMac.mm:3682 (WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):3683 (WebCore::scrollbarStateToThemeState):3684 (WebCore::ScrollbarThemeChromiumMac::paintTickmarks):3685 (WebCore::ScrollbarThemeChromiumMac::paintOverhangAreas):3686 3687 2011-08-16 Luke Macpherson <macpherson@chromium.org>3688 3689 Support cast between CSSPrimitiveValue and ETransformStyle3D and use in CSSStyleSelector.3690 https://bugs.webkit.org/show_bug.cgi?id=662733691 3692 Reviewed by Simon Fraser.3693 3694 No new tests - no functionality changed - refactoring only.3695 3696 * css/CSSPrimitiveValueMappings.h:3697 (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):3698 Define cast from CSSPrimitiveValue to ETransformStyle3D.3699 (WebCore::CSSPrimitiveValue::operator ETransformStyle3D):3700 Define cast from ETransformStyle3D to CSSPrimitiveValue.3701 * css/CSSStyleSelector.cpp:3702 (WebCore::CSSStyleSelector::applyProperty):3703 Use appropriate macro to handle CSSPropertyWebkitTransformStyle.3704 3705 2011-08-16 Luke Macpherson <macpherson@chromium.org>3706 3707 Use appropriate macro to handle CSSPropertyWebkitContentOrder in CSSStyleSelector::applyProperty()3708 https://bugs.webkit.org/show_bug.cgi?id=662793709 3710 Reviewed by Simon Fraser.3711 3712 No new tests - no functionality changed - simple refactoring only.3713 3714 * css/CSSStyleSelector.cpp:3715 (WebCore::CSSStyleSelector::applyProperty):3716 Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro to handle CSSPropertyWebkitContentOrder.3717 This works because PrimitiveValue now supports cast to int.3718 3719 2011-08-16 Eric Carlson <eric.carlson@apple.com>3720 3721 [REGRESSION] Media controls should always be enabled when scripting is disabled3722 https://bugs.webkit.org/show_bug.cgi?id=663033723 3724 Reviewed by Dimitri Glazkov.3725 3726 Tests: media/video-controls-no-scripting-iframe.html3727 media/video-controls-no-scripting.html3728 3729 * html/HTMLMediaElement.cpp:3730 (WebCore::HTMLMediaElement::attributeChanged): Move the controls enabling/disabling code3731 to configureMediaControls.3732 (WebCore::HTMLMediaElement::prepareForLoad): Call configureMediaControls.3733 (WebCore::HTMLMediaElement::configureMediaControls): New, move code duplicated in3734 attributeChanged and preDispatchEventHandler here.3735 (WebCore::HTMLMediaElement::preDispatchEventHandler): Move the controls enabling/disabling code3736 to configureMediaControls.3737 * html/HTMLMediaElement.h:3738 3739 2011-08-16 Pavel Feldman <pfeldman@google.com>3740 3741 Web Inspector: hide non-conservative methods from the protocol documentation.3742 https://bugs.webkit.org/show_bug.cgi?id=663013743 3744 Reviewed by Yury Semikhatsky.3745 3746 * inspector/Inspector.json:3747 3748 2011-08-16 Andras Becsi <abecsi@webkit.org>3749 3750 Web Inspector: nuke background events collection (dead feature)3751 https://bugs.webkit.org/show_bug.cgi?id=662963752 3753 Fix the GTK build after r93095.3754 3755 Unreviewed build fix.3756 3757 No new tests neede.3758 3759 * GNUmakefile.list.am: Remove nonexistent sources.3760 3761 2011-08-16 Andras Becsi <abecsi@webkit.org>3762 3763 Reviewed by Csaba Osztrogonác.3764 3765 Need AtomicStrings for the various font family names3766 https://bugs.webkit.org/show_bug.cgi?id=280243767 3768 Unify the usage of '-webkit' prefixed font family names by using3769 global AtomicStrings.3770 Use a .in file to generate the needed sources through make_names.pl.3771 3772 No new tests needed.3773 3774 * CMakeLists.txt:3775 * CodeGenerators.pri:3776 * DerivedSources.make:3777 * GNUmakefile.am:3778 * GNUmakefile.list.am:3779 * WebCore.gyp/WebCore.gyp:3780 * WebCore.gyp/scripts/action_makenames.py:3781 * WebCore.gypi:3782 * WebCore.vcproj/WebCore.vcproj:3783 * WebCore.xcodeproj/project.pbxproj:3784 * css/CSSComputedStyleDeclaration.cpp:3785 (WebCore::identifierForFamily):3786 * css/CSSFontSelector.cpp:3787 (WebCore::CSSFontSelector::addFontFaceRule):3788 (WebCore::fontDataForGenericFamily):3789 * css/CSSStyleSelector.cpp:3790 (WebCore::CSSStyleSelector::applyProperty):3791 * css/WebKitFontFamilyNames.in: Added.3792 * dom/make_names.pl:3793 * page/Frame.cpp:3794 (WebCore::Frame::Frame):3795 * platform/graphics/FontCache.cpp:3796 (WebCore::FontCache::getFontData):3797 * platform/graphics/FontDescription.h:3798 (WebCore::FontDescription::useFixedDefaultSize):3799 3800 2011-08-16 Pavel Feldman <pfeldman@google.com>3801 3802 Web Inspector: nuke background events collection (dead feature)3803 https://bugs.webkit.org/show_bug.cgi?id=662963804 3805 Reviewed by Yury Semikhatsky.3806 3807 * CMakeLists.txt:3808 * WebCore.gypi:3809 * WebCore.pro:3810 * WebCore.vcproj/WebCore.vcproj:3811 * WebCore.xcodeproj/project.pbxproj:3812 * inspector/EventsCollector.cpp: Removed.3813 * inspector/EventsCollector.h: Removed.3814 * inspector/Inspector.json:3815 * inspector/InspectorFrontendProxy.cpp: Removed.3816 * inspector/InspectorFrontendProxy.h: Removed.3817 * inspector/InspectorResourceAgent.cpp:3818 (WebCore::InspectorResourceAgent::setFrontend):3819 (WebCore::InspectorResourceAgent::clearFrontend):3820 (WebCore::InspectorResourceAgent::InspectorResourceAgent):3821 * inspector/InspectorResourceAgent.h:3822 * inspector/front-end/NetworkPanel.js:3823 (WebInspector.NetworkLogView):3824 3825 2011-08-16 Lindsay Mathieson <lindsay.mathieson@gmail.com>3826 3827 [Qt] Missing spell check support3828 https://bugs.webkit.org/show_bug.cgi?id=441143829 3830 Reviewed by Benjamin Poulain.3831 3832 Add drawErrorUnderline() from Cairo to render the line for text checking on the Qt port.3833 3834 * platform/graphics/qt/GraphicsContextQt.cpp:3835 (WebCore::drawErrorUnderline):3836 (WebCore::GraphicsContext::drawLineForTextChecking):3837 3838 2011-08-15 MORITA Hajime <morrita@google.com>3839 3840 REGRESSION(r70598): [Chromium] Style changes in textInput event can prevent from updating <textarea> value.3841 https://bugs.webkit.org/show_bug.cgi?id=662163842 3843 Reviewed by Ryosuke Niwa.3844 3845 Element::spellcheckAttributeState() uses Element::hasAttribute(),3846 which calls updateStyleAttribute(), which potentially makes style3847 dirty. But that is problematic since Editor calls spellcheckAttributeState()3848 during the spell-checking phase and make the style dirty,3849 which can trigger re-layout, which wipes the shadow tree of a textarea3850 out by pre-committed "value" text.3851 3852 This change removes the hasAttribute() call from3853 spellcheckAttributeState().3854 3855 Test: editing/input/style-change-during-input.html3856 3857 * dom/Element.cpp:3858 (WebCore::Element::spellcheckAttributeState):3859 3860 2011-08-15 Gyuyoung Kim <gyuyoung.kim@samsung.com>3861 3862 [CMAKE] Wrap files of websocket and worker in each macro.3863 https://bugs.webkit.org/show_bug.cgi?id=650123864 3865 Move files of web socket and workers into each macro block in CMakeList.txt.3866 And, header files related to WORKER and SHARED_WORKER are wrapped by macro in cpp files.3867 3868 Reviewed by Daniel Bates.3869 3870 * CMakeLists.txt:3871 * UseJSC.cmake:3872 * bindings/js/JSDOMWindowCustom.cpp:3873 * bindings/js/JSWorkerContextBase.cpp:3874 * bindings/js/ScriptState.cpp:3875 * bindings/js/WorkerScriptController.cpp:3876 3877 2011-08-15 Jeffrey Pfau <jpfau@apple.com>3878 3879 New XML parser: add xml namespace to the default map of namespaces3880 https://bugs.webkit.org/show_bug.cgi?id=662663881 3882 Reviewed by Adam Barth.3883 3884 * xml/parser/XMLTreeBuilder.cpp:3885 (WebCore::XMLTreeBuilder::NodeStackItem::NodeStackItem):3886 3887 2011-08-15 Hayato Ito <hayato@chromium.org>3888 3889 Fix crash when mouse moves from <summary> element to parent <details> element.3890 https://bugs.webkit.org/show_bug.cgi?id=662103891 3892 Reviewed by Dimitri Glazkov.3893 3894 This is a regression caused by r92922, which wrongly assumes that3895 a shadow host always has a shadow root as an immediate child in3896 ancestors chain. This assumption does not apply to <details>3897 element. <details> element is implemented as a shadow host, but3898 may have a <summary> element as an immediate child element in3899 ancestors chain.3900 3901 Test: fast/dom/shadow/details-summary-mouseover.html3902 3903 * dom/EventDispatcher.cpp:3904 (WebCore::EventDispatcher::adjustToShadowBoundaries):3905 3906 2011-08-15 Jeffrey Pfau <jpfau@apple.com>3907 3908 New XML parser: Use xmlnsAtom instead of redundant xmlnsPrefix3909 https://bugs.webkit.org/show_bug.cgi?id=662643910 3911 Reviewed by Adam Barth.3912 3913 * xml/parser/XMLTreeBuilder.cpp:3914 (WebCore::XMLTreeBuilder::processNamespaces):3915 (WebCore::XMLTreeBuilder::processAttributes):3916 3917 2011-08-15 Emil A Eklund <eae@chromium.org>3918 3919 Switch Element/Node to to new layout types3920 https://bugs.webkit.org/show_bug.cgi?id=662603921 3922 Reviewed by Eric Seidel.3923 3924 Convert Element, Node, ElementRareData and ContainerNode to new layout3925 abstraction as a part of the ongoing conversion work.3926 3927 No new tests, no new functionality.3928 3929 * dom/ContainerNode.cpp:3930 (WebCore::ContainerNode::getLowerRightCorner):3931 (WebCore::ContainerNode::getRect):3932 * dom/ContainerNode.h:3933 * dom/Element.cpp:3934 (WebCore::Element::scrollIntoView):3935 (WebCore::Element::scrollIntoViewIfNeeded):3936 (WebCore::adjustForLocalZoom):3937 (WebCore::Element::boundsInWindowSpace):3938 (WebCore::Element::getClientRects):3939 (WebCore::Element::getBoundingClientRect):3940 (WebCore::Element::screenRect):3941 (WebCore::Element::minimumSizeForResizing):3942 (WebCore::Element::setMinimumSizeForResizing):3943 * dom/Element.h:3944 * dom/ElementRareData.h:3945 * dom/Node.cpp:3946 (WebCore::Node::getRect):3947 (WebCore::Node::renderRect):3948 (WebCore::Node::hasNonEmptyBoundingBox):3949 * dom/Node.h:3950 3951 2011-08-15 Alexey Proskuryakov <ap@apple.com>3952 3953 Regional indicator symbols that are combined should behave as a single character when editing3954 https://bugs.webkit.org/show_bug.cgi?id=653953955 3956 Reviewed by Dan Bernstein.3957 3958 Part one: make backspace work.3959 3960 Test: editing/deleting/regional-indicators.html3961 3962 * rendering/RenderText.cpp:3963 (WebCore::isRegionalIndicator):3964 (WebCore::RenderText::previousOffsetForBackwardDeletion): Added a special case for regional3965 indicator symbols.3966 3967 2011-08-15 Jeffrey Pfau <jpfau@apple.com>3968 3969 New XML parser: Re-entering a character node should not clobber the buffered characters3970 https://bugs.webkit.org/show_bug.cgi?id=662573971 3972 Reviewed by Adam Barth.3973 3974 * xml/parser/XMLTreeBuilder.cpp:3975 (WebCore::XMLTreeBuilder::enterText):3976 3977 2011-08-15 Dmitry Titov <dimich@chromium.org>3978 3979 FrameLoaderClient::transferLoadingResourceFromPage does not have enough parameters3980 https://bugs.webkit.org/show_bug.cgi?id=661653981 3982 Reviewed by Darin Fisher.3983 3984 No new tests since no change in behavior.3985 The original issue is only reproducible on Chromium in multi-process mode3986 and is tested there by a browsertest.3987 3988 * loader/DocumentLoader.cpp:3989 (WebCore::DocumentLoader::transferLoadingResourcesFromPage):3990 Passing ResourceLoader* into the FrameLoaderClient notification.3991 Also, fixed the bug where the same ResourceRequest was passed for all subresources.3992 * loader/EmptyClients.h:3993 (WebCore::EmptyFrameLoaderClient::transferLoadingResourceFromPage):3994 * loader/FrameLoader.cpp:3995 (WebCore::FrameLoader::dispatchTransferLoadingResourceFromPage):3996 * loader/FrameLoader.h:3997 * loader/FrameLoaderClient.h:3998 * loader/ResourceLoadNotifier.cpp:3999 (WebCore::ResourceLoadNotifier::dispatchTransferLoadingResourceFromPage):4000 * loader/ResourceLoadNotifier.h:4001 * loader/ResourceLoader.cpp:4002 (WebCore::ResourceLoader::init):4003 * loader/ResourceLoader.h:4004 (WebCore::ResourceLoader::originalRequest): Added the originalRequest() accessor that4005 returns the request as it existed before redirects (but after client's will SendRequest).4006 This is to be able to pass the original request for loading subresources into4007 FrameLoaderClient::transferLoadingResourceFromPage, since that one is used to invoke4008 assignIdentifierToInitialRequest, which needs original request.4009 4010 2011-08-15 Mark Hahnenberg <mhahnenberg@apple.com>4011 4012 Refactor JS objects to allocate in static create methods rather than constructors4013 https://bugs.webkit.org/show_bug.cgi?id=653474014 4015 Reviewed by Geoffrey Garen.4016 4017 No new tests.4018 4019 Removed all calls to deprecatedGetDOMObject from initialization lists as part of a4020 larger refactoring to get rid of all allocation during initialization.4021 4022 * bindings/js/JSDOMBinding.h:4023 * bridge/c/CRuntimeObject.cpp:4024 (JSC::Bindings::CRuntimeObject::CRuntimeObject):4025 * bridge/c/CRuntimeObject.h:4026 (JSC::Bindings::CRuntimeObject::create):4027 * bridge/c/c_instance.cpp:4028 (JSC::Bindings::CRuntimeMethod::create):4029 (JSC::Bindings::CRuntimeMethod::CRuntimeMethod):4030 * bridge/jni/jsc/JavaInstanceJSC.cpp:4031 (JavaRuntimeMethod::create):4032 (JavaRuntimeMethod::JavaRuntimeMethod):4033 * bridge/jni/jsc/JavaRuntimeObject.cpp:4034 (JSC::Bindings::JavaRuntimeObject::JavaRuntimeObject):4035 * bridge/jni/jsc/JavaRuntimeObject.h:4036 (JSC::Bindings::JavaRuntimeObject::create):4037 * bridge/objc/objc_runtime.h:4038 (JSC::Bindings::ObjcFallbackObjectImp::create):4039 * bridge/objc/objc_runtime.mm:4040 (JSC::Bindings::ObjcFallbackObjectImp::ObjcFallbackObjectImp):4041 * bridge/qt/qt_instance.cpp:4042 (JSC::Bindings::QtRuntimeObject::create):4043 (JSC::Bindings::QtRuntimeObject::QtRuntimeObject):4044 * bridge/qt/qt_pixmapruntime.cpp:4045 (JSC::Bindings::QtPixmapRuntimeObject::create):4046 (JSC::Bindings::QtPixmapRuntimeObject::QtPixmapRuntimeObject):4047 * bridge/qt/qt_runtime.cpp:4048 (JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):4049 (JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod):4050 (JSC::Bindings::QtRuntimeConnectionMethod::QtRuntimeConnectionMethod):4051 * bridge/qt/qt_runtime.h:4052 (JSC::Bindings::QtRuntimeMetaMethod::create):4053 (JSC::Bindings::QtRuntimeConnectionMethod::create):4054 * bridge/runtime_array.cpp:4055 (JSC::RuntimeArray::RuntimeArray):4056 * bridge/runtime_array.h:4057 (JSC::RuntimeArray::create):4058 * bridge/runtime_object.cpp:4059 4060 2011-08-15 Adam Roben <aroben@apple.com>4061 4062 Update pages' style and content scale when the window's backing scale factor changes4063 4064 Unfortunately, I couldn't think of a way to test this in an automated fashion.4065 4066 Fixes <http://webkit.org/b/66229> <rdar://problem/9906269> WebKit doesn't react to device4067 scale factor changes4068 4069 Reviewed by Simon Fraser.4070 4071 * WebCore.exp.in: Export Frame::deviceOrScaleFactorChanged.4072 4073 * page/Frame.cpp:4074 (WebCore::Frame::deviceScaleFactorChanged):4075 * page/Frame.h:4076 Added this new function. We recalc style so that, e.g., device-scale-factor-dependent media4077 queries will be reevaluated, and we tell compositing layers about the new scale factor so4078 they can rerender at the new resolution.4079 4080 2011-08-15 Cary Clark <caryclark@google.com>4081 4082 Revise Skia on Chrome Mac to return fallback fonts.4083 https://bugs.webkit.org/show_bug.cgi?id=629864084 4085 Reviewed by Darin Fisher.4086 4087 Since Skia on Chrome Mac uses CoreText to determine4088 text metrics, CG font architecture is used to return4089 fallback fonts.4090 4091 This improves many existing layout tests, including4092 justify-ideograph-simple and t0905-c414-flt-04-c4093 4094 * platform/graphics/skia/FontSkia.cpp:4095 (WebCore::Font::canReturnFallbackFontsForComplexText):4096 4097 2011-08-15 Aaron Boodman <aa@chromium.org>4098 4099 Pass additional details to client in didCreateIsolatedContext4100 https://bugs.webkit.org/show_bug.cgi?id=660374101 4102 Reviewed by Darin Fisher.4103 4104 * bindings/v8/IsolatedWorld.cpp:4105 (WebCore::IsolatedWorld::IsolatedWorld):4106 * bindings/v8/IsolatedWorld.h:4107 (WebCore::IsolatedWorld::create):4108 (WebCore::IsolatedWorld::id):4109 * bindings/v8/V8IsolatedContext.cpp:4110 (WebCore::V8IsolatedContext::V8IsolatedContext):4111 * bindings/v8/V8IsolatedContext.h:4112 * bindings/v8/V8Proxy.cpp:4113 (WebCore::V8Proxy::evaluateInIsolatedWorld):4114 * loader/EmptyClients.h:4115 (WebCore::EmptyFrameLoaderClient::didCreateIsolatedScriptContext):4116 * loader/FrameLoaderClient.h:4117 4118 2011-08-15 Chris Rogers <crogers@google.com>4119 4120 Add shell implementation for Web Audio API's MediaElementAudioSourceNode4121 https://bugs.webkit.org/show_bug.cgi?id=661754122 4123 Reviewed by Kenneth Russell.4124 4125 Test: webaudio/mediaelementaudiosourcenode.html4126 4127 * DerivedSources.make:4128 * WebCore.gypi:4129 * WebCore.xcodeproj/project.pbxproj:4130 * html/HTMLMediaElement.idl:4131 * webaudio/AudioContext.cpp:4132 (WebCore::AudioContext::createMediaElementSource):4133 * webaudio/AudioContext.h:4134 * webaudio/AudioContext.idl:4135 * webaudio/AudioNode.h:4136 * webaudio/MediaElementAudioSourceNode.cpp: Added.4137 (WebCore::MediaElementAudioSourceNode::create):4138 (WebCore::MediaElementAudioSourceNode::MediaElementAudioSourceNode):4139 (WebCore::MediaElementAudioSourceNode::process):4140 (WebCore::MediaElementAudioSourceNode::reset):4141 * webaudio/MediaElementAudioSourceNode.h: Added.4142 (WebCore::MediaElementAudioSourceNode::mediaElement):4143 * webaudio/MediaElementAudioSourceNode.idl: Added.4144 4145 2011-08-15 Emil A Eklund <eae@chromium.org>4146 4147 Switch mouse events to to new layout types4148 https://bugs.webkit.org/show_bug.cgi?id=661794149 4150 Reviewed by Eric Seidel.4151 4152 Convert mouse events to new layout abstraction as a part of the ongoing4153 conversion work.4154 4155 No new tests, no new functionality.4156 4157 * dom/MouseRelatedEvent.cpp:4158 (WebCore::contentsScrollOffset):4159 (WebCore::MouseRelatedEvent::MouseRelatedEvent):4160 (WebCore::MouseRelatedEvent::initCoordinates):4161 (WebCore::MouseRelatedEvent::computePageLocation):4162 (WebCore::MouseRelatedEvent::computeRelativePosition):4163 (WebCore::MouseRelatedEvent::pageLocation):4164 * dom/MouseRelatedEvent.h:4165 (WebCore::MouseRelatedEvent::screenLocation):4166 (WebCore::MouseRelatedEvent::clientLocation):4167 (WebCore::MouseRelatedEvent::absoluteLocation):4168 (WebCore::MouseRelatedEvent::setAbsoluteLocation):4169 * page/EventHandler.cpp:4170 (WebCore::EventHandler::clear):4171 (WebCore::EventHandler::handleMousePressEventSingleClick):4172 (WebCore::selectionExtentRespectingEditingBoundary):4173 (WebCore::EventHandler::hitTestResultAtPoint):4174 (WebCore::EventHandler::currentMousePosition):4175 (WebCore::documentPointForWindowPoint):4176 (WebCore::EventHandler::handleMousePressEvent):4177 (WebCore::EventHandler::mouseMoved):4178 (WebCore::EventHandler::handleWheelEvent):4179 (WebCore::EventHandler::sendContextMenuEvent):4180 (WebCore::EventHandler::sendContextMenuEventForKey):4181 (WebCore::EventHandler::fakeMouseMoveEventTimerFired):4182 (WebCore::EventHandler::dragHysteresisExceeded):4183 (WebCore::EventHandler::handleDrag):4184 (WebCore::EventHandler::handleTouchEvent):4185 * page/EventHandler.h:4186 * platform/PlatformMouseEvent.h:4187 (WebCore::PlatformMouseEvent::PlatformMouseEvent):4188 (WebCore::PlatformMouseEvent::pos):4189 (WebCore::PlatformMouseEvent::x):4190 (WebCore::PlatformMouseEvent::y):4191 (WebCore::PlatformMouseEvent::globalX):4192 (WebCore::PlatformMouseEvent::globalY):4193 * platform/mac/PlatformMouseEventMac.mm:4194 (WebCore::globalPoint):4195 (WebCore::pointForEvent):4196 (WebCore::globalPointForEvent):4197 4198 2011-08-15 Ryosuke Niwa <rniwa@webkit.org>4199 4200 webkit-indent-blockquote is unnecessary4201 https://bugs.webkit.org/show_bug.cgi?id=661954202 4203 Reviewed by Tony Chang.4204 4205 Stop adding class="webkit-indent-blockquote" on blockquotes created by execCommand('Indent') and4206 execCommand('Outdent'). Also removed the code to add the class attribute in ApplyBlockElementCommand4207 since no other class inherited from ApplyBlockElementCommand uses this feature.4208 4209 * editing/ApplyBlockElementCommand.cpp:4210 (WebCore::ApplyBlockElementCommand::ApplyBlockElementCommand):4211 (WebCore::ApplyBlockElementCommand::createBlockElement):4212 * editing/ApplyBlockElementCommand.h:4213 * editing/IndentOutdentCommand.cpp:4214 (WebCore::IndentOutdentCommand::IndentOutdentCommand):4215 4216 2011-08-15 Levi Weintraub <leviw@chromium.org>4217 4218 Switch remaining SVG Rendering methods to LayoutUnits4219 https://bugs.webkit.org/show_bug.cgi?id=661694220 4221 Reviewed by Eric Seidel.4222 4223 Changing remaining integer SVG methods to use the LayoutUnits abstraction.4224 4225 No tests as no change in functionality.4226 4227 * rendering/svg/RenderSVGBlock.cpp:4228 (WebCore::RenderSVGBlock::visualOverflowRect):4229 * rendering/svg/RenderSVGBlock.h:4230 * rendering/svg/RenderSVGContainer.cpp:4231 (WebCore::RenderSVGContainer::paint):4232 * rendering/svg/RenderSVGForeignObject.cpp:4233 (WebCore::RenderSVGForeignObject::paint):4234 (WebCore::RenderSVGForeignObject::clippedOverflowRectForRepaint):4235 (WebCore::RenderSVGForeignObject::computeRectForRepaint):4236 * rendering/svg/RenderSVGHiddenContainer.cpp:4237 (WebCore::RenderSVGHiddenContainer::paint):4238 * rendering/svg/RenderSVGImage.cpp:4239 (WebCore::RenderSVGImage::paint):4240 * rendering/svg/RenderSVGInlineText.cpp:4241 (WebCore::RenderSVGInlineText::linesBoundingBox):4242 * rendering/svg/RenderSVGInlineText.h:4243 * rendering/svg/RenderSVGModelObject.cpp:4244 (WebCore::RenderSVGModelObject::outlineBoundsForRepaint):4245 * rendering/svg/RenderSVGPath.cpp:4246 (WebCore::RenderSVGPath::paint):4247 * rendering/svg/RenderSVGRoot.cpp:4248 (WebCore::RenderSVGRoot::localToBorderBoxTransform):4249 (WebCore::RenderSVGRoot::parentOriginToBorderBox):4250 (WebCore::RenderSVGRoot::borderOriginToContentBox):4251 (WebCore::RenderSVGRoot::localToRepaintContainerTransform):4252 (WebCore::RenderSVGRoot::localToParentTransform):4253 (WebCore::RenderSVGRoot::clippedOverflowRectForRepaint):4254 (WebCore::RenderSVGRoot::computeRectForRepaint):4255 * rendering/svg/RenderSVGRoot.h:4256 * rendering/svg/RenderSVGText.cpp:4257 (WebCore::RenderSVGText::paint):4258 * rendering/svg/SVGInlineFlowBox.cpp:4259 (WebCore::SVGInlineFlowBox::paint):4260 * rendering/svg/SVGInlineTextBox.cpp:4261 (WebCore::SVGInlineTextBox::paint):4262 * rendering/svg/SVGRenderSupport.cpp:4263 (WebCore::SVGRenderSupport::clippedOverflowRectForRepaint):4264 (WebCore::SVGRenderSupport::computeRectForRepaint):4265 * rendering/svg/SVGRenderSupport.h:4266 * rendering/svg/SVGRootInlineBox.cpp:4267 (WebCore::SVGRootInlineBox::paint):4268 (WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):4269 (WebCore::SVGRootInlineBox::layoutChildBoxes):4270 (WebCore::SVGRootInlineBox::layoutRootBox):4271 (WebCore::SVGRootInlineBox::closestLeafChildForPosition):4272 * rendering/svg/SVGRootInlineBox.h:4273 4274 2011-08-12 Jeff Miller <jeffm@apple.com>4275 4276 MediaPlayerPrivateAVFoundationCF::playerItemStatus() should return MediaPlayerAVPlayerItemStatusDoesNotExist if there is no AVPlayerItem4277 https://bugs.webkit.org/show_bug.cgi?id=661714278 4279 MediaPlayerPrivateAVFoundationCF::playerItemStatus() should return MediaPlayerAVPlayerItemStatusDoesNotExist if there is no AVPlayerItem4280 to match the Mac implementation in MediaPlayerPrivateAVFoundationObjC. I also added better logging to notificationCallback().4281 4282 Reviewed by Jon Honeycutt.4283 4284 No new tests, uses existing media tests.4285 4286 * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp:4287 (WebCore::MediaPlayerPrivateAVFoundationCF::playerItemStatus): Return MediaPlayerAVPlayerItemStatusDoesNotExist if no AVPlayerItem.4288 (WebCore::AVFWrapper::notificationCallback): Log the name of the received notification.4289 4290 2011-08-15 Adam Roben <aroben@apple.com>4291 4292 Rename an instance of pageScaleFactorChanged I missed in r930404293 4294 I tried to make a test for this but failed. It would probably have been easier if we dumped4295 layers' content scales in layerTreeAsText output.4296 4297 Followup to <http://webkit.org/b/55787> WebKit uses multiple conflicting names to refer to4298 the device scale factor4299 4300 * platform/graphics/ca/GraphicsLayerCA.cpp:4301 (WebCore::GraphicsLayerCA::deviceOrPageScaleFactorChanged):4302 * platform/graphics/ca/GraphicsLayerCA.h:4303 Renamed from pageScaleFactorChanged to match the base class.4304 4305 2011-08-15 Pavel Feldman <pfeldman@google.com>4306 4307 Web Inspector: [V8] crash upon stepIn while not on pause.4308 https://bugs.webkit.org/show_bug.cgi?id=662214309 4310 Reviewed by Yury Semikhatsky.4311 4312 * inspector/InspectorDebuggerAgent.cpp:4313 (WebCore::InspectorDebuggerAgent::resume):4314 (WebCore::InspectorDebuggerAgent::stepOver):4315 (WebCore::InspectorDebuggerAgent::stepInto):4316 (WebCore::InspectorDebuggerAgent::stepOut):4317 (WebCore::InspectorDebuggerAgent::assertPaused):4318 * inspector/InspectorDebuggerAgent.h:4319 * inspector/front-end/ScriptsPanel.js:4320 (WebInspector.ScriptsPanel.prototype._stepOverClicked):4321 (WebInspector.ScriptsPanel.prototype._stepIntoClicked):4322 (WebInspector.ScriptsPanel.prototype._stepOutClicked):4323 4324 2011-08-15 Vsevolod Vlasov <vsevik@chromium.org>4325 4326 Web Inspector: Network panel: display the current search match index in the toolbar.4327 https://bugs.webkit.org/show_bug.cgi?id=660514328 4329 Reviewed by Pavel Feldman.4330 4331 * inspector/front-end/NetworkPanel.js:4332 (WebInspector.NetworkLogView.prototype._highlightNthMatchedResource):4333 (WebInspector.NetworkLogView.prototype.performSearch):4334 (WebInspector.NetworkPanel):4335 (WebInspector.NetworkPanel.prototype._onSearchCountUpdated):4336 (WebInspector.NetworkPanel.prototype._onSearchIndexUpdated):4337 4338 2011-08-10 Adam Roben <aroben@apple.com>4339 4340 Clear up scale factor terminology4341 4342 WebKit by and large deals with two scale factors: one intrinsic to the device on which the4343 software is running, and one that is per-Page and can be controlled via API calls. This4344 patch names the former "deviceScaleFactor" and the latter "pageScaleFactor", and makes the4345 code use those names. It should introduce no behavior changes.4346 4347 Fixes <http://webkit.org/b/55787> WebKit uses multiple conflicting names to refer to the4348 device scale factor4349 4350 Reviewed by Simon Fraser.4351 4352 * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:4353 * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:4354 Removed an unused member. This is unrelated to this patch.4355 4356 * css/MediaQueryEvaluator.cpp:4357 * html/HTMLCanvasElement.cpp:4358 * html/HTMLCanvasElement.h:4359 * loader/EmptyClients.h:4360 * page/Chrome.cpp:4361 * page/Chrome.h:4362 * page/ChromeClient.h:4363 * page/DOMWindow.cpp:4364 * page/Frame.cpp:4365 * page/Frame.h:4366 * platform/graphics/GraphicsLayer.cpp:4367 * platform/graphics/GraphicsLayer.h:4368 * platform/graphics/GraphicsLayerClient.h:4369 * platform/graphics/ca/GraphicsLayerCA.cpp:4370 * rendering/RenderInline.cpp:4371 * rendering/RenderLayerBacking.cpp:4372 * rendering/RenderLayerBacking.h:4373 * rendering/RenderLayerCompositor.cpp:4374 * rendering/RenderLayerCompositor.h:4375 * rendering/RenderObject.cpp:4376 4377 2011-08-15 Oliver Varga <Varga.Oliver@stud.u-szeged.hu>4378 4379 Reviewed by Nikolas Zimmermann.4380 4381 Speed up SVGSMILElement::findInstanceTime.4382 https://bugs.webkit.org/show_bug.cgi?id=610254383 4384 Replace the linear search to binary search on ordered list because4385 the previous searches from the beginning was not efficient.4386 Out of index error fixed by Renata Hodovan.4387 4388 No new tests this is only a performance tweak.4389 4390 * svg/animation/SVGSMILElement.cpp:4391 (WebCore::extractTimeFromVector):4392 (WebCore::SVGSMILElement::findInstanceTime):4393 4394 2011-08-15 Hayato Ito <hayato@chromium.org>4395 4396 Implement proper handling of focusin/focusout events in regard to shadow DOM boundaries.4397 https://bugs.webkit.org/show_bug.cgi?id=642494398 4399 Reviewed by Dimitri Glazkov.4400 4401 Introduces FocusInEventDispatchMediator/FocusOutEventDispatchMediator so4402 that we can shrink ancestors of event target node considering shadow4403 DOM boundaries before dispatching focusin/focusout events.4404 4405 Test: fast/dom/shadow/shadow-boundary-events.html4406 4407 * dom/Document.cpp:4408 (WebCore::Document::setFocusedNode):4409 * dom/Node.cpp:4410 (WebCore::Node::dispatchFocusInEvent):4411 (WebCore::Node::dispatchFocusOutEvent):4412 (WebCore::Node::dispatchDOMActivateEvent):4413 (WebCore::Node::defaultEventHandler):4414 * dom/Node.h:4415 * dom/UIEvent.cpp:4416 (WebCore::FocusInEventDispatchMediator::create):4417 (WebCore::FocusInEventDispatchMediator::FocusInEventDispatchMediator):4418 (WebCore::FocusInEventDispatchMediator::dispatchEvent):4419 (WebCore::FocusOutEventDispatchMediator::create):4420 (WebCore::FocusOutEventDispatchMediator::FocusOutEventDispatchMediator):4421 (WebCore::FocusOutEventDispatchMediator::dispatchEvent):4422 * dom/UIEvent.h:4423 4424 2011-08-15 Pavel Feldman <pfeldman@google.com>4425 4426 Web Inspector: not all of the properties have valid descriptors on all platforms.4427 Includes PropertyDescriptor protocol documentation fixes.4428 https://bugs.webkit.org/show_bug.cgi?id=662154429 4430 Activations, LocalStorage and some other properties potentially don't have4431 valid property descriptors. InjectedScript should use conservative getter in order to4432 mitigate this.4433 4434 Reviewed by Yury Semikhatsky.4435 4436 * inspector/InjectedScriptSource.js:4437 * inspector/Inspector.json:4438 4439 2011-08-15 Pavel Feldman <pfeldman@google.com>4440 4441 Web Inspector: context menu on the link in the console does not have standard link options.4442 https://bugs.webkit.org/show_bug.cgi?id=662144443 4444 Reviewed by Yury Semikhatsky.4445 4446 * English.lproj/localizedStrings.js:4447 * inspector/front-end/ConsoleView.js:4448 * inspector/front-end/ElementsPanel.js:4449 * inspector/front-end/ElementsTreeOutline.js:4450 (WebInspector.ElementsTreeOutline.prototype.populateContextMenu):4451 * inspector/front-end/NetworkPanel.js:4452 (WebInspector.NetworkLogView.prototype._contextMenu):4453 * inspector/front-end/StylesSidebarPane.js:4454 (WebInspector.StylesSidebarPane.prototype._contextMenuEventFired):4455 * inspector/front-end/inspector.js:4456 (WebInspector.openLinkExternallyLabel):4457 (WebInspector.copyLinkAddressLabel):4458 (WebInspector.populateHrefContextMenu):4459 4460 2011-08-14 Pavel Feldman <pfeldman@chromium.org>4461 4462 Web Inspector: showContextMenu missing in Remote DevTools4463 https://bugs.webkit.org/show_bug.cgi?id=637254464 4465 Reviewed by Yury Semikhatsky.4466 4467 * WebCore.gypi:4468 * WebCore.vcproj/WebCore.vcproj:4469 * inspector/front-end/ConsoleView.js:4470 * inspector/front-end/SoftContextMenu.js: Added.4471 (.WebInspector.SoftContextMenu):4472 (.WebInspector.SoftContextMenu.prototype.show):4473 (.WebInspector.SoftContextMenu.prototype._createMenuItem):4474 (.WebInspector.SoftContextMenu.prototype._createSeparator):4475 (.WebInspector.SoftContextMenu.prototype._menuItemMouseDown):4476 (.WebInspector.SoftContextMenu.prototype._menuItemMouseUp):4477 (.WebInspector.SoftContextMenu.prototype._triggerAction):4478 (.WebInspector.SoftContextMenu.prototype._menuItemMouseOver):4479 (.WebInspector.SoftContextMenu.prototype._menuItemMouseOut):4480 (.WebInspector.SoftContextMenu.prototype._highlightMenuItem):4481 (.WebInspector.SoftContextMenu.prototype._highlightPrevious):4482 (.WebInspector.SoftContextMenu.prototype._highlightNext):4483 (.WebInspector.SoftContextMenu.prototype._menuKeyDown):4484 (.WebInspector.SoftContextMenu.prototype._glassPaneMouseUp):4485 (.WebInspector.SoftContextMenu.prototype._discardMenu):4486 (.InspectorFrontendHost.showContextMenu):4487 * inspector/front-end/WebKit.qrc:4488 * inspector/front-end/inspector.css:4489 (.soft-context-menu-glass-pane):4490 (.soft-context-menu):4491 (.soft-context-menu-item):4492 (.soft-context-menu-separator):4493 (.soft-context-menu-item-mouse-over):4494 * inspector/front-end/inspector.html:4495 4496 2011-08-13 Abhishek Arya <inferno@chromium.org>4497 4498 Crash in HTMLTreeBuilder::processAnyOtherEndTagForInBody4499 https://bugs.webkit.org/show_bug.cgi?id=661874500 4501 Reviewed by Adam Barth.4502 4503 RefPtr a few ContainerNodes to prevent premature deletion.4504 4505 Test: fast/html/process-end-tag-for-inbody-crash.html4506 4507 * html/parser/HTMLTreeBuilder.cpp:4508 (WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):4509 (WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):4510 (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):4511 4512 2011-08-14 Kalev Lember <kalevlember@gmail.com>4513 4514 Fix GTK Windows build after r92308.4515 https://bugs.webkit.org/show_bug.cgi?id=661404516 4517 Reviewed by Xan Lopez.4518 4519 * config.h: Don't try to include WebCoreHeaderDetection.h for GTK.4520 4521 2011-08-13 Sam Weinig <sam@webkit.org>4522 4523 Remove forward declaration of -[WebUndefined dealloc] to appease the bot gods.4524 4525 * bindings/objc/WebScriptObject.mm:4526 4527 2011-08-13 Sam Weinig <sam@webkit.org>4528 4529 Remove assertion from -[WebUndefined dealloc] to try to mollify the bots.4530 4531 * bindings/objc/WebScriptObject.mm:4532 (-[WebUndefined dealloc]):4533 4534 2011-08-13 Sam Weinig <sam@webkit.org>4535 4536 Remove unused variables from WebVideoFullscreenController.h4537 https://bugs.webkit.org/show_bug.cgi?id=661924538 4539 Reviewed by Dan Bernstein.4540 4541 * platform/mac/WebVideoFullscreenController.h:4542 Remove _isWindowLoaded, _savedUIMode and _savedUIOptions which were not used.4543 4544 2011-08-13 Sam Weinig <sam@webkit.org>4545 4546 Fix incorrect objective-c initialize in WebCore4547 https://bugs.webkit.org/show_bug.cgi?id=661914548 4549 Reviewed by David Kilzer.4550 4551 * accessibility/mac/AccessibilityObjectWrapper.mm:4552 (-[AccessibilityObjectWrapper initWithAccessibilityObject:]):4553 * rendering/RenderThemeMac.mm:4554 (-[WebCoreRenderThemeNotificationObserver initWithTheme:WebCore::]):4555 Correctly initialize by assigning to self and nil checking the result.4556 4557 2011-08-13 Adam Barth <abarth@webkit.org>4558 4559 Fix clang build.4560 4561 * platform/chromium/PopupMenuChromium.h:4562 4563 2011-08-13 David Kilzer <ddkilzer@apple.com>4564 4565 <http://webkit.org/b/66188> WebCore.xcodeproj has duplicate entries again4566 4567 Reviewed by Dan Bernstein.4568 4569 * WebCore.xcodeproj/project.pbxproj: Remove duplicate entries4570 by using uniq. Originally noticed by Xcode 4.4571 4572 2011-08-12 Dan Bernstein <mitz@apple.com>4573 4574 <rdar://problem/7337717> Add an option to automatically show tooltips (with the full text) over truncated text4575 https://bugs.webkit.org/show_bug.cgi?id=661784576 4577 Reviewed by Simon Fraser.4578 4579 * WebCore.exp.in: Export setShowsToolTipOverTruncatedText().4580 * page/Chrome.cpp:4581 (WebCore::Chrome::setToolTip): If no title is found, and the page is set to show tooltips over4582 truncated text, try to set the tooltip to the full text of the truncated text, if any.4583 * page/Settings.cpp:4584 (WebCore::Settings::Settings): Initialize new member variable.4585 (WebCore::Settings::setShowsToolTipOverTruncatedText): Added this setter.4586 * page/Settings.h:4587 (WebCore::Settings::showsToolTipOverTruncatedText): Added this getter.4588 * rendering/HitTestResult.cpp:4589 (WebCore::HitTestResult::innerTextIfTruncated): Added. If the inner node or its nearest enclosing4590 block has text-overflow: ellipsis and has truncated lines, return the node’s (full) inner text.4591 * rendering/HitTestResult.h:4592 * rendering/RootInlineBox.h:4593 (WebCore::RootInlineBox::hasEllipsisBox): Made this public.4594 4595 2011-08-12 Stephen White <senorblanco@chromium.org>4596 4597 Ownership of canvas's GraphicsContext3D should be moved to PlatformContextSkia4598 https://bugs.webkit.org/show_bug.cgi?id=661544599 4600 Reviewed by Kenneth Russell.4601 4602 Covered by existing tests in fast/canvas and canvas/philip.4603 4604 * html/canvas/CanvasRenderingContext2D.cpp:4605 (WebCore::CanvasRenderingContext2D::isAccelerated):4606 Plumb this call through GraphicsContext::isAcceleratedContext().4607 (WebCore::CanvasRenderingContext2D::paintsIntoCanvasBuffer):4608 For the ACCELERATED_2D_CANVAS path, plumb this call through4609 (the new) GraphicsContext::paintsIntoCanvasBuffer().4610 (WebCore::CanvasRenderingContext2D::clearAcceleration):4611 (WebCore::CanvasRenderingContext2D::resetAcceleration):4612 Remove the use of the m_context3D member; use a temporary instead.4613 * html/canvas/CanvasRenderingContext2D.h:4614 Remove the m_context3D member.4615 * platform/graphics/GraphicsContext.cpp:4616 (WebCore::GraphicsContext::isAcceleratedContext):4617 (WebCore::GraphicsContext::paintsIntoImageBuffer):4618 Implement stub versions of these functions for other platforms.4619 * platform/graphics/GraphicsContext.h:4620 Expose isAcceleratedContext() to all platforms. Add4621 paintsIntoImageBuffer() member function.4622 * platform/graphics/gpu/SharedGraphicsContext3D.cpp:4623 (WebCore::SharedGraphicsContext3D::create):4624 * platform/graphics/gpu/SharedGraphicsContext3D.h:4625 * platform/graphics/skia/GraphicsContextSkia.cpp:4626 (WebCore::GraphicsContext::setGraphicsContext3D):4627 (WebCore::GraphicsContext::isAcceleratedContext):4628 (WebCore::GraphicsContext::paintsIntoImageBuffer):4629 Basically gut this class leaving only a static creation function.4630 * platform/graphics/skia/ImageSkia.cpp:4631 (WebCore::paintSkBitmap):4632 (WebCore::Image::drawPattern):4633 Use isAccelerated() in place of useSkiaGpu().4634 * platform/graphics/skia/PlatformContextSkia.cpp:4635 (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):4636 (WebCore::PlatformContextSkia::paintsIntoImageBuffer):4637 * platform/graphics/skia/PlatformContextSkia.h:4638 (WebCore::PlatformContextSkia::isAccelerated):4639 Rename useSkiaGpu() to isAccelerated(). Plumb through4640 paintsIntoImageBuffer() to GraphicsContext3D.4641 4642 2011-08-12 Sam Weinig <sam@webkit.org>4643 4644 Use __builtin_trap() for CRASH when building with clang4645 https://bugs.webkit.org/show_bug.cgi?id=661524646 4647 Reviewed by Anders Carlsson.4648 4649 * bindings/js/SerializedScriptValue.cpp:4650 (WebCore::CloneBase::fail):4651 * bindings/objc/WebScriptObject.mm:4652 * platform/mac/BlockExceptions.h:4653 * platform/text/cf/StringImplCF.cpp:4654 Add NO_RETURN_DUE_TO_ASSERT.4655 4656 * bridge/IdentifierRep.h:4657 Don't define the destructor since it is never called,4658 4659 2011-08-12 Joseph Pecoraro <joepeck@webkit.org>4660 4661 Abandoned Memory: Temporary CSS Fonts May Never Be Purged4662 https://bugs.webkit.org/show_bug.cgi?id=661534663 4664 Reviewed by Dan Bernstein.4665 4666 No new tests, this is not a functional change.4667 4668 * css/CSSFontFaceSource.cpp:4669 (WebCore::CSSFontFaceSource::getFontData):4670 If the CSS font-face is loading from a URL then immediately4671 fallback to a system font matching the description, since we4672 cannot determine a reasonable family name from the m_string4673 URL. The URL could be a dataURI.4674 4675 2011-08-12 Fady Samuel <fsamuel@chromium.org>4676 4677 Refactoring of PopupMenuChromium For Readability and Maintainability4678 https://bugs.webkit.org/show_bug.cgi?id=660094679 4680 Reviewed by Darin Fisher.4681 4682 Split PopupMenuChromium into three sets of files: PopupMenuChromium.{h|cpp}, PopupContainer.{h|cpp},4683 and PopupLisBox.{h|cpp} for readability and maintainability.4684 4685 No new tests as there's no change in functionality.4686 4687 * WebCore.gypi:4688 * platform/chromium/PopupContainer.cpp: Added.4689 (WebCore::constructRelativeMouseEvent):4690 (WebCore::constructRelativeWheelEvent):4691 (WebCore::PopupContainer::create):4692 (WebCore::PopupContainer::PopupContainer):4693 (WebCore::PopupContainer::~PopupContainer):4694 (WebCore::PopupContainer::layoutAndCalculateWidgetRect):4695 (WebCore::PopupContainer::showPopup):4696 (WebCore::PopupContainer::hidePopup):4697 (WebCore::PopupContainer::notifyPopupHidden):4698 (WebCore::PopupContainer::layoutAndGetRTLOffset):4699 (WebCore::PopupContainer::handleMouseDownEvent):4700 (WebCore::PopupContainer::handleMouseMoveEvent):4701 (WebCore::PopupContainer::handleMouseReleaseEvent):4702 (WebCore::PopupContainer::handleWheelEvent):4703 (WebCore::PopupContainer::handleTouchEvent):4704 (WebCore::PopupContainer::handleGestureEvent):4705 (WebCore::PopupContainer::handleKeyEvent):4706 (WebCore::PopupContainer::hide):4707 (WebCore::PopupContainer::paint):4708 (WebCore::PopupContainer::paintBorder):4709 (WebCore::PopupContainer::isInterestedInEventForKey):4710 (WebCore::PopupContainer::chromeClientChromium):4711 (WebCore::PopupContainer::showInRect):4712 (WebCore::PopupContainer::refresh):4713 (WebCore::PopupContainer::isRTL):4714 (WebCore::PopupContainer::selectedIndex):4715 (WebCore::PopupContainer::menuItemHeight):4716 (WebCore::PopupContainer::menuItemFontSize):4717 (WebCore::PopupContainer::menuStyle):4718 (WebCore::popupData):4719 (WebCore::PopupContainer::getSelectedItemToolTip):4720 * platform/chromium/PopupContainer.h: Added.4721 (WebCore::PopupContainer::listBox):4722 (WebCore::PopupContainer::popupType):4723 * platform/chromium/PopupListBox.cpp: Added.4724 (WebCore::PopupListBox::PopupListBox):4725 (WebCore::PopupListBox::handleMouseDownEvent):4726 (WebCore::PopupListBox::handleMouseMoveEvent):4727 (WebCore::PopupListBox::handleMouseReleaseEvent):4728 (WebCore::PopupListBox::handleWheelEvent):4729 (WebCore::PopupListBox::isInterestedInEventForKey):4730 (WebCore::PopupListBox::handleTouchEvent):4731 (WebCore::PopupListBox::handleGestureEvent):4732 (WebCore::isCharacterTypeEvent):4733 (WebCore::PopupListBox::handleKeyEvent):4734 (WebCore::PopupListBox::hostWindow):4735 (WebCore::stripLeadingWhiteSpace):4736 (WebCore::PopupListBox::typeAheadFind):4737 (WebCore::PopupListBox::paint):4738 (WebCore::PopupListBox::paintRow):4739 (WebCore::PopupListBox::getRowFont):4740 (WebCore::PopupListBox::abandon):4741 (WebCore::PopupListBox::pointToRowIndex):4742 (WebCore::PopupListBox::acceptIndex):4743 (WebCore::PopupListBox::selectIndex):4744 (WebCore::PopupListBox::setOriginalIndex):4745 (WebCore::PopupListBox::getRowHeight):4746 (WebCore::PopupListBox::getRowBounds):4747 (WebCore::PopupListBox::invalidateRow):4748 (WebCore::PopupListBox::scrollToRevealRow):4749 (WebCore::PopupListBox::isSelectableItem):4750 (WebCore::PopupListBox::clearSelection):4751 (WebCore::PopupListBox::selectNextRow):4752 (WebCore::PopupListBox::selectPreviousRow):4753 (WebCore::PopupListBox::adjustSelectedIndex):4754 (WebCore::PopupListBox::hidePopup):4755 (WebCore::PopupListBox::updateFromElement):4756 (WebCore::PopupListBox::setMaxWidthAndLayout):4757 (WebCore::PopupListBox::layout):4758 (WebCore::PopupListBox::clear):4759 (WebCore::PopupListBox::isPointInBounds):4760 * platform/chromium/PopupListBox.h: Added.4761 (WebCore::PopupItem::PopupItem):4762 (WebCore::PopupListBox::create):4763 (WebCore::PopupListBox::selectedIndex):4764 (WebCore::PopupListBox::numItems):4765 (WebCore::PopupListBox::setBaseWidth):4766 (WebCore::PopupListBox::setMaxHeight):4767 (WebCore::PopupListBox::setMaxWidth):4768 (WebCore::PopupListBox::disconnectClient):4769 (WebCore::PopupListBox::items):4770 (WebCore::PopupListBox::~PopupListBox):4771 (WebCore::PopupListBox::scrollToRevealSelection):4772 * platform/chromium/PopupMenuChromium.cpp:4773 * platform/chromium/PopupMenuChromium.h:4774 4775 2011-08-12 Mark Rowe <mrowe@apple.com>4776 4777 Be more forward-looking in the choice of compiler.4778 4779 Rubber-stamped by Jon Honeycutt.4780 4781 * Configurations/CompilerVersion.xcconfig:4782 4783 2011-08-12 Nat Duca <nduca@chromium.org>4784 4785 [chromium] Fix comile warning on CCLayerTreeHost4786 4787 * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:4788 (WebCore::CCLayerTreeHost::CCLayerTreeHost):4789 4790 2011-08-12 Ryosuke Niwa <rniwa@webkit.org>4791 4792 Apple-style-span class seems unnecessary4793 https://bugs.webkit.org/show_bug.cgi?id=122484794 4795 Reviewed by Justin Garcia.4796 4797 Stop generating span or font elements with class="Apple-style-span" given WebKit's editing component4798 no longer depends on Apple-style-span since r92823 removed the dependency of copy and paste code on4799 style spans. WebKit continues to recognize Apple style spans to remove them.4800 4801 Also renamed isSpanWithoutAttributesOrUnstyleStyleSpan to isSpanWithoutAttributesOrUnstyle*d*StyleSpan.4802 4803 * editing/ApplyStyleCommand.cpp:4804 (WebCore::isLegacyAppleStyleSpan): Renamed from isStyleSpan.4805 (WebCore::isSpanWithoutAttributesOrUnstyledStyleSpan): Renamed from isSpanWithoutAttributesOr*Unstyle*StyleSpan.4806 (WebCore::createFontElement): No longer adds class="Apple-style-span".4807 (WebCore::createStyleSpanElement): Ditto.4808 (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Calls isSpanWithoutAttributesOrUnstyleStyleSpan4809 instead of isUnstyledStyleSpan since there won't be any Apple style spans.4810 (WebCore::dummySpanAncestorForNode):4811 (WebCore::ApplyStyleCommand::cleanupUnstyledAppleStyleSpans): Ditto.4812 (WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock): Ditto.4813 (WebCore::ApplyStyleCommand::removeImplicitlyStyledElement):4814 (WebCore::ApplyStyleCommand::removeCSSStyle):4815 * editing/ApplyStyleCommand.h:4816 * editing/EditingStyle.cpp:4817 (WebCore::EditingStyle::removeStyleFromRulesAndContext): Ditto.4818 * editing/ReplaceSelectionCommand.cpp:4819 (WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline): Calls isLegacyAppleStyleSpan instead4820 of isStyleSpan.4821 (WebCore::handleStyleSpansBeforeInsertion): Ditto.4822 (WebCore::ReplaceSelectionCommand::handleStyleSpans): Ditto.4823 (WebCore::ReplaceSelectionCommand::doApply): Ditto.4824 * editing/markup.cpp:4825 (WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag): No longer adds class="Apple-style-span".4826 4827 2011-08-12 Nat Duca <nduca@chromium.org>4828 4829 [chromium] Fix compositor breakage due to duplicate context creation AND by context-lost4830 https://bugs.webkit.org/show_bug.cgi?id=661684831 4832 * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:4833 (WebCore::CCLayerTreeHost::CCLayerTreeHost):4834 (WebCore::CCLayerTreeHost::initialize):4835 4836 2011-08-12 Levi Weintraub <leviw@chromium.org>4837 4838 Switch RenderMenuList, RenderListBox, and RenderFieldSet to new layout units4839 https://bugs.webkit.org/show_bug.cgi?id=661494840 4841 Reviewed by Eric Seidel.4842 4843 Changing RenderMenuList, RenderListBox, and RenderFieldSet to the LayoutUnit4844 abstraction from ints.4845 4846 No tests as no change in functionality.4847 4848 * rendering/RenderFieldset.cpp:4849 (WebCore::RenderFieldset::layoutSpecialExcludedChild):4850 * rendering/RenderListBox.cpp:4851 (WebCore::RenderListBox::numVisibleItems):4852 (WebCore::RenderListBox::listHeight):4853 (WebCore::RenderListBox::baselinePosition):4854 (WebCore::RenderListBox::itemBoundingBoxRect):4855 (WebCore::itemOffsetForAlignment):4856 (WebCore::RenderListBox::panScroll):4857 (WebCore::RenderListBox::scrollToward):4858 (WebCore::RenderListBox::autoscroll):4859 (WebCore::RenderListBox::scrollSize):4860 (WebCore::RenderListBox::scrollPosition):4861 (WebCore::RenderListBox::setScrollOffset):4862 (WebCore::RenderListBox::itemHeight):4863 (WebCore::RenderListBox::verticalScrollbarWidth):4864 (WebCore::RenderListBox::scrollWidth):4865 (WebCore::RenderListBox::scrollHeight):4866 (WebCore::RenderListBox::scrollLeft):4867 (WebCore::RenderListBox::setScrollLeft):4868 (WebCore::RenderListBox::scrollTop):4869 (WebCore::RenderListBox::setScrollTop):4870 (WebCore::RenderListBox::controlClipRect):4871 (WebCore::RenderListBox::invalidateScrollbarRect):4872 (WebCore::RenderListBox::convertFromScrollbarToContainingView):4873 (WebCore::RenderListBox::convertFromContainingViewToScrollbar):4874 (WebCore::RenderListBox::contentsSize):4875 (WebCore::RenderListBox::currentMousePosition):4876 * rendering/RenderListBox.h:4877 (WebCore::RenderListBox::scrollCornerRect):4878 (WebCore::RenderListBox::invalidateScrollCornerRect):4879 * rendering/RenderMenuList.cpp:4880 (WebCore::RenderMenuList::controlClipRect):4881 (WebCore::RenderMenuList::showPopup):4882 * rendering/RenderMenuList.h:4883 4884 2011-08-12 David Hyatt <hyatt@apple.com>4885 4886 https://bugs.webkit.org/show_bug.cgi?id=661334887 4888 Make hit testing work on RenderRegions. Pass off the hit testing to the RenderFlowThread4889 layer tree (just as we did with painting).4890 4891 Reviewed by Sam Weinig.4892 4893 Added hit-test-float.html to demonstrate basic hit testing of content flowed into regions.4894 4895 * rendering/HitTestRequest.h:4896 (WebCore::HitTestRequest::type):4897 * rendering/RenderFlowThread.cpp:4898 (WebCore::RenderFlowThread::hitTestRegion):4899 * rendering/RenderFlowThread.h:4900 * rendering/RenderRegion.cpp:4901 (WebCore::RenderRegion::paintReplaced):4902 (WebCore::RenderRegion::nodeAtPoint):4903 * rendering/RenderRegion.h:4904 4905 2011-08-12 Levi Weintraub <leviw@chromium.org>4906 4907 Switch RenderTable* to new layout types4908 https://bugs.webkit.org/show_bug.cgi?id=661464909 4910 Reviewed by Eric Seidel.4911 4912 Converting RenderTable* classes to new LayoutUnits from ints.4913 4914 No new tests as no new functionality.4915 4916 * rendering/RenderTable.cpp:4917 (WebCore::RenderTable::firstLineBoxBaseline):4918 (WebCore::RenderTable::overflowClipRect):4919 * rendering/RenderTable.h:4920 (WebCore::RenderTable::columnPositions):4921 * rendering/RenderTableCol.cpp:4922 (WebCore::RenderTableCol::clippedOverflowRectForRepaint):4923 * rendering/RenderTableRow.cpp:4924 (WebCore::RenderTableRow::clippedOverflowRectForRepaint):4925 * rendering/RenderTableSection.cpp:4926 (WebCore::RenderTableSection::setCellLogicalWidths):4927 (WebCore::RenderTableSection::calcRowLogicalHeight):4928 (WebCore::RenderTableSection::layoutRows):4929 (WebCore::RenderTableSection::calcOuterBorderBefore):4930 (WebCore::RenderTableSection::calcOuterBorderAfter):4931 (WebCore::RenderTableSection::calcOuterBorderStart):4932 (WebCore::RenderTableSection::calcOuterBorderEnd):4933 (WebCore::RenderTableSection::firstLineBoxBaseline):4934 (WebCore::RenderTableSection::paintObject):4935 (WebCore::RenderTableSection::nodeAtPoint):4936 * rendering/RenderTableSection.h:4937 (WebCore::RenderTableSection::outerBorderBefore):4938 (WebCore::RenderTableSection::outerBorderAfter):4939 (WebCore::RenderTableSection::outerBorderStart):4940 (WebCore::RenderTableSection::outerBorderEnd):4941 (WebCore::RenderTableSection::getBaseline):4942 4943 2011-08-12 Adam Bergkvist <adam.bergkvist@ericsson.com>4944 4945 Reviewed by Alexey Proskuryakov.4946 4947 EventSource loader should not buffer data4948 https://bugs.webkit.org/show_bug.cgi?id=618634949 4950 Disabled buffering in the EventSource loader.4951 4952 Added a manual test.4953 4954 * manual-tests/eventsource/eventsource-loader-buffering.html: Added.4955 * manual-tests/eventsource/eventsource-loader-buffering.php: Added.4956 * page/EventSource.cpp:4957 (WebCore::EventSource::connect):4958 4959 2011-08-11 Pratik Solanki <psolanki@apple.com>4960 4961 ResourceLoader::didReceiveDataArray() does not handle m_shouldBufferData correctly4962 https://bugs.webkit.org/show_bug.cgi?id=659264963 4964 Reviewed by Alexey Proskuryakov.4965 4966 * loader/mac/ResourceLoaderMac.mm:4967 (WebCore::ResourceLoader::didReceiveDataArray): Make sure we call the client callbacks when4968 m_shouldBufferData is set to false.4969 4970 2011-08-12 Sheriff Bot <webkit.review.bot@gmail.com>4971 4972 Unreviewed, rolling out r92976.4973 http://trac.webkit.org/changeset/929764974 https://bugs.webkit.org/show_bug.cgi?id=661594975 4976 Does not compile on chromium-win (Requested by abarth|gardener4977 on #webkit).4978 4979 * WebCore.gypi:4980 * platform/chromium/PopupContainer.cpp: Removed.4981 * platform/chromium/PopupContainer.h: Removed.4982 * platform/chromium/PopupListBox.cpp: Removed.4983 * platform/chromium/PopupListBox.h: Removed.4984 * platform/chromium/PopupMenuChromium.cpp:4985 (WebCore::PopupListBox::create):4986 (WebCore::PopupListBox::selectedIndex):4987 (WebCore::PopupListBox::numItems):4988 (WebCore::PopupListBox::setBaseWidth):4989 (WebCore::PopupListBox::setMaxHeight):4990 (WebCore::PopupListBox::setMaxWidth):4991 (WebCore::PopupListBox::disconnectClient):4992 (WebCore::PopupListBox::items):4993 (WebCore::PopupListBox::PopupListBox):4994 (WebCore::PopupListBox::~PopupListBox):4995 (WebCore::PopupListBox::scrollToRevealSelection):4996 (WebCore::constructRelativeMouseEvent):4997 (WebCore::constructRelativeWheelEvent):4998 (WebCore::PopupContainer::create):4999 (WebCore::PopupContainer::PopupContainer):5000 (WebCore::PopupContainer::~PopupContainer):5001 (WebCore::PopupContainer::layoutAndCalculateWidgetRect):5002 (WebCore::PopupContainer::showPopup):5003 (WebCore::PopupContainer::hidePopup):5004 (WebCore::PopupContainer::notifyPopupHidden):5005 (WebCore::PopupContainer::layoutAndGetRTLOffset):5006 (WebCore::PopupContainer::handleMouseDownEvent):5007 (WebCore::PopupContainer::handleMouseMoveEvent):5008 (WebCore::PopupContainer::handleMouseReleaseEvent):5009 (WebCore::PopupContainer::handleWheelEvent):5010 (WebCore::PopupContainer::handleTouchEvent):5011 (WebCore::PopupContainer::handleGestureEvent):5012 (WebCore::PopupContainer::handleKeyEvent):5013 (WebCore::PopupContainer::hide):5014 (WebCore::PopupContainer::paint):5015 (WebCore::PopupContainer::paintBorder):5016 (WebCore::PopupContainer::isInterestedInEventForKey):5017 (WebCore::PopupContainer::chromeClientChromium):5018 (WebCore::PopupContainer::showInRect):5019 (WebCore::PopupContainer::refresh):5020 (WebCore::PopupContainer::isRTL):5021 (WebCore::PopupContainer::selectedIndex):5022 (WebCore::PopupContainer::menuItemHeight):5023 (WebCore::PopupContainer::menuItemFontSize):5024 (WebCore::PopupContainer::menuStyle):5025 (WebCore::popupData):5026 (WebCore::PopupContainer::getSelectedItemToolTip):5027 (WebCore::PopupListBox::handleMouseDownEvent):5028 (WebCore::PopupListBox::handleMouseMoveEvent):5029 (WebCore::PopupListBox::handleMouseReleaseEvent):5030 (WebCore::PopupListBox::handleWheelEvent):5031 (WebCore::PopupListBox::isInterestedInEventForKey):5032 (WebCore::PopupListBox::handleTouchEvent):5033 (WebCore::PopupListBox::handleGestureEvent):5034 (WebCore::isCharacterTypeEvent):5035 (WebCore::PopupListBox::handleKeyEvent):5036 (WebCore::PopupListBox::hostWindow):5037 (WebCore::stripLeadingWhiteSpace):5038 (WebCore::PopupListBox::typeAheadFind):5039 (WebCore::PopupListBox::paint):5040 (WebCore::PopupListBox::paintRow):5041 (WebCore::PopupListBox::getRowFont):5042 (WebCore::PopupListBox::abandon):5043 (WebCore::PopupListBox::pointToRowIndex):5044 (WebCore::PopupListBox::acceptIndex):5045 (WebCore::PopupListBox::selectIndex):5046 (WebCore::PopupListBox::setOriginalIndex):5047 (WebCore::PopupListBox::getRowHeight):5048 (WebCore::PopupListBox::getRowBounds):5049 (WebCore::PopupListBox::invalidateRow):5050 (WebCore::PopupListBox::scrollToRevealRow):5051 (WebCore::PopupListBox::isSelectableItem):5052 (WebCore::PopupListBox::clearSelection):5053 (WebCore::PopupListBox::selectNextRow):5054 (WebCore::PopupListBox::selectPreviousRow):5055 (WebCore::PopupListBox::adjustSelectedIndex):5056 (WebCore::PopupListBox::hidePopup):5057 (WebCore::PopupListBox::updateFromElement):5058 (WebCore::PopupListBox::setMaxWidthAndLayout):5059 (WebCore::PopupListBox::layout):5060 (WebCore::PopupListBox::clear):5061 (WebCore::PopupListBox::isPointInBounds):5062 * platform/chromium/PopupMenuChromium.h:5063 (WebCore::PopupItem::PopupItem):5064 (WebCore::PopupContainer::listBox):5065 (WebCore::PopupContainer::popupType):5066 5067 2011-08-12 Andy Estes <aestes@apple.com>5068 5069 Cancel in onbeforeunload dialog sometime causes a button to stop working.5070 https://bugs.webkit.org/show_bug.cgi?id=262115071 5072 Reviewed by Alexey Proskuryakov.5073 5074 Test: fast/loader/form-submission-after-beforeunload-cancel.html5075 5076 If an onbeforeunload handler cancels a navigation that was triggered by5077 a form submission, WebCore's multiple form submission protection5078 prevents the form from being submitted a second time even though no5079 first submission actually took place. Fix this by clearing5080 m_submittedFormURL if the onbeforeunload handler cancels the load. This5081 allows the submission to be retried.5082 5083 * loader/FrameLoader.cpp:5084 (WebCore::FrameLoader::shouldClose): Set m_submittedFormURL to KURL()5085 if shouldClose() will return false.5086 5087 2011-08-12 David Hyatt <hyatt@apple.com>5088 5089 https://bugs.webkit.org/show_bug.cgi?id=661305090 5091 RenderRegions need to paint the entire RenderFlowThread layer tree. Instead of just calling5092 paintBlock, make sure RenderRegions paint the flow thread's layer tree instead with the appropriate5093 offset.5094 5095 Fix RenderRegions to derive from RenderReplaced instead of RenderBox, since it simplifies the code.5096 They no longer have to subclass their own layout method or worry about all of the painting logic5097 for anything other than the content area.5098 5099 Reviewed by Anders Carlsson.5100 5101 Existing tests have a layer tree example, and so those results are updated to show the tree now.5102 5103 * rendering/RenderFlowThread.cpp:5104 (WebCore::RenderFlowThread::createFlowThreadStyle):5105 (WebCore::RenderFlowThread::paintIntoRegion):5106 * rendering/RenderLayer.cpp:5107 (WebCore::RenderLayer::collectLayers):5108 * rendering/RenderRegion.cpp:5109 (WebCore::RenderRegion::RenderRegion):5110 (WebCore::RenderRegion::paintReplaced):5111 (WebCore::RenderRegion::styleDidChange):5112 * rendering/RenderRegion.h:5113 5114 2011-08-12 Chris Rogers <crogers@google.com>5115 5116 Fix mac build when web audio is enabled5117 https://bugs.webkit.org/show_bug.cgi?id=661505118 5119 Unreviewed build fix.5120 5121 * platform/audio/mac/AudioFileReaderMac.cpp:5122 (WebCore::AudioFileReader::createBus):5123 5124 2011-08-12 Jeff Miller <jeffm@apple.com>5125 5126 Need to handle kCACFContextNeedsFlushNotification notifications that arrive after the AVFWrapper has been disposed5127 https://bugs.webkit.org/show_bug.cgi?id=657245128 5129 Instead of using a pointer to the AVFWrapper object as the context for various callbacks, assign each object an5130 ID and use that instead. Keep track of the mapping between object IDs and AVFWrapper objects in a HashMap, and manage5131 access to this map using a Mutex since it can be accessed from multiple threads. This allows us to actually delete5132 AVFWrapper objects instead of leaking them (which we were doing before to prevent crashes).5133 5134 Reviewed by Eric Carlson.5135 5136 No new tests, uses existing media tests.5137 5138 * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp:5139 (WebCore::AVFWrapper::callbackContext): Added.5140 (WebCore::AVFWrapper::AVFWrapper): Initialize m_objectID and add it to the HashMap.5141 (WebCore::AVFWrapper::~AVFWrapper): Log object ID and remove obsolete assert.5142 (WebCore::AVFWrapper::mapLock): Added.5143 (WebCore::AVFWrapper::map): Added.5144 (WebCore::AVFWrapper::addToMap): Added.5145 (WebCore::AVFWrapper::removeFromMap): Added.5146 (WebCore::AVFWrapper::avfWrapperForCallbackContext): Added.5147 (WebCore::AVFWrapper::scheduleDisconnectAndDelete): Remove AVFWrapper from HashMap instead of zeroing m_owner.5148 (WebCore::AVFWrapper::disconnectAndDeleteAVFWrapper): Use callbackContext(), delete the AVFWrapper here.5149 (WebCore::AVFWrapper::createPlayer): Use callbackContext().5150 (WebCore::AVFWrapper::createPlayerItem): Use callbackContext().5151 (WebCore::AVFWrapper::periodicTimeObserverCallback): Retrieve AVFWrapper using the HashMap.5152 (WebCore::AVFWrapper::notificationCallback): Retrieve AVFWrapper using the HashMap.5153 (WebCore::AVFWrapper::loadPlayableCompletionCallback): Retrieve AVFWrapper using the HashMap.5154 (WebCore::AVFWrapper::checkPlayability): Use callbackContext().5155 (WebCore::AVFWrapper::loadMetadataCompletionCallback): Retrieve AVFWrapper using the HashMap.5156 (WebCore::AVFWrapper::beginLoadingMetadata): Use callbackContext().5157 (WebCore::AVFWrapper::seekCompletedCallback): Retrieve AVFWrapper using the HashMap.5158 (WebCore::AVFWrapper::seekToTime): Use callbackContext().5159 (WebCore::AVFWrapper::platformLayer): Remove overly noisy LOG().5160 5161 2011-08-12 Fady Samuel <fsamuel@chromium.org>5162 5163 Refactoring of PopupMenuChromium5164 https://bugs.webkit.org/show_bug.cgi?id=660095165 5166 Reviewed by Darin Fisher.5167 5168 Split PopupMenuChromium into three sets of files: PopupMenuChromium.{h|cpp}, PopupContainer.{h|cpp}, and PopupLisBox.{h|cpp}5169 for readability and maintainability.5170 5171 No new tests as no functionality has changed.5172 5173 * WebCore.gypi:5174 * platform/chromium/PopupContainer.cpp: Added.5175 (WebCore::constructRelativeMouseEvent):5176 (WebCore::constructRelativeWheelEvent):5177 (WebCore::PopupContainer::create):5178 (WebCore::PopupContainer::PopupContainer):5179 (WebCore::PopupContainer::~PopupContainer):5180 (WebCore::PopupContainer::layoutAndCalculateWidgetRect):5181 (WebCore::PopupContainer::showPopup):5182 (WebCore::PopupContainer::hidePopup):5183 (WebCore::PopupContainer::notifyPopupHidden):5184 (WebCore::PopupContainer::layoutAndGetRTLOffset):5185 (WebCore::PopupContainer::handleMouseDownEvent):5186 (WebCore::PopupContainer::handleMouseMoveEvent):5187 (WebCore::PopupContainer::handleMouseReleaseEvent):5188 (WebCore::PopupContainer::handleWheelEvent):5189 (WebCore::PopupContainer::handleTouchEvent):5190 (WebCore::PopupContainer::handleGestureEvent):5191 (WebCore::PopupContainer::handleKeyEvent):5192 (WebCore::PopupContainer::hide):5193 (WebCore::PopupContainer::paint):5194 (WebCore::PopupContainer::paintBorder):5195 (WebCore::PopupContainer::isInterestedInEventForKey):5196 (WebCore::PopupContainer::chromeClientChromium):5197 (WebCore::PopupContainer::showInRect):5198 (WebCore::PopupContainer::refresh):5199 (WebCore::PopupContainer::isRTL):5200 (WebCore::PopupContainer::selectedIndex):5201 (WebCore::PopupContainer::menuItemHeight):5202 (WebCore::PopupContainer::menuItemFontSize):5203 (WebCore::PopupContainer::menuStyle):5204 (WebCore::popupData):5205 (WebCore::PopupContainer::getSelectedItemToolTip):5206 * platform/chromium/PopupContainer.h: Added.5207 (WebCore::PopupContainer::listBox):5208 (WebCore::PopupContainer::popupType):5209 * platform/chromium/PopupListBox.cpp: Added.5210 (WebCore::PopupListBox::PopupListBox):5211 (WebCore::PopupListBox::handleMouseDownEvent):5212 (WebCore::PopupListBox::handleMouseMoveEvent):5213 (WebCore::PopupListBox::handleMouseReleaseEvent):5214 (WebCore::PopupListBox::handleWheelEvent):5215 (WebCore::PopupListBox::isInterestedInEventForKey):5216 (WebCore::PopupListBox::handleTouchEvent):5217 (WebCore::PopupListBox::handleGestureEvent):5218 (WebCore::isCharacterTypeEvent):5219 (WebCore::PopupListBox::handleKeyEvent):5220 (WebCore::PopupListBox::hostWindow):5221 (WebCore::stripLeadingWhiteSpace):5222 (WebCore::PopupListBox::typeAheadFind):5223 (WebCore::PopupListBox::paint):5224 (WebCore::PopupListBox::paintRow):5225 (WebCore::PopupListBox::getRowFont):5226 (WebCore::PopupListBox::abandon):5227 (WebCore::PopupListBox::pointToRowIndex):5228 (WebCore::PopupListBox::acceptIndex):5229 (WebCore::PopupListBox::selectIndex):5230 (WebCore::PopupListBox::setOriginalIndex):5231 (WebCore::PopupListBox::getRowHeight):5232 (WebCore::PopupListBox::getRowBounds):5233 (WebCore::PopupListBox::invalidateRow):5234 (WebCore::PopupListBox::scrollToRevealRow):5235 (WebCore::PopupListBox::isSelectableItem):5236 (WebCore::PopupListBox::clearSelection):5237 (WebCore::PopupListBox::selectNextRow):5238 (WebCore::PopupListBox::selectPreviousRow):5239 (WebCore::PopupListBox::adjustSelectedIndex):5240 (WebCore::PopupListBox::hidePopup):5241 (WebCore::PopupListBox::updateFromElement):5242 (WebCore::PopupListBox::setMaxWidthAndLayout):5243 (WebCore::PopupListBox::layout):5244 (WebCore::PopupListBox::clear):5245 (WebCore::PopupListBox::isPointInBounds):5246 * platform/chromium/PopupListBox.h: Added.5247 (WebCore::PopupItem::PopupItem):5248 (WebCore::PopupListBox::create):5249 (WebCore::PopupListBox::selectedIndex):5250 (WebCore::PopupListBox::numItems):5251 (WebCore::PopupListBox::setBaseWidth):5252 (WebCore::PopupListBox::setMaxHeight):5253 (WebCore::PopupListBox::setMaxWidth):5254 (WebCore::PopupListBox::disconnectClient):5255 (WebCore::PopupListBox::items):5256 (WebCore::PopupListBox::~PopupListBox):5257 (WebCore::PopupListBox::scrollToRevealSelection):5258 * platform/chromium/PopupMenuChromium.cpp:5259 * platform/chromium/PopupMenuChromium.h:5260 5261 2011-08-12 Sam Weinig <sam@webkit.org>5262 5263 Move compiler specific macros to their own header5264 https://bugs.webkit.org/show_bug.cgi?id=661195265 5266 Reviewed by Anders Carlsson.5267 5268 * ForwardingHeaders/wtf/Compiler.h: Added.5269 5270 2011-08-12 No'am Rosenthal <noam.rosenthal@nokia.com>5271 5272 [Qt][REGRESSION] composited content doesn't render since r926515273 https://bugs.webkit.org/show_bug.cgi?id=661085274 5275 Reviewed by Benjamin Poulain.5276 5277 Changed the signature for GraphicsLayerTextureMapper::syncCompositingState to match5278 the new signature in GraphicsLayer.h.5279 5280 No new tests. This is a regression that's covered by existing pixel tests.5281 5282 * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:5283 (WebCore::GraphicsLayerTextureMapper::syncCompositingState):5284 * platform/graphics/texmap/GraphicsLayerTextureMapper.h:5285 5286 2011-08-12 Alexandru Chiculita <achicu@adobe.com>5287 5288 Original patch by Mihnea Ovidenie <mihnea@adobe.com>.5289 Also contains some improvements done by Dave Hyatt <hyatt@apple.com>.5290 5291 [CSSRegions]RenderFlowThread should display its content using RenderRegion5292 https://bugs.webkit.org/show_bug.cgi?id=656275293 5294 RenderFlowThread collects RenderObjects from a flow. These objects are displayed by means5295 of RenderRegion objects that get the content from the same flow.5296 5297 Reviewed by David Hyatt.5298 5299 Tests: fast/regions/content-flowed-into-regions-dynamically-added.html5300 fast/regions/content-flowed-into-regions-dynamically-removed.html5301 fast/regions/content-flowed-into-regions-with-dyn-index.html5302 fast/regions/content-flowed-into-regions-with-index-dom.html5303 fast/regions/content-flowed-into-regions-with-index.html5304 fast/regions/content-flowed-into-regions.html5305 fast/regions/flow-content-basic-vertical-rl.html5306 fast/regions/flow-content-basic-vertical.html5307 5308 * dom/Node.cpp:5309 (WebCore::Node::diff):5310 * rendering/RenderFlowThread.cpp:5311 (WebCore::RenderFlowThread::RenderFlowThread):5312 (WebCore::RenderFlowThread::createFlowThreadStyle):5313 (WebCore::RenderFlowThread::styleDidChange):5314 (WebCore::compareRenderRegions):5315 (WebCore::RenderFlowThread::addRegionToThread):5316 (WebCore::RenderFlowThread::removeRegionFromThread):5317 (WebCore::RenderFlowThread::layout):5318 (WebCore::RenderFlowThread::computeLogicalWidth):5319 (WebCore::RenderFlowThread::computeLogicalHeight):5320 (WebCore::RenderFlowThread::paintIntoRegion):5321 * rendering/RenderFlowThread.h:5322 * rendering/RenderObject.cpp:5323 (WebCore::RenderObject::createObject):5324 * rendering/RenderRegion.cpp:5325 (WebCore::RenderRegion::RenderRegion):5326 (WebCore::RenderRegion::~RenderRegion):5327 (WebCore::RenderRegion::paint):5328 (WebCore::RenderRegion::styleDidChange):5329 * rendering/RenderRegion.h:5330 (WebCore::RenderRegion::setRegionRect):5331 (WebCore::RenderRegion::regionRect):5332 * rendering/RenderTreeAsText.cpp:5333 (WebCore::writeLayers):5334 * rendering/RenderView.cpp:5335 (WebCore::RenderView::styleDidChange):5336 (WebCore::RenderView::renderFlowThreadWithName):5337 * rendering/RenderView.h:5338 5339 2011-08-12 Abhishek Arya <inferno@chromium.org>5340 5341 Crash in WebCore::editingIgnoresContent5342 https://bugs.webkit.org/show_bug.cgi?id=661255343 5344 Reviewed by Ryosuke Niwa.5345 5346 RefPtr a few nodes in case they get blown away in5347 dispatchEvent calls.5348 5349 Test: editing/selection/select-start-remove-root-crash.html5350 5351 * editing/FrameSelection.cpp:5352 (WebCore::FrameSelection::selectAll):5353 * editing/ReplaceSelectionCommand.cpp:5354 (WebCore::ReplacementFragment::ReplacementFragment):5355 5356 2011-08-11 Pavel Podivilov <podivilov@chromium.org>5357 5358 Web Inspector: properly update console message count in source frames and resources panel.5359 https://bugs.webkit.org/show_bug.cgi?id=570095360 5361 Reviewed by Yury Semikhatsky.5362 5363 * inspector/front-end/ConsoleView.js:5364 (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageRepeatCountUpdated):5365 * inspector/front-end/SourceFrame.js:5366 (WebInspector.SourceFrame.prototype.show):5367 (WebInspector.SourceFrame.prototype.addMessageToSource):5368 (WebInspector.SourceFrame.prototype._updateMessageRepeatCount):5369 5370 2011-08-12 Pavel Feldman <pfeldman@google.com>5371 5372 Not reviewed: follow up to inspector test breakage.5373 5374 * inspector/front-end/ScriptsPanel.js:5375 (WebInspector.ScriptsPanel.prototype._showScriptFoldersSettingChanged):5376 5377 2011-08-12 Yury Semikhatsky <yurys@chromium.org>5378 5379 Web Inspector: expand exception properties when wrapping it as object.5380 https://bugs.webkit.org/show_bug.cgi?id=660355381 5382 Use toString() value as a description for value thrown during eval.5383 5384 Reviewed by Pavel Feldman.5385 5386 * inspector/InjectedScriptSource.js:5387 (.):5388 5389 2011-08-12 Pavel Feldman <pfeldman@google.com>5390 5391 Web Inspector: make folders optional in the Scripts' panel file selector.5392 https://bugs.webkit.org/show_bug.cgi?id=661005393 5394 Reviewed by Yury Semikhatsky.5395 5396 * English.lproj/localizedStrings.js:5397 * inspector/front-end/ScriptsPanel.js:5398 (WebInspector.ScriptsPanel.prototype._showScriptFoldersSettingChanged):5399 (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered.optionCompare):5400 (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect.insertOrdered):5401 (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):5402 (WebInspector.ScriptsPanel.prototype.reset):5403 (WebInspector.ScriptsPanel.prototype._resetFilesSelect):5404 * inspector/front-end/Settings.js:5405 (WebInspector.Settings):5406 * inspector/front-end/SettingsScreen.js:5407 (WebInspector.SettingsScreen):5408 5409 2011-08-12 Pavel Podivilov <podivilov@chromium.org>5410 5411 Web Inspector: add space between error info and error message in source frame message bubble.5412 https://bugs.webkit.org/show_bug.cgi?id=650695413 5414 Reviewed by Pavel Feldman.5415 5416 * inspector/front-end/ConsoleView.js:5417 (WebInspector.ConsoleMessage.prototype._formatMessage):5418 5419 2011-08-12 Pavel Feldman <pfeldman@google.com>5420 5421 Web Inspector: console loses focus upon reloading the page from the inspector.5422 https://bugs.webkit.org/show_bug.cgi?id=660685423 5424 Reviewed by Yury Semikhatsky.5425 5426 * inspector/front-end/AuditsPanel.js:5427 (WebInspector.AuditsPanel.prototype._auditFinishedCallback):5428 (WebInspector.AuditsPanel.prototype._clearButtonClicked):5429 * inspector/front-end/DataGrid.js:5430 (WebInspector.DataGrid.prototype.revealAndSelect):5431 (WebInspector.DataGridNode.prototype.revealAndSelect):5432 * inspector/front-end/DetailedHeapshotView.js:5433 (WebInspector.DetailedHeapshotView.prototype._jumpToSearchResult):5434 * inspector/front-end/ElementsPanel.js:5435 (WebInspector.ElementsPanel.this.treeOutline.selectedNodeChanged):5436 (WebInspector.ElementsPanel.get this):5437 (WebInspector.ElementsPanel):5438 (WebInspector.ElementsPanel.prototype._reset):5439 (WebInspector.ElementsPanel.prototype._setDocument.selectNode):5440 (WebInspector.ElementsPanel.prototype._setDocument.selectLastSelectedNode):5441 (WebInspector.ElementsPanel.prototype._setDocument):5442 (WebInspector.ElementsPanel.prototype._domWordWrapSettingChanged):5443 (WebInspector.ElementsPanel.prototype.populateHrefContextMenu):5444 (WebInspector.ElementsPanel.prototype.switchToAndFocus):5445 (WebInspector.ElementsPanel.prototype.selectedDOMNode):5446 (WebInspector.ElementsPanel.prototype.selectDOMNode):5447 (WebInspector.ElementsPanel.prototype.updateModifiedNodes):5448 (WebInspector.ElementsPanel.prototype.updateBreadcrumb.selectCrumbFunction):5449 (WebInspector.ElementsPanel.prototype.updateBreadcrumb):5450 (WebInspector.ElementsPanel.prototype.updateStyles):5451 (WebInspector.ElementsPanel.prototype.updateMetrics):5452 (WebInspector.ElementsPanel.prototype.updateProperties):5453 (WebInspector.ElementsPanel.prototype.updateEventListeners):5454 (WebInspector.ElementsPanel.prototype.handleCopyEvent):5455 (WebInspector.ElementsPanel.prototype.updateFocusedNode):5456 * inspector/front-end/ElementsTreeOutline.js:5457 (WebInspector.ElementsTreeOutline):5458 (WebInspector.ElementsTreeOutline.prototype.selectedDOMNode):5459 (WebInspector.ElementsTreeOutline.prototype.selectDOMNode):5460 (WebInspector.ElementsTreeOutline.prototype.update):5461 (WebInspector.ElementsTreeOutline.prototype._revealAndSelectNode):5462 (WebInspector.ElementsTreeOutline.prototype._ondrop.callback):5463 (WebInspector.ElementsTreeOutline.prototype._ondrop):5464 (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode):5465 (WebInspector.ElementsTreeElement.prototype._updateChildren):5466 (WebInspector.ElementsTreeElement.prototype.onselect):5467 (WebInspector.ElementsTreeElement.prototype.selectOnMouseDown):5468 (WebInspector.ElementsTreeElement.prototype._startEditingTarget):5469 (WebInspector.ElementsTreeElement.prototype._startEditing):5470 * inspector/front-end/Panel.js:5471 (WebInspector.Panel.prototype.reset):5472 * inspector/front-end/ProfileView.js:5473 (WebInspector.CPUProfileView.prototype._jumpToSearchResult):5474 * inspector/front-end/ProfilesPanel.js:5475 (WebInspector.ProfilesPanel.prototype._addProfileHeader):5476 (WebInspector.ProfilesPanel.prototype.showProfile):5477 (WebInspector.ProfileSidebarTreeElement.prototype.onselect):5478 * inspector/front-end/ResourcesPanel.js:5479 (WebInspector.ResourcesPanel.prototype._initDefaultSelection.get if):5480 (WebInspector.ResourcesPanel.prototype._initDefaultSelection):5481 (WebInspector.ResourcesPanel.prototype.reset):5482 (WebInspector.ResourcesPanel.prototype.showResource):5483 * inspector/front-end/StylesSidebarPane.js:5484 (WebInspector.StylePropertiesSection.prototype.editingSelectorCommitted):5485 (WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL):5486 * inspector/front-end/TimelinePanel.js:5487 (WebInspector.TimelinePanel.prototype._createTopPane):5488 * inspector/front-end/inspector.js:5489 * inspector/front-end/inspectorCommon.css:5490 (body):5491 * inspector/front-end/treeoutline.js:5492 (TreeOutline.prototype.revealAndSelect):5493 (TreeElement.prototype.selectOnMouseDown):5494 (TreeElement.prototype.revealAndSelect):5495 (TreeElement.prototype.select):5496 5497 2011-08-12 Yury Semikhatsky <yurys@chromium.org>5498 5499 Unreviewed. Inspector clean-up: remove unused method declaration from InspectorAgent.h5500 5501 * inspector/InspectorAgent.h:5502 5503 2011-08-12 Vsevolod Vlasov <vsevik@chromium.org>5504 5505 Web Inspector: Network resource identifier should have RequestId type and requestId name in protocol.5506 https://bugs.webkit.org/show_bug.cgi?id=660615507 5508 Reviewed by Pavel Feldman.5509 5510 * inspector/ConsoleMessage.cpp:5511 (WebCore::ConsoleMessage::ConsoleMessage):5512 (WebCore::ConsoleMessage::addToFrontend):5513 * inspector/ConsoleMessage.h:5514 * inspector/IdentifiersFactory.cpp:5515 (WebCore::IdentifiersFactory::requestId):5516 * inspector/IdentifiersFactory.h:5517 * inspector/Inspector.json:5518 * inspector/InspectorConsoleAgent.cpp:5519 (WebCore::InspectorConsoleAgent::didReceiveResponse):5520 (WebCore::InspectorConsoleAgent::didFailLoading):5521 * inspector/InspectorResourceAgent.cpp:5522 (WebCore::InspectorResourceAgent::willSendRequest):5523 (WebCore::InspectorResourceAgent::markResourceAsCached):5524 (WebCore::InspectorResourceAgent::didReceiveResponse):5525 (WebCore::InspectorResourceAgent::didReceiveData):5526 (WebCore::InspectorResourceAgent::didFinishLoading):5527 (WebCore::InspectorResourceAgent::didFailLoading):5528 (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):5529 (WebCore::InspectorResourceAgent::setInitialScriptContent):5530 (WebCore::InspectorResourceAgent::didReceiveScriptResponse):5531 (WebCore::InspectorResourceAgent::setInitialXHRContent):5532 (WebCore::InspectorResourceAgent::didReceiveXHRResponse):5533 (WebCore::InspectorResourceAgent::didCreateWebSocket):5534 (WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):5535 (WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):5536 (WebCore::InspectorResourceAgent::didCloseWebSocket):5537 (WebCore::InspectorResourceAgent::getResourceContent):5538 * inspector/InspectorResourceAgent.h:5539 * inspector/InspectorTimelineAgent.cpp:5540 (WebCore::InspectorTimelineAgent::willSendResourceRequest):5541 (WebCore::InspectorTimelineAgent::willReceiveResourceData):5542 (WebCore::InspectorTimelineAgent::willReceiveResourceResponse):5543 (WebCore::InspectorTimelineAgent::didFinishLoadingResource):5544 * inspector/NetworkResourcesData.cpp:5545 (WebCore::NetworkResourcesData::ResourceData::ResourceData):5546 (WebCore::NetworkResourcesData::resourceCreated):5547 (WebCore::NetworkResourcesData::responseReceived):5548 (WebCore::NetworkResourcesData::setResourceType):5549 (WebCore::NetworkResourcesData::resourceType):5550 (WebCore::NetworkResourcesData::setResourceContent):5551 (WebCore::NetworkResourcesData::maybeAddResourceData):5552 (WebCore::NetworkResourcesData::maybeDecodeDataToContent):5553 (WebCore::NetworkResourcesData::addCachedResource):5554 (WebCore::NetworkResourcesData::addResourceSharedBuffer):5555 (WebCore::NetworkResourcesData::data):5556 (WebCore::NetworkResourcesData::clear):5557 (WebCore::NetworkResourcesData::ensureNoDataForRequestId):5558 (WebCore::NetworkResourcesData::ensureFreeSpace):5559 * inspector/NetworkResourcesData.h:5560 (WebCore::NetworkResourcesData::ResourceData::requestId):5561 * inspector/TimelineRecordFactory.cpp:5562 (WebCore::TimelineRecordFactory::createResourceSendRequestData):5563 (WebCore::TimelineRecordFactory::createResourceReceiveResponseData):5564 (WebCore::TimelineRecordFactory::createResourceFinishData):5565 (WebCore::TimelineRecordFactory::createReceiveResourceData):5566 * inspector/TimelineRecordFactory.h:5567 * inspector/front-end/ConsoleView.js:5568 (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageAdded):5569 * inspector/front-end/ExtensionAPI.js:5570 (WebInspector.injectedExtensionAPI.Resources.prototype.getHAR):5571 * inspector/front-end/ExtensionServer.js:5572 (WebInspector.ExtensionServer):5573 (WebInspector.ExtensionServer.prototype._notifyResourceFinished):5574 (WebInspector.ExtensionServer.prototype._onGetHAR):5575 (WebInspector.ExtensionServer.prototype._requestId):5576 * inspector/front-end/NetworkManager.js:5577 (WebInspector.NetworkManager.prototype.requestContent):5578 (WebInspector.NetworkDispatcher.prototype.requestWillBeSent):5579 (WebInspector.NetworkDispatcher.prototype.resourceMarkedAsCached):5580 (WebInspector.NetworkDispatcher.prototype.responseReceived):5581 (WebInspector.NetworkDispatcher.prototype.dataReceived):5582 (WebInspector.NetworkDispatcher.prototype.loadingFinished):5583 (WebInspector.NetworkDispatcher.prototype.loadingFailed):5584 (WebInspector.NetworkDispatcher.prototype.resourceLoadedFromMemoryCache):5585 (WebInspector.NetworkDispatcher.prototype.webSocketCreated):5586 (WebInspector.NetworkDispatcher.prototype.webSocketWillSendHandshakeRequest):5587 (WebInspector.NetworkDispatcher.prototype.webSocketHandshakeResponseReceived):5588 (WebInspector.NetworkDispatcher.prototype.webSocketClosed):5589 (WebInspector.NetworkDispatcher.prototype._appendRedirect):5590 (WebInspector.NetworkDispatcher.prototype._startResource):5591 (WebInspector.NetworkDispatcher.prototype._finishResource):5592 (WebInspector.NetworkDispatcher.prototype._createResource):5593 * inspector/front-end/NetworkPanel.js:5594 (WebInspector.NetworkLogView.prototype._appendResource):5595 (WebInspector.NetworkLogView.prototype._matchResource):5596 (WebInspector.NetworkLogView.prototype._updateSearchMatchedListAfterRequestIdChanged):5597 (WebInspector.NetworkLogView.prototype.performSearch):5598 * inspector/front-end/Resource.js:5599 (WebInspector.Resource):5600 * inspector/front-end/TimelinePanel.js:5601 (WebInspector.TimelinePanel.prototype._addRecordToTimeline):5602 (WebInspector.TimelinePanel.prototype._findParentRecord):5603 (WebInspector.TimelinePanel.FormattedRecord):5604 5605 2011-08-11 Hans Wennborg <hans@chromium.org>5606 5607 IndexedDB: Object store records don't need to have keys in all indexes5608 https://bugs.webkit.org/show_bug.cgi?id=660495609 5610 Reviewed by Tony Chang.5611 5612 Allow inserting records in an object store even though they don't5613 yield keys in some index. The spec has changed in this regard.5614 5615 * storage/IDBObjectStoreBackendImpl.cpp:5616 (WebCore::IDBObjectStoreBackendImpl::putInternal):5617 5618 2011-08-10 Hans Wennborg <hans@chromium.org>5619 5620 IndexedDB: Overwriting key in unique index should be possible5621 https://bugs.webkit.org/show_bug.cgi?id=659935622 5623 Reviewed by Tony Chang.5624 5625 It should be possible to overwrite an object store record even if5626 there is a derived key for that record in an index with the unique flag set.5627 5628 * storage/IDBBackingStore.h:5629 * storage/IDBIndexBackendImpl.cpp:5630 (WebCore::IDBIndexBackendImpl::addingKeyAllowed):5631 * storage/IDBIndexBackendImpl.h:5632 * storage/IDBLevelDBBackingStore.cpp:5633 (WebCore::IDBLevelDBBackingStore::keyExistsInIndex):5634 * storage/IDBLevelDBBackingStore.h:5635 * storage/IDBObjectStoreBackendImpl.cpp:5636 (WebCore::IDBObjectStoreBackendImpl::putInternal):5637 * storage/IDBSQLiteBackingStore.cpp:5638 (WebCore::IDBSQLiteBackingStore::keyExistsInIndex):5639 * storage/IDBSQLiteBackingStore.h:5640 5641 2011-08-11 Yuta Kitamura <yutak@chromium.org>5642 5643 WebSocket: Implement "protocol" attribute5644 https://bugs.webkit.org/show_bug.cgi?id=652485645 5646 Reviewed by Kent Tamura.5647 5648 Tests: http/tests/websocket/tests/hybi/no-subprotocol.html (added)5649 http/tests/websocket/tests/hybi/set-protocol.html (added)5650 http/tests/websocket/tests/hybi/workers/no-subprotocol.html (added)5651 http/tests/websocket/tests/hixie76/undefined-attributes.html (updated)5652 http/tests/websocket/tests/hybi/multiple-subprotocols.html (updated)5653 http/tests/websocket/tests/hybi/workers/multiple-subprotocols.html (updated)5654 5655 * websockets/ThreadableWebSocketChannel.h:5656 Added subprotocol() function. This function is named differently from the counterpart of5657 WebSocket class, because the name "protocol" can be confused with the WebSocket protocol.5658 Added m_useHixie76Protocol and m_subprotocol, because these value may be used after5659 m_channel has been released. Using bool should be fine, because boolean literals do not5660 appear in ambiguous context.5661 * websockets/ThreadableWebSocketChannelClientWrapper.cpp:5662 (WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):5663 (WebCore::ThreadableWebSocketChannelClientWrapper::subprotocol):5664 (WebCore::ThreadableWebSocketChannelClientWrapper::setSubprotocol):5665 * websockets/ThreadableWebSocketChannelClientWrapper.h:5666 * websockets/WebSocket.cpp:5667 (WebCore::WebSocket::WebSocket):5668 (WebCore::WebSocket::connect):5669 (WebCore::WebSocket::protocol):5670 The "protocol" attribute is available only when the hybi-10 protocol is chosen.5671 (WebCore::WebSocket::binaryType):5672 (WebCore::WebSocket::setBinaryType):5673 (WebCore::WebSocket::didConnect):5674 * websockets/WebSocket.h:5675 * websockets/WebSocket.idl:5676 * websockets/WebSocketChannel.cpp:5677 (WebCore::WebSocketChannel::subprotocol):5678 * websockets/WebSocketChannel.h:5679 * websockets/WorkerThreadableWebSocketChannel.cpp:5680 (WebCore::WorkerThreadableWebSocketChannel::subprotocol):5681 (WebCore::workerContextDidConnect):5682 Subprotocol value is saved in the client wrapper object after the WebSocket connection is5683 established.5684 (WebCore::WorkerThreadableWebSocketChannel::Peer::didConnect):5685 * websockets/WorkerThreadableWebSocketChannel.h:5686 5687 2011-08-11 Hayato Ito <hayato@chromium.org>5688 5689 Implement proper handling of events with a related target in regard to shadow DOM boundaries.5690 https://bugs.webkit.org/show_bug.cgi?id=658995691 5692 Reviewed by Dimitri Glazkov.5693 5694 Fixes issues in the following corner cases:5695 1. When both a target node and a relatedTarget node are immediate children of5696 the same shadow root, an event is not dispatched.5697 2. If a target node is an ancestor of a relatedTarget node, crossing5698 shadow boundaries, or vice verse, an event is not dispatched or wrongly5699 dispatched.5700 5701 Test: fast/dom/shadow/shadow-boundary-events.html5702 5703 * dom/EventDispatcher.cpp:5704 (WebCore::EventDispatcher::adjustToShadowBoundaries):5705 5706 2011-08-11 John Bauman <jbauman@chromium.org>5707 5708 Readback composited webgl results for printing5709 https://bugs.webkit.org/show_bug.cgi?id=656585710 5711 Reviewed by James Robinson.5712 5713 The real composited results may be locked inside the compositor5714 context's version of a texture because the drawing buffer was5715 automatically cleared, so read from there to get the actual presented5716 version to draw.5717 5718 * html/canvas/WebGLRenderingContext.cpp:5719 (WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):5720 * platform/graphics/GraphicsContext3D.h:5721 * platform/graphics/chromium/Extensions3DChromium.h:5722 * platform/graphics/chromium/WebGLLayerChromium.cpp:5723 (WebCore::WebGLLayerChromium::paintRenderedResultsToCanvas):5724 * platform/graphics/chromium/WebGLLayerChromium.h:5725 * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:5726 (WebCore::GraphicsContext3D::paintCompositedResultsToCanvas):5727 5728 2011-08-11 Andrew Wason <rectalogic@rectalogic.com>5729 5730 REGRESSION: Qt JavaScript bridge signal connection fails5731 https://bugs.webkit.org/show_bug.cgi?id=660975732 5733 Reviewed by Gavin Barraclough.5734 5735 Tests in WebKit/qt/tests/qwebframe5736 5737 Call toThisObject() on exec->lexicalGlobalObject() so the correct5738 object is passed to the JS signal handler.5739 5740 * bridge/qt/qt_runtime.cpp:5741 (JSC::Bindings::QtRuntimeConnectionMethod::call):5742 5743 2011-08-11 Nico Weber <thakis@chromium.org>5744 5745 Remove incorrect comment about m_wheelEventHandlerCount5746 https://bugs.webkit.org/show_bug.cgi?id=661175747 5748 Reviewed by Simon Fraser.5749 5750 From what I can tell, this number is changed only in5751 Frame::notifyChromeClientWheelEventHandlerCountChanged(),5752 and there it just reads the number modified in5753 Document::didAdd/RemoveWheelEventHandler(). So this is just the number5754 of event handlers (and not related to horizontal scrollbars), and the5755 variable name expresses that already.5756 5757 * dom/Document.h:5758 5759 2011-08-11 James Robinson <jamesr@chromium.org>5760 5761 [chromium] Defer managed texture creation and destruction until updateCompositorResources5762 https://bugs.webkit.org/show_bug.cgi?id=647725763 5764 Reviewed by Kenneth Russell.5765 5766 This adds support for deferring GraphicsContext3D calls for texture creation and destruction for managed5767 textures and defers these calls until updateCompositorResources() for contents textures. The primary benefit of5768 this change is that it decouples managing the texture budget for the next frame (which has to happen before5769 painting layer contents) from the actual GL calls that create/destroy textures. That way, in the threaded5770 compositing world we can continue to use textures from the previous frame while software painting contents for5771 the next frame into software buffers or SkPictures.5772 5773 Also renames LayerTexture to ManagedTexture to better reflect what it is. Not all ManagedTextures we create are5774 necessarily associated with layers, but they are all managed by a TextureManager.5775 5776 Covered by compositing/ layout tests.5777 5778 * WebCore.gypi:5779 * platform/graphics/chromium/ContentLayerChromium.h:5780 * platform/graphics/chromium/ImageLayerChromium.cpp:5781 (WebCore::ImageLayerTextureUpdater::updateTextureRect):5782 * platform/graphics/chromium/LayerRendererChromium.cpp:5783 (WebCore::LayerRendererChromium::releaseTextures):5784 (WebCore::LayerRendererChromium::drawLayers):5785 (WebCore::LayerRendererChromium::updateLayers):5786 (WebCore::LayerRendererChromium::getOffscreenLayerTexture):5787 (WebCore::LayerRendererChromium::useRenderSurface):5788 (WebCore::LayerRendererChromium::initializeSharedObjects):5789 * platform/graphics/chromium/LayerRendererChromium.h:5790 * platform/graphics/chromium/LayerTextureUpdater.h:5791 * platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:5792 (WebCore::LayerTextureUpdaterBitmap::updateTextureRect):5793 (WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):5794 * platform/graphics/chromium/LayerTextureUpdaterCanvas.h:5795 * platform/graphics/chromium/LayerTilerChromium.cpp:5796 (WebCore::LayerTilerChromium::getSingleTexture):5797 (WebCore::LayerTilerChromium::createTile):5798 (WebCore::LayerTilerChromium::updateRect):5799 (WebCore::LayerTilerChromium::drawTiles):5800 * platform/graphics/chromium/LayerTilerChromium.h:5801 (WebCore::LayerTilerChromium::Tile::Tile):5802 (WebCore::LayerTilerChromium::Tile::texture):5803 * platform/graphics/chromium/ManagedTexture.cpp: Renamed from Source/WebCore/platform/graphics/chromium/LayerTexture.cpp.5804 (WebCore::ManagedTexture::ManagedTexture):5805 (WebCore::ManagedTexture::~ManagedTexture):5806 (WebCore::ManagedTexture::isValid):5807 (WebCore::ManagedTexture::reserve):5808 (WebCore::ManagedTexture::unreserve):5809 (WebCore::ManagedTexture::bindTexture):5810 (WebCore::ManagedTexture::framebufferTexture2D):5811 * platform/graphics/chromium/ManagedTexture.h: Renamed from Source/WebCore/platform/graphics/chromium/LayerTexture.h.5812 (WebCore::ManagedTexture::create):5813 (WebCore::ManagedTexture::format):5814 (WebCore::ManagedTexture::isReserved):5815 * platform/graphics/chromium/RenderSurfaceChromium.h:5816 * platform/graphics/chromium/TextureManager.cpp:5817 (WebCore::TextureManager::TextureManager):5818 (WebCore::TextureManager::deleteEvictedTextures):5819 (WebCore::TextureManager::removeTexture):5820 (WebCore::TextureManager::allocateTexture):5821 (WebCore::TextureManager::requestTexture):5822 * platform/graphics/chromium/TextureManager.h:5823 (WebCore::TextureManager::create):5824 (WebCore::TextureManager::setAssociatedContextDebugOnly):5825 (WebCore::TextureManager::associatedContextDebugOnly):5826 * platform/graphics/chromium/TiledLayerChromium.h:5827 * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:5828 (WebCore::CCHeadsUpDisplay::draw):5829 * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:5830 * platform/graphics/chromium/cc/CCRenderSurface.cpp:5831 (WebCore::CCRenderSurface::prepareContentsTexture):5832 (WebCore::CCRenderSurface::drawSurface):5833 * platform/graphics/chromium/cc/CCRenderSurface.h:5834 (WebCore::CCRenderSurface::contentsTexture):5835 * platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:5836 (WebCore::CCTiledLayerImpl::bindContentsTexture):5837 5838 2011-08-11 David Kilzer <ddkilzer@apple.com>5839 5840 <http://webkit.org/b/66113> [CFNetwork] willCacheResponse() leaks CFCachedURLResponseRef if delegate changes CacheStoragePolicy5841 5842 Reviewed by Joseph Pecoraro.5843 5844 This first appeared in ToT WebKit r23462 (Windows merge).5845 5846 * platform/network/cf/ResourceHandleCFNet.cpp:5847 (WebCore::willCacheResponse): Only retain cachedResponse if we5848 are returning the same object passed into the method, otherwise5849 we end up double-retaining the new object created.5850 5851 2011-08-05 Nat Duca <nduca@chromium.org>5852 5853 [chromium] Make WebViewImpl point at CCLayerTreeHost and related separation5854 https://bugs.webkit.org/show_bug.cgi?id=657915855 5856 With this patch, LayerRendererChromium becomes increasingly responsible5857 for rendering, while render scheduling and tree hosting moves into the5858 CCLayerTreeHost.5859 5860 Reviewed by James Robinson.5861 5862 * platform/graphics/chromium/ContentLayerChromium.cpp:5863 (WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded):5864 * platform/graphics/chromium/LayerChromium.h:5865 * platform/graphics/chromium/LayerRendererChromium.cpp:5866 (WebCore::LayerRendererChromium::create):5867 (WebCore::LayerRendererChromium::LayerRendererChromium):5868 (WebCore::LayerRendererChromium::initialize):5869 (WebCore::LayerRendererChromium::releaseTextures):5870 (WebCore::LayerRendererChromium::updateRootLayerContents):5871 (WebCore::LayerRendererChromium::drawRootLayer):5872 (WebCore::LayerRendererChromium::invalidateRootLayerRect):5873 (WebCore::LayerRendererChromium::rootLayerChanged):5874 (WebCore::LayerRendererChromium::viewportChanged):5875 (WebCore::LayerRendererChromium::updateLayers):5876 (WebCore::LayerRendererChromium::drawLayers):5877 (WebCore::LayerRendererChromium::drawLayersInternal):5878 (WebCore::LayerRendererChromium::getFramebufferPixels):5879 (WebCore::LayerRendererChromium::getOffscreenLayerTexture):5880 (WebCore::LayerRendererChromium::copyOffscreenTextureToDisplay):5881 (WebCore::LayerRendererChromium::useRenderSurface):5882 (WebCore::LayerRendererChromium::setScissorToRect):5883 (WebCore::LayerRendererChromium::layerTreeAsText):5884 (WebCore::LayerRendererChromium::dumpRenderSurfaces):5885 * platform/graphics/chromium/LayerRendererChromium.h:5886 (WebCore::LayerRendererChromium::settings):5887 (WebCore::LayerRendererChromium::owner):5888 (WebCore::LayerRendererChromium::rootLayer):5889 (WebCore::LayerRendererChromium::skiaContext):5890 * platform/graphics/chromium/WebGLLayerChromium.cpp:5891 (WebCore::WebGLLayerChromium::setTextureUpdated):5892 * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:5893 (WebCore::CCHeadsUpDisplay::draw):5894 (WebCore::CCHeadsUpDisplay::enabled):5895 * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:5896 * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:5897 (WebCore::CCLayerTreeHost::create):5898 (WebCore::CCLayerTreeHost::CCLayerTreeHost):5899 (WebCore::CCLayerTreeHost::initialize):5900 (WebCore::CCLayerTreeHost::animateAndLayout):5901 (WebCore::CCLayerTreeHost::createLayerTreeHostCommitter):5902 (WebCore::CCLayerTreeHost::createLayerTreeHostImpl):5903 (WebCore::CCLayerTreeHost::context):5904 (WebCore::CCLayerTreeHost::compositeAndReadback):5905 (WebCore::CCLayerTreeHost::createRootLayerPainter):5906 (WebCore::CCLayerTreeHost::finishAllRendering):5907 (WebCore::CCLayerTreeHost::invalidateRootLayerRect):5908 (WebCore::CCLayerTreeHost::setNeedsCommitAndRedraw):5909 (WebCore::CCLayerTreeHost::setNeedsRedraw):5910 (WebCore::CCLayerTreeHost::setRootLayer):5911 (WebCore::CCLayerTreeHost::setViewport):5912 (WebCore::CCLayerTreeHost::setVisible):5913 (WebCore::CCLayerTreeHost::doComposite):5914 (WebCore::CCLayerTreeHost::composite):5915 (WebCore::CCLayerTreeHost::reallocateRenderer):5916 * platform/graphics/chromium/cc/CCLayerTreeHost.h:5917 (WebCore::CCLayerTreeHost::animating):5918 (WebCore::CCLayerTreeHost::setAnimating):5919 (WebCore::CCLayerTreeHost::rootLayer):5920 (WebCore::CCLayerTreeHost::settings):5921 (WebCore::CCLayerTreeHost::viewportContentRect):5922 (WebCore::CCLayerTreeHost::viewportScrollPosition):5923 (WebCore::CCLayerTreeHost::viewportVisibleRect):5924 * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:5925 (WebCore::CCLayerTreeHostImpl::create):5926 (WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):5927 (WebCore::CCLayerTreeHostImpl::drawLayers):5928 (WebCore::CCLayerTreeHostImpl::drawLayersOnMainThread):5929 * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:5930 * platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp:5931 (WebCore::CCLayerTreeHostImplProxy::initImplOnCCThread):5932 5933 2011-08-11 Jeff Miller <jeffm@apple.com>5934 5935 WebCore::AVFWrapper fails to remove observer for kCACFContextNeedsFlushNotification5936 https://bugs.webkit.org/show_bug.cgi?id=661165937 5938 We need to pass 0 as the object parameter to CFNotificationCenterRemoveObserver() when removing5939 kCACFContextNeedsFlushNotification to match what we do when we registered for the same5940 notification with CFNotificationCenterAddObserver().5941 5942 Reviewed by John Sullivan.5943 5944 No new tests, uses existing media tests.5945 5946 * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationCF.cpp:5947 (WebCore::AVFWrapper::disconnectAndDeleteAVFWrapper): Pass 0 as the object parameter to CFNotificationCenterRemoveObserver().5948 (WebCore::AVFWrapper::notificationCallback): Remove obsolete FIXME comment.5949 5950 2011-08-11 Ryosuke Niwa <rniwa@webkit.org>5951 5952 Share code between isStyleSpanOrSpanWithOnlyStyleAttribute, isUnstyledStyleSpan,5953 isSpanWithoutAttributesOrUnstyleStyleSpan and replaceWithSpanOrRemoveIfWithoutAttributes5954 https://bugs.webkit.org/show_bug.cgi?id=660915955 5956 Reviewed by Tony Chang.5957 5958 Extracted common code as hasNoAttributeOrOnlyStyleAttribute. The only behavioral difference is that5959 replaceWithSpanOrRemoveIfWithoutAttributes will now remove elements with class="Apple-style-span",5960 for which I'm adding a test.5961 5962 Test: editing/style/remove-styled-element-with-style-span.html5963 5964 * editing/ApplyStyleCommand.cpp:5965 (WebCore::hasNoAttributeOrOnlyStyleAttribute):5966 (WebCore::isStyleSpanOrSpanWithOnlyStyleAttribute):5967 (WebCore::isUnstyledStyleSpan):5968 (WebCore::isSpanWithoutAttributesOrUnstyleStyleSpan):5969 (WebCore::ApplyStyleCommand::replaceWithSpanOrRemoveIfWithoutAttributes):5970 5971 2011-08-11 Tom Zakrajsek <tomz@codeaurora.org>5972 5973 Add HTMLUnknownElement interface as defined in5974 http://www.w3.org/TR/html5/elements.html#elements-in-the-dom.5975 https://bugs.webkit.org/show_bug.cgi?id=418415976 5977 Reviewed by Adam Barth.5978 5979 Test: fast/html/unknown-tag.html5980 5981 * CMakeLists.txt:5982 * CodeGenerators.pri:5983 * DerivedSources.cpp:5984 * DerivedSources.make:5985 * GNUmakefile.list.am:5986 * WebCore.gypi:5987 * WebCore.vcproj/WebCore.vcproj:5988 * WebCore.xcodeproj/project.pbxproj:5989 * bindings/scripts/CodeGeneratorV8.pm:5990 (IsDOMNodeType):5991 * dom/make_names.pl:5992 (defaultParametersHash):5993 (buildConstructorMap):5994 (printJSElementIncludes):5995 (printElementIncludes):5996 (printWrapperFunctions):5997 (printWrapperFactoryCppFile):5998 * html/HTMLTagNames.in:5999 * html/HTMLUnknownElement.h: Added.6000 (WebCore::HTMLUnknownElement::create):6001 (WebCore::HTMLUnknownElement::HTMLUnknownElement):6002 * html/HTMLUnknownElement.idl: Added.6003 * mathml/mathtags.in:6004 * page/DOMWindow.idl:6005 * svg/svgtags.in:6006 6007 2011-08-11 Levi Weintraub <leviw@chromium.org>6008 6009 Remove dead code: borderInnerRect6010 https://bugs.webkit.org/show_bug.cgi?id=660876011 6012 Reviewed by Adam Barth.6013 6014 Removing an old and currently unused function: RenderObject::borderInnerRect.6015 6016 No new tests since I'm just pruning dead code.6017 6018 * rendering/RenderObject.cpp:6019 * rendering/RenderObject.h:6020 6021 2011-08-11 Simon Fraser <simon.fraser@apple.com>6022 6023 Avoid adding the visible wash layer twice6024 https://bugs.webkit.org/show_bug.cgi?id=660986025 6026 Reviewed by Chris Marrin.6027 6028 Fix two issues; only create a m_visibleTileWashLayer if we don't have one6029 already, and avoid adding multiple m_visibleTileWashLayers to the sublayers6030 array when flipping between tiled and non-tiled.6031 6032 * platform/graphics/ca/GraphicsLayerCA.cpp:6033 (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):6034 6035 2011-08-11 Benjamin Poulain <benjamin@webkit.org>6036 6037 The PageSerializer should always use absolute URL6038 https://bugs.webkit.org/show_bug.cgi?id=660066039 6040 Reviewed by Adam Barth.6041 6042 Page serializer resolves every URL for storing the resources.6043 The MarkupAccumulator used there should use the same rules in order to6044 create a valid file.6045 6046 No new tests because the test infrastructure for this6047 does not exist with layout tests and the Chromium unit test for6048 the serializer are disabled.6049 6050 * page/PageSerializer.cpp:6051 (WebCore::SerializerMarkupAccumulator::SerializerMarkupAccumulator):6052 6053 2011-08-01 Adrienne Walker <enne@google.com>6054 6055 Enable fast path scrolling for composited iframes6056 https://bugs.webkit.org/show_bug.cgi?id=650566057 6058 Reviewed by James Robinson.6059 6060 iframes with composited layers for content should be able to do fast6061 path scrolling because they draw into their own backing. To enable6062 this, useSlowRepaints is modified to return true only for the cases6063 that apply to composited layers. The fast path scrolling function is6064 modified to send the invalidation to the backing itself rather than to6065 the window.6066 6067 Renamed a number of "slow repaint" functions to be the more accurate6068 "cannot blit to window" as it will not always force slow path6069 scrolling.6070 6071 * page/FrameView.cpp:6072 (WebCore::FrameView::reset):6073 (WebCore::FrameView::useSlowRepaints):6074 (WebCore::FrameView::useSlowRepaintsIfNotOverlapped):6075 (WebCore::FrameView::contentsInCompositedLayer):6076 (WebCore::FrameView::setCannotBlitToWindow):6077 (WebCore::FrameView::scrollContentsFastPath):6078 (WebCore::FrameView::scrollContentsSlowPath):6079 * page/FrameView.h:6080 * rendering/RenderLayer.cpp:6081 (WebCore::RenderLayer::cannotBlitToWindow):6082 * rendering/RenderLayer.h:6083 * rendering/RenderView.cpp:6084 (WebCore::RenderView::paintBoxDecorations):6085 6086 2011-08-10 Adrienne Walker <enne@google.com>6087 6088 Support creating compositing layers for scrollable frames and iframes6089 https://bugs.webkit.org/show_bug.cgi?id=552576090 6091 Reviewed by James Robinson.6092 6093 When force compositing mode is turned on, iframes with overflow will6094 become composited (in order to enable faster scrolling).6095 6096 This patch was originally by Daniel Sievers <sievers@chromium.org>.6097 6098 Tests: platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer.html6099 platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer.html6100 platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing.html6101 platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer.html6102 platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing.html6103 6104 * rendering/RenderLayerCompositor.cpp:6105 (WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):6106 (WebCore::RenderLayerCompositor::requiresCompositingForScrollableFrame):6107 * rendering/RenderLayerCompositor.h:6108 6109 2011-08-11 Yong Li <yoli@rim.com>6110 6111 https://bugs.webkit.org/show_bug.cgi?id=659446112 Replace QuotesData::operator==() with QuotesData::equal(const QuotesData*6113 , const QuotesData*) because QuotesData::operator==() were using non-standard6114 C++ code that is not supported by all compilers.6115 6116 Reviewed by Alexey Proskuryakov.6117 6118 No new tests because some existing test cases can show the issue,6119 for example, fast/css/content/content-quotes-01.html.6120 6121 * rendering/RenderQuote.cpp:6122 (WebCore::RenderQuote::styleDidChange):6123 * rendering/style/QuotesData.cpp:6124 (WebCore::QuotesData::equal):6125 * rendering/style/QuotesData.h:6126 * rendering/style/RenderStyle.cpp:6127 (WebCore::RenderStyle::setQuotes):6128 * rendering/style/StyleRareInheritedData.cpp:6129 (WebCore::StyleRareInheritedData::operator==):6130 6131 2011-08-11 David Hyatt <hyatt@apple.com>6132 6133 https://bugs.webkit.org/show_bug.cgi?id=660756134 6135 Turn on regions and exclusions by default. Fix one stray ifdef that I missed.6136 6137 Reviewed by James Robinson.6138 6139 * css/CSSComputedStyleDeclaration.cpp:6140 (WebCore::contentToCSSValue):6141 6142 2011-08-11 David Reveman <reveman@chromium.org>6143 6144 [Chromium] Temporarily disable layer anti-aliasing on ChromeOS.6145 https://bugs.webkit.org/show_bug.cgi?id=659226146 6147 Reviewed by James Robinson.6148 6149 No new tests.6150 6151 * platform/graphics/chromium/LayerTilerChromium.cpp:6152 (WebCore::LayerTilerChromium::draw):6153 6154 2011-08-11 Benjamin Poulain <benjamin@webkit.org>6155 6156 [Qt] PageSerializer is specific to MHTML, we should not compile it6157 https://bugs.webkit.org/show_bug.cgi?id=660546158 6159 Reviewed by Noam Rosenthal.6160 6161 PageSerializer is specific to MHTML. Do not build PageSerializer unless MHTML is enabled.6162 6163 * WebCore.pro:6164 6165 2011-08-11 Andrey Kosyakov <caseq@chromium.org>6166 6167 Web Inspector: [refactoring] make tabbed pane a view6168 https://bugs.webkit.org/show_bug.cgi?id=660606169 6170 Reviewed by Pavel Feldman.6171 6172 * inspector/front-end/NetworkItemView.js:6173 (WebInspector.NetworkItemView):6174 (WebInspector.NetworkItemView.prototype.show):6175 (WebInspector.NetworkItemView.prototype._selectTab.get if):6176 (WebInspector.NetworkItemView.prototype._selectTab):6177 * inspector/front-end/TabbedPane.js:6178 (WebInspector.TabbedPane):6179 * inspector/front-end/inspector.html:6180 6181 2011-08-11 Andrey Kosyakov <caseq@chromium.org>6182 6183 Web Inspector: source frame popover simetimes pops up after user switches from Scripts panel6184 https://bugs.webkit.org/show_bug.cgi?id=660576185 6186 Reviewed by Pavel Feldman.6187 6188 * inspector/front-end/SourceFrame.js: remove popover timer when removing popover.6189 (WebInspector.SourceFrame.prototype._mouseDown):6190 (WebInspector.SourceFrame.prototype._hidePopup):6191 6192 2011-08-11 Vsevolod Vlasov <vsevik@chromium.org>6193 6194 Web Inspector: Scripts panel: display the current search match index in the toolbar.6195 https://bugs.webkit.org/show_bug.cgi?id=660486196 6197 Reviewed by Pavel Feldman.6198 6199 * English.lproj/localizedStrings.js:6200 * inspector/front-end/ScriptsPanel.js:6201 (WebInspector.ScriptsPanel.prototype.performSearch.finishedCallback):6202 (WebInspector.ScriptsPanel.prototype.performSearch):6203 (WebInspector.ScriptsPanel.prototype.jumpToNextSearchResult):6204 (WebInspector.ScriptsPanel.prototype.jumpToPreviousSearchResult):6205 * inspector/front-end/SearchController.js:6206 (WebInspector.SearchController.prototype.updateSearchMatchesCount):6207 (WebInspector.SearchController.prototype.updateCurrentMatchIndex):6208 (WebInspector.SearchController.prototype.activePanelChanged.performPanelSearch):6209 (WebInspector.SearchController.prototype.activePanelChanged):6210 (WebInspector.SearchController.prototype._updateSearchMatchesCountAndCurrentMatchIndex):6211 (WebInspector.SearchController.prototype._performSearch):6212 * inspector/front-end/SourceFrame.js:6213 (WebInspector.SourceFrame.prototype.get currentSearchResultIndex):6214 6215 2011-08-11 Xan Lopez <xlopez@igalia.com>6216 6217 [GTK] Add another missing file to GNUmakefile6218 6219 Reviewed by Gustavo Noronha.6220 6221 * GNUmakefile.list.am:6222 6223 2011-08-11 Xan Lopez <xlopez@igalia.com>6224 6225 [GTK] Add missing files to GNUMakefile6226 6227 Reviewed by Gustavo Noronha.6228 6229 * GNUmakefile.am:6230 * GNUmakefile.list.am:6231 6232 2011-08-11 Yuta Kitamura <yutak@chromium.org>6233 6234 WebSocket: Use PassRefPtr<> in function arguments in WorkerThreadableWebSocketChannel.cpp6235 https://bugs.webkit.org/show_bug.cgi?id=660476236 6237 Reviewed by Kent Tamura.6238 6239 It's safe to use PassRefPtr<> in these functions because:6240 - CrossThreadTask knows how to pass a RefPtr<> across threads, and6241 - Call sites do not pass the pointers to anywhere else.6242 6243 No change in functionality, thus no new tests.6244 6245 * websockets/WorkerThreadableWebSocketChannel.cpp:6246 (WebCore::workerContextDidSend):6247 (WebCore::workerContextDidGetBufferedAmount):6248 (WebCore::workerContextDidConnect):6249 (WebCore::workerContextDidReceiveMessage):6250 (WebCore::workerContextDidStartClosingHandshake):6251 (WebCore::workerContextDidClose):6252 6253 2011-08-11 Pavel Feldman <pfeldman@google.com>6254 6255 Web Inspector: [Mac] search as you type does not work with the new indent in the script selector.6256 https://bugs.webkit.org/show_bug.cgi?id=660396257 6258 Reviewed by Yury Semikhatsky.6259 6260 * inspector/front-end/ScriptsPanel.js:6261 (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelect):6262 * inspector/front-end/inspector.css:6263 (select.status-bar-item):6264 6265 2011-08-11 Alexis Menard <alexis.menard@openbossa.org>6266 6267 Unreviewed build fix for Qt.6268 6269 Make sure we build when Qt is namespaced.6270 6271 * platform/graphics/gstreamer/PlatformVideoWindowPrivate.h:6272 6273 2011-08-11 Pavel Podivilov <podivilov@chromium.org>6274 6275 Web Inspector: use source-file-replaced instead of source-file-changed event.6276 https://bugs.webkit.org/show_bug.cgi?id=655516277 6278 Reviewed by Pavel Feldman.6279 6280 Test: inspector/debugger/source-frame-count.html6281 6282 * inspector/front-end/DebuggerPresentationModel.js:6283 (WebInspector.DebuggerPresentationModel.prototype._addScript):6284 (WebInspector.DebuggerPresentationModel.prototype._uiSourceCodeReplaced):6285 * inspector/front-end/ScriptsPanel.js:6286 (WebInspector.ScriptsPanel.prototype._removeSourceFrame):6287 (WebInspector.ScriptsPanel.prototype._sourceFileReplaced):6288 * inspector/front-end/SourceFile.js:6289 (WebInspector.RawSourceCode):6290 (WebInspector.RawSourceCode.prototype.get uiSourceCode):6291 (WebInspector.RawSourceCode.prototype.reload):6292 * inspector/front-end/inspector.js:6293 (WebInspector._createPanels):6294 6295 2011-08-11 Vsevolod Vlasov <vsevik@chromium.org>6296 6297 Web Inspector: [REGRESSION] Resources panel search fails when search result is found in a resource used in several frames.6298 https://bugs.webkit.org/show_bug.cgi?id=660076299 6300 Reviewed by Pavel Feldman.6301 6302 * inspector/front-end/ResourcesPanel.js:6303 (WebInspector.ResourcesPanel.prototype.performSearch.callback):6304 (WebInspector.ResourcesPanel.prototype.performSearch):6305 (WebInspector.FrameTreeElement.prototype.resourceByURL):6306 6307 2011-08-11 Andras Becsi <abecsi@webkit.org>6308 6309 [GTK] Fix the build after r92792.6310 6311 Rubber-stamped by Csaba Osztrogonác.6312 6313 No new tests needed.6314 6315 * GNUmakefile.list.am: add missing6316 RenderFlowThread.{cpp|h}6317 RenderRegion.{cpp|h}6318 6319 2011-08-11 Renata Hodovan <reni@webkit.org>6320 6321 [Qt] Fix WebGL on Windows after r928056322 https://bugs.webkit.org/show_bug.cgi?id=660426323 6324 WEBGL is temporarly disabled, because it broked the bots.6325 6326 * features.pri:6327 6328 2011-08-11 Pavel Feldman <pfeldman@google.com>6329 6330 Web Inspector: do not evaluate watch expressions on load.6331 https://bugs.webkit.org/show_bug.cgi?id=660026332 6333 Reviewed by Yury Semikhatsky.6334 6335 * inspector/front-end/ScriptsPanel.js:6336 (WebInspector.ScriptsPanel.prototype.show):6337 (WebInspector.ScriptsPanel.prototype.hide):6338 (WebInspector.ScriptsPanel.prototype.reset):6339 * inspector/front-end/WatchExpressionsSidebarPane.js:6340 (WebInspector.WatchExpressionsSidebarPane):6341 (WebInspector.WatchExpressionsSidebarPane.prototype.hide):6342 (WebInspector.WatchExpressionsSidebarPane.prototype.reset):6343 (WebInspector.WatchExpressionsSidebarPane.prototype.refreshExpressions):6344 (WebInspector.WatchExpressionsSidebarPane.prototype._refreshExpressionsIfNeeded):6345 (WebInspector.WatchExpressionsSidebarPane.prototype._refreshButtonClicked):6346 6347 2011-08-10 Ryosuke Niwa <rniwa@webkit.org>6348 6349 Copying can result in span around block elements on the clipboard6350 https://bugs.webkit.org/show_bug.cgi?id=345646351 6352 Reviewed by Tony Chang.6353 6354 Completely overhauled the way WebKit preserves style in copy and paste. Instead of wrapping the entire6355 serialized contents by a Apple style span, WebKit now adds inline style to the top level elements,6356 wrap top level text nodes by a style span.6357 6358 * editing/EditingStyle.cpp:6359 (WebCore::EditingStyle::collapseTextDecorationProperties): Remove text-decoration property when the value6360 of -webkit-text-decorations-in-effect is none.6361 (WebCore::EditingStyle::removeStyleFromRulesAndContext): Since display: inline and float: none are now6362 added on copy, remove these properties on paste.6363 (WebCore::EditingStyle::removePropertiesInElementDefaultStyle): Takes Element* instead of StyledElement*.6364 (WebCore::EditingStyle::forceInline): Added.6365 (WebCore::getPropertiesNotIn): Remove properties only when the base style has them.6366 * editing/EditingStyle.h:6367 * editing/markup.cpp:6368 (WebCore::StyledMarkupAccumulator::shouldApplyWrappingStyle): Added.6369 (WebCore::StyledMarkupAccumulator::StyledMarkupAccumulator): Takes highestNodeToBeSerialized.6370 (WebCore::StyledMarkupAccumulator::wrapWithStyleNode): Calls appendStyleNodeOpenTag and styleNodeCloseTag.6371 (WebCore::StyledMarkupAccumulator::appendStyleNodeOpenTag): Extracted from wrapWithStyleNode.6372 (WebCore::StyledMarkupAccumulator::styleNodeCloseTag): Ditto.6373 (WebCore::StyledMarkupAccumulator::appendText): Wraps text node with a style span if needed.6374 Set display: inline and float: none so that it won't be converted to a block on paste side.6375 (WebCore::StyledMarkupAccumulator::appendElement): Add wrapping style if appropriate; Remove any properties6376 that are overridden by default style and any style that may conflict with the computed style of node to6377 avoid modifying the appearance of the serialized nodes.6378 (WebCore::StyledMarkupAccumulator::serializeNodes): Compute wrapping style; copies of this style are6379 modified as needed when serializing top-level elements or text nodes. We call traverseNodesForSerialization6380 with NodeTraversalMode set to DoNotEmitString first to compute the highest node to be serialized. The second6381 call to the function actually serialize the nodes.6382 (WebCore::StyledMarkupAccumulator::traverseNodesForSerialization): Extracted from serializeNodes.6383 Outputs string only if NodeTraversalMode is set to EmitString.6384 (WebCore::createMarkup): No longer adds wrapping spans.6385 6386 2011-08-10 Adam Barth <abarth@webkit.org>6387 6388 Add tests of optional arguments for Geolocation6389 https://bugs.webkit.org/show_bug.cgi?id=658106390 6391 Reviewed by Sam Weinig.6392 6393 Geolocation's treatment of not-enough-arguments almost matches the6394 spec. getCurrentPosition and watchPosition work properly, but, because6395 they are custom, we should use the prettier form of the [Optional]6396 attribute.6397 6398 Before this series of patches, clearWatch argument was optional, but6399 that doesn't match the spec or other browsers. Calling this function6400 with zero arguments is pretty non-sensical, so there shouldn't be much6401 compat risk to tightening up our behavior here. Matching other6402 browsers and the spec seems like the bigger win. If we run into compat6403 problems, we can re-evaluate this decision.6404 6405 Test: fast/dom/Geolocation/not-enough-arguments.html6406 6407 * page/Geolocation.idl:6408 6409 2011-08-10 Tim Horton <timothy_horton@apple.com>6410 6411 SVGAElement check for internal non-view anchors is inside ENABLE(SVG_ANIMATION)6412 https://bugs.webkit.org/show_bug.cgi?id=660266413 6414 Reviewed by Rob Buis.6415 6416 Move only the SMIL-related code inside the ENABLE(SVG_ANIMATION) block.6417 6418 No new tests, as it depends on the enabled features.6419 6420 * svg/SVGAElement.cpp:6421 (WebCore::SVGAElement::defaultEventHandler):6422 6423 2011-08-10 Tim Horton <timothy_horton@apple.com>6424 6425 Crash when clicking an SVG <a> link to the local document6426 https://bugs.webkit.org/show_bug.cgi?id=660196427 <rdar://problem/9933311>6428 6429 Reviewed by Rob Buis.6430 6431 Check if the target element of an internal link is valid before6432 making use of it.6433 6434 Test: svg/custom/click-internal-anchor-with-use-crash.xhtml6435 6436 * svg/SVGAElement.cpp:6437 (WebCore::SVGAElement::defaultEventHandler):6438 6439 2011-08-10 No'am Rosenthal <noam.rosenthal@nokia.com>6440 6441 [Qt] Enable WebGL by default for QtWebKit6442 https://bugs.webkit.org/show_bug.cgi?id=659986443 6444 Reviewed by Benjamin Poulain.6445 6446 Make ENABLE_WEBGL true by default when Qt is configured with OpenGL.6447 6448 No new tests. Build change only.6449 6450 * features.pri:6451 6452 2011-08-10 Abhishek Arya <inferno@chromium.org>6453 6454 Check that we do not need layout before trying to dirty6455 m_originatingLine for our floats.6456 https://bugs.webkit.org/show_bug.cgi?id=659386457 6458 Reviewed by Dave Hyatt.6459 6460 Test: fast/block/float/float-originating-line-deleted-crash.html6461 6462 * rendering/RenderBlock.cpp:6463 (WebCore::RenderBlock::removeFloatingObject):6464 (WebCore::RenderBlock::clearFloats):6465 6466 2011-08-10 David Hyatt <hyatt@apple.com>6467 6468 Add missing regions/exclusions-related files to EFL.6469 6470 * CMakeLists.txt:6471 6472 2011-08-10 David Hyatt <hyatt@apple.com>6473 6474 Add missing regions/exclusions-related files to Chromium.6475 6476 * WebCore.gypi:6477 6478 2011-08-10 David Hyatt <hyatt@apple.com>6479 6480 Fix Qt build bustage. Add missing regions/exclusions-related files to their project.6481 6482 * WebCore.pro:6483 6484 2011-08-10 David Hyatt <hyatt@apple.com>6485 6486 https://bugs.webkit.org/show_bug.cgi?id=660046487 6488 Remove ifdefs for CSS Exclusions (since the feature doesn't exist any longer and has morphed into positioned6489 floats instead). Go ahead and yank the ifdefs for CSS Regions also and just turn them on.6490 6491 Reviewed by Adam Roben.6492 6493 * Configurations/FeatureDefines.xcconfig:6494 * css/CSSComputedStyleDeclaration.cpp:6495 (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):6496 * css/CSSParser.cpp:6497 (WebCore::CSSParser::parseValue):6498 (WebCore::CSSParser::parseContent):6499 (WebCore::CSSParser::parseWrapShape):6500 (WebCore::CSSParser::parseFromFlowContent):6501 * css/CSSParser.h:6502 * css/CSSPrimitiveValue.cpp:6503 (WebCore::CSSPrimitiveValue::init):6504 (WebCore::CSSPrimitiveValue::cleanup):6505 (WebCore::CSSPrimitiveValue::getStringValue):6506 (WebCore::CSSPrimitiveValue::cssText):6507 * css/CSSPrimitiveValue.h:6508 (WebCore::CSSPrimitiveValue::getShapeValue):6509 * css/CSSPrimitiveValueMappings.h:6510 (WebCore::CSSPrimitiveValue::operator RegionOverflow):6511 * css/CSSPropertyNames.in:6512 * css/CSSStyleSelector.cpp:6513 (WebCore::CSSStyleSelector::applyProperty):6514 * css/CSSValueKeywords.in:6515 * css/CSSWrapShapes.cpp:6516 * css/CSSWrapShapes.h:6517 * css/SVGCSSValueKeywords.in:6518 * dom/Node.cpp:6519 (WebCore::Node::diff):6520 * dom/NodeRenderingContext.cpp:6521 (WebCore::NodeRenderingContext::NodeRenderingContext):6522 (WebCore::NodeRenderingContext::setStyle):6523 (WebCore::NodeRenderingContext::nextRenderer):6524 (WebCore::NodeRenderingContext::previousRenderer):6525 (WebCore::NodeRenderingContext::parentRenderer):6526 (WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):6527 (WebCore::NodeRendererFactory::createRendererIfNeeded):6528 * dom/NodeRenderingContext.h:6529 * rendering/RenderFlowThread.cpp:6530 * rendering/RenderFlowThread.h:6531 * rendering/RenderLayer.cpp:6532 (WebCore::RenderLayer::collectLayers):6533 * rendering/RenderObject.cpp:6534 (WebCore::RenderObject::createObject):6535 * rendering/RenderObject.h:6536 (WebCore::RenderObject::isRenderRegion):6537 (WebCore::RenderObject::isRenderFlowThread):6538 * rendering/RenderRegion.cpp:6539 * rendering/RenderRegion.h:6540 * rendering/RenderTreeAsText.cpp:6541 (WebCore::writeLayers):6542 * rendering/RenderView.cpp:6543 (WebCore::RenderView::renderFlowThreadWithName):6544 * rendering/RenderView.h:6545 * rendering/style/RenderStyle.cpp:6546 (WebCore::RenderStyle::diff):6547 * rendering/style/RenderStyle.h:6548 (WebCore::InheritedFlags::regionOverflow):6549 (WebCore::InheritedFlags::setRegionOverflow):6550 (WebCore::InheritedFlags::initialWrapShape):6551 (WebCore::InheritedFlags::initialRegionOverflow):6552 * rendering/style/RenderStyleConstants.h:6553 * rendering/style/StyleRareNonInheritedData.cpp:6554 (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):6555 (WebCore::StyleRareNonInheritedData::operator==):6556 * rendering/style/StyleRareNonInheritedData.h:6557 6558 2011-08-10 Abhishek Arya <inferno@chromium.org>6559 6560 Don't create html renderer for SVG <glyphRef>6561 https://bugs.webkit.org/show_bug.cgi?id=660006562 6563 Reviewed by David Hyatt.6564 6565 Test: svg/text/glyphref-renderer-create-crash.html6566 6567 * svg/SVGGlyphRefElement.h:6568 6569 2011-08-10 Scott Graham <scottmg@google.com>6570 6571 OpenTypeSanitizer in chromium gyp files is linked twice6572 https://bugs.webkit.org/show_bug.cgi?id=659276573 6574 Reviewed by Adam Barth.6575 6576 No new tests, should just build and link properly on all platforms.6577 6578 * WebCore.gyp/WebCore.gyp:6579 6580 2011-08-10 Oliver Hunt <oliver@apple.com>6581 6582 Make GC checks more aggressive in release builds6583 https://bugs.webkit.org/show_bug.cgi?id=660016584 6585 Reviewed by Gavin Barraclough.6586 6587 Fix GC bugs found while testing increased validation logic6588 6589 * bindings/js/JSDOMWindowShell.cpp:6590 (WebCore::JSDOMWindowShell::JSDOMWindowShell):6591 * bindings/js/JSDOMWindowShell.h:6592 * bindings/js/ScriptController.cpp:6593 (WebCore::ScriptController::createWindowShell):6594 * bridge/objc/ObjCRuntimeObject.h:6595 (JSC::Bindings::ObjCRuntimeObject::create):6596 * bridge/objc/ObjCRuntimeObject.mm:6597 (JSC::Bindings::ObjCRuntimeObject::ObjCRuntimeObject):6598 * bridge/objc/objc_instance.mm:6599 6600 2011-08-10 Ben Wells <benwells@chromium.org>6601 6602 [skia] Move calls to makeGrContextCurrent into clipPathAntiAliased from callers6603 https://bugs.webkit.org/show_bug.cgi?id=657336604 6605 This protects against callers of clipPathAntiAliased forgetting to call makeGrContextCurrent.6606 6607 Reviewed by James Robinson.6608 6609 No change in functionality, no new tests.6610 6611 * platform/graphics/skia/GraphicsContextSkia.cpp:6612 (WebCore::GraphicsContext::addInnerRoundedRectClip):6613 (WebCore::GraphicsContext::clip):6614 * platform/graphics/skia/PlatformContextSkia.cpp:6615 (WebCore::PlatformContextSkia::clipPathAntiAliased):6616 6617 2011-08-10 Benjamin Poulain <ikipou@gmail.com>6618 6619 MarkupAccumulator: make resolution of URLs implicit to appendQuotedURLAttributeValue()6620 https://bugs.webkit.org/show_bug.cgi?id=659906621 6622 Reviewed by Ryosuke Niwa.6623 6624 Instead of resolving the URLs in the call site of appendQuotedURLAttributeValue(),6625 the URL is now resolved if necessary in appendQuotedURLAttributeValue().6626 6627 * editing/MarkupAccumulator.cpp:6628 (WebCore::MarkupAccumulator::appendQuotedURLAttributeValue):6629 (WebCore::MarkupAccumulator::appendAttribute):6630 * editing/MarkupAccumulator.h:6631 6632 2011-08-10 Kenichi Ishibashi <bashi@chromium.org>6633 6634 [Chromium] Implement text shaping with font-feature-settings on Linux6635 https://bugs.webkit.org/show_bug.cgi?id=659036636 6637 - Modifies Font::codePath() to return Complex when there is font feature settings CSS property.6638 - Implements OpenType advanced typography feature using Harfbuzz on Chromium Linux port.6639 6640 Reviewed by Adam Barth.6641 6642 Test: css3/font-feature-settings-rendering.html6643 6644 * platform/graphics/Font.cpp:6645 (WebCore::Font::codePath): Returns Complex when fontFeatureSettings exists.6646 * platform/graphics/chromium/ComplexTextControllerLinux.cpp:6647 (WebCore::setupFontFeatures): Added.6648 (WebCore::ComplexTextController::setupFontForScriptRun): Calls setupFontFeatures().6649 6650 2011-08-10 Tony Gentilcore <tonyg@chromium.org>6651 6652 [chromium] Notify MemoryCache of decoded data access6653 https://bugs.webkit.org/show_bug.cgi?id=658596654 6655 Reviewed by James Robinson.6656 6657 This causes us to call CachedImage::didDraw() which calls CachedResource::didAccessDecodedData()6658 which updates the LRU for decoded image data and potentially prunes the cache. This is already done6659 by almost all of the other ports.6660 6661 The decoded bitmaps obviously use quite a bit of memory, so pruning them when necessary is important.6662 In my tests, this saves several MB on many popular web pages.6663 6664 No new tests because no observable difference in functionality.6665 6666 * platform/graphics/skia/ImageSkia.cpp:6667 (WebCore::BitmapImage::draw):6668 (WebCore::BitmapImageSingleFrameSkia::draw):6669 6670 2011-08-10 Vsevolod Vlasov <vsevik@chromium.org>6671 6672 Web Inspector: Remove Network.initialContentSet from protocol, store workers content on backend.6673 https://bugs.webkit.org/show_bug.cgi?id=659296674 6675 Reviewed by Pavel Feldman.6676 6677 Tests: http/tests/inspector/network/network-shared-worker.html6678 http/tests/inspector/network/network-worker.html6679 6680 * inspector/Inspector.json:6681 * inspector/InspectorInstrumentation.cpp:6682 (WebCore::InspectorInstrumentation::didReceiveScriptResponseImpl):6683 * inspector/InspectorInstrumentation.h:6684 (WebCore::InspectorInstrumentation::didReceiveScriptResponse):6685 * inspector/InspectorResourceAgent.cpp:6686 (WebCore::InspectorResourceAgent::didReceiveResponse):6687 (WebCore::InspectorResourceAgent::setInitialScriptContent):6688 (WebCore::InspectorResourceAgent::didReceiveScriptResponse):6689 * inspector/InspectorResourceAgent.h:6690 * inspector/front-end/NetworkManager.js:6691 * inspector/front-end/Resource.js:6692 * workers/DefaultSharedWorkerRepository.cpp:6693 (WebCore::SharedWorkerScriptLoader::didReceiveResponse):6694 * workers/Worker.cpp:6695 (WebCore::Worker::didReceiveResponse):6696 * workers/Worker.h:6697 * workers/WorkerScriptLoader.cpp:6698 (WebCore::WorkerScriptLoader::didReceiveResponse):6699 * workers/WorkerScriptLoaderClient.h:6700 (WebCore::WorkerScriptLoaderClient::didReceiveResponse):6701 6702 2011-08-10 Vsevolod Vlasov <vsevik@chromium.org>6703 6704 Web Inspector: [Network] Filtering by stylesheet does not update the # reqs, filesizes.6705 https://bugs.webkit.org/show_bug.cgi?id=655156706 6707 Reviewed by Pavel Feldman.6708 6709 * English.lproj/localizedStrings.js:6710 * inspector/front-end/NetworkPanel.js:6711 (WebInspector.NetworkLogView.prototype._updateSummaryBar):6712 (WebInspector.NetworkLogView.prototype._updateFilter):6713 6714 2011-08-10 Vsevolod Vlasov <vsevik@chromium.org>6715 6716 Web Inspector: console messages markers are lost in Resources panel after page reload6717 https://bugs.webkit.org/show_bug.cgi?id=607016718 6719 Reviewed by Pavel Feldman.6720 6721 Test: http/tests/inspector/resource-tree/resource-tree-errors-reload.html6722 6723 * inspector/front-end/ResourceTreeModel.js:6724 (WebInspector.ResourceTreeModel):6725 (WebInspector.ResourceTreeModel.prototype._consoleMessageAdded):6726 (WebInspector.ResourceTreeModel.prototype._addPendingConsoleMessage):6727 (WebInspector.ResourceTreeModel.prototype._addPendingConsoleMessagesToResource):6728 (WebInspector.ResourceTreeModel.prototype._addConsoleMessageToResource):6729 (WebInspector.ResourceTreeModel.prototype._consoleCleared):6730 (WebInspector.ResourceTreeModel.prototype._bindResourceURL):6731 6732 2011-08-10 Lars Knudsen <lars.knudsen@nokia.com>6733 6734 Add device specific settings to support viewport computing6735 https://bugs.webkit.org/show_bug.cgi?id=659846736 6737 Reviewed by Kenneth Rohde Christiansen.6738 6739 Based on patch by Zalan Bujtas.6740 6741 Added settings for device size, dpi and layout fallback width6742 to support viewport computing.6743 6744 * page/Settings.cpp:6745 (WebCore::Settings::Settings):6746 * page/Settings.h:6747 (WebCore::Settings::setLayoutFallbackWidth):6748 (WebCore::Settings::layoutFallbackWidth):6749 (WebCore::Settings::setDeviceWidth):6750 (WebCore::Settings::deviceWidth):6751 (WebCore::Settings::setDeviceHeight):6752 (WebCore::Settings::deviceHeight):6753 (WebCore::Settings::setDeviceDPI):6754 (WebCore::Settings::deviceDPI):6755 6756 2011-08-10 Benjamin Poulain <benjamin@webkit.org>6757 6758 Unify the way we generate HTML for an image in the Clipboard6759 https://bugs.webkit.org/show_bug.cgi?id=580436760 6761 Reviewed by Ryosuke Niwa.6762 6763 Unify the way we generate the markup when dragging and image.6764 6765 Previously, the code was using the special function imageToMarkup() that was6766 spread from the Chromium port.6767 That function ignores some edge cases so this patch replace it by the6768 more generic MarkupAccumulator (which is also used by the other pasteboard6769 actions).6770 6771 The MarkupAccumulator was modified because following r61178, the local filepath6772 are treated differently (the enum was changed to make this behavior6773 explicit).6774 6775 Tests: fast/drag-and-drop/drag-and-drop-image-contenteditable.html6776 fast/drag-and-drop/drag-and-drop-inputimage-contenteditable.html6777 fast/drag-and-drop/drag-and-drop-objectimage-contenteditable.html6778 6779 * editing/MarkupAccumulator.cpp:6780 (WebCore::MarkupAccumulator::MarkupAccumulator):6781 (WebCore::MarkupAccumulator::resolveURLIfNeeded):6782 (WebCore::MarkupAccumulator::appendAttribute):6783 * editing/MarkupAccumulator.h:6784 * editing/markup.cpp:6785 * editing/markup.h:6786 * page/PageSerializer.cpp:6787 (WebCore::SerializerMarkupAccumulator::SerializerMarkupAccumulator):6788 * platform/chromium/ClipboardChromium.cpp:6789 (WebCore::ClipboardChromium::declareAndWriteDragImage):6790 (WebCore::ClipboardChromium::writeRange):6791 * platform/chromium/PasteboardChromium.cpp:6792 (WebCore::Pasteboard::writeSelection):6793 * platform/gtk/ClipboardGtk.cpp:6794 (WebCore::ClipboardGtk::declareAndWriteDragImage):6795 (WebCore::ClipboardGtk::writeRange):6796 * platform/gtk/DataObjectGtk.cpp:6797 (WebCore::DataObjectGtk::markup):6798 * platform/gtk/PasteboardGtk.cpp:6799 (WebCore::Pasteboard::writeSelection):6800 (WebCore::Pasteboard::writeImage):6801 * platform/haiku/PasteboardHaiku.cpp:6802 (WebCore::Pasteboard::writeSelection):6803 * platform/qt/ClipboardQt.cpp:6804 (WebCore::ClipboardQt::declareAndWriteDragImage):6805 (WebCore::ClipboardQt::writeRange):6806 * platform/qt/PasteboardQt.cpp:6807 (WebCore::Pasteboard::writeSelection):6808 * platform/win/ClipboardWin.cpp:6809 (WebCore::ClipboardWin::declareAndWriteDragImage):6810 6811 2011-08-10 Pavel Feldman <pfeldman@google.com>6812 6813 Web Inspector: auto-completion for string literals doesn't work6814 https://bugs.webkit.org/show_bug.cgi?id=657016815 6816 Reviewed by Yury Semikhatsky.6817 6818 * inspector/InjectedScript.cpp:6819 (WebCore::InjectedScript::evaluateOnCallFrame):6820 * inspector/InjectedScript.h:6821 * inspector/InjectedScriptSource.js:6822 (.):6823 ():6824 * inspector/Inspector.json:6825 * inspector/InspectorDebuggerAgent.cpp:6826 (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):6827 * inspector/InspectorDebuggerAgent.h:6828 * inspector/front-end/ConsoleView.js:6829 (WebInspector.ConsoleView.prototype._completions.evaluated.getCompletions):6830 (WebInspector.ConsoleView.prototype._completions.evaluated):6831 (WebInspector.ConsoleView.prototype._completions.receivedPropertyNamesFromEval):6832 (WebInspector.ConsoleView.prototype._completions.receivedPropertyNames):6833 (WebInspector.ConsoleView.prototype._completions):6834 (WebInspector.ConsoleView.prototype.evalInInspectedWindow):6835 * inspector/front-end/DebuggerPresentationModel.js:6836 (WebInspector.PresenationCallFrame.prototype.evaluate):6837 * inspector/front-end/RemoteObject.js:6838 (WebInspector.RemoteObject):6839 * inspector/front-end/ScriptsPanel.js:6840 (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):6841 (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.evaluateInSelectedCallFrame):6842 6843 2011-08-10 Pavel Feldman <pfeldman@google.com>6844 6845 Web Inspector: CSS editing file containing tabs leads to the whole file change in revision history.6846 https://bugs.webkit.org/show_bug.cgi?id=659596847 6848 Reviewed by Yury Semikhatsky.6849 6850 * inspector/front-end/SourceFrame.js:6851 (WebInspector.SourceFrame):6852 * inspector/front-end/TextEditorModel.js:6853 (WebInspector.TextEditorModel.prototype._innerSetText):6854 6855 2011-08-10 Pavel Feldman <pfeldman@chromium.org>6856 6857 Web Inspector: there should be a way to tell what properties are non-enumerable when expanding objects.6858 https://bugs.webkit.org/show_bug.cgi?id=655186859 6860 Reviewed by Yury Semikhatsky.6861 6862 * inspector/InjectedScript.cpp:6863 (WebCore::InjectedScript::getProperties):6864 * inspector/InjectedScript.h:6865 * inspector/InjectedScriptSource.js:6866 (.):6867 * inspector/Inspector.json:6868 * inspector/InspectorRuntimeAgent.cpp:6869 (WebCore::InspectorRuntimeAgent::getProperties):6870 * inspector/InspectorRuntimeAgent.h:6871 * inspector/front-end/ObjectPropertiesSection.js:6872 (WebInspector.ObjectPropertyTreeElement.prototype.ondblclick):6873 (WebInspector.ObjectPropertyTreeElement.prototype.update):6874 * inspector/front-end/RemoteObject.js:6875 (WebInspector.RemoteObject.prototype.getOwnProperties):6876 (WebInspector.RemoteObject.prototype.getAllProperties):6877 (WebInspector.RemoteObjectProperty):6878 * inspector/front-end/inspector.css:6879 (.section .properties .dimmed):6880 6881 1 2011-08-10 Alexander Pavlov <apavlov@chromium.org> 6882 2 -
branches/chromium/835/Source/WebCore/inspector/front-end/StylesSidebarPane.js
r92288 r93524 239 239 }, 240 240 241 _innerUpdate: function(refresh, editedSection )241 _innerUpdate: function(refresh, editedSection, userCallback) 242 242 { 243 243 var node = this.node; … … 246 246 this._computedStylePane.bodyElement.removeChildren(); 247 247 this.sections = {}; 248 if (userCallback) 249 userCallback(); 248 250 return; 249 251 } … … 253 255 if (this.node === node && styles) 254 256 this._rebuildUpdate(node, styles); 257 if (userCallback) 258 userCallback(); 255 259 } 256 260 … … 259 263 if (this.node === node && computedStyle) 260 264 this._refreshUpdate(node, computedStyle, editedSection); 265 if (userCallback) 266 userCallback(); 261 267 } 262 268 … … 1612 1618 }, 1613 1619 1614 _updateAll: function() 1615 { 1616 if (!this.treeOutline) 1617 return; 1618 if (this.treeOutline.section && this.treeOutline.section.pane) 1619 this.treeOutline.section.pane._innerUpdate(true, this.treeOutline.section); 1620 else if (this.treeOutline.section) 1621 this.treeOutline.section.update(true); 1622 else 1623 this.updateTitle(); // FIXME: this will not show new properties. But we don't hit this case yet. 1620 _updatePane: function(userCallback) 1621 { 1622 if (this.treeOutline && this.treeOutline.section && this.treeOutline.section.pane) 1623 this.treeOutline.section.pane._innerUpdate(true, this.treeOutline.section, userCallback); 1624 else { 1625 if (userCallback) 1626 userCallback(); 1627 } 1624 1628 }, 1625 1629 … … 1639 1643 this.treeOutline.section.pane.dispatchEventToListeners("style property toggled"); 1640 1644 1641 this._update All();1645 this._updatePane(); 1642 1646 } 1643 1647 … … 2081 2085 applyStyleText: function(styleText, updateInterface, majorChange, isRevert) 2082 2086 { 2087 function userOperationFinishedCallback(parentPane, updateInterface) 2088 { 2089 if (updateInterface) 2090 delete parentPane._userOperation; 2091 } 2092 2083 2093 // Leave a way to cancel editing after incremental changes. 2084 2094 if (!isRevert && !updateInterface && !this._hasBeenModifiedIncrementally()) { … … 2100 2110 2101 2111 var currentNode = this._parentPane.node; 2102 this._parentPane._userOperation = true; 2103 2104 function callback(originalPropertyText, newStyle) 2112 if (updateInterface) 2113 this._parentPane._userOperation = true; 2114 2115 function callback(userCallback, originalPropertyText, newStyle) 2105 2116 { 2106 delete this._parentPane._userOperation;2107 2117 if (!newStyle) { 2108 2118 if (updateInterface) { … … 2110 2120 this._revertStyleUponEditingCanceled(originalPropertyText); 2111 2121 } 2122 userCallback(); 2112 2123 return; 2113 2124 } … … 2120 2131 section.pane.dispatchEventToListeners("style edited"); 2121 2132 2122 if (updateInterface && currentNode === section.pane.node) 2123 this._updateAll(); 2133 if (updateInterface && currentNode === section.pane.node) { 2134 this._updatePane(userCallback); 2135 return; 2136 } 2137 2138 userCallback(); 2124 2139 } 2125 2140 … … 2128 2143 if (styleText.length && !/;\s*$/.test(styleText)) 2129 2144 styleText += ";"; 2130 this.property.setText(styleText, majorChange, callback.bind(this, this.originalPropertyText));2145 this.property.setText(styleText, majorChange, callback.bind(this, userOperationFinishedCallback.bind(null, this._parentPane, updateInterface), this.originalPropertyText)); 2131 2146 } 2132 2147 }
Note:
See TracChangeset
for help on using the changeset viewer.
