Changeset 94705 in webkit


Ignore:
Timestamp:
Sep 7, 2011, 1:13:34 PM (14 years ago)
Author:
commit-queue@webkit.org
Message:

Add test infrastructure to test rubber-banding overhang drawing along with layout tests for existing Chromium Mac overhang drawing in the non-gpu path.
​https://bugs.webkit.org/show_bug.cgi?id=67511

Patch by Alexei Svitkine <​asvitkine@chromium.org> on 2011-09-07
Reviewed by Dimitri Glazkov.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

Tests: platform/chromium-mac/rubberbanding/overhang-e.html

platform/chromium-mac/rubberbanding/overhang-n.html
platform/chromium-mac/rubberbanding/overhang-ne.html
platform/chromium-mac/rubberbanding/overhang-nw.html
platform/chromium-mac/rubberbanding/overhang-s.html
platform/chromium-mac/rubberbanding/overhang-se.html
platform/chromium-mac/rubberbanding/overhang-sw.html
platform/chromium-mac/rubberbanding/overhang-w.html

  • WebCore.exp.in:
  • platform/ScrollableArea.h:
  • testing/Internals.cpp:

(WebCore::Internals::setScrollViewPosition):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

  • win/WebKit2.def:
  • win/WebKit2CFLite.def:

LayoutTests:

  • platform/chromium-mac/rubberbanding: Added.
  • platform/chromium-mac/rubberbanding/overhang-e-expected.png: Added.
  • platform/chromium-mac/rubberbanding/overhang-e-expected.txt: Added.
  • platform/chromium-mac/rubberbanding/overhang-e.html: Added.
  • platform/chromium-mac/rubberbanding/overhang-n-expected.png: Added.
  • platform/chromium-mac/rubberbanding/overhang-n-expected.txt: Added.
  • platform/chromium-mac/rubberbanding/overhang-n.html: Added.
  • platform/chromium-mac/rubberbanding/overhang-ne-expected.png: Added.
  • platform/chromium-mac/rubberbanding/overhang-ne-expected.txt: Added.
  • platform/chromium-mac/rubberbanding/overhang-ne.html: Added.
  • platform/chromium-mac/rubberbanding/overhang-nw-expected.png: Added.
  • platform/chromium-mac/rubberbanding/overhang-nw-expected.txt: Added.
  • platform/chromium-mac/rubberbanding/overhang-nw.html: Added.
  • platform/chromium-mac/rubberbanding/overhang-s-expected.png: Added.
  • platform/chromium-mac/rubberbanding/overhang-s-expected.txt: Added.
  • platform/chromium-mac/rubberbanding/overhang-s.html: Added.
  • platform/chromium-mac/rubberbanding/overhang-se-expected.png: Added.
  • platform/chromium-mac/rubberbanding/overhang-se-expected.txt: Added.
  • platform/chromium-mac/rubberbanding/overhang-se.html: Added.
  • platform/chromium-mac/rubberbanding/overhang-sw-expected.png: Added.
  • platform/chromium-mac/rubberbanding/overhang-sw-expected.txt: Added.
  • platform/chromium-mac/rubberbanding/overhang-sw.html: Added.
  • platform/chromium-mac/rubberbanding/overhang-w-expected.png: Added.
  • platform/chromium-mac/rubberbanding/overhang-w-expected.txt: Added.
  • platform/chromium-mac/rubberbanding/overhang-w.html: Added.
Location:
trunk
Files:
25 added
14 edited

Legend:

Unmodified
Added
Removed

  • trunk/ChangeLog

    r94586 r94705  
     12011-09-07  Alexei Svitkine  <asvitkine@chromium.org>
     2
     3        Add test infrastructure to test rubber-banding overhang drawing along with layout tests for existing Chromium Mac overhang drawing in the non-gpu path.
     4        https://bugs.webkit.org/show_bug.cgi?id=67511
     5
     6        Reviewed by Dimitri Glazkov.
     7
     8        * Source/autotools/symbols.filter:
     9
    1102011-09-06  Ryosuke Niwa  <rniwa@webkit.org>
    211

  • trunk/LayoutTests/ChangeLog

    r94703 r94705  
     12011-09-07  Alexei Svitkine  <asvitkine@chromium.org>
     2
     3        Add test infrastructure to test rubber-banding overhang drawing along with layout tests for existing Chromium Mac overhang drawing in the non-gpu path.
     4        https://bugs.webkit.org/show_bug.cgi?id=67511
     5
     6        Reviewed by Dimitri Glazkov.
     7
     8        * platform/chromium-mac/rubberbanding: Added.
     9        * platform/chromium-mac/rubberbanding/overhang-e-expected.png: Added.
     10        * platform/chromium-mac/rubberbanding/overhang-e-expected.txt: Added.
     11        * platform/chromium-mac/rubberbanding/overhang-e.html: Added.
     12        * platform/chromium-mac/rubberbanding/overhang-n-expected.png: Added.
     13        * platform/chromium-mac/rubberbanding/overhang-n-expected.txt: Added.
     14        * platform/chromium-mac/rubberbanding/overhang-n.html: Added.
     15        * platform/chromium-mac/rubberbanding/overhang-ne-expected.png: Added.
     16        * platform/chromium-mac/rubberbanding/overhang-ne-expected.txt: Added.
     17        * platform/chromium-mac/rubberbanding/overhang-ne.html: Added.
     18        * platform/chromium-mac/rubberbanding/overhang-nw-expected.png: Added.
     19        * platform/chromium-mac/rubberbanding/overhang-nw-expected.txt: Added.
     20        * platform/chromium-mac/rubberbanding/overhang-nw.html: Added.
     21        * platform/chromium-mac/rubberbanding/overhang-s-expected.png: Added.
     22        * platform/chromium-mac/rubberbanding/overhang-s-expected.txt: Added.
     23        * platform/chromium-mac/rubberbanding/overhang-s.html: Added.
     24        * platform/chromium-mac/rubberbanding/overhang-se-expected.png: Added.
     25        * platform/chromium-mac/rubberbanding/overhang-se-expected.txt: Added.
     26        * platform/chromium-mac/rubberbanding/overhang-se.html: Added.
     27        * platform/chromium-mac/rubberbanding/overhang-sw-expected.png: Added.
     28        * platform/chromium-mac/rubberbanding/overhang-sw-expected.txt: Added.
     29        * platform/chromium-mac/rubberbanding/overhang-sw.html: Added.
     30        * platform/chromium-mac/rubberbanding/overhang-w-expected.png: Added.
     31        * platform/chromium-mac/rubberbanding/overhang-w-expected.txt: Added.
     32        * platform/chromium-mac/rubberbanding/overhang-w.html: Added.
     33
    1342011-09-07  David Reveman  <reveman@chromium.org>
    235

  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r94703 r94705  
    463463// throw.  V8 follows the spec.
    464464WONTFIX SKIP : fast/js/reparsing-semicolon-insertion.html = FAIL
     465
     466// Rubber-banding is currently a Mac only feature.
     467WONTFIX WIN LINUX : platform/chromium/rubberbanding = IMAGE
    465468
    466469// -----------------------------------------------------------------

  • trunk/Source/WebCore/ChangeLog

    r94703 r94705  
     12011-09-07  Alexei Svitkine  <asvitkine@chromium.org>
     2
     3        Add test infrastructure to test rubber-banding overhang drawing along with layout tests for existing Chromium Mac overhang drawing in the non-gpu path.
     4        https://bugs.webkit.org/show_bug.cgi?id=67511
     5
     6        Reviewed by Dimitri Glazkov.
     7
     8        Tests: platform/chromium-mac/rubberbanding/overhang-e.html
     9               platform/chromium-mac/rubberbanding/overhang-n.html
     10               platform/chromium-mac/rubberbanding/overhang-ne.html
     11               platform/chromium-mac/rubberbanding/overhang-nw.html
     12               platform/chromium-mac/rubberbanding/overhang-s.html
     13               platform/chromium-mac/rubberbanding/overhang-se.html
     14               platform/chromium-mac/rubberbanding/overhang-sw.html
     15               platform/chromium-mac/rubberbanding/overhang-w.html
     16
     17        * WebCore.exp.in:
     18        * platform/ScrollableArea.h:
     19        * testing/Internals.cpp:
     20        (WebCore::Internals::setScrollViewPosition):
     21        * testing/Internals.h:
     22        * testing/Internals.idl:
     23
    1242011-09-07  David Reveman  <reveman@chromium.org>
    225

  • trunk/Source/WebCore/WebCore.exp.in

    r94644 r94705  
    373373__ZN7WebCore14ScrollableArea17willEndLiveResizeEv
    374374__ZN7WebCore14ScrollableArea19willStartLiveResizeEv
     375__ZN7WebCore14ScrollableArea28setScrollOffsetFromInternalsERKNS_8IntPointE
    375376__ZN7WebCore14ScrollbarTheme11nativeThemeEv
     377__ZN7WebCore10ScrollView23setScrollbarsSuppressedEbb
    376378__ZN7WebCore14SecurityOrigin14threadsafeCopyEv
    377379__ZN7WebCore14SecurityOrigin16createFromStringERKN3WTF6StringE
    … …  
    13211323__ZNK7WebCore8Document6loaderEv
    13221324__ZNK7WebCore8Document8settingsEv
     1325__ZNK7WebCore8Document4viewEv
    13231326__ZNK7WebCore8IntPointcv7CGPointEv
    13241327__ZNK7WebCore8IntPointcv8_NSPointEv

  • trunk/Source/WebCore/platform/ScrollableArea.cpp

    r91735 r94705  
    136136#endif
    137137
     138// NOTE: Only called from Internals for testing.
     139void ScrollableArea::setScrollOffsetFromInternals(const IntPoint& offset)
     140{
     141    setScrollOffsetFromAnimation(offset);
     142}
     143
    138144void ScrollableArea::setScrollOffsetFromAnimation(const IntPoint& offset)
    139145{

  • trunk/Source/WebCore/platform/ScrollableArea.h

    r91735 r94705  
    159159    virtual bool scrollAnimatorEnabled() const { return false; }
    160160
     161    // NOTE: Only called from Internals for testing.
     162    void setScrollOffsetFromInternals(const IntPoint&);
     163
    161164private:
    162165    // NOTE: Only called from the ScrollAnimator.
    163166    friend class ScrollAnimator;
    164167    void setScrollOffsetFromAnimation(const IntPoint&);
    165    
     168
    166169    mutable OwnPtr<ScrollAnimator> m_scrollAnimator;
    167170    bool m_constrainsScrollingToContentEdge;

  • trunk/Source/WebCore/testing/Internals.cpp

    r94633 r94705  
    3333#include "Element.h"
    3434#include "ExceptionCode.h"
     35#include "FrameView.h"
    3536#include "HTMLInputElement.h"
    3637#include "HTMLNames.h"
    … …  
    271272}
    272273
     274void Internals::setScrollViewPosition(Document* document, long x, long y, ExceptionCode& ec)
     275{
     276    if (!document || !document->view()) {
     277        ec = INVALID_ACCESS_ERR;
     278        return;
     279    }
     280
     281    FrameView* frameView = document->view();
     282    bool constrainsScrollingToContentEdgeOldValue = frameView->constrainsScrollingToContentEdge();
     283    bool scrollbarsSuppressedOldValue = frameView->scrollbarsSuppressed();
     284
     285    frameView->setConstrainsScrollingToContentEdge(false);
     286    frameView->setScrollbarsSuppressed(false);
     287    frameView->setScrollOffsetFromInternals(IntPoint(x, y));
     288    frameView->setScrollbarsSuppressed(scrollbarsSuppressedOldValue);
     289    frameView->setConstrainsScrollingToContentEdge(constrainsScrollingToContentEdgeOldValue);
     290}
     291
    273292void Internals::reset(Document* document)
    274293{

  • trunk/Source/WebCore/testing/Internals.h

    r94586 r94705  
    8282    void setPasswordEchoDurationInSeconds(Document*, double durationInSeconds, ExceptionCode&);
    8383
     84    void setScrollViewPosition(Document*, long x, long y, ExceptionCode&);
     85
    8486    bool wasLastChangeUserEdit(Element* textField, ExceptionCode&);
    8587    String suggestedValue(Element* inputElement, ExceptionCode&);

  • trunk/Source/WebCore/testing/Internals.idl

    r94586 r94705  
    5656        void setPasswordEchoDurationInSeconds(in Document document, in double durationInSeconds) raises(DOMException);
    5757
     58        void setScrollViewPosition(in Document document, in long x, in long y) raises(DOMException);
     59
    5860        boolean wasLastChangeUserEdit(in Element textField) raises (DOMException);
    5961        DOMString suggestedValue(in Element inputElement) raises (DOMException);

  • trunk/Source/WebKit2/ChangeLog

    r94701 r94705  
     12011-09-07  Alexei Svitkine  <asvitkine@chromium.org>
     2
     3        Add test infrastructure to test rubber-banding overhang drawing along with layout tests for existing Chromium Mac overhang drawing in the non-gpu path.
     4        https://bugs.webkit.org/show_bug.cgi?id=67511
     5
     6        Reviewed by Dimitri Glazkov.
     7
     8        * win/WebKit2.def:
     9        * win/WebKit2CFLite.def:
     10
    1112011-09-06  Oliver Hunt  <oliver@apple.com>
    212

  • trunk/Source/WebKit2/win/WebKit2.def

    r94633 r94705  
    166166        ?setDOMException@WebCore@@YAXPAVExecState@JSC@@H@Z
    167167        ?setResourcesDataSizeLimitsFromInternals@InspectorController@WebCore@@QAEXHH@Z
     168        ?setScrollbarsSuppressed@ScrollView@WebCore@@QAEX_N0@Z
     169        ?setScrollOffsetFromInternals@ScrollableArea@WebCore@@QAEXABVIntPoint@2@@Z
    168170        ?setSuggestedValue@HTMLInputElement@WebCore@@QAEXABVString@WTF@@@Z
    169171        ?settings@Document@WebCore@@QBEPAVSettings@2@XZ
    … …  
    176178        ?toJS@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVRange@1@@Z
    177179        ?updateLayoutIgnorePendingStylesheets@Document@WebCore@@QAEXXZ
     180        ?view@Document@WebCore@@QBEPAVFrameView@2@XZ
    178181        ?virtualFunctionToPreventWeakVtable@JSDOMWrapper@WebCore@@MAEXXZ

  • trunk/Source/WebKit2/win/WebKit2CFLite.def

    r94633 r94705  
    160160        ?setDOMException@WebCore@@YAXPAVExecState@JSC@@H@Z
    161161        ?setResourcesDataSizeLimitsFromInternals@InspectorController@WebCore@@QAEXHH@Z
     162        ?setScrollbarsSuppressed@ScrollView@WebCore@@QAEX_N0@Z
     163        ?setScrollOffsetFromInternals@ScrollableArea@WebCore@@QAEXABVIntPoint@2@@Z
    162164        ?setSuggestedValue@HTMLInputElement@WebCore@@QAEXABVString@WTF@@@Z
    163165        ?settings@Document@WebCore@@QBEPAVSettings@2@XZ
    … …  
    169171        ?toJS@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@PAVJSDOMGlobalObject@1@PAVRange@1@@Z
    170172        ?toNode@WebCore@@YAPAVNode@1@VJSValue@JSC@@@Z
     173        ?view@Document@WebCore@@QBEPAVFrameView@2@XZ
    171174        ?virtualFunctionToPreventWeakVtable@JSDOMWrapper@WebCore@@MAEXXZ

  • trunk/Source/autotools/symbols.filter

    r94586 r94705  
    7373_ZNK7WebCore8Document4pageEv;
    7474_ZNK7WebCore8Document8settingsEv;
     75_ZNK7WebCore8Document4viewEv;
    7576_ZNK7WebCore9TreeScope14getElementByIdERKN3WTF12AtomicStringE;
     77_ZN7WebCore14ScrollableArea28setScrollOffsetFromInternalsERKNS_8IntPointE;
     78_ZN7WebCore10ScrollView23setScrollbarsSuppressedEbb;
    7679local:
    7780_Z*;
Note: See TracChangeset for help on using the changeset viewer.